Re: Report error in scheme evaluation

2022-09-12 Thread Ihor Radchenko
Felipe Lema writes: > Let me know if I'm missing anything so this can be merged. It is correct to > report errors this way, right? I am going through old patch submission that have not been resolved. Note that this is not a patch, but a diff. Also, > + (when-let* ((err (geiser-ev

Re: Report error in scheme evaluation

2022-05-03 Thread Felipe Lema
On 2022-04-30 06:35, Neil Jerram wrote: On Sat, 30 Apr 2022 at 09:14, Ihor Radchenko wrote: Felipe Lema writes: I just realized I was un-CCed out of the thread Here's the updated patch with the requested changes (actually single one) Lemme know if I'm missing anything else. Can you upda

Re: Report error in scheme evaluation

2022-04-30 Thread Neil Jerram
On Sat, 30 Apr 2022 at 09:14, Ihor Radchenko wrote: > > Felipe Lema writes: > > > I just realized I was un-CCed out of the thread > > > > Here's the updated patch with the requested changes (actually single one) > > > > Lemme know if I'm missing anything else. > > Can you update the patch making

Re: Report error in scheme evaluation

2022-04-30 Thread Ihor Radchenko
Felipe Lema writes: > I just realized I was un-CCed out of the thread > > Here's the updated patch with the requested changes (actually single one) > > Lemme know if I'm missing anything else. Can you update the patch making it a proper patch under your name? See https://orgmode.org/worg/org-con

Re: Report error in scheme evaluation

2021-12-27 Thread Felipe Lema
I just realized I was un-CCed out of the thread Here's the updated patch with the requested changes (actually single one) Lemme know if I'm missing anything else. Felipediff --git a/lisp/org/ob-scheme.el b/lisp/org/ob-scheme.el index f4836b23fe..8720bd099e 100644 --- a/lisp/org/ob-scheme.el +++

Re: Report error in scheme evaluation

2021-12-23 Thread Rudolf Adamkovič
Felipe Lema writes: > I'd say that geiser transforms Emacs into a full blown IDE: code > completion, documentation, symbol/tag search... you name it. This also > applies to Org when you edit the source code using C-c C-c, so that > helps a ton with learning the language. That sounds fantastic!

Re: Report error in scheme evaluation

2021-12-22 Thread Ihor Radchenko
Max Nikulin writes: >> Let me know if I'm missing anything so this can be merged. It is correct to >> report errors this way, right? > >> + (when-let* ((err (geiser-eval--retort-error ret))) > > Doesn't (require 'subr-x) should be added to the file? Hmm. You are right. I thought th

Re: Report error in scheme evaluation

2021-12-22 Thread Felipe Lema
On Wednesday, 22 December 2021 11.54.33 -03 Ihor Radchenko wrote: > Felipe Lema writes: > > > I started using guile with Org Babel and I was a little confused that > > errors weren't being reported. The attached patch will report the error the > > same way as python evaluation does. > > The pa

Re: Report error in scheme evaluation

2021-12-22 Thread Max Nikulin
On 22/12/2021 02:58, Felipe Lema wrote: Let me know if I'm missing anything so this can be merged. It is correct to report errors this way, right? + (when-let* ((err (geiser-eval--retort-error ret))) Doesn't (require 'subr-x) should be added to the file?

Re: Report error in scheme evaluation

2021-12-22 Thread Ihor Radchenko
Felipe Lema writes: > * ob-scheme.el (org-babel-scheme-execute-with-geiser): paste error into > `org-babel-error-buffer-name` and setup buffer to compilation-mode Marking this as a patch for updates.orgmode.org Best, Ihor

Re: Report error in scheme evaluation

2021-12-22 Thread Ihor Radchenko
Felipe Lema writes: > I started using guile with Org Babel and I was a little confused that errors > weren't being reported. The attached patch will report the error the same way > as python evaluation does. The patch looks fine to me. Though never used scheme... The only thing that can be im

Re: Report error in scheme evaluation

2021-12-21 Thread Felipe Lema
On Tuesday, 21 December 2021 20.07.01 -03 Rudolf Adamkovič wrote: > Felipe Lema writes: > > > Sup, y'all > > > > I started using guile with Org Babel […] > > Sup! I plan to write some literate Scheme soon as well. How do you find > the experience so far? As of today, I use 'scheme-mode' with a

Re: Report error in scheme evaluation

2021-12-21 Thread Rudolf Adamkovič
Felipe Lema writes: > Sup, y'all > > I started using guile with Org Babel […] Sup! I plan to write some literate Scheme soon as well. How do you find the experience so far? As of today, I use 'scheme-mode' with a set of TAGS files for completion and help, all based on my (incomplete) notes abo