Re: [PATCH] org-agenda.el: Avoid dependency on subr-x

2021-08-06 Thread Timothy
Hi Maxim, > Timothy, I have seen that discussion. For me it does not matter in which way > org-agenda.el will be fixed: by adding (require ’subr-x) or by using string= > instead of string-empty-p. Both variants work with Emacs-26.3. The point is > that > “make single” should work without warnings

Re: [PATCH] org-agenda.el: Avoid dependency on subr-x

2021-08-06 Thread Maxim Nikulin
On 05/08/2021 19:59, Timothy wrote: Restore compatibility with Emacs-24.3. FYI Emacs 24 is no longer Org’s minimum version, from the next release onward it will be Emacs 25. Timothy, I have seen that discussion. For me it does not matter in which way org-agenda.el will be fixed: by adding

Re: [PATCH] org-agenda.el: Avoid dependency on subr-x

2021-08-05 Thread Maxim Nikulin
On 05/08/2021 04:41, Вячеслав Гришин wrote: Now I don't know if I need to do something extra, because the problem arose because of my mistake. Vyacheslav, you do not need to react to my patch, it is for Org maintainers. There is neither continuous integration server nor ready to use configur

Re: [PATCH] org-agenda.el: Avoid dependency on subr-x

2021-08-05 Thread Timothy
Hi Maxim, > Restore compatibility with Emacs-24.3. FYI Emacs 24 is no longer Org’s minimum version, from the next release onward it will be Emacs 25. All the best, Timothy

Re: [PATCH] org-agenda.el: Avoid dependency on subr-x

2021-08-05 Thread Maxim Nikulin
The patch is created for the maint branch. I have reordered some part of the quoted message. On 05/08/2021 05:11, Tim Cross wrote: > I don't think this patch is required, especially since we have not had > any bug reported relating to that version. org-agenda.el (and some other files) should be

Re: [PATCH] org-agenda.el: Avoid dependency on subr-x

2021-08-04 Thread Tim Cross
Note that compatibility with 24.3 was not the cause of the OP original issue (they were running 26.3). Do we really want to maintain compatibility with Emacs 24.3? That version was released over 8 years ago and I suspect there are other areas of org which are not compatible with that version. No