Note that compatibility with 24.3 was not the cause of the OP original issue (they were running 26.3).
Do we really want to maintain compatibility with Emacs 24.3? That version was released over 8 years ago and I suspect there are other areas of org which are not compatible with that version. Note also that the subr-x and string-empty-p were introduced in Emacs 24.4. If we are going to support Emacs 24, I think it is reasonable it be 24.4 rather than aiming for all 24 releases. I don't think this patch is required, especially since we have not had any bug reported relating to that version. Maxim Nikulin <maniku...@gmail.com> writes: > * lisp/org-agenda.el (org-agenda-highlight-todo): Do not use `string-empty-p'. > > Restore compatibility with Emacs-24.3. > --- > lisp/org-agenda.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el > index c3fbabc01..b6cd895bc 100644 > --- a/lisp/org-agenda.el > +++ b/lisp/org-agenda.el > @@ -7080,7 +7080,7 @@ The optional argument TYPE tells the agenda type." > (setq x > (concat > (substring x 0 (match-end 1)) > - (unless (string-empty-p org-agenda-todo-keyword-format) > + (unless (string= org-agenda-todo-keyword-format "") > (format org-agenda-todo-keyword-format > (match-string 2 x))) > ;; Remove `display' property as the icon could leak
