This replaces the previous patch. The `sql-product-interactive' call
was still using the modified signature and does no longer.
>From e27f8231c2f97e6f7f84b6acb793eec7060b8396 Mon Sep 17 00:00:00 2001
From: Phil Estival
Date: Wed, 13 June 2025 17:00:00 +0200
Subject: [PATCH 06/08] ob-sql: add se
On Saturday, February 15th, 2025 at 4:25 PM, Ihor Radchenko
wrote:
> Ihor Radchenko yanta...@posteo.net writes:
>
> > May you please post the patch on Emacs bug tracker? (M-x
> > submit-emacs-patch) and X-Debbugs-CC me?
> > That way, we get the Emacs maintainers involved into the discussion.
>
Phil Estival writes:
>> May you please update your latest patch for ob-sql.el, converting it
>> into (1) patch to sql.el; (2) patch for ob-sql.el that assumes changes
>> to sql.el?
>
> Here they are
> 1) the patch of sql.el
> 2) the list of changes in ob-sql.el against release_9.7.30.
>The pa
* [2025-05-14 16:29 +0200] Phil Estival :
> * [2025-02-15 16:25 +] Ihor Radchenko :
>> Ihor Radchenko writes:
>>
>> May you please update your latest patch for ob-sql.el, converting it
>> into (1) patch to sql.el; (2) patch for ob-sql.el that assumes changes
>> to sql.el?
>
> Here they are
> 1
* [2025-02-15 16:25 +] Ihor Radchenko :
> Ihor Radchenko writes:
>
> May you please update your latest patch for ob-sql.el, converting it
> into (1) patch to sql.el; (2) patch for ob-sql.el that assumes changes
> to sql.el?
Here they are
1) the patch of sql.el
2) the list of changes in ob-sql
Ihor Radchenko writes:
> May you please post the patch on Emacs bug tracker? (M-x
> submit-emacs-patch) and X-Debbugs-CC me?
> That way, we get the Emacs maintainers involved into the discussion.
The patch is in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=76025
There are no major objections t
Phil Estival writes:
>> What about changing sql.el to provide the necessary flexibility?
>> I'd prefer it better than rewriting parts of sql.el in Org mode.
>
> Gladly. Here is a proposal for patch for `sql-product-interactive' in
> sql.el. A specific case for sqlite is handled and this is not 10
* [2025-01-17 Fri 06:58 +0100] Ihor Radchenko
Phil Estival writes:
Is there any specific reason why you are seemingly re-implementing what
`sql-product-interactive' does? May we re-use it instead?
Yes. When opening a new connection `sql-product-interactive' will
systematically ask for input
