Re: [PATCH] Re: [ISSUE] Re: [PATCH] lisp/org-agenda.el: Add header to agenda clock report table

Ihor Radchenko writes: > "Christopher M. Miles" writes: > >> I tested this commit, it should auto append a newline character after >> ~org-agenda-clock-report-header~. Otherwise the header line will in same >> line with table first line. > > Reasonable concern. > The attached patch should fix i

[PATCH] Re: [ISSUE] Re: [PATCH] lisp/org-agenda.el: Add header to agenda clock report table

"Christopher M. Miles" writes: > I tested this commit, it should auto append a newline character after > ~org-agenda-clock-report-header~. Otherwise the header line will in same line > with table first line. Reasonable concern. The attached patch should fix it. Best, Ihor >From c918d5097af4ca

[ISSUE] Re: [PATCH] lisp/org-agenda.el: Add header to agenda clock report table

I tested this commit, it should auto append a newline character after ~org-agenda-clock-report-header~. Otherwise the header line will in same line with table first line. Samim Pezeshki writes: > Thanks Nicolas for reviewing the changes! > > I applied the changes. > Attached is the updated pat

Re: [PATCH] lisp/org-agenda.el: Add header to agenda clock report table

Hello, Samim Pezeshki writes: > Thanks Nicolas for reviewing the changes! > > I applied the changes. > Attached is the updated patch. Applied. Thank you. Regards, -- Nicolas Goaziou

Re: [PATCH] lisp/org-agenda.el: Add header to agenda clock report table

Thanks Nicolas for reviewing the changes! I applied the changes. Attached is the updated patch. On Fri, Jan 21, 2022 at 1:58 PM Nicolas Goaziou wrote: > Hello, > > Samim Pezeshki writes: > > > +(defcustom org-agenda-clock-report-header nil > > + "Header for org agenda clock report mode" > >

Re: [PATCH] lisp/org-agenda.el: Add header to agenda clock report table

Hello, Samim Pezeshki writes: > +(defcustom org-agenda-clock-report-header nil > + "Header for org agenda clock report mode" > + :group 'org-agenda > + :type 'string) Please add :package-version and :safe keywords to the definition. Also, type does not match the default value. You probably

Re: [PATCH] lisp/org-agenda.el: Add header to agenda clock report table

Should I do something for this patch to be approved? On Mon, Jan 10, 2022 at 1:58 PM Christopher M. Miles wrote: > > Good idea to add header for clock report table. > > Samim Pezeshki writes: > > > Hi, > > > > This patch adds a header to the clock report table in the agenda, if > > org-agenda-c

Re: [PATCH] lisp/org-agenda.el: Add header to agenda clock report table

Good idea to add header for clock report table. Samim Pezeshki writes: > Hi, > > This patch adds a header to the clock report table in the agenda, if > org-agenda-clock-report-header is set. > > Thanks, > Samim > > [4. text/x-patch; > 0001-lisp-org-agenda.el-Add-header-to-agenda-clock-report.