Thanks Nicolas for reviewing the changes! I applied the changes. Attached is the updated patch.
On Fri, Jan 21, 2022 at 1:58 PM Nicolas Goaziou <m...@nicolasgoaziou.fr> wrote: > Hello, > > Samim Pezeshki <p.sa...@gmail.com> writes: > > > +(defcustom org-agenda-clock-report-header nil > > + "Header for org agenda clock report mode" > > + :group 'org-agenda > > + :type 'string) > > Please add :package-version and :safe keywords to the definition. > > Also, type does not match the default value. You probably mean > > (choice > (string :tag "Header") > (const :tag "No header" nil)) > > > + > > (defun org-agenda-time-of-day-to-ampm (time) > > "Convert TIME of a string like \"13:45\" to an AM/PM style time > string." > > (let* ((hour-number (string-to-number (substring time 0 -3))) > > @@ -4473,6 +4478,10 @@ items if they have an hour specification like > [h]h:mm." > > (setq p (plist-put p :tend clocktable-end)) > > (setq p (plist-put p :scope 'agenda)) > > (setq tbl (apply #'org-clock-get-clocktable p)) > > + (when org-agenda-clock-report-header > > + (put-text-property 0 (length org-agenda-clock-report-header) > 'face 'org-agenda-structure > > + org-agenda-clock-report-header) > > + (insert org-agenda-clock-report-header)) > > Maybe: > > (insert (propertize org-agenda-clock-report-header 'face > 'org-agenda-structure)) > > Could you send an updated patch? > > Regards, > -- > Nicolas Goaziou >
From 6691abdcef95181ea9517e2c2c60ca52443c14a6 Mon Sep 17 00:00:00 2001 From: Samim Pezeshki <psa...@gmail.com> Date: Mon, 10 Jan 2022 12:32:51 +0330 Subject: [PATCH] lisp/org-agenda.el: Add header to agenda clock report table * lisp/org-agenda.el (org-agenda-list): Add header to agenda clock report table. TINYCHANGE --- doc/org-manual.org | 4 ++-- etc/ORG-NEWS | 1 + lisp/org-agenda.el | 11 +++++++++++ 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/doc/org-manual.org b/doc/org-manual.org index b4c20f252..2c54fde87 100644 --- a/doc/org-manual.org +++ b/doc/org-manual.org @@ -9742,8 +9742,8 @@ the other commands, point needs to be in the desired line. variable ~org-agenda-start-with-clockreport-mode~. By using a prefix argument when toggling this mode (i.e., {{{kbd(C-u R)}}}), the clock table does not show contributions from entries that are - hidden by agenda filtering[fn:99]. See also the variable - ~org-clock-report-include-clocking-task~. + hidden by agenda filtering[fn:99]. See also the variables + ~org-clock-report-include-clocking-task~ and ~org-agenda-clock-report-header~. - {{{kbd(v c)}}} :: diff --git a/etc/ORG-NEWS b/etc/ORG-NEWS index 335db4139..5a94e737e 100644 --- a/etc/ORG-NEWS +++ b/etc/ORG-NEWS @@ -140,6 +140,7 @@ introduced which will accept three new formats: Chmod-style permissions are based on the new variable ~org-babel-tangle-default-file-mode~. +*** A new custom setting =org-agenda-clock-report-header= to add a header to org agenda clock report * Version 9.5 ** Important announcements and breaking changes diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el index 7bcaf7117..6357d9cec 100644 --- a/lisp/org-agenda.el +++ b/lisp/org-agenda.el @@ -1217,6 +1217,15 @@ For example, 9:30am would become 09:30 rather than 9:30." :version "24.1" :type 'boolean) +(defcustom org-agenda-clock-report-header nil + "Header for org agenda clock report mode" + :group 'org-agenda + :type '(choice + (string :tag "Header") + (const :tag "No header" nil)) + :safe #'stringp + :package-version '(Org . "9.6")) + (defun org-agenda-time-of-day-to-ampm (time) "Convert TIME of a string like \"13:45\" to an AM/PM style time string." (let* ((hour-number (string-to-number (substring time 0 -3))) @@ -4473,6 +4482,8 @@ items if they have an hour specification like [h]h:mm." (setq p (plist-put p :tend clocktable-end)) (setq p (plist-put p :scope 'agenda)) (setq tbl (apply #'org-clock-get-clocktable p)) + (when org-agenda-clock-report-header + (insert (propertize org-agenda-clock-report-header 'face 'org-agenda-structure))) (insert tbl))) (goto-char (point-min)) (or org-agenda-multi (org-agenda-fit-window-to-buffer)) -- 2.34.1