Re: [Orgmode] Re: Fontification of blocks

2011-02-04 Thread Eric Schulte
Hi Seb, This looks very nice, I am now able to turn fontification on and off as expected using your three new faces. I've just committed your patch with one minor change (not having the block background face set by default). Maybe it would be worth a worg post about how to use these faces with s

Re: [Orgmode] Re: Fontification of blocks

2011-02-04 Thread Eric S Fraga
Sébastien Vauban writes: [...] > Corrected patch is attached to this post. which appears to work just fine! Thanks. -- : Eric S Fraga (GnuPG: 0xC89193D8FFFCF67D) in Emacs 24.0.50.1 : using Org-mode version 7.4 (release_7.4.311.ga9d2.dirty) ___ Emac

Re: [Orgmode] Re: Fontification of blocks

2011-02-03 Thread Eric S Fraga
"Eric Schulte" writes: [...] > > Hi Seb, > > Thanks for sharing this code. I couldn't help myself but to turn it > into a patch as that has become my favorite way of reviewing new code. > The resulting patch it attached. Seb's code worked for me but your patch doesn't unfortunately. > I notic

Re: [Orgmode] Re: Fontification of blocks

2011-02-03 Thread Eric Schulte
Sébastien Vauban writes: > Hi Eric(s), Dan & all, > > Sébastien Vauban wrote: >> "Eric Schulte" wrote: >>> I think that adding a new block delimiter face which inherits from the >>> org-meta face as you've suggested is the way to go. >>> >>> I would recommend however that rather than removing/cha

Re: [Orgmode] Re: Fontification of blocks

2011-02-02 Thread Eric S Fraga
Sébastien Vauban writes: [...] > Eric (Fraga), David (O'Toole) and Carsten, you should love the following... > when in native fontification... You are correct: I do love it! I've tried it on a large document with many source code blocks and it seems to work very well (and really helps with the

Re: [Orgmode] Re: Fontification of blocks

2011-02-02 Thread Eric S Fraga
Sébastien Vauban writes: > Hi Eric, Dan & all, > > "Eric Schulte" wrote: >> I think that adding a new block delimiter face which inherits from the >> org-meta face as you've suggested is the way to go. [...] > Here a proposition that goes in that direction -- not yet a real patch, but > somethi

Re: [Orgmode] Re: Fontification of blocks

2010-12-15 Thread Eric Schulte
Hi Seb, I was thinking that it would be nice to be able to try this out through setting a variable (as most org customizations are handled) which would activate/de-activate the extra fontification. I think that adding a new block delimiter face which inherits from the org-meta face as you've sugg