Re: [O] [PATCH] ob-eval: display error fix

Andreas Gerler writes: > * lisp/ob-eval.el: (org-babel-eval-error-notify): Display standard > error only if command exits non zero. > > The problem is that sql connections might give warnings. > Now the information is available in the *Org-Babel Error* buffer > without displaying. > If you need a

Re: [O] [PATCH] ob-eval: display error fix

Hi Ihor, way too busy right now. As soon as I find some time I’ll rework that change. Might take a week or two. so long... Andreas Gerler > On Jan 27, 2023, at 2:11 PM, Ihor Radchenko wrote: > > Andreas Gerler writes: > >> +(defcustom org-babel-eval-error-display-notify nil >> + "Display

Re: [O] [PATCH] ob-eval: display error fix

Andreas Gerler writes: > +(defcustom org-babel-eval-error-display-notify nil > + "Display org-babel-eval-errors always or only if exit code is not 0." This docstring is confusing. What will happen if the value is nil? non-nil? I cannot answer these questions by reading the docstring. Also, wha

Re: [O] [PATCH] ob-eval: display error fix

Ping -- I don't think anyone else has replied / reviewed this patch yet, unless it has happened in a different thread. Best, RY Andreas Gerler writes: > [[PGP Signed Part:Undecided]] > > [2. text/x-patch; 0001-lisp-ob-eval.el-Display-error-fix.patch]... > > > > Hi Ruijie, > > thanks for ask

Re: [O] [PATCH] ob-eval: display error fix

0001-lisp-ob-eval.el-Display-error-fix.patch Description: Binary data Hi Ruijie, thanks for asking. I combined them now and tested again all variants. Andreas > On 7. Jan 2023, at 22:33, Ruijie Yu via General discussions about Org-mode. > wrote: > > > Hi Andreas, > > -(display-buff

Re: [O] [PATCH] ob-eval: display error fix

Hi Andreas, -(display-buffer buf)) +(if org-babel-eval-error-display-notify +(display-buffer buf) + (if (or (not (numberp exit-code)) + (> exit-code 0)) + (display-buffer buf Quick question, does it help or hurt readability if we change this nested

Re: [O] [PATCH 2/4] ob-clojure.el: Add ClojureScript interface

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, any update on this patch? I still have this feature reminder in my GTD. Really hope ob-clojure.el can support ClojureScript too. If possible, hope this can integrate with current CIDER new session manager "sesman". roberthambr...@gmail.com wr

Re: [O] [PATCH] org-manual: Dynamic Blocks: Fix explanation of :content

Sebastian Miele writes: > * doc/org-manual.org (Dynamic Blocks): Correct the information given > on :content in the plist passed to the writer function. Looks correct to me. Applied in 634880a2e. Thanks.

Re: [O] [PATCH] Add :eval only-manual to babel blocks

Hello, Ken Mankoff writes: > On 2019-10-16 at 12:38 +02, Nicolas Goaziou wrote... > > Would you accept a documentation patch that defines the current > behavior? I don't know enough of the problem to answer. A default answer which in neither "yes" or "no" is odd. Let's discuss it with other us

Re: [O] [PATCH] Respect buffer-local value of `org-edit-src-content-indentation'

Hello Adam, Adam Porter writes: > You might consider using the function buffer-local-value instead of the > macro with-current-buffer. Not that it matters so much here, but > benchmarking shows that it is much faster when simply accessing the > buffer-local value of a variable. Thank you. Such

Re: [O] [PATCH] Add :eval only-manual to babel blocks

On 2019-10-16 at 12:38 +02, Nicolas Goaziou wrote... > Of course, meawhile, do not rely on undefined behaviour :) Would you accept a documentation patch that defines the current behavior? Then I get what I want, and it is on future developers to not mess it up :). -k.

Re: [O] [PATCH] ox-html: add option to restore old src block behaviour?

Hello, Jens Lechtenboerger writes: > Thanks! A patch is attached. Applied. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] Add :eval only-manual to babel blocks

Hello, Ken Mankoff writes: > Can you provide a more obvious hint? :) I don't have enough time to help you more on that, sorry. I didn't even look closely to the issue you're encountering. Hopefully, someone else on the ML can provide guidance on it. > I've read the documentation on called-inte

Re: [O] [PATCH] Add :eval only-manual to babel blocks

Hi Nicolas, On 2019-10-16 at 12:38 +02, Nicolas Goaziou wrote... > Note that what you want, i.e., to distinguish behaviour depending on > the location of the call stack is cheesy, at best. Think about macros, > user-defined functions, etc. Yes, it felt a bit hackish. But I'm new to this level of

Re: [O] [PATCH] Add :eval only-manual to babel blocks

Hello, Ken Mankoff writes: > Hmm. So it turns out (I think) this patch isn't necessary. The > behavior I wanted and thought I implemented is actually the default > behavior! I think the behavior is undefined for :eval not equal to > "yes", "no", or "query", but the current undefined implementati

Re: [O] [PATCH] Add :eval only-manual to babel blocks

On 2019-10-14 at 09:10 +02, Ken Mankoff wrote... > With this patch and ":eval only-manual" in a babel header, > > Org evaluates the source code if it is run via ~org-ctrl-c-ctrl-c~ > (e.g. =C-c C-c= in the babel block), but not if run via the > ~org-babel-execute-buffer~ function. Hmm. So it tu

Re: [O] [PATCH] Respect buffer-local value of `org-edit-src-content-indentation'

Hi Sebastian, Sebastian Miele writes: > * lisp/org-src.el (org-src--contents-for-write-back): Use the > potentially buffer-local value of `org-edit-src-content-indentation' > from the source buffer instead of that from the editing buffer. > --- > lisp/org-src.el | 3 ++- > 1 file changed, 2 ins

Re: [O] [PATCH] ox-html: add option to restore old src block behaviour?

On 2019-10-13, at 09:30, Nicolas Goaziou wrote: > Jens Lechtenboerger writes: > >> Subject: [PATCH] ox-html: Control wrapping of source lines >> >> * lisp/ox-html.el (org-html-format-code, org-html-do-format-code): >> Use new export option :html-wrap-src-lines with variable >> org-html-wrap-s

Re: [O] [PATCH] ob-ocaml: Support for pretty-printed outputs

Hello, "Robert M. Kovacsics" writes: > Subject: [PATCH] ob-ocaml: Support for pretty-printed outputs > > E.g. the following snippet produces multiple lines of output, due to > pretty-printing > > #+BEGIN_SRC ocaml :exports code :eval no-export :results verbatim > (* Note, no need to have parent

Re: [O] [PATCH] Document "help:" Org link type in manual

Hello, Robert Irelan writes: > Patch attached Thank you. However, I couldn't apply your patch since manual changed quite a bit in this area not so long ago. I adapted your patch to the new structure and applied it. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] ox-html: add option to restore old src block behaviour?

Hello, Jens Lechtenboerger writes: > Subject: [PATCH] ox-html: Control wrapping of source lines > > * lisp/ox-html.el (org-html-format-code, org-html-do-format-code): > Use new export option :html-wrap-src-lines with variable > org-html-wrap-src-lines to control whether source code lines sho

Re: [O] [PATCH] org: org-get-priority: reduce `not`, deduplicate magic `(* 1000 ..)` operation

Please.I tried to explain myself, but I see the more I explain myself, and write - the more people would assume the things that not correspond to reality.I not even started the work, or shown changes. And I already received a bunch of recommendations and people being concern, and people confusing t

Re: [O] [PATCH] org: org-get-priority: reduce `not`, deduplicate magic `(* 1000 ..)` operation

Hello, Anton Latukha writes: > Well, after re-reading my letter - it obviously probably comes off as > being very strong and ambitious. I am pretty cool-headed about > everything. I am aware of that I need to gradual do ideally clean and > 100% compatible changes, I looked at the code - and the

Re: [O] [PATCH] org: org-get-priority: reduce `not`, deduplicate magic `(* 1000 ..)` operation

i don't use the priority stuff, but i think it could perhaps be useful to use terminology to distinguish the priority stuff from the priority stuff. i.e. 1] the stuff i don't use that you are talking about 2] [#A] and all that when i was a beginner i got confused by that. :) On 10/9/19, Adam

Re: [O] [PATCH] org: org-get-priority: reduce `not`, deduplicate magic `(* 1000 ..)` operation

Hi Anton, Nicolas, et al, I'm in favor of tidying up the priority-related code, as I also have found it hard to follow. But please do not change the API of these functions, i.e. the signatures and return values. Their output is used in other packages, including some of mine like org-rifle, org-s

Re: [O] [PATCH] org: org-get-priority: reduce `not`, deduplicate magic `(* 1000 ..)` operation

Well, after re-reading my letter - it obviously probably comes off as being very strong and ambitious. I am pretty cool-headed about everything. I am aware of that I need to gradual do ideally clean and 100% compatible changes, I looked at the code - and the changes needed are at the pretty simple

Re: [O] [PATCH] org: org-get-priority: reduce `not`, deduplicate magic `(* 1000 ..)` operation

Ok.I would tend to it.This hardcode goes through several org.el functions. The main custom priority (priority retrieval) function should be already working and accepted in the whole Org system. But that hardcode expectation of (* 1000 ..) should be moved-out of the main priority functions and be su

Re: [O] [PATCH] ox-html: add option to restore old src block behaviour?

On 2019-10-08, at 11:31, Nicolas Goaziou wrote: > Jens Lechtenboerger writes: > >> The attached patch adds a new variable org-html-wrap-src-lines to >> control whether code tags should be added or not. > > Thank you. > > However, the patch is not right. Exporters do not use defcustoms > directly.

Re: [O] [PATCH] org: org-get-priority-function: Clearly state that this is a holder for a name of the function

Indeed, I now also understand so.Let's drop this one. 08.10.2019, 13:59, "Nicolas Goaziou" :Hello,Anton Latukha writes:  Additionally state that this is a holder of a function name, so the simple user did not get confused.Your patch doesn't sound right. The value could be a lamb

Re: [O] [PATCH] ox-html: add option to restore old src block behaviour?

Hello, Jens Lechtenboerger writes: > The attached patch adds a new variable org-html-wrap-src-lines to > control whether code tags should be added or not. Thank you. However, the patch is not right. Exporters do not use defcustoms directly. Instead, you register them within :options-alist in t

Re: [O] [PATCH] org: org-get-priority: reduce `not`, deduplicate magic `(* 1000 ..)` operation

Hello, Anton Latukha writes: > Another two small patches. Please merge the two patches and factor out the (- org-lowest-priority ...) while you're at it. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] org.el: fx org-get-priority-function funcall (give arg - headline)

Hello, Anton Latukha writes: > * org.el (org-get-priority): Fix to allow the use of custom priority > getters. > Provide the headline as argument to the custom priority getter > function. Applied. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] org: org-get-priority-function: Clearly state that this is a holder for a name of the function

Hello, Anton Latukha writes: > Additionally state that this is a holder of a function name, so the > simple user did not get confused. Your patch doesn't sound right. The value could be a lambda function, or a symbol with a function value. Besides, "function name" is confusing. It could mean, e

Re: [O] [PATCH] ob-plantuml.el support for non-UML diagrams

Sounds great, is it merged now? Henrik Koschitzki writes: > Hello, > ob-plantuml encloses the body of PlantUML ( http://plantuml.com) diagram code > with @startuml/@enduml clauses. Recent versions of PlantUML support non-UML > diagrams > like gantt, mindmap and others that needs to be enclo

Re: [O] [PATCH] ox-html: add option to restore old src block behaviour?

So I'm pretty interested in this: what to others thi k? On Sat., Sep. 21, 2019, 8:16 a.m. Jens Lechtenboerger, < jens.lechtenboer...@fsfe.org> wrote: > On 2019-09-19, Matt Price wrote: > > > Over the summer, commit ded3d27b1468b878197e5fe55a70c5e13350ea27 > > by Nik Clayton was merged to master.

Re: [O] [PATCH] ox-latex.el: Extend :placement attribute to source blocks

Hello, Mario Schlegel writes: > * lisp/ox-latex.el (org-latex-src-block): Extend :placement attribute > to source blocks when the minted package is used. Applied. Thank you! Regards, -- Nicolas Goaziou

Re: [O] [PATCH] org: Prevent loss of `re-search-forward' results

Hello, Max Mouratov writes: > * org.el (org-activate-links): `match-beginning' and `match-end` should > be called shortly after `re-search-forward'. Otherwise, they may return > values corresponding to a different invocation of `re-search-forward'. Applied. Thank you! Regards, -- Nicolas Goa

Re: [O] [PATCH] org-macs: Fix indentation for fullwidth characters

Hello, Yuichiro Hakozaki writes: > @@ -335,7 +335,7 @@ if it fails." >(let ((min-ind (point-max))) > (save-excursion >(while (re-search-forward "^[ \t]*\\S-" nil t) > -(let ((ind (1- (current-column > +

Re: [O] Patch: strip (unneeded) quotes from singular value results

Hello, Mike Ivanov writes: > lisp/ob-lisp.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lisp/ob-lisp.el b/lisp/ob-lisp.el > index e717fc34e..0afb8c053 100644 > --- a/lisp/ob-lisp.el > +++ b/lisp/ob-lisp.el > @@ -107,7 +107,7 @@ a property list containing the parame

Re: [O] [Patch] Hide the file column in a clock report.

Hello, Michaël Cadilhac writes: > Here attached. Let me know if that's all good! It is. Applied. Could you provide an ORG-NEWS entry? Thank you! Regards, -- Nicolas Goaziou

Re: [O] [PATCH] Add org-agenda-show-indirect variable

At 2019-09-01 22:28:00, "Adam Porter" wrote: >tumashu writes: > >> + (when org-agenda-show-indirect >> +(let ((org-indirect-buffer-display 'current-window)) >> + (org-tree-to-indirect-buffer) >> + ;; hide indirect buffer in ibuffer >> + (rename-buffer (concat " "

Re: [O] [PATCH] Add org-agenda-show-indirect variable

tumashu writes: > + (when org-agenda-show-indirect > + (let ((org-indirect-buffer-display 'current-window)) > + (org-tree-to-indirect-buffer) > + ;; hide indirect buffer in ibuffer > + (rename-buffer (concat " " (buffer-name) 1. That does not affect only ibuffer,

Re: [O] [Patch] Hide the file column in a clock report.

Here attached. Let me know if that's all good! Cheers, M. On Sun, 3 Sep 2017 at 03:15, Nicolas Goaziou wrote: > Hello, > > Michaël Cadilhac writes: > > > From f251bf0fa764e245eabe88e3959e801af5c8fd37 Mon Sep 17 00:00:00 2001 > > From: =?UTF-8?q?Micha=C3=ABl=20Cadilhac?= > > Date: Thu, 31 Aug

Re: [O] [PATCH] Fixing org-store-link for eshell

Hello, Abhishek Chandratre writes: > I wanted to use org-store-link for eshell, but it failed. > Looked like dired-directory was nil, I fixed it by calling (eshell/pwd) to > get pwd. > I tested with and without TRAMP, works like a charm. Applied. I added a `declare-function' to silence compilat

Re: [O] patch: adding split-window-right option for src block editing

Hello, "Fraga, Eric" writes: > Please find attached two patch files, both the one I have already sent > and now one with a change to the NEWS file. Applied. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] org.el (org-todo): Respect state argument when called from elisp

Renato Ferreira writes: > (org-todo): Fast selection should only be shown if a state argument was not > used > * list/org.el (org-todo): Respect argument when called from elisp > when calling from elisp (such as in `org-clock-in'). Thanks for the patch! I hit this earlier today but hadn't yet

Re: [O] [PATCH] ob-plantuml.el support for non-UML diagrams

Thanks for this. I've not tested but I appreciate the head's up on the new features in plantuml! -- Eric S Fraga via Emacs 27.0.50, Org release_9.2.4-399-g4e6222

Re: [O] patch: adding split-window-right option for src block editing

On Monday, 15 Jul 2019 at 12:02, Nicolas Goaziou wrote: > Hello, > > "Fraga, Eric" writes: > >> most of my work now involves using quite large wide monitors and having >> the editing of src blocks open windows below is less convenient than >> splitting horizontally. I have added the option to spl

Re: [O] [PATCH] ox-rss: Fix typos

Hello, Applied. Thank you. Regards, -- Nicolas Goaziou

Re: [O] patch: adding split-window-right option for src block editing

Thanks Nicolas. I'm currently travelling for work. I'll add the news item for this change early next week. -- Eric S Fraga via Emacs 27.0.50, Org release_9.2.4-379-g1b74ae

Re: [O] patch: adding split-window-right option for src block editing

Hello, "Fraga, Eric" writes: > most of my work now involves using quite large wide monitors and having > the editing of src blocks open windows below is less convenient than > splitting horizontally. I have added the option to split > horizontally. See attached patch. Thank you. Could you pro

Re: [O] [PATCH] Export with verbatim LaTeX removes spaces

Hello, Michaël Cadilhac writes: > When LaTeX is exported verbatim, some spaces are lost. Try for instance: > M-: (let ((org-html-with-latex 'verbatim)) (org-html-export-as-html)) RET > on a buffer containing "$a$ $b$". Post-blanks were simply not added > back, see below. I applied a variant

Re: [O] [PATCH] doc: Corrected typo, Java script -> JavaScript

Hello, Rovanion Luckey writes: > - a Java script for displaying webpages derived from Org using an > + a JavaScript for displaying webpages derived from Org using an Fixed. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] Feature proposal : support "scale=" includegraphics option in the builtin latex exporter.

Le dimanche 16 juin 2019 à 10:35 +0200, Nicolas Goaziou a écrit : [ Snip... ] > New features are applied to master branch. maint branch is for > bugfixes > only. Okay. I missed that... > Since your patch is a new feature, it went into master branch. It > will > be available in Org 9.3. Hopeful

Re: [O] [PATCH] Feature proposal : support "scale=" includegraphics option in the builtin latex exporter.

Hello, Emmanuel Charpentier writes: > We are now on June 16. The ELPA-distributed org-plus-contrib still does > not carry these patches (re-attached, FWIW). > > I have checked that they are present in the ~master~ branch of the > source tree, but not its ~maint~ branch. > > Am I misunderstanding

Re: [O] [PATCH] Feature proposal : support "scale=" includegraphics option in the builtin latex exporter.

Le mardi 23 avril 2019 à 10:26 +0200, Nicolas Goaziou a écrit : > Hello, > > Emmanuel Charpentier writes: > > > Le lundi 22 avril 2019 à 15:26 +0200, Nicolas Goaziou a écrit : > > > Emmanuel Charpentier writes: > > > > > > > Do you want a direct answer or a partch against /etc/ORG-NEWS ? > > >

Re: [O] [PATCH] org-clock.el: Clear org-clock-current-task on clock cancel

Hello, m...@bcc32.com writes: > From: "Aaron L. Zeng" > > * org-mode/lisp/org-clock.el (org-clock-cancel): Clear > `org-clock-current-task' when a clock is canceled. > > This variable is used by some mode line packages (e.g., > spaceline-all-the-icons), so not clearing the variable incorrectly >

Re: [O] [PATCH] Manual update

Nicolas Goaziou writes: > Hello, > > Cheong Yiufung writes: > >> From 14ff6eb2b451471514206d5126c0af02125ec7e6 Mon Sep 17 00:00:00 2001 >> From: Cheong Yiu Fung >> Date: Mon, 13 May 2019 22:51:08 +0800 >> Subject: [PATCH] org-manual: Small fixes >> >> * doc/org-manual.org (Handling Links): upda

Re: [O] [PATCH] * doc/org-manual.org (External Links): Fix URL

Hello, Gregor Zattler writes: > --- > doc/org-manual.org | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/org-manual.org b/doc/org-manual.org > index 469e16402..583840a74 100644 > --- a/doc/org-manual.org > +++ b/doc/org-manual.org > @@ -3081,7 +3081,7 @@ External li

Re: [O] [PATCH] Manual update

Hello, Cheong Yiufung writes: > From 14ff6eb2b451471514206d5126c0af02125ec7e6 Mon Sep 17 00:00:00 2001 > From: Cheong Yiu Fung > Date: Mon, 13 May 2019 22:51:08 +0800 > Subject: [PATCH] org-manual: Small fixes > > * doc/org-manual.org (Handling Links): update variable > `org-id-link-to-org-use-

Re: [O] [PATCH] Add :target option for the TOC keyword

Whoops, I'm so sorry - I accidentally used org-make-link-string instead of org-link-make-string. Tiny patch fixing it attached. Sacha Chua - sa...@sachachua.com - Blog: sachachua.com - Mobile: +1 416 823 2669 On Fri, May 31, 2019 at 12:30 PM Nicolas Goaziou wrote: > Hello, > > Sacha Chua writ

Re: [O] [PATCH] Add :target option for the TOC keyword

Hello, Sacha Chua writes: > - catch the signal raised by org-export-resolve-fuzzy-link and then check for > the > special case of "local" > - always handle :target "local" as a local TOC > - or just leave the behaviour as it is. What would you recommend? The latter is fine. I applied you patc

Re: [O] [PATCH] Add :target option for the TOC keyword

Nicolas Goaziou writes: Hello, Nicolas! > Thank you! I cannot guess the use case, but you certainly have one :) I'm guessing DC Toedt likes to make Org files that have some kind of overview TOC in a different section. I haven't used it myself, but it seems like a potentially handy thing to have

Re: [O] [PATCH] org-clock.el: Fix restore of frame-title-format

Hello, Andrii Kolomoiets writes: > * lisp/org-clock.el (org-frame-title-format-backup): Use nil as initial value. > (org-clock-in): set `org-frame-title-format-backup' to `frame-title-format'. > (org-clock-restore-frame-title-format): New function. > (org-clock-out): Use it. > (org-clock-cancel)

Re: [O] [PATCH] Docstring update

Hello, "Cheong Yiu Fung" writes: > Fix docstring of `org-latex-packages-alist'. Applied. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] org-clock-out overrides frame-title-format [9.2.3 (9.2.3-17-g4df705-elpa @ ~/.emacs.d/elpa/org-20190513/)]

Hello, Andrii Kolomoiets writes: > The org-frame-title-format-backup variable is initialized on > org-clock.el loading and future changes to frame-title-format is > ignored: > > 1. emacs -Q > 2. M-: frame-title-format >It's "%b" > 3. M-: (require 'org-clock) > 4. (setq frame-title-format "%b

Re: [O] [PATCH] Add :target option for the TOC keyword

Hello, Sacha Chua writes: > Hi! Here's a patch to allow table of contents to target a specified > headline. I've added tests for HTML, ASCII, Markdown, and ODT export. > I should have copyright assignment papers already on file. > > Does it work for anyone other than me? =) Thank you! I cannot

Re: [O] [PATCH] org-manual: Small fixes

Cheong Yiu Fung writes: > * doc/org-manual.org (Handling Links): update variable > `org-id-link-to-org-use-id', which is changed in v7.9.2. Thanks. Because this was relevant for the maint branch as well, I adjusted your commit to apply to maint (tweaking the commit message slightly). -- Kyle

Re: [O] [PATCH] Ruby tests

Hello, Achim Gratz writes: > I no longer have the commit bit since the server software was changed. > If it still requires an account on the server then I don't intend to > create one, either. I don't remember. You may want to ask Bastien about it. The project certainly needs more contributors

Re: [O] [PATCH] Ruby tests

Nicolas Goaziou writes: >> Ruby tests have been failing for quite some time, here's my fix. > > Feel free to push these changes if they fix tests for you. I no longer have the commit bit since the server software was changed. If it still requires an account on the server then I don't intend to cre

Re: [O] [PATCH] Ruby tests

Hello, Achim Gratz writes: > Ruby tests have been failing for quite some time, here's my fix. Feel free to push these changes if they fix tests for you. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] org-attach: Make dispatcher commands customizable

Hello, Eric Danan writes: > Sure, here it is. Applied. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] org-attach: Make dispatcher commands customizable

Sure, here it is. On 2019-04-27 18:51, Nicolas Goaziou wrote: Hello, Eric Danan writes: As discussed previously, https://lists.gnu.org/r/emacs-orgmode/2018-11/msg00038.html here is a patch to make the list of commands in the org-attach dispatcher customizable. Applied, with small fixes.

Re: [O] [PATCH] Fix behaviour of ":dir" when ":mkdirp" is not defined

Am 24.04.2019 um 12:43 schrieb Joaquín Aguirrezabalaga: #+begin_src elisp :dir /tmp/some-test-dir :mkdirp t default-directory #+end_src Do not hardcode "/tmp" in the tests. -- Achim. (on the road :-)

Re: [O] [PATCH] org-attach: Make dispatcher commands customizable

Hello, Eric Danan writes: > As discussed previously, > > https://lists.gnu.org/r/emacs-orgmode/2018-11/msg00038.html > > here is a patch to make the list of commands in the org-attach > dispatcher customizable. Applied, with small fixes. Thank you. Would you mind proving an entry in ORG-NEWS?

Re: [O] [PATCH] Fix behaviour of ":dir" when ":mkdirp" is not defined

Hello, Joaquín Aguirrezabalaga writes: > Hello, > > I think the behaviour of ":dir" is broken since commit 8b5941330 > (ob-core: Make :mkdirp work for :dir too). It only works now if > ":mkdirp" is defined. > > If I execute the following: > > #+begin_src elisp :dir /tmp/some-test-dir > defau

Re: [O] [PATCH] org-manual: Fix typo

Hello, Sebastian Miele writes: > * doc/org-manual.org (Footnotes): Fix typo. Applied. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] Feature proposal : support "scale=" includegraphics option in the builtin latex exporter.

Hello, Emmanuel Charpentier writes: > Le lundi 22 avril 2019 à 15:26 +0200, Nicolas Goaziou a écrit : >> Emmanuel Charpentier writes: >> >> > Do you want a direct answer or a partch against /etc/ORG-NEWS ? >> >> Anything that suits you. > > A patch it is (enclosed). Applied. Thank you. > If

Re: [O] [PATCH] Feature proposal : support "scale=" includegraphics option in the builtin latex exporter.

Le lundi 22 avril 2019 à 15:26 +0200, Nicolas Goaziou a écrit : > Emmanuel Charpentier writes: > > > Do you want a direct answer or a partch against /etc/ORG-NEWS ? > > Anything that suits you. A patch it is (enclosed). If this documentation is customaty, this should be mentioned in the "Contr

Re: [O] [PATCH] Feature proposal : support "scale=" includegraphics option in the builtin latex exporter.

Possible duplicate answer (my email provider isn't very reliable at the moment...). Le lundi 22 avril 2019 à 14:04 +0200, Nicolas Goaziou a écrit : > Hello, > > Emmanuel Charpentier writes: > > > Attached is my proposal for the feature I suggested. My quick tests > > pass[1]. Better tests by so

Re: [O] [PATCH] Feature proposal : support "scale=" includegraphics option in the builtin latex exporter.

Hello, Emmanuel Charpentier writes: > Attached is my proposal for the feature I suggested. My quick tests > pass[1]. Better tests by someone knowledgeable in graphics would be > useful, as well as a test in the test suite. Applied, with some slight fixes. Could you provide an entry in ORG-NEW

Re: [O] [PATCH] ob-sql.el: Option to reference connections in `sql-connection-alist'

Stefano Rodighiero writes: > On Mon, Apr 15, 2019 at 6:11 PM Nicolas Goaziou > wrote: > > Thank you. I applied your patch. > > Great, thank you again for your help. > > Could you also provide an entry in ORG-NEWS? > > Attached. > > regards, > s. Now this patch is applied. I'm curious

Re: [O] [PATCH] ob-sql.el: Option to reference connections in `sql-connection-alist'

Hello, Stefano Rodighiero writes: >> Could you also provide an entry in ORG-NEWS? >> > > Attached. Applied. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] org-manual: Minor fixes

Hello, Sebastian Miele writes: > * doc/org-manual.org (Motion): Fix the names of the four functions > bound to C-c C-n, C-c C-p, C-c C-f, and C-c C-b. Applied. Thank you. I also fixed kindex values. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] ob-sql.el: Option to reference connections in `sql-connection-alist'

On Mon, Apr 15, 2019 at 6:11 PM Nicolas Goaziou wrote: > Thank you. I applied your patch. > Great, thank you again for your help. > Could you also provide an entry in ORG-NEWS? > Attached. regards, s. -- www.stefanorodighiero.net From 802cbc9c8e631c4457934c4ad00b3c6ac2a62105 Mon Sep 17 00

Re: [O] [PATCH] ob-sql.el: Option to reference connections in `sql-connection-alist'

Hello, Stefano Rodighiero writes: > I am attaching a new patch that should address your remarks. > Also, see comments below. Thank you. I applied your patch. Could you also provide an entry in ORG-NEWS? Regards, -- Nicolas Goaziou

Re: [O] [PATCH] ob-sql.el: Option to reference connections in `sql-connection-alist'

On Sun, Apr 7, 2019 at 9:24 AM Nicolas Goaziou wrote: Thank you for your review. I am attaching a new patch that should address your remarks. Also, see comments below. > > +Given a param NAME, if :dbconnection is defined in PARAMS then > > +look for the param into the corresponding connection d

Re: [O] [PATCH] ob-sql.el: Option to reference connections in `sql-connection-alist'

Hello, Stefano Rodighiero writes: > [This is the first patch I ever submitted. Thank you. Some comments follow. > I hope it complies with > your standards: if it does not, I'll be happy to work on it until it's > fine. I am not sure it qualifies as a tiny change.] It does. > Subject: [PATCH

Re: [O] [PATCH] org-drill.el: Fix void function error

Hello, alexander.haec...@web.de writes: > * org-drill.el (org-drill--compute-cloze-keywords, org-drill-cloze-regexp) Use > real function name cl-copy-list instead of alias copy-list, because of void > function error at org startup in emacs 26.1 for org-plus-contrib package. > --- > contrib/l

Re: [O] [PATCH] org-collector.el: Add support for formulas appending

Hello, Slava Barinov writes: > So these options have to be documented? I don't know, hence my question :) However, it is a good habit to document features, IMO. > I think there'll be more than one update then, for example :noquote and :scope > options were not documented as well. I've been sur

Re: [O] [PATCH] org-collector.el: Add support for formulas appending

Hello, So these options have to be documented? I think there'll be more than one update then, for example :noquote and :scope options were not documented as well. I've been sure that it's okay to check source code and find all possible features. Anyway, where should documentation be added? I can

Re: [O] [PATCH] org-collector.el: Add support for formulas appending

Hello, Slava Barinov writes: > * contrib/lisp/org-collector.el (org-dblock-write:propview): add > :tblfm keyword parameter support > > This adds possiblity to append formula line to table which is useful > in certain cases, especially during updates and recalculation of whole > table. Thank y

Re: [O] [PATCH] org-agenda: Add org-agenda-breadcrumbs-separator

Hello, tumashu writes: > +(defcustom org-agenda-breadcrumbs-separator "->" > + "The separator of breadcrumbs in agenda lines." > + :group 'org-agenda-line-format > + :type 'string) I added :package-version and :safe keywords and applied the patch. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] ob-core: Add edit-prep in org-babel-make-language-alias

Hello, Sebastian Miele writes: > Nicolas Goaziou writes: >> Could you provide a commit message for your patch? > > * lisp/ob-core.el (org-babel-make-language-alias): Add edit-prep to > the list of defalias'ed functions. Applied. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] org-agenda: Add org-agenda-breadcrumbs-separator

Added info to ORG-NEW At 2019-03-21 21:49:14, "Nicolas Goaziou" wrote: >Hello, > >tumashu writes: > >> From 7b94df17217c116c882e8a080f686b626c82f45e Mon Sep 17 00:00:00 2001 >> From: Feng Shu >> Date: Thu, 21 Mar 2019 12:49:42 +0800 >> Subject: [PATCH] org-agenda: Add org-agenda-breadcrumb

Re: [O] [PATCH] org-agenda: Add org-agenda-breadcrumbs-separator

Hello, tumashu writes: > From 7b94df17217c116c882e8a080f686b626c82f45e Mon Sep 17 00:00:00 2001 > From: Feng Shu > Date: Thu, 21 Mar 2019 12:49:42 +0800 > Subject: [PATCH] org-agenda: Add org-agenda-breadcrumbs-separator > > * lisp/org-agenda.el (org-agenda-breadcrumbs-separator): New variable.

Re: [O] [PATCH] org-agenda: Add org-agenda-breadcrumbs-separator

tumashu writes: > * lisp/org-agenda.el (org-agenda-breadcrumbs-separator): New variable. > (org-agenda-format-item): Use org-agenda-breadcrumbs-separator +1

Re: [O] [PATCH] make 'org-at-date-range-p work like org-at-timestamp-p

Nicolas, thanks for taking care. But there's another thing. I don't know what I've done to my Org buffer, but what look like timestamps are a mixture of element types 'timestamp and 'planning. Anyway, 'org-at-timestamp-p returns nil for the 'planning timestamps. Which causes breakage. Please t

Re: [O] [PATCH] make 'org-at-date-range-p work like org-at-timestamp-p

Hello, thu...@arcor.de (Thomas Plass) writes: > I don't know what I've done to my Org buffer, but what look like > timestamps are a mixture of element types 'timestamp and 'planning. > > Anyway, 'org-at-timestamp-p returns nil for the 'planning timestamps. > Which causes breakage. That behaviour

Re: [O] [PATCH] make 'org-at-date-range-p work like org-at-timestamp-p

Nicolas, thanks for taking care. But there's another thing. I don't know what I've done to my Org buffer, but what look like timestamps are a mixture of element types 'timestamp and 'planning. Anyway, 'org-at-timestamp-p returns nil for the 'planning timestamps. Which causes breakage. Please t

  1   2   3   4   5   6   7   8   9   10   >