Sounds good. Thanks for your patience, I learned a lot doing this! I
look forward to using it in the wild ;)
Nicolas Goaziou writes:
> John Kitchin writes:
>
>> Ok. I have attached 20 patches with the updates below.
>
> Applied, with minor tweaks (trailing white spaces and too wide lines).
> Tha
John Kitchin writes:
> Ok. I have attached 20 patches with the updates below.
Applied, with minor tweaks (trailing white spaces and too wide lines).
Thank you for all this work.
Ultimately, I removed `org--open-file-link' altogether since default
behaviour for file+apps links DTRT. I also start
Nicolas Goaziou writes:
> John Kitchin writes:
>
>> I am not sure what you mean for this. Let me know if it isn't fixed in
>> the attached patches. I thought I had squashed everything into a concise
>> history.
>
> No worries. Let's just apply the 21 patches.
Ok. I have attached 20 patches with
John Kitchin writes:
> I am not sure what you mean for this. Let me know if it isn't fixed in
> the attached patches. I thought I had squashed everything into a concise
> history.
No worries. Let's just apply the 21 patches.
> I think this code below (which should be in the patches) handles the
Nicolas Goaziou writes:
> Hello,
>
> John Kitchin writes:
>
>> Here are my current suggestions for the org-link 9.0.
>
> Thank you.
I think I fixed the points you made in the previous email.
>
>> Let me know what the best way to send these might be. It looks like it
>> might be 21 patches righ
John Kitchin writes:
> What do you think of this approach:
>
> (defcustom org-link-parameters
> - '(("file" :complete 'org-file-complete-link)
> -("file+emacs" :follow (lambda (path) (org-open-file path '(4
> -("file+sys" :follow (lambda (path) (org-open-file path 'system)))
> + '
Hello,
John Kitchin writes:
> Here are my current suggestions for the org-link 9.0.
Thank you.
> Let me know what the best way to send these might be. It looks like it
> might be 21 patches right now.
AFAIU, many among them introduce code that no longer exists in the final
draft. It would be
Here are my current suggestions for the org-link 9.0. Let me know what
the best way to send these might be. It looks like it might be 21
patches right now. Thanks,
17 files changed, 187 insertions(+), 87 deletions(-)
contrib/orgmanual.org | 27 +
doc/org.texi | 27 +
etc/O
What do you think of this approach:
(defcustom org-link-parameters
- '(("file" :complete 'org-file-complete-link)
-("file+emacs" :follow (lambda (path) (org-open-file path '(4
-("file+sys" :follow (lambda (path) (org-open-file path 'system)))
+ '(("file" :complete #'org-file-compl
K
On Friday, July 8, 2016, Nicolas Goaziou wrote:
> John Kitchin > writes:
>
> > Here are the new revisions that implement the previous solution you
> > suggested and that incorporate the commit merges as far as I can see.
>
> Thank you.
>
> > +(defcustom org-link-parameters
> > + '(("file" :c
John Kitchin writes:
> Here are the new revisions that implement the previous solution you
> suggested and that incorporate the commit merges as far as I can see.
Thank you.
> +(defcustom org-link-parameters
> + '(("file" :complete 'org-file-complete-link)
#'org-file-complete-link
> +("
Hello,
John Kitchin writes:
> I don't understand what you mean here. The contents of org-link
> protocols (in master) looks a lot like a list of (link-type :follow
> :export), e.g.
You're right. Keys in `org-link-protocols' are types.
>> (nth 1 (assoc app org-link-protocols))
>
> I see that
Here are the new revisions that implement the previous solution you
suggested and that incorporate the commit merges as far as I can see.
WDYT?
commit 290213ef3eee86175d5a6b15c7b6173afd0c1616
Author: John Kitchin
Date: Tue Jul 5 10:38:42 2016 -0400
Update the contrib manual
diff --git a/
Let me preface my reply that I think your last suggestion:
> (org-link-get-parameter (if app (concat type "+" app) type) :follow)
Is the thing to do for this set of changes for now. I think it would
wrap up this set of changes. I will send a new set of diffs that
implement this shortly after th
John Kitchin writes:
>> Here is the gotcha. `type' is "file", not "file+sys" or "file+emacs",
>> so, when checking `dedicated-function' first, we cannot tell the
>> difference between "file+sys" and "file+emacs".
>
> I don't follow this. Why can't these be three types?
The type is "file". "sys"
>
> That's great. I realized there's one gotcha left.
>
>>(let* ((option (org-element-property :search-option link))
>> (app (org-element-property :application link))
>> (dedicated-function
>> - (nth 1 (assoc app org-l
Hello,
John Kitchin writes:
> I think I have addressed these. Revised commits appended and at
> https://github.com/jkitchin/org-mode/tree/link-9.0-v3.
>
> The new org-link-set-parameters function you suggested works fine as far
> as I can tell. WDYT?
That's great. I realized there's one gotcha
I think I have addressed these. Revised commits appended and at
https://github.com/jkitchin/org-mode/tree/link-9.0-v3.
The new org-link-set-parameters function you suggested works fine as far
as I can tell. WDYT?
commit f8bb180150514b92535506601c747001da305610
Author: John Kitchin
Date: Tue J
Thanks. I responded to some below. I didn't respond to all of them. I
will revise the commits accordingly and send a new version.
Nicolas Goaziou writes:
> Hello,
>
> John Kitchin writes:
>
>> Your version doesn't let you add properties to links with no
>> existing properties, e.g. ("http")
>
>
Hello,
John Kitchin writes:
> Your version doesn't let you add properties to links with no
> existing properties, e.g. ("http")
There was a typo (spurious `cdr'), the correct version is
(defun org-link-set-parameters (type &rest parameters)
"Set link TYPE properties to PARAMETERS.
PARA
20 matches
Mail list logo
