Re: [O] [PATCH] Fix clocktable scope parameter

2017-03-05 Thread Nicolas Goaziou
Hello, Thank you. Some comments follow. Eduardo Bellani writes: > org-clock.el: Fix clocktable scope parameter Why is it a "fix"? I think this patch belongs to master branch, not maint. > * lisp/org-clock.el (org-dblock-write:clocktable): Funcall the scope > argument if it is a function. >

Re: [O] [PATCH] Fix clocktable scope parameter

2017-03-04 Thread Eduardo Bellani
org-clock.el: Fix clocktable scope parameter * lisp/org-clock.el (org-dblock-write:clocktable): Funcall the scope argument if it is a function. * doc/org.texi: Document the feature of using a function, both bounded and as a lambda form, as the scope for the clocktable. This modifies the beha

Re: [O] [PATCH] Fix clocktable scope parameter

2016-12-16 Thread Nicolas Goaziou
Eduardo Bellani writes: > The only problem I see with this is that it will be backwards > incompatible. > > Any thoughts on that? That's not a problem, as long as there is an entry about it in ORG-NEWS and that the behaviour is properly documented this time. Regards,

Re: [O] [PATCH] Fix clocktable scope parameter

2016-12-16 Thread Eduardo Bellani
Hello Nicolas Goaziou writes: > can also be written, if really needed, > > :scope (lambda () (foo bar baz)) > > I'd favor clarity here and suggest to accept a function of no argument. The only problem I see with this is that it will be backwards incompatible. Any thoughts on that? signature

Re: [O] [PATCH] Fix clocktable scope parameter

2016-12-16 Thread Nicolas Goaziou
Hello, Eduardo Bellani writes: > The old behavior was an eval on a form if that form was not a list of > strings. The implicit expectation was for a list of strings to be > returned by that eval call. > > The above seems to be a raw attempt to evaluate a function form. In that > case, it seems m

Re: [O] [PATCH] Fix clocktable scope parameter

2016-12-15 Thread Eduardo Bellani
Hello Nicolas. > Thank you. However, this is not a "fix" per se. I agree. I should be more explicit as to what this is. >> * lisp/org-clock.el (org-dblock-write:clocktable): Make sure to eval >> the scope if it is a lisp expression, or to return the scope if it >> is just a list. > > This co

Re: [O] [PATCH] Fix clocktable scope parameter

2016-12-15 Thread Nicolas Goaziou
Hello, Eduardo Bellani writes: > org-clock.el: Fix clocktable scope parameter Thank you. However, this is not a "fix" per se. > * lisp/org-clock.el (org-dblock-write:clocktable): Make sure to eval > the scope if it is a lisp expression, or to return the scope if it > is just a list. This

Re: [O] [PATCH] Fix clocktable scope parameter

2016-12-15 Thread Nicolas Goaziou
Hello, "Thomas S. Dye" writes: > orgmanual.org is an old experiment about keeping the org mode manual in > org mode. I don't consider it as an outdated experiment however. I welcome any work to keep it up to date. > The documentation is in org.texi, and this is the one you should work on > fo

Re: [O] [PATCH] Fix clocktable scope parameter

2016-12-15 Thread Eduardo Bellani
org-clock.el: Fix clocktable scope parameter * lisp/org-clock.el (org-dblock-write:clocktable): Make sure to eval the scope if it is a lisp expression, or to return the scope if it is just a list. * doc/org.texi: Document the feature of using a function as the scope for the clocktable. Thi

Re: [O] [PATCH] Fix clocktable scope parameter

2016-12-15 Thread Thomas S. Dye
Aloha Eduardo, orgmanual.org is an old experiment about keeping the org mode manual in org mode. The documentation is in org.texi, and this is the one you should work on for new documentation. All the best, Tom Eduardo Bellani writes: > Hello everyone, > > One extra question, about documentati

Re: [O] [PATCH] Fix clocktable scope parameter

2016-12-15 Thread Eduardo Bellani
Hello everyone, One extra question, about documentation. The place for documenting this feature seems to be 'orgmanual.org'. But my searches revealed that there is also 'org.texi' there. Exporting the first file to the texi format didn't match the second file. Is there a documentation about, wel

Re: [O] [PATCH] Fix clocktable scope parameter

2016-12-15 Thread Eduardo Bellani
Hello Nicolas, I agree with you about introducing 'eval' into the code base. This was just me getting the code from 8.3 back in a format the current code understand. Which leads me to conclude that this is not new functionality, just old undocumented functionality. I've found out about it through

Re: [O] [PATCH] Fix clocktable scope parameter

2016-12-15 Thread Nicolas Goaziou
Hello, Eduardo Bellani writes: > org-clock.el: Fix clocktable scope parameter > > * lisp/org-clock.el (org-dblock-write:clocktable): Make sure to eval > the scope if it is a lisp expression, or to return the scope if it > is just a list. > > This adds back to the clocktable the capacity to h