Hello,
Thank you. Some comments follow.
Eduardo Bellani <ebell...@gmail.com> writes:
> org-clock.el: Fix clocktable scope parameter
Why is it a "fix"? I think this patch belongs to master branch, not
maint.
> * lisp/org-clock.el (org-dblock-write:clocktable): Funcall the scope
> argument if it is a function.
>
> * doc/org.texi: Document the feature of using a function, both bounded
> and as a lambda form, as the scope for the clocktable.
Since a bounded symbol and a lambda form are both functions, I'd rather
not distinguish them. Actually, this distinction is usually not made.
> + symbol @r{scan the files returned by calling the nullary
> function bound to this symbol}
> + lambda-form @r{Same as above, but the nullary function is
> passed as a lambda form.}
See above. I suggest:
function @r{...}
> - ((pred consp) scope)
> + ((pred #'functionp) (funcall scope))
(pred functionp)
> + ((pred listp) scope)
Is there any reason to change consp into listp? This change doesn't
appear in the commit message.
Could you provide an entry in ORG-NEWS? Also, would you mind writing
a couple of simple tests in test-org-clock.el?
Regards,
--
Nicolas Goaziou
