Re: [PATCH v7] Inline image display as part of a new org-link-preview system

2024-10-12 Thread Ihor Radchenko
Karthik Chikmagalur writes: > Suppose a package author is aware that Org now supports previews for > custom link types and wants to add a preview. What section of the > manual would they expect to find this information? "Adding hyperlink types", I think. As you guessed. > My current plan for t

Re: [PATCH v7] Inline image display as part of a new org-link-preview system

2024-10-10 Thread Karthik Chikmagalur
Will address the other issues. I had some questions about the manual. > I think that it is the time to move ahead with updating the ORG-NEWS and > the manual. Suppose a package author is aware that Org now supports previews for custom link types and wants to add a preview. What section of the m

Re: [PATCH v7] Inline image display as part of a new org-link-preview system

2024-10-10 Thread Ihor Radchenko
Karthik Chikmagalur writes: > Latest patch attached. Thanks! See my (minor) comments below. I think that it is the time to move ahead with updating the ORG-NEWS and the manual. > (org-defkey org-mode-map (kbd "C-c C-x C-M-v") #'org-redisplay-inline-images) > > Do we need this command any more?

Re: [PATCH v7] Inline image display as part of a new org-link-preview system

2024-10-07 Thread Karthik Chikmagalur
Latest patch attached. As of this patch, I don't see any flymake errors with the `elisp-flymake-byte-compile' backend. Is this not sufficient? Byte-compiling in my active Emacs session doesn't work as the state is "polluted". I don't know of a convenient way to byte-compile c