Karthik Chikmagalur <karthikchikmaga...@gmail.com> writes: > Latest patch attached.
Thanks! See my (minor) comments below. I think that it is the time to move ahead with updating the ORG-NEWS and the manual. > (org-defkey org-mode-map (kbd "C-c C-x C-M-v") #'org-redisplay-inline-images) > > Do we need this command any more? I don't understand what it does > differently from `org-link-preview'. Calling `org-link-preview' with > the right scope argument (e.g. C-u C-u for buffer-wide) should > automatically refresh/redisplay images. We can simply make it call org-link-preview with C-u C-u argument. > I also don't know what to do about this warning: > > (define-obsolete-variable-alias 'org-plain-link-re > 'org-link-plain-re "9.3") > > org-compat.el:1184:4: Warning: Alias for ‘org-link-plain-re’ should be > declared before its referent > > I think this warning is unrelated to this patch? It is related. The warning is raised because you put (defvar org-link-plain-re) before the obsolete alias. You need to move things further down, after that obsolete definition. > +(declare-function org-link-preview--remove-overlay "ol") > +(declare-function org-link-preview--get-overlays "ol") > +(declare-function org-link-preview-clear "ol") > +(declare-function org-link-preview--remove-overlay "ol") > ... Good idea to provide arglist declaration as well. > +(declare-function org-attach-expand "org-attach") > +(declare-function org-display-inline-image--width "org") > +(declare-function org-image--align "org") > +(declare-function org--create-inline-image "org") same -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
