Re: [PATCH] Turn org-mouse features into minor-modes

2025-04-09 Thread Visuwesh
[புதன் ஏப்ரல் 09, 2025] Ihor Radchenko wrote: > Visuwesh writes: > >>> Although I believe that using conditional menu entries in the keymap >>> will make the code even simpler. Or do I miss some problem with using menus? >> >> You didn't miss anything. It simply didn't occur to me to use >> menu

Re: [PATCH] Turn org-mouse features into minor-modes

2025-04-09 Thread Ihor Radchenko
Visuwesh writes: >> Although I believe that using conditional menu entries in the keymap >> will make the code even simpler. Or do I miss some problem with using menus? > > You didn't miss anything. It simply didn't occur to me to use > menu-items in the above example when I wrote it. It has be

Re: [PATCH] Turn org-mouse features into minor-modes

2025-02-15 Thread Visuwesh
[சனி பிப்ரவரி 15, 2025] Ihor Radchenko wrote: > Visuwesh writes: > >>> `org-mouse--old-mouse-map' is awkward. >>> May we use :enable + menu item instead? >> >> Hmm looking closely at the modifications org-mouse does to >> org-mouse-map, I see a severe interdependence between all the features >> i

Re: [PATCH] Turn org-mouse features into minor-modes

2025-02-15 Thread Ihor Radchenko
Visuwesh writes: >> `org-mouse--old-mouse-map' is awkward. >> May we use :enable + menu item instead? > > Hmm looking closely at the modifications org-mouse does to > org-mouse-map, I see a severe interdependence between all the features > in org-mouse-features. > > There's no way C-mouse-1 will

Re: [PATCH] Turn org-mouse features into minor-modes

2025-02-13 Thread Visuwesh
[வியாழன் ஜனவரி 09, 2025] Ihor Radchenko wrote: Thanks for the review, and sorry for getting back so late. >> +(defvar-local org-mouse--old-mouse-map (copy-keymap org-mouse-map)) >> ... >> +(when org-mouse-minor-mode >> + ;; Without `copy-keymap', later `org-defkey' calls modify the >> +

Re: [PATCH] Turn org-mouse features into minor-modes

2025-02-13 Thread Visuwesh
[வியாழன் ஜனவரி 09, 2025] Ihor Radchenko wrote: Thanks for the review, and sorry for getting back so late. >> +(defvar-local org-mouse--old-mouse-map (copy-keymap org-mouse-map)) >> ... >> +(when org-mouse-minor-mode >> + ;; Without `copy-keymap', later `org-defkey' calls modify the >> +

Re: [PATCH] Turn org-mouse features into minor-modes

2025-01-09 Thread Ihor Radchenko
Visuwesh writes: > Subject: [PATCH] org-mouse: Make it possible to turn on and off the feature Thanks for the update! See my comments inline. > +*** ~org-mouse~ is no longer activated by default by anymore + by anymore+ > +To enable the ~org-mouse~ features, the new minor-modes > +~org-mouse-

Re: [PATCH] Turn org-mouse features into minor-modes

2025-01-07 Thread Visuwesh
[புதன் ஜனவரி 08, 2025] Visuwesh wrote: > [வெள்ளி டிசம்பர் 27, 2024] Ihor Radchenko wrote: > >> Visuwesh writes: >> >>> [ Resending it as it seems like it never reached the mailing list. ] >>> >>> To make loading org-mouse less annoying for all, I was thinking of >>> introducing minor-modes like

Re: [PATCH] Turn org-mouse features into minor-modes

2025-01-07 Thread Visuwesh
[வெள்ளி டிசம்பர் 27, 2024] Ihor Radchenko wrote: > Visuwesh writes: > >> [ Resending it as it seems like it never reached the mailing list. ] >> >> To make loading org-mouse less annoying for all, I was thinking of >> introducing minor-modes like in the attached patch. If this approach is >> ac

Re: [PATCH] Turn org-mouse features into minor-modes

2024-12-27 Thread Ihor Radchenko
Visuwesh writes: >> Although they should probably be globalized to keep things closer to the >> existing behavior. > > That would make it hard to toggle the feature on/off on a per-buffer > basis, which was my intention behind using a minor mode. I don't have > strong opinions here so if you thi

Re: [PATCH] Turn org-mouse features into minor-modes

2024-12-27 Thread Visuwesh
[வெள்ளி டிசம்பர் 27, 2024] Ihor Radchenko wrote: > Visuwesh writes: > >> [ Resending it as it seems like it never reached the mailing list. ] >> >> To make loading org-mouse less annoying for all, I was thinking of >> introducing minor-modes like in the attached patch. If this approach is >> ac

Re: [PATCH] Turn org-mouse features into minor-modes

2024-12-27 Thread Ihor Radchenko
Visuwesh writes: > [ Resending it as it seems like it never reached the mailing list. ] > > To make loading org-mouse less annoying for all, I was thinking of > introducing minor-modes like in the attached patch. If this approach is > acceptable, I will get to calling out the change in NEWS and

[PATCH] Turn org-mouse features into minor-modes

2024-12-26 Thread Visuwesh
[ Resending it as it seems like it never reached the mailing list. ] To make loading org-mouse less annoying for all, I was thinking of introducing minor-modes like in the attached patch. If this approach is acceptable, I will get to calling out the change in NEWS and updating the manual if requ