Re: [Orgmode] [PATCH 0/2] Teach org-version to include git version information

2009-08-19 Thread Bernt Hansen
Manish writes: > On Wed, Aug 19, 2009 at 8:46 PM, Bernt Hansen wrote: >> Nick Dokos writes: >> > [...] >>> >>> Bernt's code checks for the existence of the .git subdirectory >>> in the parent directory of wherever emacs get the org.el[c] library: >>> if it's present, then the assumption is that g

Re: [Orgmode] [PATCH 0/2] Teach org-version to include git version information

2009-08-19 Thread Manish
On Wed, Aug 19, 2009 at 8:46 PM, Bernt Hansen wrote: > Nick Dokos writes: > [...] >> >> Bernt's code checks for the existence of the .git subdirectory >> in the parent directory of wherever emacs get the org.el[c] library: >> if it's present, then the assumption is that git is installed. > > Well m

Re: [Orgmode] [PATCH 0/2] Teach org-version to include git version information

2009-08-19 Thread Bernt Hansen
Nick Dokos writes: > Manish wrote: > > >> ... >> Do we test if git is installed if we are on a non-Windows system or >> show whatever error shell returns in case git is not installed? >> >> I tried calling cygwin git from CMD shell and it seems to work okay. >> So I am guessing we need to figu

Re: [Orgmode] [PATCH 0/2] Teach org-version to include git version information

2009-08-19 Thread Manish
On Wed, Aug 19, 2009 at 8:34 PM, Nick Dokos wrote: > Manish wrote: > > >> ... >> Do we test if git is installed if we are on a non-Windows system or >> show whatever error shell returns in case git is not installed? >> >> I tried calling cygwin git from CMD shell and it seems to work okay. >> So I

Re: [Orgmode] [PATCH 0/2] Teach org-version to include git version information

2009-08-19 Thread Nick Dokos
Manish wrote: > ... > Do we test if git is installed if we are on a non-Windows system or > show whatever error shell returns in case git is not installed? > > I tried calling cygwin git from CMD shell and it seems to work okay. > So I am guessing we need to figure out how to correctly pass gi

Re: [Orgmode] [PATCH 0/2] Teach org-version to include git version information

2009-08-19 Thread Manish
On Wed, Aug 19, 2009 at 8:12 PM, Bernt Hansen wrote: > Nick Dokos writes: > >> Thanks! IIUC, there are then multiple forks in the decision tree: >> >> o running on Windows or on something else? >> >> o if on Windows, running native or under cygwin? >> >> o what shell am I using? cmd.exe

Re: [Orgmode] [PATCH 0/2] Teach org-version to include git version information

2009-08-19 Thread Bernt Hansen
Manish writes: > On Wed, Aug 19, 2009 at 7:47 PM, Bernt Hansen wrote: > [snip: attempting to make git reporting functionality in org-version (29 > lines)] >> >> Maybe I should just disable the git version for now on ms-dos, >> windows-nt, and cygwin since I don't know how to make it work reliabl

Re: [Orgmode] [PATCH 0/2] Teach org-version to include git version information

2009-08-19 Thread Bernt Hansen
Nick Dokos writes: > Thanks! IIUC, there are then multiple forks in the decision tree: > > o running on Windows or on something else? > > o if on Windows, running native or under cygwin? > > o what shell am I using? cmd.exe and bash under cygwin accept > different

Re: [Orgmode] [PATCH 0/2] Teach org-version to include git version information

2009-08-19 Thread Manish
On Wed, Aug 19, 2009 at 7:47 PM, Bernt Hansen wrote: [snip: attempting to make git reporting functionality in org-version (29 lines)] > > Maybe I should just disable the git version for now on ms-dos, > windows-nt, and cygwin since I don't know how to make it work reliably > on windows. > > Opinion

Re: [Orgmode] [PATCH 0/2] Teach org-version to include git version information

2009-08-19 Thread Nick Dokos
Manish wrote: > On Wed, Aug 19, 2009 at 7:32 PM, Nick Dokos wrote: > > Bernt Hansen wrote: > > > > ... > >>(shell-command (concat "GITDIR=" dir " && git describe --abbrev=4 > >> HEAD")) > > ... > > > > Disclaimer: I touch Windows once a day to check a mail account and > > possibly surf the

Re: [Orgmode] [PATCH 0/2] Teach org-version to include git version information

2009-08-19 Thread Bernt Hansen
Nick Dokos writes: > Bernt Hansen wrote: > > ... >> (shell-command (concat "GITDIR=" dir " && git describe --abbrev=4 >> HEAD")) > ... > > Disclaimer: I touch Windows once a day to check a mail account and > possibly surf the web - other than that, I'm pretty much at sea in it > (and I've

Re: [Orgmode] [PATCH 0/2] Teach org-version to include git version information

2009-08-19 Thread Manish
On Wed, Aug 19, 2009 at 7:32 PM, Nick Dokos wrote: > Bernt Hansen wrote: > > ... >>(shell-command (concat "GITDIR=" dir " && git describe --abbrev=4 HEAD")) > ... > > Disclaimer: I touch Windows once a day to check a mail account and > possibly surf the web - other than that, I'm pretty much a

Re: [Orgmode] [PATCH 0/2] Teach org-version to include git version information

2009-08-19 Thread Nick Dokos
Bernt Hansen wrote: ... >(shell-command (concat "GITDIR=" dir " && git describe --abbrev=4 > HEAD")) ... Disclaimer: I touch Windows once a day to check a mail account and possibly surf the web - other than that, I'm pretty much at sea in it (and I've never used emacs on Windows, let al

Re: [Orgmode] [PATCH 0/2] Teach org-version to include git version information

2009-08-19 Thread Manish
On Wed, Aug 19, 2009 at 7:02 PM, Bernt Hansen wrote: > Manish writes: > >> On Wed, Aug 19, 2009 at 6:00 PM, Bernt Hansen wrote: >>> Manish, >>> >>> Could you try this patch - does it work? >> >> Patch application fails.  I tried with patch -p1 as well. >> >> , >> | [Wed 19 18:47] (2118) ~/elisp

Re: [Orgmode] [PATCH 0/2] Teach org-version to include git version information

2009-08-19 Thread Nick Dokos
Bernt Hansen wrote: > Manish writes: > > > On Wed, Aug 19, 2009 at 5:38 PM, Bernt Hansen wrote: > >> Manish writes: > >> > > When I tried to run the function under debug the *Shell Command > > Output* buffer displays this message "The system cannot find the path > > specified." Perhaps this i

Re: [Orgmode] [PATCH 0/2] Teach org-version to include git version information

2009-08-19 Thread Bernt Hansen
Manish writes: > On Wed, Aug 19, 2009 at 5:38 PM, Bernt Hansen wrote: >> Manish writes: >> > When I tried to run the function under debug the *Shell Command > Output* buffer displays this message "The system cannot find the path > specified." Perhaps this is because of the slashes since Windows

Re: [Orgmode] [PATCH 0/2] Teach org-version to include git version information

2009-08-19 Thread Bernt Hansen
Bernt Hansen writes: > Can you try evaluating this? and then M-x org-version and report the > results? Nevermind - that version is broken. -Bernt ___ Emacs-orgmode mailing list Remember: use `Reply All' to send replies to the list. Emacs-orgmode@gnu

Re: [Orgmode] [PATCH 0/2] Teach org-version to include git version information

2009-08-19 Thread Bernt Hansen
Manish writes: > On Wed, Aug 19, 2009 at 6:00 PM, Bernt Hansen wrote: >> Manish, >> >> Could you try this patch - does it work? > > Patch application fails. I tried with patch -p1 as well. > > , > | [Wed 19 18:47] (2118) ~/elisp/org-mode.git $ git apply > org-version-patch-by-bernt.patch > |

Re: [Orgmode] [PATCH 0/2] Teach org-version to include git version information

2009-08-19 Thread Manish
On Wed, Aug 19, 2009 at 5:38 PM, Bernt Hansen wrote: > Manish writes: > >> On Wed, Aug 19, 2009 at 4:54 PM, Bernt Hansen wrote: >>> Does it crash and cause an error or report the old org version as before? >> >> It just reports the version as before; no crashing or error of any sort. > > Okay that

Re: [Orgmode] [PATCH 0/2] Teach org-version to include git version information

2009-08-19 Thread Manish
On Wed, Aug 19, 2009 at 6:00 PM, Bernt Hansen wrote: > Manish, > > Could you try this patch - does it work? Patch application fails. I tried with patch -p1 as well. , | [Wed 19 18:47] (2118) ~/elisp/org-mode.git $ git apply org-version-patch-by-bernt.patch | error: patch failed: lisp/org.el:

Re: [Orgmode] [PATCH 0/2] Teach org-version to include git version information

2009-08-19 Thread Manish
On Wed, Aug 19, 2009 at 5:51 PM, Nick Dokos wrote: > Manish wrote: > >> On Wed, Aug 19, 2009 at 12:45 AM, Carsten Dominik wrote: >> > >> > On Aug 18, 2009, at 8:10 PM, Bernt Hansen wrote: >> > >> >> I don't know if that will work on Windows (with git). I've only tested >> >> it on Linux here. You m

Re: [Orgmode] [PATCH 0/2] Teach org-version to include git version information

2009-08-19 Thread Bernt Hansen
Manish, Could you try this patch - does it work? -Bernt >From 1b26a9ef0a9105d3e855c242fce3a44d1b8cd9c7 Mon Sep 17 00:00:00 2001 From: Bernt Hansen Date: Wed, 19 Aug 2009 08:26:43 -0400 Subject: [PATCH] Fix org-version so

Re: [Orgmode] [PATCH 0/2] Teach org-version to include git version information

2009-08-19 Thread Nick Dokos
Manish wrote: > On Wed, Aug 19, 2009 at 12:45 AM, Carsten Dominik wrote: > > > > On Aug 18, 2009, at 8:10 PM, Bernt Hansen wrote: > > > >> I don't know if that will work on Windows (with git). I've only tested > >> it on Linux here. You may want to test drive it before including it. > > > > I hav

Re: [Orgmode] [PATCH 0/2] Teach org-version to include git version information

2009-08-19 Thread Manish
On Wed, Aug 19, 2009 at 5:38 PM, Bernt Hansen wrote: > Manish writes: > >> On Wed, Aug 19, 2009 at 4:54 PM, Bernt Hansen wrote: >>> Does it crash and cause an error or report the old org version as before? >> >> It just reports the version as before; no crashing or error of any sort. > > Okay that

Re: [Orgmode] [PATCH 0/2] Teach org-version to include git version information

2009-08-19 Thread Bernt Hansen
Manish writes: > On Wed, Aug 19, 2009 at 4:54 PM, Bernt Hansen wrote: >> Does it crash and cause an error or report the old org version as before? > > It just reports the version as before; no crashing or error of any sort. Okay that's good. I don't have Emacs on windows here. If you have time

Re: [Orgmode] [PATCH 0/2] Teach org-version to include git version information

2009-08-19 Thread Manish
On Wed, Aug 19, 2009 at 4:54 PM, Bernt Hansen wrote: > Manish writes: > >> On Wed, Aug 19, 2009 at 12:45 AM, Carsten Dominik wrote: >>> >>> On Aug 18, 2009, at 8:10 PM, Bernt Hansen wrote: >>> I don't know if that will work on Windows (with git). I've only tested it on Linux here. You may

Re: [Orgmode] [PATCH 0/2] Teach org-version to include git version information

2009-08-19 Thread Bernt Hansen
Manish writes: > On Wed, Aug 19, 2009 at 12:45 AM, Carsten Dominik wrote: >> >> On Aug 18, 2009, at 8:10 PM, Bernt Hansen wrote: >> >>> I don't know if that will work on Windows (with git). I've only tested >>> it on Linux here. You may want to test drive it before including it. >> >> I have alre

Re: [Orgmode] [PATCH 0/2] Teach org-version to include git version information

2009-08-19 Thread Manish
On Wed, Aug 19, 2009 at 12:45 AM, Carsten Dominik wrote: > > On Aug 18, 2009, at 8:10 PM, Bernt Hansen wrote: > >> I don't know if that will work on Windows (with git). I've only tested >> it on Linux here. You may want to test drive it before including it. > > I have already included it, please te

Re: [Orgmode] [PATCH 0/2] Teach org-version to include git version information

2009-08-18 Thread Stefan Vollmar
Dear Carsten, dear Bernt, On 18.08.2009, at 21:15, Carsten Dominik wrote: On Aug 18, 2009, at 8:10 PM, Bernt Hansen wrote: I don't know if that will work on Windows (with git). I've only tested it on Linux here. You may want to test drive it before including it. I have already included

Re: [Orgmode] [PATCH 0/2] Teach org-version to include git version information

2009-08-18 Thread Carsten Dominik
On Aug 18, 2009, at 8:10 PM, Bernt Hansen wrote: I don't know if that will work on Windows (with git). I've only tested it on Linux here. You may want to test drive it before including it. I have already included it, please test M-x org-version on your system and let me know if it cause

Re: [Orgmode] [PATCH 0/2] Teach org-version to include git version information

2009-08-18 Thread Bernt Hansen
I don't know if that will work on Windows (with git). I've only tested it on Linux here. You may want to test drive it before including it. -Bernt Carsten Dominik writes: > Awesome! > > I had meant to ask you for this change. > > THanks! > > - Carsten > > On Aug 18, 2009, at 6:22 PM, Bernt H

Re: [Orgmode] [PATCH 0/2] Teach org-version to include git version information

2009-08-18 Thread Carsten Dominik
Awesome! I had meant to ask you for this change. THanks! - Carsten On Aug 18, 2009, at 6:22 PM, Bernt Hansen wrote: This series teaches org-version to include the git version number information from git describe when running org-mode from a git repository. The version is reported as dirt

[Orgmode] [PATCH 0/2] Teach org-version to include git version information

2009-08-18 Thread Bernt Hansen
This series teaches org-version to include the git version number information from git describe when running org-mode from a git repository. The version is reported as dirty if tracked files are modified. This series is available at git://git.norang.ca/org-mode for-carsten Bernt Hansen (2): Ad