Re: [O] Tangling is broken in git master

2012-08-13 Thread Bastien
Nicolas Goaziou writes: > You can have recursive local functions: > > #+begin_src emacs-lisp > (let* (len ; For byte compiler. >(len (lambda (l) (if (not l) 0 > (1+ (funcall len (cdr l))) > (funcall len '(1 2 3))) > #+end_src Indeed

Re: [O] Tangling is broken in git master

2012-08-13 Thread Bastien
Hi Nick, Nick Dokos writes: > I'd suggest that that can be a source of bugs that would be > avoided with a compatibility macro. `org-labels' is an alias for `cl-labels' (when available) or `labels'. There is no need for a compatibility macro here, as the current code is compatible with both E

Re: [O] Tangling is broken in git master

2012-08-13 Thread Nick Dokos
Bastien wrote: > Hi Nick, > > Nick Dokos writes: > > > Can't the definition of letrec in emacs24 be lifted bodily into > > org-compat.el > > (or whatever the correct place is) as a compatibility-with-emacs-23 macro? > > I don't think it's worth the effort. > > The current code works and com

Re: [O] Tangling is broken in git master

2012-08-13 Thread Nicolas Goaziou
Hello, Bastien writes: > Eric Schulte writes: > >> I'm surprised that elisp doesn't provide any mechanism for local >> anonymous functions. > > (let ((my-local-func (lambda (a) (message a > (funcall my-local-func "Hello!")) > > is fine. > > It's just for recursive local function -- l

Re: [O] Tangling is broken in git master

2012-08-13 Thread Bastien
Hi Nick, Nick Dokos writes: > Can't the definition of letrec in emacs24 be lifted bodily into org-compat.el > (or whatever the correct place is) as a compatibility-with-emacs-23 macro? I don't think it's worth the effort. The current code works and compiles without warnings for the user. Gett

Re: [O] Tangling is broken in git master

2012-08-13 Thread Nick Dokos
Eric Schulte wrote: > Bastien writes: > > > Hi Eric, > > > > Eric Schulte writes: > > > >> I've just pushed up another version of this commit, which I believe > >> removes cl-labels while still preserving tangling behavior. If you have > >> a chance please re-check tangling with the latest Or

Re: [O] Tangling is broken in git master

2012-08-13 Thread Bastien
Hi Eric, Eric Schulte writes: > I'm surprised that elisp doesn't provide any mechanism for local > anonymous functions. (let ((my-local-func (lambda (a) (message a (funcall my-local-func "Hello!")) is fine. It's just for recursive local function -- letrec provides it now, but appa

Re: [O] Tangling is broken in git master

2012-08-13 Thread Eric Schulte
Bastien writes: > Hi Eric, > > Eric Schulte writes: > >> I've just pushed up another version of this commit, which I believe >> removes cl-labels while still preserving tangling behavior. If you have >> a chance please re-check tangling with the latest Org-mode. > > `letrec' is not available on

Re: [O] Tangling is broken in git master

2012-08-13 Thread Bastien
Hi Eric, Eric Schulte writes: > I've just pushed up another version of this commit, which I believe > removes cl-labels while still preserving tangling behavior. If you have > a chance please re-check tangling with the latest Org-mode. `letrec' is not available on Emacs <24.1 Your commit loo

Re: [O] Tangling is broken in git master

2012-08-13 Thread Eric Schulte
Bastien writes: > Bernt Hansen writes: > >> That doesn't work. There's a missing ) at the end of the defalias and >> after I add that I get > > Er, sorry for the typo. > > I've reverted this commit for now, I'll see if I can get rid of > cl-labels another way. > I've just pushed up another ver

Re: [O] Tangling is broken in git master

2012-08-12 Thread Bastien
Bernt Hansen writes: > That doesn't work. There's a missing ) at the end of the defalias and > after I add that I get Er, sorry for the typo. I've reverted this commit for now, I'll see if I can get rid of cl-labels another way. Thanks, -- Bastien

Re: [O] Tangling is broken in git master

2012-08-12 Thread Bernt Hansen
Achim Gratz writes: > Bernt Hansen writes: >> Tangling doesn't work for me in git master anymore. Git bisect >> identifies the following commit as introducing the problem > [...] >> Debugger entered--Lisp error: (void-function letrec) >> (letrec ((intersect ...)) (funcall intersect (case conte

Re: [O] Tangling is broken in git master

2012-08-12 Thread Bernt Hansen
Bastien writes: > Hi Bernt, > > Bernt Hansen writes: > >> Tangling doesn't work for me in git master anymore. Git bisect >> identifies the following commit as introducing the problem > > Please try the attached patch and let us know if it works. > > Thanks, That doesn't work. There's a missin

Re: [O] Tangling is broken in git master

2012-08-12 Thread Bastien
Hi Bernt, Bernt Hansen writes: > Tangling doesn't work for me in git master anymore. Git bisect > identifies the following commit as introducing the problem Please try the attached patch and let us know if it works. Thanks, >From 45c517919756b7af78b720e454e8ea8d969f6a43 Mon Sep 17 00:00:00 2

Re: [O] Tangling is broken in git master

2012-08-11 Thread Achim Gratz
Bernt Hansen writes: > Tangling doesn't work for me in git master anymore. Git bisect > identifies the following commit as introducing the problem [...] > Debugger entered--Lisp error: (void-function letrec) > (letrec ((intersect ...)) (funcall intersect (case context ... ... ...) > (split-stri

[O] Tangling is broken in git master

2012-08-11 Thread Bernt Hansen
Hi Bastien, Tangling doesn't work for me in git master anymore. Git bisect identifies the following commit as introducing the problem --8<---cut here---start->8--- ba16c3c6f50738b070769040586945436439be76 is the first bad commit commit ba16c3c6f50738b070769040