Re: [O] Replaced obsolete interactive-p function

2011-07-01 Thread Bastien
Hi Eric, Eric Schulte writes: > This extra argument supplies more information to the macro (e.g., an > idea of /how/ interactive is considered /interactive/) through taking on > the value of 'any or 'interactive. This information is thrown out in > older versions of Emacs but is passed on to th

Re: [O] Replaced obsolete interactive-p function

2011-06-30 Thread Eric Schulte
Bastien writes: > Hi Eric and Michael, > > Eric Schulte writes: > >> Michael's patch looks great to me, I can confirm that it does stifle the >> warnings on Emacs24, and everything compiles and works as expected -- at >> least as far as the Org-mode test suite is able to differentiate. > > Thank

Re: [O] Replaced obsolete interactive-p function

2011-06-30 Thread Bastien
Michael Markert writes: > Appended is a patch to the macro that checks on expand which interactive > predicate we need. > I don't see those warnings anymore and a quick check showed that it > behaves as the complete version (at least on emacs24). Thanks for this patch Michael! -- Bastien

Re: [O] Replaced obsolete interactive-p function

2011-06-30 Thread Bastien
Hi Eric and Michael, Eric Schulte writes: > Michael's patch looks great to me, I can confirm that it does stifle the > warnings on Emacs24, and everything compiles and works as expected -- at > least as far as the Org-mode test suite is able to differentiate. Thanks to Michael for the patch, it

Re: [O] Replaced obsolete interactive-p function

2011-06-29 Thread Eric Schulte
Michael's patch looks great to me, I can confirm that it does stifle the warnings on Emacs24, and everything compiles and works as expected -- at least as far as the Org-mode test suite is able to differentiate. In addition to applying this patch I've also added another patch which supplies the op

Re: [O] Replaced obsolete interactive-p function

2011-06-29 Thread Carsten Dominik
I suggest to talk to Eric Schulte before applying this patch - Carsten On 30.6.2011, at 00:29, Michael Markert wrote: > On 29 Jun 2011, Bastien wrote: > >> Dear all, >> >> interactive-p is obsolete since Emacs 23.2 and should be replaced by >> called-interactively-p. >> >> The org-called-

Re: [O] Replaced obsolete interactive-p function

2011-06-29 Thread Michael Markert
On 29 Jun 2011, Bastien wrote: > Dear all, > > interactive-p is obsolete since Emacs 23.2 and should be replaced by > called-interactively-p. > > The org-called-interactively-p macro takes care of using either > interactive-p or called-interactively-p. > > I've just updated the latest git and Org

[O] Replaced obsolete interactive-p function

2011-06-29 Thread Bastien
Dear all, interactive-p is obsolete since Emacs 23.2 and should be replaced by called-interactively-p. The org-called-interactively-p macro takes care of using either interactive-p or called-interactively-p. I've just updated the latest git and Org uses org-called-interactively-p wherever it m