Bastien <b...@altern.org> writes: > Hi Eric and Michael, > > Eric Schulte <schulte.e...@gmail.com> writes: > >> Michael's patch looks great to me, I can confirm that it does stifle the >> warnings on Emacs24, and everything compiles and works as expected -- at >> least as far as the Org-mode test suite is able to differentiate. > > Thanks to Michael for the patch, it does indeed fix the warnings. > >> In addition to applying this patch I've also added another patch which >> supplies the optional KIND argument to every invocation of >> org-called-interactively-p. > > I thought the absence of argument was taken care by the > org-called-interactively-p macro -- see the (with-no-warning ...) > sexp in it, and the comment. > > Eric, any reason for explicitely adding an argument? > > I understand it's better for readability and it will ease the future > replacement of org-called-interactively-p by called-interactively-p, > but I was just curious to know if there was some other reasons. >
This extra argument supplies more information to the macro (e.g., an idea of /how/ interactive is considered /interactive/) through taking on the value of 'any or 'interactive. This information is thrown out in older versions of Emacs but is passed on to the called-interactively-p function in Emacs24 and should influence its behavior. Cheers -- Eric > > Thanks! -- Eric Schulte http://cs.unm.edu/~eschulte/
