Re: [O] [PATCH 1/3] ob-table: Fix org-sbe's handling of quotes in arguments

2018-03-18 Thread Nicolas Goaziou
Vladimir Panteleev writes: > Ah! Well, thanks for the clarification, and apologies for the > confusion. Well, thanks for bearing with me. >> I consider it to be a bug if you need to write $"string" instead of >> "string" in any `org-sbe' call. We should not test such a mis-feature, >> which sho

Re: [O] [PATCH 1/3] ob-table: Fix org-sbe's handling of quotes in arguments

2018-03-18 Thread Vladimir Panteleev
Hi, On 2018-03-18 22:24, Nicolas Goaziou wrote: We're clearly mis-communicating. I know the difference between a symbol and a string, and how `read' operates. I think what puzzles me is some design choices made in `org-sbe', and the fact that the second note of its docstring is clear as mud. A

Re: [O] [PATCH 1/3] ob-table: Fix org-sbe's handling of quotes in arguments

2018-03-18 Thread Nicolas Goaziou
Hello, Vladimir Panteleev writes: > On 2018-03-14 15:00, Nicolas Goaziou wrote: >> I disagree. You are testing an implementation detail here: the fact that >> "$" is not necessarily a prefix. According to the docstring, it should >> be, so the test should use that, too. What if we rewrite `org-

Re: [O] [PATCH 1/3] ob-table: Fix org-sbe's handling of quotes in arguments

2018-03-14 Thread Vladimir Panteleev
On 2018-03-14 15:00, Nicolas Goaziou wrote: Vladimir Panteleev writes: I wrote about this in the cover letter too. $"foo" and $ "foo" are both the same thing. Just to make it clear: I read the cover letter. My confusion doesn't come from the fact I may not have read it. In that case, I need

Re: [O] [PATCH 1/3] ob-table: Fix org-sbe's handling of quotes in arguments

2018-03-14 Thread Nicolas Goaziou
Vladimir Panteleev writes: > I wrote about this in the cover letter too. $"foo" and $ "foo" are > both the same thing. Just to make it clear: I read the cover letter. My confusion doesn't come from the fact I may not have read it. > In both cases, they are two distinct lisp tokens. > The way $

Re: [O] [PATCH 1/3] ob-table: Fix org-sbe's handling of quotes in arguments

2018-03-14 Thread Vladimir Panteleev
Hi, On 2018-03-14 13:49, Nicolas Goaziou wrote: Vladimir Panteleev writes: I agree that it is strange. I mentioned it (and its strangeness) in the cover-letter. The documentation of org-sbe describes it as well. AFAICT, it doesn't. "org-sbe" describes a dollar _prefix_, but yours stands on i

Re: [O] [PATCH 1/3] ob-table: Fix org-sbe's handling of quotes in arguments

2018-03-14 Thread Nicolas Goaziou
Hello, Vladimir Panteleev writes: > I agree that it is strange. I mentioned it (and its strangeness) in > the cover-letter. The documentation of org-sbe describes it as well. AFAICT, it doesn't. "org-sbe" describes a dollar _prefix_, but yours stands on its own. It prefixes nothing. Also, it se

Re: [O] [PATCH 1/3] ob-table: Fix org-sbe's handling of quotes in arguments

2018-03-13 Thread Vladimir Panteleev
Hi, On 2018-03-12 23:15, Nicolas Goaziou wrote: The dollar character looks strange. What syntax is that? I agree that it is strange. I mentioned it (and its strangeness) in the cover-letter. The documentation of org-sbe describes it as well. +#+name: identity +#+begin_src emacs-lisp :eval

Re: [O] [PATCH 1/3] ob-table: Fix org-sbe's handling of quotes in arguments

2018-03-12 Thread Nicolas Goaziou
Hello, Vladimir Panteleev writes: > * ob-table.el (org-sbe): (org-sbe func (x $ "a\"b\"c")) did the wrong The dollar character looks strange. What syntax is that? > - (quote (format "\"%s\"" el)) > + (quote (format "%S"

[O] [PATCH 1/3] ob-table: Fix org-sbe's handling of quotes in arguments

2018-03-08 Thread Vladimir Panteleev
* ob-table.el (org-sbe): (org-sbe func (x $ "a\"b\"c")) did the wrong thing because org-sbe would simply wrap any $-prefixed value in quotes, without any escaping. Fix this by using "%S" (instead of "\"%s\""). * test-ob-table.el: Add test. --- lisp/ob-table.el | 2 +- testing/lisp/t