Hi, On 2018-03-18 22:24, Nicolas Goaziou wrote:
We're clearly mis-communicating. I know the difference between a symbol and a string, and how `read' operates. I think what puzzles me is some design choices made in `org-sbe', and the fact that the second note of its docstring is clear as mud.
Ah! Well, thanks for the clarification, and apologies for the confusion.
I consider it to be a bug if you need to write $"string" instead of "string" in any `org-sbe' call. We should not test such a mis-feature, which should be removed.
Agreed completely, but, wouldn't this be a breaking change? So far I've tried to avoid breaking any meaningful existing uses of org-sbe.
Let me insist on this. $"string" (or $ "string") is very wrong. Please do not write your tests on top of this. IIUC, `org-sbe' is about passing table fields into source blocks. Let's test that instead, with a table, and a source block. I don't mind superfluous coverage. It is just a matter of tests. Your changes sound good. So, would you mind adjusting your tests so we can move forward?
No problem. To clarify, would you prefer tests which still use $-prefixing, but with a table cell reference to get the value in the cell (i.e. $$2), or tests which do not use $-prefixing in order to interpret the string in the table cell as a reference to another block in the org-mode document?
-- Best regards, Vladimir
