Hello,
stardiviner writes:
> From 4519624de8543205533b89e05d14e308d891f45b Mon Sep 17 00:00:00 2001
> From: stardiviner
> Date: Mon, 4 Jun 2018 12:02:55 +0800
> Subject: [PATCH] ob-shell.el: Initialize header arguments for other shell
> names too
>
> * lisp/ob-shell.el (org-babel-shell-initial
>From 4519624de8543205533b89e05d14e308d891f45b Mon Sep 17 00:00:00 2001
From: stardiviner
Date: Mon, 4 Jun 2018 12:02:55 +0800
Subject: [PATCH] ob-shell.el: Initialize header arguments for other shell
names too
* lisp/ob-shell.el (org-babel-shell-initialize) initialize
org-babel-default-header
Hello,
stardiviner writes:
> Add "zsh" and "fish" into ob-shell support.
Applied. Thank you.
Regards,
--
Nicolas Goaziou
Add "zsh" and "fish" into ob-shell support.
From 699f8623542b5903b5291dd10d7bdaa74d5b25bd Mon Sep 17 00:00:00 2001
From: stardiviner
Date: Sun, 1 Apr 2018 14:27:01 +0800
Subject: [PATCH] * ob-shell.el (org-babel-shell-names) add "zsh" and "fish".
---
lisp/ob-shell.el | 2 +-
1 file changed, 1 i
Pascal Fleury writes:
> Here is a patch that will figure out the version of bash in a less
> fork-y way. It keeps the result in a variable after having gotten it
> the first time by indeed forking to bash.
I still think this should be a defcustom instead with a setter function
that checks for the
Hello,
Here is a patch that will figure out the version of bash in a less fork-y
way.
It keeps the result in a variable after having gotten it the first time by
indeed forking to bash.
--Pascal
On Fri, Aug 22, 2014 at 8:16 PM, Achim Gratz wrote:
> Pascal Fleury writes:
> > Please forget about
Pascal Fleury writes:
> Please forget about the previous patch I submitted, I have a new one
> that should work now on all platforms.
> Let me know if it should be formatted differently.
You don't really want to fork into bash each time you're about to run a
shell code block just to find out if it
Hello,
I have a little patch (attached) that does check the version of bash, and
uses associative arrays (or doesn't) depending on that version.
The problem now is that the test suite will only work on one platform t a
time, i.e. if there is a bash4 there, it will pass, but if it has bash3, it
wi
On 2014-08-13 15:20, Pascal Fleury writes:
> Yes, sorry for late reaction (it's holiday season here :-).
Funny, it's holiday season here as well (in Bretagne) ;-)
> This is an issue I introduced with the assoc. arrays, which does not
> verify if the installed version of bash handles them (from
Yes, sorry for late reaction (it's holiday season here :-).
This is an issue I introduced with the assoc. arrays, which does not verify
if the installed version of bash handles them (from bash4 on).
It needs a modification in the setup code that checks the version and only
issues assoc. array code
On 2014-08-04 21:48, Achim Gratz writes:
> Alan Schmitt writes:
>> Has this been applied? I'm still seeing a failing test for ob-shell.
>>
>> 1 unexpected results:
>>FAILED ob-shell/bash-uses-assoc-arrays
>
> That's to be expected if you use a version of bash that doesn't support
> assoc arr
Alan Schmitt writes:
> Has this been applied? I'm still seeing a failing test for ob-shell.
>
> 1 unexpected results:
>FAILED ob-shell/bash-uses-assoc-arrays
That's to be expected if you use a version of bash that doesn't support
assoc arrays. WHat is the backtrace from the test? Babel (and
Alan Schmitt writes:
> Hello,
>
> On 2014-06-22 14:50, Eric Schulte writes:
>
>> If this maintains existing functionality, please go ahead and apply it.
>
> Has this been applied? I'm still seeing a failing test for ob-shell.
>
> 1 unexpected results:
>FAILED ob-shell/bash-uses-assoc-arrays
Hi Achim,
Achim Gratz writes:
> I've added all user-visible changes from me that will go into 8.3.
Thanks for this. Any committer can add visible changes from anyone,
so please feel free.
Best,
--
Bastien
Hello,
On 2014-06-22 14:50, Eric Schulte writes:
> If this maintains existing functionality, please go ahead and apply it.
Has this been applied? I'm still seeing a failing test for ob-shell.
1 unexpected results:
FAILED ob-shell/bash-uses-assoc-arrays
Best,
Alan
--
OpenPGP Key ID : 04
Bastien writes:
> In the perspective of Org 8.3, we need to start updating etc/ORG-NEWS.
Done.
> Regardless of whether this was documented in the official manual or
> not, a note in ORG-NEWS would be useful -- feel free to start editing
> this file.
I've added all user-visible changes from me th
Hi Achim,
thanks for this.
Achim Gratz writes:
> In the case you mention above shell-file-name is used. Which means that
> if you change it in a running emacs session, then it will be picked up
> for shell blocks (as one might reasonably expect), whereas you would
> have had to change org-babe
[re-sent, sorry if you get this twice]
Eric Schulte writes:
> If this maintains existing functionality, please go ahead and apply it.
Done on master. The tests are left untouched, I will not have time to
do anything there for the next few days. Any helping hand is welcome.
Regards,
Achim.
--
Eric Schulte writes:
> I thought that `org-babel-sh-command' was still used if code blocks used
> the keyword "shell" as the language. If that's not the case and there
> really is no more use for `org-babel-sh-command', then please go ahead
> and apply this patch.
Done on master.
In the case you
Pascal Fleury writes:
> I was wondering how it would behave if the string that is put into a
> variable contains newlines, backslashes and other things that bash
> (and other shells) treats specially.
Exactly like it does with the earlier method, except it doesn't fork and
doesn't require certain
Hi Achim,
I was wondering how it would behave if the string that is put into a
variable contains newlines, backslashes and other things that bash (and
other shells) treats specially. The trick with cat and BABEL_TABLE is
resistant to this. As in many cases (when I use it at least) the variable
com
If this maintains existing functionality, please go ahead and apply it.
Thanks,
Achim Gratz writes:
> Achim Gratz writes:
>> Sebastien Vauban writes:
>>> I just ran `make test' and got the same error for
>>> `ob-shell/bash-uses-assoc-arrays'.
>>
>> Yes, that's because not all versions of bash t
I thought that `org-babel-sh-command' was still used if code blocks used
the keyword "shell" as the language. If that's not the case and there
really is no more use for `org-babel-sh-command', then please go ahead
and apply this patch.
Thanks,
--
Eric Schulte
https://cs.unm.edu/~eschulte
PGP: 0
When using a shell block with a :session, the specified shell is ignored
and the original value of org-babel-sh-command (defaulting to the value
of shell-file-name as set at load-time) gets used. The following patch
fixes this, however there are still several other problems with how
shells are in
Achim Gratz writes:
> Sebastien Vauban writes:
>> I just ran `make test' and got the same error for
>> `ob-shell/bash-uses-assoc-arrays'.
>
> Yes, that's because not all versions of bash that have associative
> arrays can parse the bizarre quoting style that goes through a
> sub-process and here-do
25 matches
Mail list logo
