Re: [O] [PATCH] ob-eval: display error fix

2023-04-14 Thread Ihor Radchenko
Andreas Gerler writes: > * lisp/ob-eval.el: (org-babel-eval-error-notify): Display standard > error only if command exits non zero. > > The problem is that sql connections might give warnings. > Now the information is available in the *Org-Babel Error* buffer > without displaying. > If you need a

Re: [O] [PATCH] ob-eval: display error fix

2023-02-03 Thread Andreas Gerler
Hi Ihor, way too busy right now. As soon as I find some time I’ll rework that change. Might take a week or two. so long... Andreas Gerler > On Jan 27, 2023, at 2:11 PM, Ihor Radchenko wrote: > > Andreas Gerler writes: > >> +(defcustom org-babel-eval-error-display-notify nil >> + "Display

Re: [O] [PATCH] ob-eval: display error fix

2023-01-27 Thread Ihor Radchenko
Andreas Gerler writes: > +(defcustom org-babel-eval-error-display-notify nil > + "Display org-babel-eval-errors always or only if exit code is not 0." This docstring is confusing. What will happen if the value is nil? non-nil? I cannot answer these questions by reading the docstring. Also, wha

Re: [O] [PATCH] ob-eval: display error fix

2023-01-26 Thread General discussions about Org-mode.
Ping -- I don't think anyone else has replied / reviewed this patch yet, unless it has happened in a different thread. Best, RY Andreas Gerler writes: > [[PGP Signed Part:Undecided]] > > [2. text/x-patch; 0001-lisp-ob-eval.el-Display-error-fix.patch]... > > > > Hi Ruijie, > > thanks for ask

Re: [O] [PATCH] ob-eval: display error fix

2023-01-08 Thread Andreas Gerler
0001-lisp-ob-eval.el-Display-error-fix.patch Description: Binary data Hi Ruijie, thanks for asking. I combined them now and tested again all variants. Andreas > On 7. Jan 2023, at 22:33, Ruijie Yu via General discussions about Org-mode. > wrote: > > > Hi Andreas, > > -(display-buff

Re: [O] [PATCH] ob-eval: display error fix

2023-01-07 Thread General discussions about Org-mode.
Hi Andreas, -(display-buffer buf)) +(if org-babel-eval-error-display-notify +(display-buffer buf) + (if (or (not (numberp exit-code)) + (> exit-code 0)) + (display-buffer buf Quick question, does it help or hurt readability if we change this nested

[O] [PATCH] ob-eval: display error fix

2023-01-07 Thread Andreas Gerler
0001-lisp-ob-eval.el-Display-error-fix.patch Description: Binary data Dear all, since commit f7b16402e6a694d592210f766544f6114056b4b0 every sql code block is displaying the *Org-Babel Error Output* for me due to warning messages from the database. I added a check to display the buffer only

Re: [O] [PATCH 2/4] ob-clojure.el: Add ClojureScript interface

2020-02-12 Thread stardiviner
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, any update on this patch? I still have this feature reminder in my GTD. Really hope ob-clojure.el can support ClojureScript too. If possible, hope this can integrate with current CIDER new session manager "sesman". roberthambr...@gmail.com wr

Re: [O] [PATCH] org-manual: Dynamic Blocks: Fix explanation of :content

2019-11-16 Thread Kyle Meyer
Sebastian Miele writes: > * doc/org-manual.org (Dynamic Blocks): Correct the information given > on :content in the plist passed to the writer function. Looks correct to me. Applied in 634880a2e. Thanks.

[O] [PATCH] COMMENT and noweb-ref

2019-10-20 Thread Sebastian Miele
Sorry. I messed up the previous mail. Please ignore it. I wrote: > org-babel-tangle on > > * A > > #+BEGIN_SRC elisp :tangle yes :noweb yes > ;; A > <> > #+END_SRC > > * COMMENT B > > #+BEGIN_SRC elisp :noweb-ref B > ;; B > #+END_SRC > > * COMMENT C > > #+BEG

[O] [PATCH] COMMENT and noweb-ref

2019-10-20 Thread Sebastian Miele
>From ddf0b6d89d30766158311c047d6de10091cb0377 Mon Sep 17 00:00:00 2001 From: Sebastian Miele Date: Sun, 20 Oct 2019 21:34:02 + Subject: [PATCH 1/2] ob-core: Respect COMMENTed headlines when expanding noweb references * lisp/ob-core.el (org-babel-expand-noweb-references): Add calls to org-in

Re: [O] [PATCH] Add :eval only-manual to babel blocks

2019-10-17 Thread Nicolas Goaziou
Hello, Ken Mankoff writes: > On 2019-10-16 at 12:38 +02, Nicolas Goaziou wrote... > > Would you accept a documentation patch that defines the current > behavior? I don't know enough of the problem to answer. A default answer which in neither "yes" or "no" is odd. Let's discuss it with other us

Re: [O] [PATCH] Respect buffer-local value of `org-edit-src-content-indentation'

2019-10-16 Thread Sebastian Miele
Hello Adam, Adam Porter writes: > You might consider using the function buffer-local-value instead of the > macro with-current-buffer. Not that it matters so much here, but > benchmarking shows that it is much faster when simply accessing the > buffer-local value of a variable. Thank you. Such

Re: [O] [PATCH] Add :eval only-manual to babel blocks

2019-10-16 Thread Ken Mankoff
On 2019-10-16 at 12:38 +02, Nicolas Goaziou wrote... > Of course, meawhile, do not rely on undefined behaviour :) Would you accept a documentation patch that defines the current behavior? Then I get what I want, and it is on future developers to not mess it up :). -k.

Re: [O] [PATCH] ox-html: add option to restore old src block behaviour?

2019-10-16 Thread Nicolas Goaziou
Hello, Jens Lechtenboerger writes: > Thanks! A patch is attached. Applied. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] Add :eval only-manual to babel blocks

2019-10-16 Thread Nicolas Goaziou
Hello, Ken Mankoff writes: > Can you provide a more obvious hint? :) I don't have enough time to help you more on that, sorry. I didn't even look closely to the issue you're encountering. Hopefully, someone else on the ML can provide guidance on it. > I've read the documentation on called-inte

Re: [O] [PATCH] Add :eval only-manual to babel blocks

2019-10-16 Thread Ken Mankoff
Hi Nicolas, On 2019-10-16 at 12:38 +02, Nicolas Goaziou wrote... > Note that what you want, i.e., to distinguish behaviour depending on > the location of the call stack is cheesy, at best. Think about macros, > user-defined functions, etc. Yes, it felt a bit hackish. But I'm new to this level of

Re: [O] [PATCH] Add :eval only-manual to babel blocks

2019-10-16 Thread Nicolas Goaziou
Hello, Ken Mankoff writes: > Hmm. So it turns out (I think) this patch isn't necessary. The > behavior I wanted and thought I implemented is actually the default > behavior! I think the behavior is undefined for :eval not equal to > "yes", "no", or "query", but the current undefined implementati

Re: [O] [PATCH] Add :eval only-manual to babel blocks

2019-10-15 Thread Ken Mankoff
On 2019-10-14 at 09:10 +02, Ken Mankoff wrote... > With this patch and ":eval only-manual" in a babel header, > > Org evaluates the source code if it is run via ~org-ctrl-c-ctrl-c~ > (e.g. =C-c C-c= in the babel block), but not if run via the > ~org-babel-execute-buffer~ function. Hmm. So it tu

Re: [O] [PATCH] Respect buffer-local value of `org-edit-src-content-indentation'

2019-10-15 Thread Adam Porter
Hi Sebastian, Sebastian Miele writes: > * lisp/org-src.el (org-src--contents-for-write-back): Use the > potentially buffer-local value of `org-edit-src-content-indentation' > from the source buffer instead of that from the editing buffer. > --- > lisp/org-src.el | 3 ++- > 1 file changed, 2 ins

[O] [PATCH] Respect buffer-local value of `org-edit-src-content-indentation'

2019-10-14 Thread Sebastian Miele
* lisp/org-src.el (org-src--contents-for-write-back): Use the potentially buffer-local value of `org-edit-src-content-indentation' from the source buffer instead of that from the editing buffer. --- lisp/org-src.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/org-src.

[O] [PATCH] org-manual: Dynamic Blocks: Fix explanation of :content

2019-10-14 Thread Sebastian Miele
* doc/org-manual.org (Dynamic Blocks): Correct the information given on :content in the plist passed to the writer function. --- doc/org-manual.org | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/doc/org-manual.org b/doc/org-manual.org index 59591894d..79257b7e0 100644

[O] [PATCH] Add :eval only-manual to babel blocks

2019-10-14 Thread Ken Mankoff
With this patch and ":eval only-manual" in a babel header, Org evaluates the source code if it is run via ~org-ctrl-c-ctrl-c~ (e.g. =C-c C-c= in the babel block), but not if run via the ~org-babel-execute-buffer~ function. This is my first contribution to Org core. I've signed FSF papers.

Re: [O] [PATCH] ox-html: add option to restore old src block behaviour?

2019-10-13 Thread Jens Lechtenboerger
On 2019-10-13, at 09:30, Nicolas Goaziou wrote: > Jens Lechtenboerger writes: > >> Subject: [PATCH] ox-html: Control wrapping of source lines >> >> * lisp/ox-html.el (org-html-format-code, org-html-do-format-code): >> Use new export option :html-wrap-src-lines with variable >> org-html-wrap-s

Re: [O] [PATCH] ob-ocaml: Support for pretty-printed outputs

2019-10-13 Thread Nicolas Goaziou
Hello, "Robert M. Kovacsics" writes: > Subject: [PATCH] ob-ocaml: Support for pretty-printed outputs > > E.g. the following snippet produces multiple lines of output, due to > pretty-printing > > #+BEGIN_SRC ocaml :exports code :eval no-export :results verbatim > (* Note, no need to have parent

Re: [O] [PATCH] Document "help:" Org link type in manual

2019-10-13 Thread Nicolas Goaziou
Hello, Robert Irelan writes: > Patch attached Thank you. However, I couldn't apply your patch since manual changed quite a bit in this area not so long ago. I adapted your patch to the new structure and applied it. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] ox-html: add option to restore old src block behaviour?

2019-10-13 Thread Nicolas Goaziou
Hello, Jens Lechtenboerger writes: > Subject: [PATCH] ox-html: Control wrapping of source lines > > * lisp/ox-html.el (org-html-format-code, org-html-do-format-code): > Use new export option :html-wrap-src-lines with variable > org-html-wrap-src-lines to control whether source code lines sho

Re: [O] [PATCH] org: org-get-priority: reduce `not`, deduplicate magic `(* 1000 ..)` operation

2019-10-10 Thread Anton Latukha
Please.I tried to explain myself, but I see the more I explain myself, and write - the more people would assume the things that not correspond to reality.I not even started the work, or shown changes. And I already received a bunch of recommendations and people being concern, and people confusing t

Re: [O] [PATCH] org: org-get-priority: reduce `not`, deduplicate magic `(* 1000 ..)` operation

2019-10-10 Thread Nicolas Goaziou
Hello, Anton Latukha writes: > Well, after re-reading my letter - it obviously probably comes off as > being very strong and ambitious. I am pretty cool-headed about > everything. I am aware of that I need to gradual do ideally clean and > 100% compatible changes, I looked at the code - and the

Re: [O] [PATCH] org: org-get-priority: reduce `not`, deduplicate magic `(* 1000 ..)` operation

2019-10-09 Thread Samuel Wales
i don't use the priority stuff, but i think it could perhaps be useful to use terminology to distinguish the priority stuff from the priority stuff. i.e. 1] the stuff i don't use that you are talking about 2] [#A] and all that when i was a beginner i got confused by that. :) On 10/9/19, Adam

Re: [O] [PATCH] org: org-get-priority: reduce `not`, deduplicate magic `(* 1000 ..)` operation

2019-10-09 Thread Adam Porter
Hi Anton, Nicolas, et al, I'm in favor of tidying up the priority-related code, as I also have found it hard to follow. But please do not change the API of these functions, i.e. the signatures and return values. Their output is used in other packages, including some of mine like org-rifle, org-s

Re: [O] [PATCH] org: org-get-priority: reduce `not`, deduplicate magic `(* 1000 ..)` operation

2019-10-08 Thread Anton Latukha
Well, after re-reading my letter - it obviously probably comes off as being very strong and ambitious. I am pretty cool-headed about everything. I am aware of that I need to gradual do ideally clean and 100% compatible changes, I looked at the code - and the changes needed are at the pretty simple

Re: [O] [PATCH] org: org-get-priority: reduce `not`, deduplicate magic `(* 1000 ..)` operation

2019-10-08 Thread Anton Latukha
Ok.I would tend to it.This hardcode goes through several org.el functions. The main custom priority (priority retrieval) function should be already working and accepted in the whole Org system. But that hardcode expectation of (* 1000 ..) should be moved-out of the main priority functions and be su

Re: [O] [PATCH] ox-html: add option to restore old src block behaviour?

2019-10-08 Thread Jens Lechtenboerger
On 2019-10-08, at 11:31, Nicolas Goaziou wrote: > Jens Lechtenboerger writes: > >> The attached patch adds a new variable org-html-wrap-src-lines to >> control whether code tags should be added or not. > > Thank you. > > However, the patch is not right. Exporters do not use defcustoms > directly.

Re: [O] [PATCH] org: org-get-priority-function: Clearly state that this is a holder for a name of the function

2019-10-08 Thread Anton Latukha
Indeed, I now also understand so.Let's drop this one. 08.10.2019, 13:59, "Nicolas Goaziou" :Hello,Anton Latukha writes:  Additionally state that this is a holder of a function name, so the simple user did not get confused.Your patch doesn't sound right. The value could be a lamb

[O] [PATCH] Document "help:" Org link type in manual

2019-10-08 Thread Robert Irelan
Patch attached -- Robert Irelan rire...@gmail.com From 31867e399f00093647c1b0583b7682b407be5b55 Mon Sep 17 00:00:00 2001 From: Robert Irelan Date: Tue, 8 Oct 2019 03:17:49 -0700 Subject: [PATCH] Document "help:" Org link type --- doc/org-manual.org | 2 ++ 1 file changed, 2 insertions(+) diff

Re: [O] [PATCH] ox-html: add option to restore old src block behaviour?

2019-10-08 Thread Nicolas Goaziou
Hello, Jens Lechtenboerger writes: > The attached patch adds a new variable org-html-wrap-src-lines to > control whether code tags should be added or not. Thank you. However, the patch is not right. Exporters do not use defcustoms directly. Instead, you register them within :options-alist in t

Re: [O] [PATCH] org: org-get-priority: reduce `not`, deduplicate magic `(* 1000 ..)` operation

2019-10-08 Thread Nicolas Goaziou
Hello, Anton Latukha writes: > Another two small patches. Please merge the two patches and factor out the (- org-lowest-priority ...) while you're at it. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] org.el: fx org-get-priority-function funcall (give arg - headline)

2019-10-08 Thread Nicolas Goaziou
Hello, Anton Latukha writes: > * org.el (org-get-priority): Fix to allow the use of custom priority > getters. > Provide the headline as argument to the custom priority getter > function. Applied. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] org: org-get-priority-function: Clearly state that this is a holder for a name of the function

2019-10-08 Thread Nicolas Goaziou
Hello, Anton Latukha writes: > Additionally state that this is a holder of a function name, so the > simple user did not get confused. Your patch doesn't sound right. The value could be a lambda function, or a symbol with a function value. Besides, "function name" is confusing. It could mean, e

Re: [O] [PATCH] ob-plantuml.el support for non-UML diagrams

2019-10-06 Thread stardiviner
Sounds great, is it merged now? Henrik Koschitzki writes: > Hello, > ob-plantuml encloses the body of PlantUML ( http://plantuml.com) diagram code > with @startuml/@enduml clauses. Recent versions of PlantUML support non-UML > diagrams > like gantt, mindmap and others that needs to be enclo

[O] [PATCH] ob-ocaml: Support for pretty-printed outputs

2019-10-04 Thread Robert M. Kovacsics
E.g. the following snippet produces multiple lines of output, due to pretty-printing #+BEGIN_SRC ocaml :exports code :eval no-export :results verbatim (* Note, no need to have parentheses around sqrt, as application binds the tightest *) let rec gamma n = if n = 0 then (1.0 +.

Re: [O] [PATCH] ox-html: add option to restore old src block behaviour?

2019-10-02 Thread Matt Price
So I'm pretty interested in this: what to others thi k? On Sat., Sep. 21, 2019, 8:16 a.m. Jens Lechtenboerger, < jens.lechtenboer...@fsfe.org> wrote: > On 2019-09-19, Matt Price wrote: > > > Over the summer, commit ded3d27b1468b878197e5fe55a70c5e13350ea27 > > by Nik Clayton was merged to master.

[O] [PATCH] org: org-get-priority: reduce `not`, deduplicate magic `(* 1000 ..)` operation

2019-09-28 Thread Anton Latukha
Another two small patches.(First I subscribed mail profile with a `name+tag@mail` format, after that understood that I can receive messages, but I can not write back from that tag address. Still do not see or know, if I reached the mailing list with the patches). $ make test---Ran 808 tests, 80

[O] [PATCH] org.el: fx org-get-priority-function funcall (give arg - headline)

2019-09-28 Thread Anton Latukha
From d9b237304b23b8bbb75e9b799bd3698060bc82a9 Mon Sep 17 00:00:00 2001From: Anton-Latukha Date: Sun, 29 Sep 2019 01:13:41 +0300Subject: [PATCH] org.el: fx org-get-priority-function funcall (give arg - headline) * org.el (org-get-priority): Fix to allow the use of custom prioritygetters.Provide

[O] [PATCH] org: org-get-priority-function: Clearly state that this is a holder for a name of the function

2019-09-28 Thread Anton Latukha
Additionally state that this is a holder of a function name, so the simple user did not get confused. Regards,Anton Latukha From da3066489128af42a89e498db7fb8b0bcda9e431 Mon Sep 17 00:00:00 2001 From: Anton-Latukha Date: Sun, 29 Sep 2019 03:41:17 +0300 Subject: [PATCH] org: org-get-priority-functi

[O] [PATCH] org.el: fx org-get-priority-function funcall (give arg - headline)

2019-09-28 Thread Anton Latukha
From d9b237304b23b8bbb75e9b799bd3698060bc82a9 Mon Sep 17 00:00:00 2001From: Anton-Latukha Date: Sun, 29 Sep 2019 01:13:41 +0300Subject: [PATCH] org.el: fx org-get-priority-function funcall (give arg - headline) * org.el (org-get-priority): Fix to allow the use of custom

[O] [PATCH] ox-html: add option to restore old src block behaviour?

2019-09-21 Thread Jens Lechtenboerger
On 2019-09-19, Matt Price wrote: > Over the summer, commit ded3d27b1468b878197e5fe55a70c5e13350ea27 > by Nik Clayton was merged to master. It's a one-line change that > adds new ~~ tags around each lin of code in html export of > source blocks. It's useful because it allows individual lines to >

Re: [O] [PATCH] ox-latex.el: Extend :placement attribute to source blocks

2019-09-16 Thread Nicolas Goaziou
Hello, Mario Schlegel writes: > * lisp/ox-latex.el (org-latex-src-block): Extend :placement attribute > to source blocks when the minted package is used. Applied. Thank you! Regards, -- Nicolas Goaziou

Re: [O] [PATCH] org: Prevent loss of `re-search-forward' results

2019-09-16 Thread Nicolas Goaziou
Hello, Max Mouratov writes: > * org.el (org-activate-links): `match-beginning' and `match-end` should > be called shortly after `re-search-forward'. Otherwise, they may return > values corresponding to a different invocation of `re-search-forward'. Applied. Thank you! Regards, -- Nicolas Goa

Re: [O] [PATCH] org-macs: Fix indentation for fullwidth characters

2019-09-16 Thread Nicolas Goaziou
Hello, Yuichiro Hakozaki writes: > @@ -335,7 +335,7 @@ if it fails." >(let ((min-ind (point-max))) > (save-excursion >(while (re-search-forward "^[ \t]*\\S-" nil t) > -(let ((ind (1- (current-column > +

Re: [O] Patch: strip (unneeded) quotes from singular value results

2019-09-16 Thread Nicolas Goaziou
Hello, Mike Ivanov writes: > lisp/ob-lisp.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lisp/ob-lisp.el b/lisp/ob-lisp.el > index e717fc34e..0afb8c053 100644 > --- a/lisp/ob-lisp.el > +++ b/lisp/ob-lisp.el > @@ -107,7 +107,7 @@ a property list containing the parame

[O] [PATCH] ox-latex.el: Extend :placement attribute to source blocks

2019-09-12 Thread Mario Schlegel
* lisp/ox-latex.el (org-latex-src-block): Extend :placement attribute to source blocks when the minted package is used. TINYCHANGE --- lisp/ox-latex.el | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/lisp/ox-latex.el b/lisp/ox-latex.el index 1f1be240a..77aac78f4 100644

[O] [PATCH] org: Prevent loss of `re-search-forward' results

2019-09-12 Thread Max Mouratov
Hello! I got burned by this issue while implementing a custom link handler. 0001-org-Prevent-loss-of-re-search-forward-results.patch Description: Binary data

[O] [PATCH] org-macs: Fix indentation for fullwidth characters

2019-09-07 Thread Yuichiro Hakozaki
Hi, When the least indented line in buffer begins from fullwidth character like 'あ', a Japanese character, `org-do-remove-indentation' doesn't remove indentation at all or removes improperly. e.g. 'あ' with 2 spaces indent -[buffer begin]- あ -[buffer end]- `org-do-remove-inde

[O] Patch: strip (unneeded) quotes from singular value results

2019-09-07 Thread Mike Ivanov
Hi there, Here's a TINYCHANGE patch that fixes an issue in ob-lisp.el. Before: #+BEGIN_SRC lisp :results file "plot.png" #+END_SRC #+RESULTS: [[file:"plot.png"]] <-- which is wrong After: #+BEGIN_SRC lisp :results file "plot.png" #+END_SRC #+RESULTS: [[file:plot.png]] Mike From 414af442f

Re: [O] [Patch] Hide the file column in a clock report.

2019-09-05 Thread Nicolas Goaziou
Hello, Michaël Cadilhac writes: > Here attached. Let me know if that's all good! It is. Applied. Could you provide an ORG-NEWS entry? Thank you! Regards, -- Nicolas Goaziou

Re: [O] [PATCH] Add org-agenda-show-indirect variable

2019-09-01 Thread tumashu
At 2019-09-01 22:28:00, "Adam Porter" wrote: >tumashu writes: > >> + (when org-agenda-show-indirect >> +(let ((org-indirect-buffer-display 'current-window)) >> + (org-tree-to-indirect-buffer) >> + ;; hide indirect buffer in ibuffer >> + (rename-buffer (concat " "

Re: [O] [PATCH] Add org-agenda-show-indirect variable

2019-09-01 Thread Adam Porter
tumashu writes: > + (when org-agenda-show-indirect > + (let ((org-indirect-buffer-display 'current-window)) > + (org-tree-to-indirect-buffer) > + ;; hide indirect buffer in ibuffer > + (rename-buffer (concat " " (buffer-name) 1. That does not affect only ibuffer,

Re: [O] [Patch] Hide the file column in a clock report.

2019-08-28 Thread Michaël Cadilhac
Here attached. Let me know if that's all good! Cheers, M. On Sun, 3 Sep 2017 at 03:15, Nicolas Goaziou wrote: > Hello, > > Michaël Cadilhac writes: > > > From f251bf0fa764e245eabe88e3959e801af5c8fd37 Mon Sep 17 00:00:00 2001 > > From: =?UTF-8?q?Micha=C3=ABl=20Cadilhac?= > > Date: Thu, 31 Aug

[O] [PATCH] Add org-agenda-show-indirect variable

2019-08-22 Thread tumashu
0001-Add-org-agenda-show-indirect-variable.patch Description: Binary data

Re: [O] [PATCH] Fixing org-store-link for eshell

2019-08-22 Thread Nicolas Goaziou
Hello, Abhishek Chandratre writes: > I wanted to use org-store-link for eshell, but it failed. > Looked like dired-directory was nil, I fixed it by calling (eshell/pwd) to > get pwd. > I tested with and without TRAMP, works like a charm. Applied. I added a `declare-function' to silence compilat

[O] [PATCH] Fixing org-store-link for eshell

2019-08-20 Thread Abhishek Chandratre
Hello all, Thank you for supporting and maintaining org mode. I wanted to use org-store-link for eshell, but it failed. Looked like dired-directory was nil, I fixed it by calling (eshell/pwd) to get pwd. I tested with and without TRAMP, works like a charm. The patch did not create new test case f

Re: [O] patch: adding split-window-right option for src block editing

2019-08-17 Thread Nicolas Goaziou
Hello, "Fraga, Eric" writes: > Please find attached two patch files, both the one I have already sent > and now one with a change to the NEWS file. Applied. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] org.el (org-todo): Respect state argument when called from elisp

2019-08-16 Thread Kyle Meyer
Renato Ferreira writes: > (org-todo): Fast selection should only be shown if a state argument was not > used > * list/org.el (org-todo): Respect argument when called from elisp > when calling from elisp (such as in `org-clock-in'). Thanks for the patch! I hit this earlier today but hadn't yet

[O] [PATCH] org.el (org-todo): Respect state argument when called from elisp

2019-08-16 Thread Renato Ferreira
(org-todo): Fast selection should only be shown if a state argument was not used * list/org.el (org-todo): Respect argument when called from elisp when calling from elisp (such as in `org-clock-in'). TINYCHANGE --- lisp/org.el | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --

Re: [O] [PATCH] ob-plantuml.el support for non-UML diagrams

2019-08-01 Thread Fraga, Eric
Thanks for this. I've not tested but I appreciate the head's up on the new features in plantuml! -- Eric S Fraga via Emacs 27.0.50, Org release_9.2.4-399-g4e6222

[O] [PATCH] ob-plantuml.el support for non-UML diagrams

2019-08-01 Thread Henrik Koschitzki
Hello, ob-plantuml encloses the body of PlantUML ( http://plantuml.com) diagram code with @startuml/@enduml clauses. Recent versions of PlantUML support non-UML diagrams like gantt, mindmap and others that needs to be enclosed with @startgantt/@endgantt and @startmindmap/@endmindmap clauses. I

Re: [O] patch: adding split-window-right option for src block editing

2019-07-24 Thread Fraga, Eric
On Monday, 15 Jul 2019 at 12:02, Nicolas Goaziou wrote: > Hello, > > "Fraga, Eric" writes: > >> most of my work now involves using quite large wide monitors and having >> the editing of src blocks open windows below is less convenient than >> splitting horizontally. I have added the option to spl

Re: [O] [PATCH] ox-rss: Fix typos

2019-07-16 Thread Nicolas Goaziou
Hello, Applied. Thank you. Regards, -- Nicolas Goaziou

Re: [O] patch: adding split-window-right option for src block editing

2019-07-16 Thread Fraga, Eric
Thanks Nicolas. I'm currently travelling for work. I'll add the news item for this change early next week. -- Eric S Fraga via Emacs 27.0.50, Org release_9.2.4-379-g1b74ae

[O] [PATCH] ox-rss: Fix typos

2019-07-15 Thread Tim Landscheidt
--- contrib/lisp/ox-rss.el | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/contrib/lisp/ox-rss.el b/contrib/lisp/ox-rss.el index 10f2cc244..bb069dadf 100644 --- a/contrib/lisp/ox-rss.el +++ b/contrib/lisp/ox-rss.el @@ -22,8 +22,8 @@ ;;; Commentary: -;; This libr

Re: [O] patch: adding split-window-right option for src block editing

2019-07-15 Thread Nicolas Goaziou
Hello, "Fraga, Eric" writes: > most of my work now involves using quite large wide monitors and having > the editing of src blocks open windows below is less convenient than > splitting horizontally. I have added the option to split > horizontally. See attached patch. Thank you. Could you pro

[O] patch: adding split-window-right option for src block editing

2019-07-11 Thread Fraga, Eric
Hello all, most of my work now involves using quite large wide monitors and having the editing of src blocks open windows below is less convenient than splitting horizontally. I have added the option to split horizontally. See attached patch. However, ideally, I would like the option to specify

Re: [O] [PATCH] Export with verbatim LaTeX removes spaces

2019-07-09 Thread Nicolas Goaziou
Hello, Michaël Cadilhac writes: > When LaTeX is exported verbatim, some spaces are lost. Try for instance: > M-: (let ((org-html-with-latex 'verbatim)) (org-html-export-as-html)) RET > on a buffer containing "$a$ $b$". Post-blanks were simply not added > back, see below. I applied a variant

[O] [PATCH] Export with verbatim LaTeX removes spaces

2019-07-08 Thread Michaël Cadilhac
Hi, When LaTeX is exported verbatim, some spaces are lost. Try for instance: M-: (let ((org-html-with-latex 'verbatim)) (org-html-export-as-html)) RET on a buffer containing "$a$ $b$". Post-blanks were simply not added back, see below. Thanks! Cheers, Michaël ox.el: Add post-blanks when lat

Re: [O] [PATCH] doc: Corrected typo, Java script -> JavaScript

2019-06-22 Thread Nicolas Goaziou
Hello, Rovanion Luckey writes: > - a Java script for displaying webpages derived from Org using an > + a JavaScript for displaying webpages derived from Org using an Fixed. Thank you. Regards, -- Nicolas Goaziou

[O] [PATCH] doc: Corrected typo, Java script -> JavaScript

2019-06-19 Thread Rovanion Luckey
--- doc/org-manual.org | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/org-manual.org b/doc/org-manual.org index 4fcd15d22..201389ce6 100644 --- a/doc/org-manual.org +++ b/doc/org-manual.org @@ -20553,7 +20553,7 @@ Before I get to this list, a few special mentions are in o

Re: [O] [PATCH] Feature proposal : support "scale=" includegraphics option in the builtin latex exporter.

2019-06-16 Thread Emmanuel Charpentier
Le dimanche 16 juin 2019 à 10:35 +0200, Nicolas Goaziou a écrit : [ Snip... ] > New features are applied to master branch. maint branch is for > bugfixes > only. Okay. I missed that... > Since your patch is a new feature, it went into master branch. It > will > be available in Org 9.3. Hopeful

Re: [O] [PATCH] Feature proposal : support "scale=" includegraphics option in the builtin latex exporter.

2019-06-16 Thread Nicolas Goaziou
Hello, Emmanuel Charpentier writes: > We are now on June 16. The ELPA-distributed org-plus-contrib still does > not carry these patches (re-attached, FWIW). > > I have checked that they are present in the ~master~ branch of the > source tree, but not its ~maint~ branch. > > Am I misunderstanding

Re: [O] [PATCH] Feature proposal : support "scale=" includegraphics option in the builtin latex exporter.

2019-06-15 Thread Emmanuel Charpentier
Le mardi 23 avril 2019 à 10:26 +0200, Nicolas Goaziou a écrit : > Hello, > > Emmanuel Charpentier writes: > > > Le lundi 22 avril 2019 à 15:26 +0200, Nicolas Goaziou a écrit : > > > Emmanuel Charpentier writes: > > > > > > > Do you want a direct answer or a partch against /etc/ORG-NEWS ? > > >

Re: [O] [PATCH] org-clock.el: Clear org-clock-current-task on clock cancel

2019-06-15 Thread Nicolas Goaziou
Hello, m...@bcc32.com writes: > From: "Aaron L. Zeng" > > * org-mode/lisp/org-clock.el (org-clock-cancel): Clear > `org-clock-current-task' when a clock is canceled. > > This variable is used by some mode line packages (e.g., > spaceline-all-the-icons), so not clearing the variable incorrectly >

[O] [PATCH] org-clock.el: Clear org-clock-current-task on clock cancel

2019-06-14 Thread me
From: "Aaron L. Zeng" * org-mode/lisp/org-clock.el (org-clock-cancel): Clear `org-clock-current-task' when a clock is canceled. This variable is used by some mode line packages (e.g., spaceline-all-the-icons), so not clearing the variable incorrectly displays the previous task as ongoing. --- l

Re: [O] [PATCH] Manual update

2019-06-07 Thread Kyle Meyer
Nicolas Goaziou writes: > Hello, > > Cheong Yiufung writes: > >> From 14ff6eb2b451471514206d5126c0af02125ec7e6 Mon Sep 17 00:00:00 2001 >> From: Cheong Yiu Fung >> Date: Mon, 13 May 2019 22:51:08 +0800 >> Subject: [PATCH] org-manual: Small fixes >> >> * doc/org-manual.org (Handling Links): upda

Re: [O] [PATCH] * doc/org-manual.org (External Links): Fix URL

2019-06-07 Thread Nicolas Goaziou
Hello, Gregor Zattler writes: > --- > doc/org-manual.org | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/org-manual.org b/doc/org-manual.org > index 469e16402..583840a74 100644 > --- a/doc/org-manual.org > +++ b/doc/org-manual.org > @@ -3081,7 +3081,7 @@ External li

Re: [O] [PATCH] Manual update

2019-06-07 Thread Nicolas Goaziou
Hello, Cheong Yiufung writes: > From 14ff6eb2b451471514206d5126c0af02125ec7e6 Mon Sep 17 00:00:00 2001 > From: Cheong Yiu Fung > Date: Mon, 13 May 2019 22:51:08 +0800 > Subject: [PATCH] org-manual: Small fixes > > * doc/org-manual.org (Handling Links): update variable > `org-id-link-to-org-use-

Re: [O] [PATCH] Add :target option for the TOC keyword

2019-06-05 Thread Sacha Chua
Whoops, I'm so sorry - I accidentally used org-make-link-string instead of org-link-make-string. Tiny patch fixing it attached. Sacha Chua - sa...@sachachua.com - Blog: sachachua.com - Mobile: +1 416 823 2669 On Fri, May 31, 2019 at 12:30 PM Nicolas Goaziou wrote: > Hello, > > Sacha Chua writ

[O] [PATCH] * doc/org-manual.org (External Links): Fix URL

2019-06-01 Thread Gregor Zattler
--- doc/org-manual.org | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/org-manual.org b/doc/org-manual.org index 469e16402..583840a74 100644 --- a/doc/org-manual.org +++ b/doc/org-manual.org @@ -3081,7 +3081,7 @@ External links are URL-like locators. They start with a s

Re: [O] [PATCH] Add :target option for the TOC keyword

2019-05-31 Thread Nicolas Goaziou
Hello, Sacha Chua writes: > - catch the signal raised by org-export-resolve-fuzzy-link and then check for > the > special case of "local" > - always handle :target "local" as a local TOC > - or just leave the behaviour as it is. What would you recommend? The latter is fine. I applied you patc

Re: [O] [PATCH] Add :target option for the TOC keyword

2019-05-29 Thread Sacha Chua
Nicolas Goaziou writes: Hello, Nicolas! > Thank you! I cannot guess the use case, but you certainly have one :) I'm guessing DC Toedt likes to make Org files that have some kind of overview TOC in a different section. I haven't used it myself, but it seems like a potentially handy thing to have

Re: [O] [PATCH] org-clock.el: Fix restore of frame-title-format

2019-05-28 Thread Nicolas Goaziou
Hello, Andrii Kolomoiets writes: > * lisp/org-clock.el (org-frame-title-format-backup): Use nil as initial value. > (org-clock-in): set `org-frame-title-format-backup' to `frame-title-format'. > (org-clock-restore-frame-title-format): New function. > (org-clock-out): Use it. > (org-clock-cancel)

[O] [PATCH] org-clock.el: Fix restore of frame-title-format

2019-05-28 Thread Andrii Kolomoiets
* lisp/org-clock.el (org-frame-title-format-backup): Use nil as initial value. (org-clock-in): set `org-frame-title-format-backup' to `frame-title-format'. (org-clock-restore-frame-title-format): New function. (org-clock-out): Use it. (org-clock-cancel): Use it. The problem was that the `org-frame

Re: [O] [PATCH] Docstring update

2019-05-28 Thread Nicolas Goaziou
Hello, "Cheong Yiu Fung" writes: > Fix docstring of `org-latex-packages-alist'. Applied. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] org-clock-out overrides frame-title-format [9.2.3 (9.2.3-17-g4df705-elpa @ ~/.emacs.d/elpa/org-20190513/)]

2019-05-28 Thread Nicolas Goaziou
Hello, Andrii Kolomoiets writes: > The org-frame-title-format-backup variable is initialized on > org-clock.el loading and future changes to frame-title-format is > ignored: > > 1. emacs -Q > 2. M-: frame-title-format >It's "%b" > 3. M-: (require 'org-clock) > 4. (setq frame-title-format "%b

Re: [O] [PATCH] Add :target option for the TOC keyword

2019-05-21 Thread Nicolas Goaziou
Hello, Sacha Chua writes: > Hi! Here's a patch to allow table of contents to target a specified > headline. I've added tests for HTML, ASCII, Markdown, and ODT export. > I should have copyright assignment papers already on file. > > Does it work for anyone other than me? =) Thank you! I cannot

[O] [PATCH] org-clock-out overrides frame-title-format [9.2.3 (9.2.3-17-g4df705-elpa @ ~/.emacs.d/elpa/org-20190513/)]

2019-05-19 Thread Andrii Kolomoiets
Hello. The org-frame-title-format-backup variable is initialized on org-clock.el loading and future changes to frame-title-format is ignored: 1. emacs -Q 2. M-: frame-title-format It's "%b" 3. M-: (require 'org-clock) 4. (setq frame-title-format "%b bar") 5. C-x b test.org 6. M-x org-mode 7. I

[O] [PATCH] Docstring update

2019-05-17 Thread Cheong Yiu Fung
Fix docstring of `org-latex-packages-alist'. -- YiufungFrom f854de4a4570a433871a2559160a7499c4c054d7 Mon Sep 17 00:00:00 2001 From: Cheong Yiu Fung Date: Fri, 17 May 2019 17:15:43 +0800 Subject: [PATCH] org.el: Fix docstring of org-latex-packages-alist * lisp/org.el (org-latex-packages-alist): F

Re: [O] [PATCH] org-manual: Small fixes

2019-05-16 Thread Kyle Meyer
Cheong Yiu Fung writes: > * doc/org-manual.org (Handling Links): update variable > `org-id-link-to-org-use-id', which is changed in v7.9.2. Thanks. Because this was relevant for the maint branch as well, I adjusted your commit to apply to maint (tweaking the commit message slightly). -- Kyle

[O] [PATCH] org-manual: Small fixes

2019-05-16 Thread Cheong Yiu Fung
* doc/org-manual.org (Handling Links): update variable `org-id-link-to-org-use-id', which is changed in v7.9.2. --- doc/org-manual.org | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/doc/org-manual.org b/doc/org-manual.org index 54b89e5bf..c519d310b 100644 --- a/

[O] [PATCH] Manual update

2019-05-16 Thread Cheong Yiufung
>From 14ff6eb2b451471514206d5126c0af02125ec7e6 Mon Sep 17 00:00:00 2001 From: Cheong Yiu Fung Date: Mon, 13 May 2019 22:51:08 +0800 Subject: [PATCH] org-manual: Small fixes * doc/org-manual.org (Handling Links): update variable `org-id-link-to-org-use-id', which is changed in v7.9.2. --- doc/org

  1   2   3   4   5   6   7   8   9   10   >