Re: [O] [BUG] [ODT] Subtree export gives wrong footnote style

2013-04-02 Thread Christian Moe
Thanks! Yours, Christian Nicolas Goaziou writes: > Christian Moe writes: > >>> For now, I think the patch is correct to apply. What do you think? >> >> Absolutely, it fixes a bug in footnote styling, and adds useful styling >> of quotes within footnotes. > > Patch applied. Thank you. > > > Re

Re: [O] [BUG] [ODT] Subtree export gives wrong footnote style

2013-04-01 Thread Nicolas Goaziou
Christian Moe writes: >> For now, I think the patch is correct to apply. What do you think? > > Absolutely, it fixes a bug in footnote styling, and adds useful styling > of quotes within footnotes. Patch applied. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [BUG] [ODT] Subtree export gives wrong footnote style

2013-04-01 Thread Christian Moe
Hi again, Now that I've finally pointed to the patched file, the patch seems to work perfectly. > We could also make use of OrgFootnoteVerse and OrgFootnoteCode styles, > but I'm not sure about their definition. It doesn't matter all that much, I think -- in any case the style definition is ent

Re: [O] [BUG] [ODT] Subtree export gives wrong footnote style

2013-04-01 Thread Nicolas Goaziou
Christian Moe writes: > Apologies, it looks like my installation is to blame, and that the part > of the patch that inserted the new style definitions was never applied > to OrgOdtStyles.xml. My org-odt-styles-dir becomes > "/usr/share/emacs/etc/org/styles/", not "etc/styles/". I assume the > lat

Re: [O] [BUG] [ODT] Subtree export gives wrong footnote style

2013-04-01 Thread Christian Moe
Hi, Nicolas, Apologies, it looks like my installation is to blame, and that the part of the patch that inserted the new style definitions was never applied to OrgOdtStyles.xml. My org-odt-styles-dir becomes "/usr/share/emacs/etc/org/styles/", not "etc/styles/". I assume the latter would be the co

Re: [O] [BUG] [ODT] Subtree export gives wrong footnote style

2013-04-01 Thread Nicolas Goaziou
Hello, Christian Moe writes: > * The new styles don't seem to get applied > > Quote and center blocks in footnotes do not get OrgFootnoteQuotations > style in my test. They remain Footnote. > > (You didn't add any OrgFootnoteVerse style, but I tried it out anyway. A > verse block inside a footno

Re: [O] [BUG] [ODT] Subtree export gives wrong footnote style

2013-03-30 Thread Christian Moe
Nicolas Goaziou writes: > I understood your problem, but I needed to know how deep I had to change > paragraph styles. Pardon the noise. > Would you mind testing the following patch? I added two new styles. Feel > free to correct them if needed. * The patch fixes the announced bug. Thank you!

Re: [O] [BUG] [ODT] Subtree export gives wrong footnote style

2013-03-29 Thread Nicolas Goaziou
Hello, Christian Moe writes: > Maybe I'm being obtuse, but I don't understand the relevance of your > question to the bug I pointed out. My example had two simple footnotes, > neither of which contained any blocks. I understood your problem, but I needed to know how deep I had to change paragra

Re: [O] [BUG] [ODT] Subtree export gives wrong footnote style

2013-03-29 Thread Christian Moe
Hi, Maybe I'm being obtuse, but I don't understand the relevance of your question to the bug I pointed out. My example had two simple footnotes, neither of which contained any blocks. The only difference between them was that one was located inside the subtree being exported and the other not. Th

Re: [O] [BUG] [ODT] Subtree export gives wrong footnote style

2013-03-29 Thread Nicolas Goaziou
Hello, Christian Moe writes: > The new ODT exporter sometimes, but not always fails to put footnotes in > Footnote style as expected. They are left in Text Body, which is wrong > (and surprisingly difficult to fix in LibreOffice). > > After a bit of trial and failure, it seems the error depends

[O] [BUG] [ODT] Subtree export gives wrong footnote style

2013-03-28 Thread Christian Moe
Hi, The new ODT exporter sometimes, but not always fails to put footnotes in Footnote style as expected. They are left in Text Body, which is wrong (and surprisingly difficult to fix in LibreOffice). After a bit of trial and failure, it seems the error depends on the scope of export: Exporting