Re: [FR] Allow flattened imenu index

2023-12-14 Thread Spencer Baugh
Ihor Radchenko writes: > Eli Zaretskii writes: > >>> I am wondering if it makes more sense to add this "flatten" option >>> globally into imenu instead. >> >> I'm not sure I understand what you are asking. As we don't seem to >> have an active maintainer of imenu on board, more details are neede

Re: [FR] Allow flattened imenu index

2023-12-11 Thread João Távora
On Mon, Dec 11, 2023 at 11:54 PM Dmitry Gutov wrote: > > On 12/12/2023 01:48, João Távora wrote: > > On Mon, Dec 11, 2023 at 11:41 PM Dmitry Gutov wrote: > >> On 12/12/2023 01:35, João Távora wrote: > >>> Or maybe say what the ruby-mode imenu backend > >>> does? > >> Juri just posted a long examp

Re: [FR] Allow flattened imenu index

2023-12-11 Thread João Távora
On Mon, Dec 11, 2023 at 11:41 PM Dmitry Gutov wrote: > > On 12/12/2023 01:35, João Távora wrote: > > Or maybe say what the ruby-mode imenu backend > > does? > > Juri just posted a long example of what ruby-mode does (and ruby-ts-mode > too) in his last message in this thread. OK, and doesn't it a

Re: [FR] Allow flattened imenu index

2023-12-11 Thread João Távora
On Mon, Dec 11, 2023 at 11:23 PM Dmitry Gutov wrote: > >> But if the LS will produce distinct strings, good. > > All imenu backends, at least all the ones I've seen, produce > > trees, not strings. > > There are exceptions, like the previously mentioned one. What is the imenu backend that produc

Re: [FR] Allow flattened imenu index

2023-12-11 Thread João Távora
On Mon, Dec 11, 2023 at 7:24 PM Dmitry Gutov wrote: > > It's no invention, it's docstring syntax for reference to a method. In Ruby right? > But if the LS will produce distinct strings, good. All imenu backends, at least all the ones I've seen, produce trees, not strings. If you collect all th

Re: [FR] Allow flattened imenu index

2023-12-11 Thread João Távora
On Mon, Dec 11, 2023 at 7:27 PM Ihor Radchenko wrote: > > Indeed, it's unfortunate that imenu--make-index-alist and imenu--index-alist > > are named as internal. > > Should they be renamed to `imenu-make-index-alist' and `imenu-index-alist' > then? Maybe, but it's much more urgent IMO to review

Re: [FR] Allow flattened imenu index

2023-12-11 Thread Ihor Radchenko
Juri Linkov writes: >> It shouldn't be needed here at all, but in case anyone's thinking >> about it, please avoid messing with imenu's internal representation of >> hierarchies as that structure is relied upon by many extensions (not just >> mine, but several others). Even certain things suppor

Re: [FR] Allow flattened imenu index

2023-12-11 Thread João Távora
On Mon, Dec 11, 2023 at 5:43 PM Dmitry Gutov wrote: > > is still usable even without special characters like "#". > > Until a class contains both an instance and a class method with the same > name, I suppose. If that happens, the LS will have to provide to distinct paths to these two distinct i

Re: [FR] Allow flattened imenu index

2023-12-11 Thread João Távora
On Mon, Dec 11, 2023 at 5:21 PM Juri Linkov wrote: > > By the way, this seems to be exactly what the breadcrumb-jump command > > in my breadcrumb.el package does. Goes reasonably well with a flex/fuzzy > > completion style. > > It would be great to have some form of breadcrumb-jump in imenu.el >

Re: [FR] Allow flattened imenu index

2023-12-11 Thread Juri Linkov
>> menu1 >> sub-item1 >> sub-item2 >> >> could be flattened to >> >> menu1 -> sub-item1 >> menu1 -> sub-item2 > > By the way, this seems to be exactly what the breadcrumb-jump command > in my breadcrumb.el package does. Goes reasonably well with a flex/fuzzy > completion style. It w

Re: [FR] Allow flattened imenu index

2023-12-11 Thread João Távora
On Sat, Dec 9, 2023 at 5:39 PM Juri Linkov wrote: > menu1 > sub-item1 > sub-item2 > > could be flattened to > > menu1 -> sub-item1 > menu1 -> sub-item2 By the way, this seems to be exactly what the breadcrumb-jump command in my breadcrumb.el package does. Goes reasonably well wit

Re: [FR] Allow flattened imenu index

2023-12-09 Thread Juri Linkov
> Normally, `imenu' supports nested menus, when users select the target > location in steps, like item3 -> item3.1 -> ... > > What is proposed is to list all the sub-menus together, as an option, so > that the users can choose, for example, item.3.1 directly, without going > through parent item3.

Re: [FR] Allow flattened imenu index (was: [PATCH] Add new option 'org-imenu-flatten')

2023-12-09 Thread Ihor Radchenko
Eli Zaretskii writes: >> I am wondering if it makes more sense to add this "flatten" option >> globally into imenu instead. > > I'm not sure I understand what you are asking. As we don't seem to > have an active maintainer of imenu on board, more details are needed > to understand the request.

Re: [FR] Allow flattened imenu index (was: [PATCH] Add new option 'org-imenu-flatten')

2023-12-09 Thread Eli Zaretskii
> From: Ihor Radchenko > Cc: emacs-orgmode@gnu.org, 58...@debbugs.gnu.org, emacs-de...@gnu.org > Date: Sat, 09 Dec 2023 10:57:15 + > > Morgan Smith writes: > > > Ihor Radchenko writes: > > > >> Have you considered adding a "flatten" option to imenu itself? > >> That way, you could automat

[FR] Allow flattened imenu index (was: [PATCH] Add new option 'org-imenu-flatten')

2023-12-09 Thread Ihor Radchenko
Morgan Smith writes: > Ihor Radchenko writes: > >> Have you considered adding a "flatten" option to imenu itself? >> That way, you could automatically get the functionality for free >> everywhere, not just in Org mode. > > I have considered that but gave up with minimal investigation because it