Re: [PATCH v2] Fix Emacs-26 compatibility (was: Re: [BUG] org-element loading fails with "regexp" argument not "stringp")

2023-07-08 Thread Ihor Radchenko
Max Nikulin writes: > On 06/07/2023 16:54, Ihor Radchenko wrote: >> You are removing `org-protocol-flatten' function, which is a breaking >> change. We should leave an obsolete alias. > > I have added an alias for this function hardly known to anybody else. It was easy enough, so why not. There

[PATCH v2] Fix Emacs-26 compatibility (was: Re: [BUG] org-element loading fails with "regexp" argument not "stringp")

2023-07-07 Thread Max Nikulin
in `setq-local'. Reported as: Justin to emacs-orgmode. [BUG] org-element loading fails with "regexp" argument not "stringp" Tue, 4 Jul 2023 19:51:44 -0400. https://list.orgmode.org/2ff109c7-b3ec-27ac-e75d-ae5ddac14...@vallon.homeip.net --- lisp/org-element.el | 32

Re: [PATCH] Fix Emacs-26 compatibility (was: Re: [BUG] org-element loading fails with "regexp" argument not "stringp")

2023-07-06 Thread Ihor Radchenko
Max Nikulin writes: > On 05/07/2023 17:35, Ihor Radchenko wrote: >> However, you will see many more failures with Emacs 26 on the latest >> main. > > With the couple of attached patches the only failing test is > > ... > Test test-org/delete-indentation condition: > (wrong-number-of-argument

[PATCH] Fix Emacs-26 compatibility (was: Re: [BUG] org-element loading fails with "regexp" argument not "stringp")

2023-07-05 Thread Max Nikulin
22:44:33 +0700 Subject: [PATCH 1/2] org-element.el: Fix Emacs-26 compatibility * org-element.el (org-element--current-element-re): Use `rx-to-string' instead of `rx' to expand variables. (org-element--cache-setup-change-functions): Avoid multiple variables in `setq-local'. Reported as:

Re: [BUG] org-element loading fails with "regexp" argument not "stringp"

2023-07-05 Thread Ihor Radchenko
Justin writes: > Using emacs 26.1 (in case it matters).  Loading is failing at: > > (defconst org-element--current-element-re >   (rx >    (or >     (group-n 1 (regexp org-element--latex-begin-environment-nogroup)) > > rx is a macro, and so org-element* is not being evaluated.  It's > complai

[BUG] org-element loading fails with "regexp" argument not "stringp"

2023-07-04 Thread Justin
Using emacs 26.1 (in case it matters).  Loading is failing at: (defconst org-element--current-element-re   (rx    (or     (group-n 1 (regexp org-element--latex-begin-environment-nogroup)) rx is a macro, and so org-element* is not being evaluated.  It's complaining that the argument to regexp is