Max Nikulin <maniku...@gmail.com> writes: > On 06/07/2023 16:54, Ihor Radchenko wrote: >> You are removing `org-protocol-flatten' function, which is a breaking >> change. We should leave an obsolete alias. > > I have added an alias for this function hardly known to anybody else.
It was easy enough, so why not. There is no reason to avoid backward-compatible code when it costs us very little. >> Also, you are defining `flatten-tree' function, which is outside Org's >> namespace. We should better avoid it and use something like >> `org-flatten-tree'. > > The idea was to minimize conflicts with your branch for the compat > package. When used together with compat, we would fight for the same namespace, loading either Org's or compat's variant of the function depending on the loading order. Of course, it would not matter this time - compat's definition of `flatten-tree' is a copy-paste from the Emacs implementation, just as ours. But such practice is to be avoided. > ... I hope, it will be merged soon. Applied, onto main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=caa27be10 https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=879ba22ef Thanks! -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
