Re: [PATCH v2] libdwfl: Correctly handle corefile non-contiguous segments

2023-11-21 Thread Mark Wielaard
Hi Aaron, On Fri, 2023-11-17 at 21:48 -0500, Aaron Merey wrote: > v1: https://sourceware.org/pipermail/elfutils-devel/2023q4/006644.html > > v2 changes: > > The size of the uncompressed testcore-noncontig has been reduced from > 736M to 54K. Uncompressed it is 580K. Still a bit large, but much

Re: [PATCH v2 1/2] libdwfl: handle duplicate ELFs when reporting archives

2023-11-21 Thread Mark Wielaard
Hi Aleksei, On Mon, 2023-11-20 at 17:44 +, Aleksei Vetrov wrote: > When archive is processed in process_archive (libdwfl/offline.c), it > creates an Elf object for each archive member. Then in > process_archive_member it calls process_file to create a Dwfl_Module > through __libdwfl_report_elf

Re: [PATCH v2 2/2] tests: Add test for duplicate entries in archive

2023-11-21 Thread Mark Wielaard
Hi Aleksei, On Mon, 2023-11-20 at 17:44 +, Aleksei Vetrov wrote: > Test dwfl-report-offline-memory against an archive that contains > non-relocatable ELFs with the same name and contents. > > * tests/test-ar-duplicates.a.bz2: New test file. > * tests/run-dwfl-report-offline-memory.sh:

Re: [PATCH v2] libdwfl: Correctly handle corefile non-contiguous segments

2023-11-21 Thread Aaron Merey
Hi Mark, On Tue, Nov 21, 2023 at 7:48 AM Mark Wielaard wrote: > > > > The size of the uncompressed testcore-noncontig has been reduced from > > 736M to 54K. > > Uncompressed it is 580K. Still a bit large, but much more reasonable. > We even have a couple of larger test files in the repo. Thanks.

[Bug general/30975] elfutils incorrectly reports core files with non-contiguous segments

2023-11-21 Thread amerey at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=30975 --- Comment #5 from Aaron Merey --- A fix for this bug has been merged into elfutils upstream in commit 2f38fa57942f9. I'm going to leave this bug open for now while the patch makes its way into Fedora and RHEL. Pablo if you get a chance, ple