Hi Mark, On Tue, Nov 21, 2023 at 7:48 AM Mark Wielaard <m...@klomp.org> wrote: > > > > The size of the uncompressed testcore-noncontig has been reduced from > > 736M to 54K. > > Uncompressed it is 580K. Still a bit large, but much more reasonable. > We even have a couple of larger test files in the repo. Thanks. > And in theory it can be replicated.
Sorry about that, I didn't mean to mix compressed and uncompressed sizes. > > dwfl_addrsegment tests have been added to verify correct handling of > > non-contiguous segments. > > BTW. Adding extra comments after the --- makes it easier to post a > commit as you will apply it because comments after the --- will be > ignored by git am. > > Please restore the original commit message before pushing. > The description of the issue was really good. Done. > > + /* First segment of non-contiguous module following the address space > > gap. */ > > + seg = dwfl_addrsegment (dwfl, 0x7f14e47ad000, NULL); > > + assert (seg == 40); > > OK. This does make sense if you have seen the eu-readelf -l testcore- > noncontig output. Maybe that should be there in a comment? Done. > All looks good. Maybe add the suggested comment about looking at the > program headers to undestand the testscase and please restore the > original commit message before applying. Pushed as commit 2f38fa57942f95. Thanks, Aaron
