Re: [Bug debuginfod/27983] ignore duplicate urls

2021-07-20 Thread Mark Wielaard
Hi Noah, On Mon, Jul 19, 2021 at 09:31:17AM -0400, Noah Sanci wrote: > On Wed, Jul 14, 2021 at 12:36 PM Mark Wielaard wrote: > > You deduplicate the full URLs after they are fully constructed. Would > > it make sense to do the deduplication on server_url, maybe even as > > part of the Count numb

Re: [Bug debuginfod/28034] %-escape url characters

2021-07-20 Thread Mark Wielaard
Hi Noah, On Mon, Jul 19, 2021 at 10:53:17AM -0400, Noah Sanci via Elfutils-devel wrote: > When requesting some source files, some URL-inconvenient chars > sometimes pop up. Example from f33 libstdc++: > /buildid/44d8485cb75512c2ca5c8f70afbd475cae30af4f/source/usr/src/debug/ > gcc-10.3.1-1.fc33.x8

Re: [Bug debuginfod/28034] %-escape url characters

2021-07-20 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > Could you rewrite the commit message to describe what is done in this > patch? (Yeah, Noah's commit text on his branch was corrected.) > [...] > I note that filename is actually the full path component of the URL so > includes slashes ('/'). curl_easy_escape seems to convert these to %2F

Re: [Bug debuginfod/28034] %-escape url characters

2021-07-20 Thread Mark Wielaard
Hi Noah, On Tue, Jul 20, 2021 at 07:50:11PM +0200, Mark Wielaard wrote: > > + * run-debuginfod-find.sh: Added a test case ensuring files with % > > + escapable characters in their paths are accessible. > > There are also a couple of changes (fixes?) to the testcases. > Could those be split ou