Hi Noah,
On Tue, Jul 20, 2021 at 07:50:11PM +0200, Mark Wielaard wrote:
> > + * run-debuginfod-find.sh: Added a test case ensuring files with %
> > + escapable characters in their paths are accessible.
>
> There are also a couple of changes (fixes?) to the testcases.
> Could those be split out?
I think you almost had the right fix for a race in killing the last
debuginfod server. Does the attached work for you?
Thanks,
Mark
>From 83b7eb24a5796a4aecc5d32eb0c3f459788c4690 Mon Sep 17 00:00:00 2001
From: Mark Wielaard <m...@klomp.org>
Date: Tue, 20 Jul 2021 20:50:48 +0200
Subject: [PATCH] tests: wait for PID4 before setting to zero
A debuginfod server might take a while to shut down to clean and close
the sqlite databases. Wait for the process after killing it and
clearing the PID variable so it won't be killed again.
Reported-by: Noah Sanci <nsa...@redhat.com>
Signed-off-by: Mark Wielaard <m...@klomp.org>
---
tests/ChangeLog | 4 ++++
tests/run-debuginfod-find.sh | 2 ++
2 files changed, 6 insertions(+)
diff --git a/tests/ChangeLog b/tests/ChangeLog
index 1196d6b2..b0303e00 100644
--- a/tests/ChangeLog
+++ b/tests/ChangeLog
@@ -1,3 +1,7 @@
+2021-07-20 Mark Wielaard <m...@klomp.org>
+
+ * tests/run-debuginfod-find.sh: wait for PID4 before setting to zero.
+
2021-06-28 Noah Sanci <nsa...@redhat.com>
PR25978
diff --git a/tests/run-debuginfod-find.sh b/tests/run-debuginfod-find.sh
index 1d664be9..23eac329 100755
--- a/tests/run-debuginfod-find.sh
+++ b/tests/run-debuginfod-find.sh
@@ -754,6 +754,8 @@ wait_ready $PORT3 'groom{statistic="files scanned (#)"}' 0
wait_ready $PORT3 'groom{statistic="files scanned (mb)"}' 0
kill $PID4
+wait $PID4
+PID4=0
########################################################################
# set up tests for retrying failed queries.
--
2.32.0
