Re: [PATCH] Don't use locale functions when libintl header isn't included.

2020-10-26 Thread Érico Nogueira via Elfutils-devel
On Mon Oct 26, 2020 at 3:22 PM -03, Frank Ch. Eigler wrote: > Hi - > > > On Mon, 2020-10-26 at 01:11 -0300, Érico Nogueira via Elfutils-devel wrote: > > > debuginfod.cxx used the bindtextdomain() and textdomain() functions > > > despite not including any translated output. These functions were als

Re: [PATCH] Don't use locale functions when libintl header isn't included.

2020-10-26 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > On Mon, 2020-10-26 at 01:11 -0300, Érico Nogueira via Elfutils-devel wrote: > > debuginfod.cxx used the bindtextdomain() and textdomain() functions > > despite not including any translated output. These functions were also > > used without including the libintl.h header. > > debuginfod do

Re: [PATCH] Don't use locale functions when libintl header isn't included.

2020-10-26 Thread Mark Wielaard
On Mon, 2020-10-26 at 15:53 -0300, Érico Nogueira via Elfutils-devel wrote: > I had talked with fche on #elfutils, and it was suggested that I could > remove the locale functions from debuginfod.cxx. If you think it makes > more sense to simply include the header (which is what I did initially > fo

Re: [PATCH] Don't use locale functions when libintl header isn't included.

2020-10-26 Thread Érico Nogueira via Elfutils-devel
On Mon Oct 26, 2020 at 4:46 PM -03, Mark Wielaard wrote: > Hi Érico, > > On Mon, 2020-10-26 at 01:11 -0300, Érico Nogueira via Elfutils-devel > wrote: > > debuginfod.cxx used the bindtextdomain() and textdomain() functions > > despite not including any translated output. These functions were also >

Re: [PATCH] Don't use locale functions when libintl header isn't included.

2020-10-26 Thread Mark Wielaard
Hi Érico, On Mon, 2020-10-26 at 01:11 -0300, Érico Nogueira via Elfutils-devel wrote: > debuginfod.cxx used the bindtextdomain() and textdomain() functions > despite not including any translated output. These functions were also > used without including the libintl.h header. debuginfod doesn't di

[PATCH] Don't use locale functions when libintl header isn't included.

2020-10-25 Thread Érico Nogueira via Elfutils-devel
debuginfod.cxx used the bindtextdomain() and textdomain() functions despite not including any translated output. These functions were also used without including the libintl.h header. Signed-off-by: Érico Rolim --- debuginfod/debuginfod.cxx | 2 -- 1 file changed, 2 deletions(-) diff --git a/de