On Mon, 2020-10-26 at 15:53 -0300, Érico Nogueira via Elfutils-devel wrote: > I had talked with fche on #elfutils, and it was suggested that I could > remove the locale functions from debuginfod.cxx. If you think it makes > more sense to simply include the header (which is what I did initially > for my own build), I guess I should remove the comment about C++ support > as well, right? Or modify it to something else, at least. Would you have > any suggestions for that?
Aha, I hadn't seen that before, you mean this line in debuginfod.cxx: // #include <libintl.h> // not until it supports C++ << better I think it is nice if all elfutils tools would use the same print_version function so --version always produces the same thing. I think that is the only "real" thing in debuginfod.cxx that uses localization and I don't believe anybody actually submitted a translation of that notice. If so (you'll have to double check) and it makes things easier/cleaner for debuginfod then you could remove the gettext call from print_version and remove the textdomain calls (please also remove the commented out include). Especially if Frank (fche) agrees. But if it is all the same, then I would simply add the include for libintl.h and remove or update the comment to say this is just form calling textdomain for some C helper functions, but isn't used in the C++ code (yet). Cheers, Mark
