[PATCH] staging: mt7621-mmc: Add blank line after declaration

2018-11-06 Thread nicolas
From: Nícolas F. R. A. Prado Correct the following warning from checkpatch.pl: WARNING: Missing a blank line after declarations + struct msdc_host *host = mmc_priv(mmc); + msdc_pm(state, (void *)host); Signed-off-by: Nícolas F. R. A. Prado --- Hi, this is my first

Re: ICH BRAUCHE IHRE FINANZIELLE UNTERSTÜTZUNG!!

2018-09-24 Thread Olivia Nicolas
Von: Olivia Nicolas Liebste, Guten Tag und danke für Ihre Aufmerksamkeit. Bitte ich möchte, dass Sie meine E-Mail sorgfältig lesen und mir helfen, dieses Projekt zu bearbeiten. Ich bin Fräulein Olivia Nicolas und ich schreibe demütig für Ihre Partnerschaft und Unterstützung bei der

Re: ICH BRAUCHE IHRE FINANZIELLE UNTERSTÜTZUNG!!

2018-09-24 Thread Olivia Nicolas
Von: Olivia Nicolas Liebste, Guten Tag und danke für Ihre Aufmerksamkeit. Bitte ich möchte, dass Sie meine E-Mail sorgfältig lesen und mir helfen, dieses Projekt zu bearbeiten. Ich bin Fräulein Olivia Nicolas und ich schreibe demütig für Ihre Partnerschaft und Unterstützung bei der

Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP

2021-02-04 Thread Nicolas Boichat
On Thu, Feb 4, 2021 at 8:07 PM Robert Foss wrote: > > Hi Xin, > > Thanks for the patch. > > On Thu, 28 Jan 2021 at 12:17, Xin Ji wrote: > > > > Enable DSI EOTP feature for fixing some panel screen constance > > shift issue. > > Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP. > > I

Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP

2021-02-04 Thread Nicolas Boichat
On Thu, Feb 4, 2021 at 8:59 PM Andrzej Hajda wrote: > > > W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze: > > On Thu, Feb 4, 2021 at 8:07 PM Robert Foss wrote: > >> Hi Xin, > >> > >> Thanks for the patch. > >> > >> On Thu, 28 Jan 202

Re: [RFC RESEND 0/3] vp9 v4l2 stateless uapi

2021-04-26 Thread Nicolas Dufresne
Le lundi 26 avril 2021 à 09:38 +0200, Hans Verkuil a écrit : > Hi Andrzej, > > Thank you for working on this! > > On 21/04/2021 12:00, Andrzej Pietrasiewicz wrote: > > Dear All, > > > > This is an RFC on stateless uapi for vp9 decoding with v4l2. This work is > > based on https://lkml.org/lkml/

Re: [RFC RESEND 0/3] vp9 v4l2 stateless uapi

2021-04-29 Thread Nicolas Dufresne
Le jeudi 29 avril 2021 à 11:23 +0200, Hans Verkuil a écrit : > On 27/04/2021 01:34, Ezequiel Garcia wrote: > > On Mon, 26 Apr 2021 at 14:38, Nicolas Dufresne wrote: > > > > > > Le lundi 26 avril 2021 à 09:38 +0200, Hans Verkuil a écrit : > > > > Hi Andrzej,

Re: [PATCH v10 6/9] media: uapi: Add a control for HANTRO driver

2021-05-05 Thread Nicolas Dufresne
Le mercredi 05 mai 2021 à 16:18 +0100, John Cox a écrit : > > The HEVC HANTRO driver needs to know the number of bits to skip at > > the beginning of the slice header. > > That is a hardware specific requirement so create a dedicated control > > for this purpose. > > > > Signed-off-by: Benjamin Ga

Re: [RFC RESEND 2/3] media: uapi: Add VP9 stateless decoder controls

2021-05-05 Thread Nicolas Dufresne
n aligned with how it works inside the codec, without having to do a translation dance, and then properly implement CAPTURE TRY_FMT base on that. To make an analogy with stateful codec, this replaces the queuing of a frame that contains codec headers. We skip the SRC_CH events, since this is no long

Re: [PATCH v10 6/9] media: uapi: Add a control for HANTRO driver

2021-05-06 Thread Nicolas Dufresne
Le jeudi 06 mai 2021 à 14:11 +0100, John Cox a écrit : > > On 05/05/2021 17:20, Benjamin Gaignard wrote: > > > > > > Le 05/05/2021 à 16:55, Hans Verkuil a écrit : > > > > On 20/04/2021 14:10, Benjamin Gaignard wrote: > > > > > The HEVC HANTRO driver needs to know the number of bits to skip at > >

Re: [PATCH v10 6/9] media: uapi: Add a control for HANTRO driver

2021-05-18 Thread Nicolas Dufresne
plitely > > > > setting this control, then perhaps this should be part of the standard > > > > HEVC API. > > > > Non-hantro drivers that do not need this can just skip it. > > > > > > Even if I put this parameter in decode_params structure that

Re: [PATCH] media: cedrus: Propagate OUTPUT resolution to CAPTURE

2020-09-17 Thread Nicolas Dufresne
Le jeudi 17 septembre 2020 à 12:39 +0200, Hans Verkuil a écrit : > On 14/05/2020 17:39, Nicolas Dufresne wrote: > > As per spec, the CAPTURE resolution should be automatically set based on > > the OTUPUT resolution. This patch properly propagate width/height to the > > ca

[PATCH v2] media: cedrus: Propagate OUTPUT resolution to CAPTURE

2020-09-17 Thread Nicolas Dufresne
. This also prevents userspace from selecting a CAPTURE resolution that is too small, avoiding kernel oops. Signed-off-by: Nicolas Dufresne Reviewed-by: Ezequiel Garcia Acked-by: Paul Kocialkowski Tested-by: Ondrej Jirman --- .../staging/media/sunxi/cedrus/cedrus_video.c | 29

Re: [PATCH v2] media: cedrus: Propagate OUTPUT resolution to CAPTURE

2020-09-17 Thread Nicolas Dufresne
Le jeudi 17 septembre 2020 à 20:27 -0400, Nicolas Dufresne a écrit : > As per spec, the CAPTURE resolution should be automatically set based on > the OTUPUT resolution. This patch properly propagate width/height to the > capture when the OUTPUT format is set and override the user provide

Re: [PATCH RFC PKS/PMEM 33/58] fs/cramfs: Utilize new kmap_thread()

2020-10-13 Thread Nicolas Pitre
On Fri, 9 Oct 2020, ira.we...@intel.com wrote: > From: Ira Weiny > > The kmap() calls in this FS are localized to a single thread. To avoid > the over head of global PKRS updates use the new kmap_thread() call. > > Cc: Nicolas Pitre > Signed-off-by: Ira Weiny Ac

Re: [linux-sunxi] [PATCH v2 1/2] media: v4l: Add definitions for the HEVC slice format and controls

2019-01-29 Thread Nicolas Dufresne
Le mardi 29 janvier 2019 à 16:44 +0900, Alexandre Courbot a écrit : > On Fri, Jan 25, 2019 at 10:04 PM Paul Kocialkowski > wrote: > > Hi, > > > > On Thu, 2019-01-24 at 20:23 +0800, Ayaka wrote: > > > Sent from my iPad > > > > > > > On Jan 24, 2019, at 6:27 PM, Paul Kocialkowski > > > > wrote:

Re: [PATCH 5/8] media: cedrus: Detect first slice of a frame

2019-08-30 Thread Nicolas Dufresne
ple video > > with > > out-of-order slices? It's my understanding that this is uncommon. > > I'm not entirely sure, but my understanding was that it might be used > when streaming over network where some packets might be l

Re: [PATCH 01/31] staging: bcm2835-camera: Ensure H264 header bytes get a sensible timestamp

2019-06-27 Thread Nicolas Dufresne
Hi Dave, Le jeudi 27 juin 2019 à 20:55 +0200, Stefan Wahren a écrit : > From: Dave Stevenson > > H264 header come from VC with 0 timestamps, which means they get a > strange timestamp when processed with VC/kernel start times, > particularly if used with the inline header option. > Remember the

Re: [PATCH 19/31] staging: bcm2835-camera: Ensure timestamps never go backwards.

2019-06-27 Thread Nicolas Dufresne
Le jeudi 27 juin 2019 à 20:56 +0200, Stefan Wahren a écrit : > From: Dave Stevenson > > There is an awkward situation with H264 header bytes. Currently > they are returned with a PTS of 0 because they aren't associated > with a timestamped frame to encode. These are handled by either > returning

Re: [PATCH 01/31] staging: bcm2835-camera: Ensure H264 header bytes get a sensible timestamp

2019-06-28 Thread Nicolas Dufresne
Le vendredi 28 juin 2019 à 11:10 +0100, Dave Stevenson a écrit : > Hi Nicolas > > On Thu, 27 Jun 2019 at 20:55, Nicolas Dufresne wrote: > > Hi Dave, > > > > Le jeudi 27 juin 2019 à 20:55 +0200, Stefan Wahren a écrit : > > > From: Dave Stevenson > >

Re: [PATCH 01/31] staging: bcm2835-camera: Ensure H264 header bytes get a sensible timestamp

2019-06-28 Thread Nicolas Dufresne
Le vendredi 28 juin 2019 à 16:08 +0200, Hans Verkuil a écrit : > On 6/28/19 4:00 PM, Nicolas Dufresne wrote: > > Le vendredi 28 juin 2019 à 11:10 +0100, Dave Stevenson a écrit : > > > Hi Nicolas > > > > > > On Thu, 27 Jun 2019 at 20:55, Nicolas Duf

Re: [PATCH v3 1/2] staging: Introduce NVIDIA Tegra20 video decoder driver

2017-10-11 Thread Nicolas Dufresne
ll driver that requires parsed headers like PPS/SPS. https://lwn.net/Articles/720797/ regards, Nicolas signature.asc Description: This is a digitally signed message part ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v4 3/5] staging: Introduce NVIDIA Tegra video decoder driver

2017-12-10 Thread Nicolas Dufresne
will use the > requests > API for video decoding in order to upstream the requests API. Does it sound > good? Chromium/Chrome already have support for that type of decoder in their tree. In theory, it should just work. Nicolas __

[PATCH 1/1] staging: rtl8723bs: make memcmp() calls consistent

2017-12-10 Thread Nicolas Iooss
sscanf(extra+4, "%u", &mode); The space between the key ("lps" and "ips") and the equal sign seems suspicious. Remove it in order to make the calls to memcmp() consistent. Signed-off-by: Nicolas Iooss --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 4

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-14 Thread Nicolas Dufresne
Le lundi 13 mars 2017 à 10:45 +, Russell King - ARM Linux a écrit : > On Mon, Mar 13, 2017 at 11:02:34AM +0100, Hans Verkuil wrote: > > On 03/11/2017 07:14 PM, Steve Longerbeam wrote: > > > The event must be user visible, otherwise the user has no indication > > > the error, and can't correct i

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

2017-03-14 Thread Nicolas Dufresne
be replaced by a "get caps" > ioctl which will > describe heap capabilities. At least that is my understanding of > kernel part > of "unix memory allocator" project I think what we really need from userspace point of view, is the ability to find a compatible heap for

Re: media / v4l2-mc: wishlist for complex cameras (was Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline)

2017-03-15 Thread Nicolas Dufresne
imxv4l2videosrc' from the gstreamer-imx > package > at https://github.com/Freescale/gstreamer-imx, and 'v4l2-ctl'. This one is specific to IMX hardware using vendor driver. You can probably ignore that. Nicolas signature.asc Description: This is a digitally signed m

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-18 Thread Nicolas Dufresne
ong with the norm fallback, GStreamer could could also consider the currently set framerate as returned by VIDIOC_G_PARM. At the same time, implementing that enumeration shall be straightforward, and will make a large amount of existing userspace work. regards, Nicolas signature.asc Description:

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Nicolas Dufresne
ready requestable through /dev/video10. Ok that wasn't clear. So basically video9 is a front-end to video10, and it does not proxy the enumerations. I understand this is what you are now fixing. And this has to be fixed, because I can image cases where the front-end could support only a subs

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Nicolas Dufresne
a interface, but that wasn't the goal. It would still fail with application that enumerates the possible resolutions and framerate and let you select them with a drop- down (like cheese). In general, I can only conclude that making everything that matter enumerable is the only working way to go

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Nicolas Dufresne
gt; the cause of problems and pin them down with detailed logs in > conjunction > with the source code. I read your analyses with GStreamer, and it was all correct. Nicolas signature.asc Description: This is a digitally signed message part _

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-22 Thread Nicolas Dufresne
esn't report V4L2_CAP_TIMEPERFRAME For encoders, the framerate value is used as numerical value to implement bitrate control. So in most cases any interval is accepted. Though, it would be cleaner to just implement the enumeration. It's quite simple when you support everything. Nicolas signature.asc

Re: [PATCH v3 1/3] resource: Use list_head to link resource sibling

2018-04-09 Thread Nicolas Pitre
ms with 32-bit pointers, so this probably won't matter much in the end. This is if reverse iteration is actually needed as you say though. Unless I'm mistaken, resource iteration doesn't happen that often, and not in critical paths either. Making the code clearer while keeping t

[PATCH] Staging: fbtft: fix header guard typo

2015-04-17 Thread Nicolas Iooss
drivers/staging/fbtft/internal.h header guard tests for __LINUX_FBTFT__INTERNAL_H but then defines __LINUX_FBTFT_INTERNAL_H (only 1 underscore) and uses the same name for the #endif comment. Use the same name everywhere. Signed-off-by: Nicolas Iooss --- drivers/staging/fbtft/internal.h | 2

Re: [PATCH v3 1/2] staging: wilc1000: Add SDIO/SPI 802.11 driver

2015-05-17 Thread Nicolas Ferre
: Dean Lee > Signed-off-by: Chris Park > Acked-by: Nicolas Ferre > --- > Changes in v3: > - fix the permissions. > - fix the folder tree. > - forget to add the mailing-list during the previous sending. Hi Greg, Do you have any comment on this v3 series (aka ping ;-)). Bye,

Re: [PATCH v3 1/2] staging: wilc1000: Add SDIO/SPI 802.11 driver

2015-05-18 Thread Nicolas Ferre
reless. Bye, -- Nicolas Ferre ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging/wilc1000: fix Kconfig dependencies

2015-05-28 Thread Nicolas Ferre
211, wext, and ipv4). > > In order to make it readable, I also took the liberty of re-indenting > the Kconfig file to the normal conventions. > > Signed-off-by: Arnd Bergmann Acked-by: Nicolas Ferre Thanks a lot Arnd! Bye, > diff --git a/drivers/staging/wilc1000/Kconfig

Re: [PATCH] media: hantro: Support H264 profile control

2019-11-22 Thread Nicolas Dufresne
Le vendredi 22 novembre 2019 à 14:16 +0900, Hirokazu Honda a écrit : > The Hantro G1 decoder supports H.264 profiles from Baseline to High, with > the exception of the Extended profile. > > Expose the V4L2_CID_MPEG_VIDEO_H264_PROFILE control, so that the > applications can query the driver for the

Re: [PATCH] media: hantro: Support H264 profile control

2019-11-22 Thread Nicolas Dufresne
Le samedi 23 novembre 2019 à 01:00 +0900, Tomasz Figa a écrit : > On Sat, Nov 23, 2019 at 12:09 AM Nicolas Dufresne > wrote: > > Le vendredi 22 novembre 2019 à 14:16 +0900, Hirokazu Honda a écrit : > > > The Hantro G1 decoder supports H.264 profiles from Baseline to

Re: [PATCH] media: hantro: Support H264 profile control

2020-01-18 Thread Nicolas Dufresne
Le vendredi 10 janvier 2020 à 13:31 +0100, Hans Verkuil a écrit : > On 11/29/19 1:16 AM, Tomasz Figa wrote: > > On Sat, Nov 23, 2019 at 1:52 AM Nicolas Dufresne > > wrote: > > > Le samedi 23 novembre 2019 à 01:00 +0900, Tomasz Figa a écrit : > > > > On S

Re: [PATCH v7 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver

2020-04-23 Thread Nicolas Boichat
Hi, Just commenting on the mode_fixup function that was added in v7. On Tue, Feb 25, 2020 at 2:15 PM Xin Ji wrote: > > The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed > for portable device. It converts MIPI DSI/DPI to DisplayPort 1.3 4K. > > The ANX7625 can support both USB T

Re: [PATCH v7 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver

2020-04-24 Thread Nicolas Boichat
On Fri, Apr 24, 2020 at 2:51 PM Xin Ji wrote: > > On Thu, Apr 23, 2020 at 07:55:15PM +0800, Nicolas Boichat wrote: > > Hi, > > > > Just commenting on the mode_fixup function that was added in v7. > > > [snip] > > > + /* > > > +* o

Re: [PATCH v8 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver

2020-04-28 Thread Nicolas Boichat
On Mon, Apr 27, 2020 at 2:18 PM Xin Ji wrote: > > The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed > for portable device. It converts MIPI DSI/DPI to DisplayPort 1.3 4K. > > The ANX7625 can support both USB Type-C PD feature and MIPI DSI/DPI > to DP feature. This driver only ena

Re: [PATCH v5 22/50] mtd: nand: atmel: switch to mtd_ooblayout_ops

2016-04-13 Thread Nicolas Ferre
Le 30/03/2016 18:14, Boris Brezillon a écrit : > Implementing the mtd_ooblayout_ops interface is the new way of exposing > ECC/OOB layout to MTD users. > > Signed-off-by: Boris Brezillon It seems good: Reviewed-by: Nicolas Ferre Bye, > --- > drivers/mtd/nand

Re: [PATCH v5 04/50] mtd: nand: atmel: use mtd_ooblayout_xxx() helpers where appropriate

2016-04-13 Thread Nicolas Ferre
* This only works on large pages because the ECC controller > + * waits for NAND_CMD_RNDOUTSTART after the NAND_CMD_RNDOUT. > + * Anyway, for small pages, the first ECC byte is at offset > + * 0 in the OOB area. >*/ > chip->cmdfunc(mtd, NAND_CMD_RNDOUT, > - mtd->writesize + eccpos[0], -1); > + mtd->writesize + oobregion.offset, -1); > } > > /* the ECC controller needs to read the ECC just after the data */ > - ecc_pos = oob + eccpos[0]; > + ecc_pos = oob + oobregion.offset; > chip->read_buf(mtd, ecc_pos, eccbytes); > > /* check if there's an error */ > -- Nicolas Ferre ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[RESEND PATCH] drivers: android: correct the size of struct binder_uintptr_t for BC_DEAD_BINDER_DONE

2016-02-16 Thread Nicolas Boichat
Signed-off-by: Lisa Du Signed-off-by: Nicolas Boichat --- This patch was first sent upstream here: https://lkml.org/lkml/2015/5/28/747, but was not picked up (probably because it was part of a bigger series that refactored binder). This patch fixes issues when using 64-bit binder API on

Re: [PATCH 5/5] usb: gadget: atmel_usba_udc: add missing ret value check

2015-07-08 Thread Nicolas Ferre
Le 07/07/2015 16:02, Robert Baldyga a écrit : > Add missing return value check. In case of error print debug message > and return error code. > > Signed-off-by: Robert Baldyga Yes, it's indeed missing: Acked-by: Nicolas Ferre Thanks, bye. > --- > drivers/usb/gadget/u

[PATCH] MAINTAINERS: Update maintainer entry for wilc1000

2016-06-27 Thread Nicolas Ferre
From: Aditya Shankar Take the maintenance of the Atmel WIFI staging driver wilc1000. Former maintainers are no more with Atmel. Reported-by: Loic Lefort Signed-off-by: Aditya Shankar Signed-off-by: Ganesh Krishna Signed-off-by: Nicolas Ferre --- Hi Luis, Greg, I'd like that we

[RESEND PATCH] MAINTAINERS: Update maintainer entry for wilc1000

2016-08-02 Thread Nicolas Ferre
From: Aditya Shankar Take the maintenance of the Atmel WIFI staging driver wilc1000. Former maintainers are no more with Atmel. Reported-by: Loic Lefort Signed-off-by: Aditya Shankar Signed-off-by: Ganesh Krishna Acked-by: Luis de Bethencourt Signed-off-by: Nicolas Ferre --- Hi all, Just

[PATCH 1/1] staging: rtl8192u: do not use undefined $(TOPDIR) in Makefile

2016-09-03 Thread Nicolas Iooss
drivers/staging/rtl8192u/ieee80211/Makefile uses $(TOPDIR) to configure an include directory, without defining this variable first. The path which is configured is therefore "/drivers/net/wireless", which does not seem to be the intended path. Remove the offending line. Signed-off-b

[PATCH 1/1] staging/atomisp: fix header guards

2017-09-03 Thread Nicolas Iooss
#ifndef. Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2") Signed-off-by: Nicolas Iooss --- .../css2400/css_2400_system/hrt/input_formatter_subsystem_defs.h| 2 +- .../css2400/css_2401_csi2p_system/hrt/input_formatter_subsystem_defs.h | 2 +- .

[PATCH] staging/olpc_dcon: fix checkpatch warnings

2014-05-06 Thread Nicolas Joseph
WARNING: Missing a blank line after declarations Signed-off-by: Nicolas Joseph --- drivers/staging/olpc_dcon/olpc_dcon.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c index 26b4ec5

Re: [PATCH] staging/olpc_dcon: fix checkpatch warnings

2014-05-23 Thread Nicolas Joseph
On 23/05/2014 14:42, Greg Kroah-Hartman wrote: > All of the tabs were stripped out and replaced with spaces, making it > impossible to apply this patch :( > > Can you please fix up your email client and resend? Sorry, I rebase and resend it. ___ devel

[PATCH] staging/olpc_dcon: fix checkpatch warnings

2014-05-23 Thread Nicolas Joseph
WARNING: Missing a blank line after declarations Signed-off-by: Nicolas Joseph --- drivers/staging/olpc_dcon/olpc_dcon.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c index 26b4ec5

[PATCH 2/2] staging: vt6656: fix leaks in error path

2014-05-30 Thread Nicolas Thery
Fix memory leaks in ioctl error handling paths. Signed-off-by: Nicolas Thery --- drivers/staging/vt6656/hostap.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vt6656/hostap.c b/drivers/staging/vt6656/hostap.c index 506e5d3..a25bfef 100644 --- a

Re: [PATCH 2/2] staging: vt6656: fix leaks in error path

2014-05-30 Thread Nicolas Thery
Sorry I didn't know staging patches should be based against linux-next. Please disregard this patch and the previous one. Best regards Nicolas On 30 May 2014 21:23, Christian Engelmayer wrote: > On Fri, 30 May 2014 20:47:44 +0200, Nicolas Thery wrote: >> Fix memory leaks

[PATCH] fix coding style issues

2014-06-03 Thread Nicolas Koch
Done as task 10 of the eudyptula challenge. Signed-off-by: Nicolas Koch --- drivers/staging/octeon/ethernet-mem.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/staging/octeon/ethernet-mem.c b/drivers/staging/octeon/ethernet-mem.c index bf666b0

[patch] Staging: octeon: minor style cleanups

2014-06-03 Thread Nicolas Koch
Done as task 10 of the eudyptula challenge. Signed-off-by: Nicolas Koch --- drivers/staging/octeon/ethernet-mem.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/staging/octeon/ethernet-mem.c b/drivers/staging/octeon/ethernet-mem.c index bf666b0

[PATCH] staging: rtl8188eu: include missing header

2014-09-05 Thread Nicolas Thery
ing: symbol 'phy_set_tx_power_level' was not declared. Should it be static? drivers/staging/rtl8188eu/hal/phy.c:324:6: warning: symbol 'phy_set_bw_mode' was not declared. Should it be static? drivers/staging/rtl8188eu/hal/phy.c:360:6: warning: symbol 'phy_sw_chnl'

Re: [PATCH 31/44] arm: Register with kernel poweroff handler

2014-10-07 Thread Nicolas Ferre
s the system or puts the CPU in sleep mode, > select a priority of 0 to indicate that the poweroff handler is one of last > resort. If the poweroff handler powers off the system, select a priority > of 128. > > Cc: Russell King > Cc: Andrew Victor > Cc: Nicolas Ferre &g

Re: [PATCHv3 3/3] drm: bridge: anx78xx: Add anx78xx driver support by analogix.

2015-09-14 Thread Nicolas Boichat
Hi Enric, Partial review for now, thanks for you work. Best, On Thu, Sep 10, 2015 at 06:35:52PM +0200, Enric Balletbo i Serra wrote: > At the moment it only supports ANX7814. > > The ANX7814 is an ultra-low power Full-HD (1080p60) SlimPort transmitter > designed for portable devices. > > This

[PATCH] staging/rtl8192u: remove unused function

2015-09-14 Thread Nicolas Joseph
Remove N_DBPSOfRate used in ComputeTxTime, remove by commit 742728f97a99 ("staging: rtl8192u: remove unused function.") Signed-off-by: Nicolas Joseph --- drivers/staging/rtl8192u/r8192U_core.c | 44 -- 1 file changed, 44 deletions(-) diff --git a/drive

Re: [PATCH] staging/rtl8192u: remove unused function

2015-09-15 Thread Nicolas Joseph
Le 14/09/15 à 14:25, Raphaël Beamonte a écrit : > Not sure the commit message is really clear. Something like this seems > more clean to me: > "Remove unused function N_DBPSOfRate. This function was only > used by function ComputeTxTime that was removed in a previous > commit." Indeed, is more cle

[PATCH] staging/rtl8192u: remove unused function

2015-09-15 Thread Nicolas Joseph
Remove unused function N_DBPSOfRate. This function was only used by function ComputeTxTime that was removed in the previous commit 742728f97a99 ("staging: rtl8192u: remove unused function.") Signed-off-by: Nicolas Joseph --- drivers/staging/rtl8192u/r8192U_c

Re: [PATCH 1/4] staging: wilc1000: Modify null check routine

2015-09-17 Thread Nicolas Ferre
rWILC_WFIDrv *) drvHandler; > > - if (pstrWFIDrv == NULL) > + if (!pstrWFIDrv) { > PRINT_ER("Driver handler is NULL\n"); > + return -EFAULT; > + } > PRINT_D(GENERIC_DBG, "Current State = %d,Received state = %d\n", &

[PATCH] staging/rdma/hfi1: do not use u8 to store a 32-bit integer

2015-09-20 Thread Nicolas Iooss
:2399:9: warning: shift count >= width of type [-Wshift-count-overflow] opcode >>= 24; ^ ~~ All of this lead to the point that opcode may have been designed to be a 32-bit integer instead of an 8-bit one. Therefore make this variable u32. Signed-off-by: Nico

[PATCH] staging: ft1000: fix some checkpatch complaints

2014-07-27 Thread Nicolas Thery
multiple statements should be enclosed in a do - while loop ft1000_proc.c:49: WARNING: static const char * array should probably be static const char * const ft1000_proc.c:53: WARNING: static const char * array should probably be static const char * const Signed-off-by: Nicolas Thery --- drivers

Re: [PATCH] staging: ft1000: fix some checkpatch complaints

2014-07-27 Thread Nicolas Thery
On Sun, Jul 27, 2014 at 10:35:38AM -0700, Greg KH wrote: > On Sun, Jul 27, 2014 at 10:23:53AM -0700, Joe Perches wrote: > > On Sun, 2014-07-27 at 19:08 +0200, Nicolas Thery wrote: > > > This patch fixes the following errors and warnings: > > [] > > > diff --gi

[PATCH] staging: ft1000: remove procfs entries

2014-07-27 Thread Nicolas Thery
This patch started as a fix to some checkpatch complaints in ft1000 procfs code but Greg suggested to remove the procfs entries altogether: http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2014-July/055594.html Signed-off-by: Nicolas Thery --- drivers/staging/ft1000/ft1000

Re: [PATCH v2 0/3] Initial driver support for Xilinx M2M Video Scaler

2018-02-22 Thread Nicolas Dufresne
Le mercredi 21 février 2018 à 14:43 -0800, Rohit Athavale a écrit : > This patch series has three commits : > - Driver support for the Xilinx M2M Video Scaler IP > - TODO document > - DT binding doc > > Changes in HW register map is expected as the IP undergoes changes. > This is a first attemp

Re: [PATCH v2 1/3] staging: xm2mvscale: Driver support for Xilinx M2M Video Scaler

2018-03-19 Thread Nicolas Dufresne
Le mardi 20 mars 2018 à 00:46 +, Rohit Athavale a écrit : > Hi Hans, > > Thanks for taking the time to take a look at this. > > > This should definitely use the V4L2 API. I guess it could be added > > to staging/media with a big fat TODO that this should be converted > > to > > the V4L2 mem2m

[PATCH] media: cedrus: Propagate OUTPUT resolution to CAPTURE

2020-05-14 Thread Nicolas Dufresne
. This also prevents userspace from selecting a CAPTURE resolution that is too small, avoiding unwanted page faults. Signed-off-by: Nicolas Dufresne --- drivers/staging/media/sunxi/cedrus/cedrus_video.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media

Re: [PATCH] media: cedrus: Propagate OUTPUT resolution to CAPTURE

2020-05-14 Thread Nicolas Dufresne
Le jeudi 14 mai 2020 à 11:39 -0400, Nicolas Dufresne a écrit : > As per spec, the CAPTURE resolution should be automatically set based on > the OTUPUT resolution. This patch properly propagate width/height to the > capture when the OUTPUT format is set and override the user provided >

Re: [PATCH] media: cedrus: Add support for VP8 decoding

2020-05-20 Thread Nicolas Dufresne
Le mercredi 20 mai 2020 à 23:01 +0200, Jernej Skrabec a écrit : > VP8 in Cedrus shares same engine as H264. > > Note that it seems necessary to call bitstream parsing functions, > to parse frame header, otherwise decoded image is garbage. This is > contrary to what is driver supposed to do. Howeve

Re: [PATCH 1/3] media: uapi: h264: update reference lists

2020-06-05 Thread Nicolas Dufresne
Sorry, missed one thing. Le vendredi 05 juin 2020 à 13:08 -0400, Nicolas Dufresne a écrit : > Le jeudi 04 juin 2020 à 20:57 +0200, Jernej Skrabec a écrit : > > When dealing with with interlaced frames, reference lists must tell if > > each particular reference is meant for top

Re: [PATCH 1/3] media: uapi: h264: update reference lists

2020-06-05 Thread Nicolas Dufresne
ill come in > following commit. > > Signed-off-by: Jernej Skrabec This looks like the right approach to me and is extensible if anything else is needed for MVC and SVC special referencing (at least will be enough for what H.264 actually supports in this regard). Reviewed-by: Nicolas Dufr

Re: [PATCH 2/3] media: cedrus: h264: Properly configure reference field

2020-06-05 Thread Nicolas Dufresne
ay hold both fields. > > Fix this by checking newly introduced flags in reference lists. > > Signed-off-by: Jernej Skrabec Perhaps an additional patch could cleanup the miss-leading comment in v4l2_h264_dpb_entry definition. Reviewed-by: Nicolas Dufresne > --- > driv

Re: [PATCH 0/3] media: uapi: cedrus: Fix decoding interlaced H264 content

2020-06-07 Thread Nicolas Dufresne
Le samedi 06 juin 2020 à 09:46 -0300, Ezequiel Garcia a écrit : > Hi Jernej, > > On Thu, 4 Jun 2020 at 15:55, Jernej Skrabec wrote: > > Currently H264 interlaced content it's not properly decoded on Cedrus. > > There are two reasons for this: > > 1. slice parameters control doesn't provide enough

Re: [PATCH 0/3] media: uapi: cedrus: Fix decoding interlaced H264 content

2020-06-07 Thread Nicolas Dufresne
Le dimanche 07 juin 2020 à 16:21 -0400, Nicolas Dufresne a écrit : > Le samedi 06 juin 2020 à 09:46 -0300, Ezequiel Garcia a écrit : > > Hi Jernej, > > > > On Thu, 4 Jun 2020 at 15:55, Jernej Skrabec wrote: > > > Currently H264 interlaced content it's not prop

[PATCH 0/4] Detect and remove trace_printk

2020-06-27 Thread Nicolas Boichat
detect such trace_printk at compile time (instead of printing a nasty warning at runtime). Nicolas Boichat (4): usb: cdns3: gadget: Replace trace_printk by dev_dbg media: atomisp: Replace trace_printk by pr_info media: camss: vfe: Use trace_printk for debugging only kernel/trace: Add

[PATCH v2 4/4] kernel/trace: Add TRACING_ALLOW_PRINTK config option

2020-06-27 Thread Nicolas Boichat
: Nicolas Boichat --- Changes since v1: - Use static_assert instead of __static_assert (Jason Gunthorpe) - Fix issues that can be detected by this patch (running some randconfig in a loop, kernel test robot, or manual inspection), by: - Making some debug config options that use

[PATCH 2/4] media: atomisp: Replace trace_printk by pr_info

2020-06-27 Thread Nicolas Boichat
trace_printk should not be used in production code, replace it call with pr_info. Signed-off-by: Nicolas Boichat --- drivers/staging/media/atomisp/pci/hmm/hmm.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/hmm/hmm.c b/drivers

[PATCH 3/4] media: camss: vfe: Use trace_printk for debugging only

2020-06-27 Thread Nicolas Boichat
trace_printk should not be used in production code. Since tracing interrupts is presumably latency sensitive, pr_dbg is not appropriate, so guard the call with a preprocessor symbol that can be defined for debugging purpose. Signed-off-by: Nicolas Boichat --- drivers/media/platform/qcom/camss

[PATCH 1/4] usb: cdns3: gadget: Replace trace_printk by dev_dbg

2020-06-27 Thread Nicolas Boichat
trace_printk should not be used in production code, replace it call with dev_dbg. Signed-off-by: Nicolas Boichat --- Unclear why a trace_printk was used in the first place, it's possible that some rate-limiting is necessary here. drivers/usb/cdns3/gadget.c | 2 +- 1 file changed, 1 inse

Re: [PATCH v13 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP

2020-07-07 Thread Nicolas Boichat
On Tue, Jun 9, 2020 at 3:20 PM Xin Ji wrote: > > The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed > for portable device. It converts MIPI DSI/DPI to DisplayPort 1.3 4K. > > Signed-off-by: Xin Ji > --- > drivers/gpu/drm/bridge/analogix/Kconfig |9 + > drivers/gpu/drm/brid

Re: [PATCH 1/3] media: uapi: h264: update reference lists

2020-07-08 Thread Nicolas Dufresne
Le mercredi 08 juillet 2020 à 17:57 +0200, Jernej Škrabec a écrit : > Hi! > > Dne sreda, 08. julij 2020 ob 15:28:52 CEST je Ezequiel Garcia napisal(a): > > Hello Jernej, > > > > I'd like to post a new H264 uAPI cleanup series soon, > > would you mind resending this, or otherwise do you > > mind i

[RESEND PATCH] media: atomisp: Replace trace_printk by pr_info

2020-07-09 Thread Nicolas Boichat
trace_printk should not be used in production code, replace it call with pr_info. Signed-off-by: Nicolas Boichat --- Sent this before as part of a series (whose 4th patch was a change that allows to detect such trace_printk), but maybe it's easier to get individual maintainer attenti

Re: [PATCH 1/4] usb: cdns3: gadget: Replace trace_printk by dev_dbg

2020-07-23 Thread Nicolas Boichat
On Thu, Jul 23, 2020 at 9:17 PM Felipe Balbi wrote: > > Nicolas Boichat writes: > > > trace_printk should not be used in production code, replace it > > call with dev_dbg. > > > > Signed-off-by: Nicolas Boichat > > > > --- > > > > Unc

Re: [RESEND PATCH] media: atomisp: Replace trace_printk by pr_info

2020-07-24 Thread Nicolas Boichat
On Fri, Jul 10, 2020 at 3:03 PM Greg Kroah-Hartman wrote: > > On Fri, Jul 10, 2020 at 02:45:29PM +0800, Nicolas Boichat wrote: > > trace_printk should not be used in production code, replace it > > call with pr_info. > > > > Signed-off-by: Nicolas Boichat > >

Re: [RESEND PATCH] media: atomisp: Replace trace_printk by pr_info

2020-08-06 Thread Nicolas Boichat
On Fri, Jul 24, 2020 at 8:41 PM Nicolas Boichat wrote: > > On Fri, Jul 10, 2020 at 3:03 PM Greg Kroah-Hartman > wrote: > > > > On Fri, Jul 10, 2020 at 02:45:29PM +0800, Nicolas Boichat wrote: > > > trace_printk should not be used in production code, repl

Re: [RESEND PATCH] media: atomisp: Replace trace_printk by pr_info

2020-08-06 Thread Nicolas Boichat
On Fri, Aug 7, 2020 at 2:28 PM Greg Kroah-Hartman wrote: > > On Fri, Aug 07, 2020 at 09:50:23AM +0800, Nicolas Boichat wrote: > > On Fri, Jul 24, 2020 at 8:41 PM Nicolas Boichat > > wrote: > > > > > > On Fri, Jul 10, 2020 at 3:03 PM Greg Kroah-Hartman >

Re: [RESEND PATCH] media: atomisp: Replace trace_printk by pr_info

2020-08-07 Thread Nicolas Boichat
On Fri, Aug 7, 2020 at 4:04 PM Mauro Carvalho Chehab wrote: > > Em Fri, 7 Aug 2020 14:51:12 +0800 > Nicolas Boichat escreveu: > > > On Fri, Aug 7, 2020 at 2:28 PM Greg Kroah-Hartman > > wrote: > > > > > > On Fri, Aug 07, 2020 at 09:50:23AM +0800, Nic

[PATCH v4 3/3] media: atomisp: Only use trace_printk if allowed

2020-08-20 Thread Nicolas Boichat
We added a config option CONFIG_TRACING_ALLOW_PRINTK to make sure that no extra trace_printk gets added to the kernel, let's use that in this driver to guard the trace_printk call. Signed-off-by: Nicolas Boichat --- Technically, we could only initialize the trace_printk buffers when the

Re: [PATCH v4 3/3] media: atomisp: Only use trace_printk if allowed

2020-08-20 Thread Nicolas Boichat
On Thu, Aug 20, 2020 at 10:23 PM Steven Rostedt wrote: > > On Thu, 20 Aug 2020 17:14:12 +0800 > Nicolas Boichat wrote: > > > Technically, we could only initialize the trace_printk buffers > > when the print env is switched, to avoid the build error and > > uncondit

Re: [PATCH v4 3/3] media: atomisp: Only use trace_printk if allowed

2020-08-20 Thread Nicolas Boichat
On Fri, Aug 21, 2020 at 8:36 AM Steven Rostedt wrote: > > On Fri, 21 Aug 2020 08:13:00 +0800 > Nicolas Boichat wrote: > > > On Thu, Aug 20, 2020 at 10:23 PM Steven Rostedt wrote: > > > > > > On Thu, 20 Aug 2020 17:14:12 +0800 > > > Nicolas Boicha

Re: [PATCH v4 3/3] media: atomisp: Only use trace_printk if allowed

2020-08-20 Thread Nicolas Boichat
On Fri, Aug 21, 2020 at 9:57 AM Steven Rostedt wrote: > > On Fri, 21 Aug 2020 09:39:19 +0800 > Nicolas Boichat wrote: > > > On Fri, Aug 21, 2020 at 8:36 AM Steven Rostedt wrote: > > > > > > On Fri, 21 Aug 2020 08:13:00 +0800 > > > Nicolas Boichat wr

Re: [PATCH v4 3/3] media: atomisp: Only use trace_printk if allowed

2020-08-20 Thread Nicolas Boichat
On Fri, Aug 21, 2020 at 10:36 AM Joe Perches wrote: > > On Thu, 2020-08-20 at 21:57 -0400, Steven Rostedt wrote: > > On Fri, 21 Aug 2020 09:39:19 +0800 > > Nicolas Boichat wrote: > [] > > > Some other approaches/ideas: > > > 1. Filter all lkml messages t

Re: [PATCH v4 3/3] media: atomisp: Only use trace_printk if allowed

2020-08-21 Thread Nicolas Boichat
On Fri, Aug 21, 2020 at 4:48 PM David Laight wrote: > > From: Steven Rostedt > > Sent: 21 August 2020 01:36 > > On Fri, 21 Aug 2020 08:13:00 +0800 > > Nicolas Boichat wrote: > > > > > On Thu, Aug 20, 2020 at 10:23 PM Steven Rostedt > > > wro

Re: [PATCH v4 3/3] media: atomisp: Only use trace_printk if allowed

2020-08-21 Thread Nicolas Boichat
On Fri, Aug 21, 2020 at 7:32 PM David Laight wrote: > > From: Nicolas Boichat > > Sent: 21 August 2020 11:28 > > > > On Fri, Aug 21, 2020 at 4:48 PM David Laight > > wrote: > > > > > > From: Steven Rostedt > > > > Sent: 21

Re: [PATCH v4 3/3] media: atomisp: Only use trace_printk if allowed

2020-08-21 Thread Nicolas Boichat
On Fri, Aug 21, 2020 at 11:01 AM Steven Rostedt wrote: > > On Fri, 21 Aug 2020 10:39:02 +0800 > Nicolas Boichat wrote: > > > I'm not sure how that helps? I mean, the use case you have in mind is > > somebody reusing a distro/random config and not being able to us

  1   2   3   4   5   6   >