Re: [PATCH] staging: vc04_services: setup DMA and coherent mask

2016-10-31 Thread Michael Zoran
On Mon, 2016-10-31 at 11:36 -0700, Eric Anholt wrote: > Michael Zoran writes: > > > Setting the DMA mask is optional on 32 bit but > > is mandatory on 64 bit.  Set the DMA mask and coherent > > to force all DMA to be in the 32 bit address space. > > > > This

Re: [PATCH] staging: vc04_services: setup DMA and coherent mask

2016-10-31 Thread Michael Zoran
On Mon, 2016-10-31 at 11:40 -0700, Michael Zoran wrote: > On Mon, 2016-10-31 at 11:36 -0700, Eric Anholt wrote: > > Michael Zoran writes: > > > > > Setting the DMA mask is optional on 32 bit but > > > is mandatory on 64 bit.  Set the DMA mask and coherent >

Re: [PATCH] staging: vc04_services: setup DMA and coherent mask

2016-10-31 Thread Michael Zoran
On Mon, 2016-10-31 at 12:53 -0700, Michael Zoran wrote: > On Mon, 2016-10-31 at 11:40 -0700, Michael Zoran wrote: > > On Mon, 2016-10-31 at 11:36 -0700, Eric Anholt wrote: > > > Michael Zoran writes: > > > > > > > Setting the DMA mask is optional on 32

[PATCH v2] staging: vc04_services: setup DMA and coherent mask

2016-10-31 Thread Michael Zoran
VCHI messages between the CPU and firmware use 32-bit bus addresses. Explicitly set the DMA mask and coherent on all platforms. Signed-off-by: Michael Zoran --- .../staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers

[PATCH] staging: vc04_services: parse_rx_slots() - Fix compiler warning

2016-11-01 Thread Michael Zoran
cast to long before the original cast to int to silence the warning. Signed-off-by: Michael Zoran --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b

[PATCH v2] staging: vc04_services: add vchiq_pagelist_info structure

2016-11-07 Thread Michael Zoran
Signed-off-by: Michael Zoran --- .../interface/vchiq_arm/vchiq_2835_arm.c | 223 +++-- 1 file changed, 113 insertions(+), 110 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm

Re: [PATCH] staging: vc04_services: add vchiq_pagelist_info structure

2016-11-07 Thread Michael Zoran
On Mon, 2016-11-07 at 11:03 +0100, Greg KH wrote: > On Mon, Oct 31, 2016 at 01:10:35AM -0700, Michael Zoran wrote: > > The current dma_map_sg based implementation for bulk messages > > computes many offsets into a single allocation multiple times in > > both the create and f

[PATCH] staging: vc04_services: Add 32-bit compatibility ioctls

2016-11-07 Thread Michael Zoran
chroot install from the same OS to test the compatibility ioctls. Both test cases now pass. Signed-off-by: Michael Zoran --- .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 269 + .../vc04_services/interface/vchiq_arm/vchiq_if.h | 25 ++ .../interface/vchiq_arm

[PATCH] staging: vc04_services: rework ioctl code path

2016-11-09 Thread Michael Zoran
OS. Both test cases pass. Signed-off-by: Michael Zoran --- .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 1914 +--- .../vc04_services/interface/vchiq_arm/vchiq_if.h | 19 + .../interface/vchiq_arm/vchiq_ioctl.h | 69 + 3 files changed, 1389 insertions

[PATCH v2] staging: vc04_services: rework ioctl code path

2016-11-10 Thread Michael Zoran
parameters have been reduced for the handling functions by giving a different prototype to ioctls that pass no arguments. 3. Macros in linux/compat.h are now used for compatibility data structures. Signed-off-by: Michael Zoran --- .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 1733

Re: [PATCH v2] staging: vc04_services: rework ioctl code path

2016-11-14 Thread Michael Zoran
On Mon, 2016-11-14 at 12:48 +0300, Dan Carpenter wrote: > On Thu, Nov 10, 2016 at 10:15:31PM -0800, Michael Zoran wrote: > > +static void * > > +vchiq_ioctl_kmalloc(struct vchiq_ioctl_call_context *ctxt, size_t > > size) > > +{ > > + void *mem; > > + &

Re: [PATCH v2] staging: vc04_services: rework ioctl code path

2016-11-15 Thread Michael Zoran
On Tue, 2016-11-15 at 10:55 +0100, Greg KH wrote: > On Thu, Nov 10, 2016 at 10:15:31PM -0800, Michael Zoran wrote: > > VCHIQ/vc04_services has a userland device interface > > that includes ioctls. The current ioctl implementation > > is a single monolithic function over

Re: [bug report] staging: add bcm2708 vchiq driver

2016-11-15 Thread Michael Zoran
On Tue, 2016-11-15 at 20:42 +0100, Stefan Wahren wrote: > Hi Dan, > > > Dan Carpenter hat am 15. November 2016 > > um 14:15 > > geschrieben: > > > > > > Hello popcornmix, > > > > The patch 71bad7f08641: "staging: add bcm2708 vchiq driver" from > > Jul > > 2, 2013, leads to the following static

Re: [bug report] staging: add bcm2708 vchiq driver

2016-11-15 Thread Michael Zoran
On Tue, 2016-11-15 at 22:04 -0500, Vince Weaver wrote: > On Tue, 15 Nov 2016, Michael Zoran wrote: > > > I'm still interested to know more about the MMU statement.  I would > > think at least some of the RPI models have one because swapping > > appears > > to

Re: [PATCH v3] staging: vboxvideo: Add vboxvideo to drivers/staging

2017-06-27 Thread Michael Thayer
st beware pls. > > Thanks for the heads up Daniel, for now I would like to move forward with > getting this in staging, but I do agree that it would be good to get it > into drivers/gpu soon. Michael do you think you will have some time soon > to look at moving this to the atomic

[PATCH 1/1] rtl8188eu: add TL-WN722N v2 support

2017-07-17 Thread Michael Gugino
Add support for USB Device TP-Link TL-WN722N v2. VendorID: 0x2357, ProductID: 0x010c Signed-off-by: Michael Gugino --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep

[PATCH 1/1] staging: rtl8188eu: add TL-WN722N v2 support

2017-07-17 Thread Michael Gugino
Add support for USB Device TP-Link TL-WN722N v2. VendorID: 0x2357, ProductID: 0x010c Signed-off-by: Michael Gugino --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep

Re: [PATCH] staging: vboxvideo: make a couple of symbols static

2017-07-22 Thread Michael Thayer
s de Goede Looks good to me too. Sorry for the slow response. Still had no time to actually apply it, but as said, it looks completely sensible. Regards Michael Acked-by: Michael Thayer >> --- >> drivers/staging/vboxvideo/vbox_drv.c | 2 +- >> drivers/staging/vboxvid

Re: [PATCH] staging: vboxvideo: remove unused variables

2017-07-23 Thread Michael Thayer
yet, but as said, it looks completely sensible. Regards Michael Acked-by: Michael Thayer > Regards, > > Hans > > >> --- >> drivers/staging/vboxvideo/vbox_mode.c | 5 - >> 1 file changed, 5 deletions(-) >> >> diff --git a/drivers/staging/vboxvi

Re: [lustre-devel] [PATCH 1/3] staging: lustre: checkpatch cleanups for nidstring.c

2015-11-01 Thread Michael Shuey
I suspect you're over-thinking it. The maintainers appear to be reacting to the different types of style changes - "checkpatch cleanups" is an awfully broad commit message. I'd suggest breaking this patch (and any others like it) into two pieces; one with whitespace cleanups, and one with the "==

[PATCH] [media] davinci: vpfe: remove deprecated IRQF_DISABLED

2013-10-05 Thread Michael Opdenacker
This patch proposes to remove the use of the IRQF_DISABLED flag It's a NOOP since 2.6.35 and it will be removed one day. Signed-off-by: Michael Opdenacker --- drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dr

[PATCH][RESEND] [media] davinci: vpfe: remove deprecated IRQF_DISABLED

2013-12-09 Thread Michael Opdenacker
This patch proposes to remove the use of the IRQF_DISABLED flag It's a NOOP since 2.6.35 and it will be removed one day. Signed-off-by: Michael Opdenacker Acked-by: Lad, Prabhakar --- drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c | 6 +++--- 1 file changed, 3 insertions(+), 3 dele

[PATCH] silicom: fixed checkpatch issues in bypass.c

2013-12-18 Thread Michael Hoefler
ition - whitespace stuff - a C++ one line comment - parenthesis at return statements - missing __init and __exit macros Signed-off-by: Michael Hoefler Signed-off-by: Christoph Kohl --- drivers/staging/silicom/bypasslib/bypass.c | 168 +++-- 1 file changed, 90 insertions(+

[PATCHv2 0/3] staging: silicom: fix code styling according to checkpatch

2013-12-20 Thread Michael Hoefler
some empty lines for a better readability and added missing braces. This series does not perform functional changes to the code because i do not have any hardware to test it. Michael Hoefler (3): silicom: fix whitespace issues in bypass.c silicom: fix coding style issues in bypass.c silicom

[PATCHv2 1/3] silicom: fix whitespace issues in bypass.c

2013-12-20 Thread Michael Hoefler
local declarations - empty line after { The empty line issues were not discovered by checkpatch but in my opinion these changes make perfect sense in terms of readability. Signed-off-by: Michael Hoefler Signed-off-by: Christoph Kohl --- drivers/staging/silicom/bypasslib/bypass.c | 111

[PATCHv2 3/3] silicom: remaining checkpatch issues in bypass.c

2013-12-20 Thread Michael Hoefler
change the functionality in any way. Signed-off-by: Michael Hoefler Signed-off-by: Christoph Kohl --- drivers/staging/silicom/bypasslib/bypass.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/staging/silicom/bypasslib/bypass.c b/drivers/staging/silicom

[PATCHv2 2/3] silicom: fix coding style issues in bypass.c

2013-12-20 Thread Michael Hoefler
: Michael Hoefler Signed-off-by: Christoph Kohl --- drivers/staging/silicom/bypasslib/bypass.c | 32 -- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/drivers/staging/silicom/bypasslib/bypass.c b/drivers/staging/silicom/bypasslib/bypass.c index

vme_tsi148 question

2013-12-27 Thread Michael Kenney
-list for this question, please let me know. Thanks. --Mike - Michael Kenney Ocean Engineering Dept Applied Physics Lab University of Washi

Re: vme_tsi148 question

2013-12-27 Thread Michael Kenney
Hi Martyn, On Fri, Dec 27, 2013 at 4:23 PM, Martyn Welch wrote: > On 27/12/13 20:15, Michael Kenney wrote: >> >> We are using the vme_tsi148 bridge driver along with the vme_user >> driver to access the VME boards. The A/D board requires D32 bus cycles >> and the VME

[PATCH 2/7] vt6655: Fix most of checkpatch.pl errors in wroute

2013-12-30 Thread Michael Gunselmann
line 189 will be fixed in a later commit because it's purpose is not yet known. Signed-off-by: Michael Gunselmann Signed-off-by: Martin Hofmann --- drivers/staging/vt6655/wroute.c | 71 - drivers/staging/vt6655/wroute.h | 3 +- 2

[PATCH 6/7] vt6655: Remove typedefs in 80211hdr.h

2013-12-30 Thread Michael Gunselmann
From: Martin Hofmann The file 80211hdr.h contained typedefs for 5 types. To satisfy checkpatch, this commit removes them. In 10 other files, every occurence of a now deleted type has been substituted with the correct struct ... syntax. Signed-off-by: Martin Hofmann Signed-off-by: Michael

[PATCH 4/7] vt6655: Fixed most of the checkpatch warnings in wpa2

2013-12-30 Thread Michael Gunselmann
necessary to adjust variable declarations that depended on typedefs in wpa2.h. The checkpatch cleanup of this file still remains. Signed-off-by: Michael Gunselmann Signed-off-by: Martin Hofmann --- drivers/staging/vt6655/vntwifi.c | 4 +- drivers/staging/vt6655/wpa2.c| 186

[PATCH 5/7] vt6655: Fixed most of the checkpatch warnings in wpa

2013-12-30 Thread Michael Gunselmann
wpa.h: Checkpatch does no longer complain about anything. wpactl.c: Some long-line-warnings still remain but fixing them would deteriorate code readability. Signed-off-by: Michael Gunselmann Signed-off-by: Martin Hofmann --- drivers/staging/vt6655/wpa.c | 156

[PATCH 0/7] vt6655: Cleanup of checkpatch errors

2013-12-30 Thread Michael Gunselmann
This patch series cleans up all checkpatch errors and some warnings in some files of the vt6655 driver in staging. The reference git tree is linux-next. Some checkpatch warnings were not fixed, they are commented in the particular patches. Not all files of the driver were cleaned up in this patc

[PATCH 3/7] vt6655: Fixed most of the checkpatch warnings in wpactl

2013-12-30 Thread Michael Gunselmann
r. hostap.c and iwctl.c: wpactl.h used the typedef statement, which was removed while fixing checkpatch-errors. For this to work one statement in hostap.c was adjusted. The ckecpatch cleanup of these two files still remains. Signed-off-by: Michael Gunselmann Signe

[PATCH 1/7] vt6655: Remove unused macros in 80211hdr.h

2013-12-30 Thread Michael Gunselmann
From: Martin Hofmann The file 80211hdr.h contained 4 macros (in both little and big endain fashion) that were not used in the driver. Thus, this patch removes them. Signed-off-by: Martin Hofmann Signed-off-by: Michael Gunselmann --- drivers/staging/vt6655/80211hdr.h | 8 1 file

Re: vme_tsi148 question

2014-01-07 Thread Michael Kenney
Hi Martyn, On Fri, Dec 27, 2013 at 4:34 PM, Michael Kenney wrote: > > Hi Martyn, > > On Fri, Dec 27, 2013 at 4:23 PM, Martyn Welch wrote: > > On 27/12/13 20:15, Michael Kenney wrote: > >> > >> We are using the vme_tsi148 bridge driver along with the vme_user

Re: vme_tsi148 question

2014-01-13 Thread Michael Kenney
Hi Martyn, On Mon, Jan 13, 2014 at 4:00 AM, Martyn Welch wrote: [snip] > > Hi Mike, > > I'm a little bemused by this one - I haven't managed to replicate it yet. I > have a feeling that the VME driver in version 3.2 won't use 16-bit transfers > at the beginning of blocks that aren't naturally ali

Re: vme_tsi148 question

2014-01-13 Thread Michael Kenney
Hi Martyn, On Mon, Jan 13, 2014 at 6:49 AM, Michael Kenney wrote: > Hi Martyn, > > On Mon, Jan 13, 2014 at 4:00 AM, Martyn Welch wrote: > [snip] >> >> Hi Mike, >> >> I'm a little bemused by this one - I haven't managed to replicate it yet. I >&g

Re: vme_tsi148 question

2014-01-14 Thread Michael Kenney
On Tue, Jan 14, 2014 at 1:39 AM, Martyn Welch wrote: > On 14/01/14 04:07, Michael Kenney wrote: >> Unfortunately, the results are the same. I'm running this from home so >> I'll have to confirm with the logic-analyzer tomorrow but the bridge >> driver error mess

Re: vme_tsi148 question

2014-02-05 Thread Michael Kenney
On Wed, Feb 5, 2014 at 1:22 PM, Martyn Welch wrote: > > > > On 5 February 2014 17:41, Greg KH wrote: >> >> On Tue, Feb 04, 2014 at 06:34:13PM +, Martyn Welch wrote: >> > On 04/02/14 16:34, Michael Kenney wrote: >> > >Hi Martyn, >> >

Re: vme_tsi148 question

2014-02-05 Thread Michael Kenney
On Wed, Feb 5, 2014 at 1:38 PM, Michael Kenney wrote: > On Wed, Feb 5, 2014 at 1:22 PM, Martyn Welch wrote: >> >> >> >> On 5 February 2014 17:41, Greg KH wrote: >>> >>> On Tue, Feb 04, 2014 at 06:34:13PM +, Martyn Welch wrote: >>> >

Re: vme_tsi148 question

2014-02-06 Thread Michael Kenney
On Thu, Feb 6, 2014 at 12:40 AM, Martyn Welch wrote: > > > On 05/02/14 23:21, Michael Kenney wrote: >> >> On Wed, Feb 5, 2014 at 1:38 PM, Michael Kenney wrote: >>> >>> On Wed, Feb 5, 2014 at 1:22 PM, Martyn Welch wrote: >>>> >>&

CONTRACT AWARDED!!!1!

2014-08-29 Thread Michael Hiwot
ate email address, mobile telephone number and your private fax number (if any). Yours faithfully, Michael Hiwot ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

CONTRACT AWARDED!!!1!

2014-08-29 Thread Michael Hiwot
ate email address, mobile telephone number and your private fax number (if any). Yours faithfully, Michael Hiwot ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: nokia_h4: remove deprecated IRQF_DISABLED

2014-10-01 Thread Michael Opdenacker
Remove the use of the IRQF_DISABLED flag from drivers/staging/nokia_h4p/nokia_core.c It's a NOOP since 2.6.35 and it will be removed soon. Signed-off-by: Michael Opdenacker --- drivers/staging/nokia_h4p/nokia_core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --

Re: [PATCH] staging: nokia_h4: remove deprecated IRQF_DISABLED

2014-10-02 Thread Michael Opdenacker
Hi Aaro, Thank you for reviewing my patch! On 10/01/2014 11:42 PM, Aaro Koskinen wrote: > Hi, > > On Wed, Oct 01, 2014 at 10:33:48PM +0200, Michael Opdenacker wrote: >> Remove the use of the IRQF_DISABLED flag >> from drivers/staging/nokia_h4p/nokia_core.c >> >>

[PATCH] staging: comedi: add identifiers to function parameters

2017-12-21 Thread Michael Gebhard
ned-off-by: Michael Gebhard Signed-off-by: David Sauerwein --- drivers/staging/comedi/comedidev.h | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h index fb1f07fa..8f6d160 10

[PATCH] staging: pi433: Cleanup codestyle, indent statements after case labels

2017-12-23 Thread Michael Panzlaff
ments into the same line of their belonging case labels. Therefore this adapts to the more usual style. Please note that there is still a lot of > 80 character lines which will cause checkpatch warnings. This patch does not intent to fix this already existing issue. Signed-off-by: Michael

[PATCH 1/1] staging: pi433: Cleanup codestyle, indent statements after case labels

2018-01-09 Thread Michael Panzlaff
lease note that there is still a lot of > 80 character lines which will cause checkpatch warnings. This patch does not intent to fix this already existing issue. Signed-off-by: Michael Panzlaff Signed-off-by: Tillmann Zipperer --- drivers/staging/pi433/rf69

[PATCH char-misc 1/1] Drivers: hv: vmbus: Fix ring buffer signaling

2018-02-10 Thread Michael Kelley
03bad714a161 ("vmbus: more host signalling avoidance") Signed-off-by: Michael Kelley --- drivers/hv/ring_buffer.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/drivers/hv/ring_buffer.c b/drivers/hv/ring_buffer.c index 50e0714..b64be18 100644

[PATCH v2 char-misc 1/1] Drivers: hv: vmbus: Fix ring buffer signaling

2018-02-16 Thread Michael Kelley
03bad714a161 ("vmbus: more host signalling avoidance") Signed-off-by: Michael Kelley --- Changes in v2: * Restructured to do signaling calcuations only if needed. Makes the most common path faster [KY Srinivasan, Steve Hemminger] * Moved bytes read calculation to new routine hv_pk

[PATCH char-misc 1/1] Drivers: hv: vmbus: Add hooks for per-CPU IRQ

2018-03-11 Thread Michael Kelley
/x64 don't use an IRQ. Signed-off-by: Michael Kelley --- arch/x86/include/asm/mshyperv.h | 4 drivers/hv/hv.c | 2 ++ 2 files changed, 6 insertions(+) diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h index e73c4d0..b73b839 100644 --- a/arc

[PATCH] staging: rtl8188eu: clean up some declarations

2020-05-24 Thread Michael Straube
Clean up some array declarations in phy_iq_calibrate() to reduce indentation and clear line over 80 characters checkpatch warnings. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/phy.c | 33 +++-- 1 file changed, 17 insertions(+), 16 deletions(-) diff

[PATCH v2 2/2] staging: rtl8188eu: make some arrays static const

2020-05-24 Thread Michael Straube
Make some arrays in phy_iq_calibrate() static const and adjust the functions that take these arrays as parameters accordingly. Reduces object file size by 84 bytes (GCC 9.3.1 x86_64). Suggested-by: Joe Perches Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/phy.c | 21

[PATCH v2 1/2] staging: rtl8188eu: clean up some declarations

2020-05-24 Thread Michael Straube
Clean up some array declarations in phy_iq_calibrate() to reduce indentation and clear line over 80 characters checkpatch warnings. Signed-off-by: Michael Straube --- v1 -> v2 Added patch that makes arrays static const. drivers/staging/rtl8188eu/hal/phy.c | 33 +++--

[PATCH] staging: rtl8188eu: use common packet header constants

2020-06-19 Thread Michael Straube
The driver replicates the definitions of rfc1042_header and bridge_tunnel_header available from cfg80211.h. Use the common ones from cfg80211.h. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_recv.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions

[PATCH] staging: rtl8188eu: remove blank lines in header files

2020-06-27 Thread Michael Straube
Remove blank lines in header files to clear checkpatch issues. CHECK: Please don't use multiple blank lines Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/include/drv_types.h | 1 - drivers/staging/rtl8188eu/include/hal_com.h | 1 - drivers/staging/rtl8188eu/in

[PATCH] staging: rtl8188eu: remove unnecessary comments in hal8188e_phy_cfg.h

2020-06-27 Thread Michael Straube
Remove unnecessary comments in hal8188e_phy_cfg.h to improve readability and clear multiple blank lines checkpatch issues. CHECK: Please don't use multiple blank lines Signed-off-by: Michael Straube --- .../rtl8188eu/include/hal8188e_phy_cfg.h | 23 --- 1 file change

[PATCH v2] staging: rtl8188eu: remove unnecessary comments in hal8188e_phy_cfg.h

2020-06-28 Thread Michael Straube
Remove unnecessary comments in hal8188e_phy_cfg.h to improve readability and clear multiple blank lines checkpatch issues. CHECK: Please don't use multiple blank lines Signed-off-by: Michael Straube --- v1 -> v2 Remove one more line as suggested by Dan Carpenter. .../rtl8188eu

Re: [PATCH] staging: rtl8188eu: include: ieee80211.h: fixed multiple blank line coding style issues.

2020-06-29 Thread Michael Straube
5bfb7eadc5874a3a08dd173d66a16a1ed0548444 ("staging: rtl8188eu: remove blank lines in header files") regards, Michael ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 2/2] staging: rtl8188eu: add spaces around operators

2020-06-29 Thread Michael Straube
Add spaces around operators to improve readability and clear checkpatch issues. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 8 +- drivers/staging/rtl8188eu/core/rtw_recv.c | 70 ++-- drivers/staging/rtl8188eu/core/rtw_security.c | 102

[PATCH 1/2] staging: rtl8188eu: use compound assignment operators

2020-06-29 Thread Michael Straube
Use compound assignment operators to simplify the code and clear missing spaces around operators checkpatch issues. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu

[PATCH 2/3] staging: rtl8723bs: remove some ieee80211 constants from wifi.h

2020-06-29 Thread Michael Straube
The constants IEEE80211_BAR_CTRL_ACK_POLICY_NORMAL and IEEE80211_BAR_CTRL_CBMTID_COMPRESSED_BA are not used in the driver code and, if ever needed, available from 'include/linux/ieee80211.h'. Remove them from wifi.h. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/incl

[PATCH 3/3] staging: rtl8712: remove some ieee80211 constants from wifi.h

2020-06-29 Thread Michael Straube
The constants IEEE80211_BAR_CTRL_ACK_POLICY_NORMAL and IEEE80211_BAR_CTRL_CBMTID_COMPRESSED_BA are not used in the driver code and, if ever needed, available from 'include/linux/ieee80211.h'. Remove them from wifi.h. Signed-off-by: Michael Straube --- drivers/staging/rtl8712/wifi.h |

[PATCH 1/3] staging: rtl8188eu: remove some ieee80211 constants from wifi.h

2020-06-29 Thread Michael Straube
The constants IEEE80211_BAR_CTRL_ACK_POLICY_NORMAL and IEEE80211_BAR_CTRL_CBMTID_COMPRESSED_BA are not used in the driver code and, if ever needed, available from 'include/linux/ieee80211.h'. Remove them from wifi.h. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/incl

Re: [PATCH] media: allegro: Fix some NULL vs IS_ERR() checks in probe

2020-07-01 Thread Michael Tretter
On Fri, 19 Jun 2020 17:30:07 +0300, Dan Carpenter wrote: > The devm_ioremap() function doesn't return error pointers, it returns > NULL on error. > > Fixes: f20387dfd065 ("media: allegro: add Allegro DVT video IP core driver") > Signed-off-by: Dan Carpenter

[PATCH] staging: rtl8712: use common ieee80211 constants

2020-07-01 Thread Michael Straube
Many defined constants in wifi.h are unused and/or available from , some with slightly different names. Use the common ones, rename where necessary and remove unused. Signed-off-by: Michael Straube --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 2 +- drivers/staging/rtl8712/rtl871x_mlme.c

[PATCH] staging: rtl8188eu: remove unused parameter

2020-07-01 Thread Michael Straube
Remove unused parameter 'padapter' from rtw_os_xmit_resource_alloc(). Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 6 +++--- drivers/staging/rtl8188eu/include/xmit_osdep.h | 3 +-- drivers/staging/rtl8188eu/os_dep/xmit_linux.c | 3 +-- 3 files

[PATCH] staging: rtl8188eu: use common ieee80211 constants

2020-07-01 Thread Michael Straube
Many defined constants in wifi.h are unused and/or available from , some with slightly different names. Use the common ones, rename where necessary and remove unused. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_ap.c | 12 ++--- drivers/staging/rtl8188eu/core

[PATCH 1/2] staging: rtl8192u: remove GPL boiler plate text

2020-07-03 Thread Michael Straube
The SPDX identifier is a legally binding shorthand, which can be used instead of the full boiler plate text. The file ieee80211_module.c has a proper SPDX line, so the GPL boiler plate text is not needed. Signed-off-by: Michael Straube --- .../rtl8192u/ieee80211/ieee80211_module.c| 16

[PATCH 2/2] staging: rtl8192u: remove copying file

2020-07-03 Thread Michael Straube
All source and header files have a GPL-2.0 SPDX identifier. The 'copying' file with the whole GPL text is not needed, delete it. Signed-off-by: Michael Straube --- drivers/staging/rtl8192u/copying | 340 --- 1 file changed, 340 deletions(-) delete m

[PATCH] staging: rtl8188eu: clear tabstop style issues

2020-07-17 Thread Michael Straube
Clear tabstop style issues reported by checkpatch. WARNING: Statements should start on a tabstop Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_ioctl_set.c| 2 +- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 2 +- drivers/staging/rtl8188eu/os_dep/ioctl_linux.c

[PATCH] staging: rtl8188eu: add spaces around operators in header files

2020-07-19 Thread Michael Straube
Add spaces around operators in the header files to improve readability and clear checkpatch issues. Signed-off-by: Michael Straube --- .../rtl8188eu/include/hal8188e_rate_adaptive.h | 4 ++-- drivers/staging/rtl8188eu/include/odm_types.h| 6 +++--- drivers/staging/rtl8188eu

Re: [PATCH][next] media: allegro: fix potential null dereference on header

2020-07-22 Thread Michael Tretter
itch statement right below the assignment. Thus, you could remove the local variable and directly use header->type in the switch. Michael > + > switch (type) { > case MCU_MSG_TYPE_INIT: > size = allegro_enc_init(&dst[1], msg); > -- > 2.27.0 >

Re: [PATCH] media: allegro: fix an error pointer vs NULL check

2020-07-22 Thread Michael Tretter
On Wed, 22 Jul 2020 15:38:48 +0300, Dan Carpenter wrote: > The allegro_mbox_init() function returns error pointers, it never > returns NULL. > > Fixes: 94dc76560261 ("media: allegro: rework mbox handling") > Signed-off-by: Dan Carpenter Reviewed-by: Michael Tretter

Re: [PATCH][next][V2] media: allegro: fix potential null dereference on header

2020-07-22 Thread Michael Tretter
coding") > Signed-off-by: Colin Ian King Reviewed-by: Michael Tretter > --- > > V2: remove need for variable type, as suggested by Michael Tretter > > --- > drivers/staging/media/allegro-dvt/allegro-mail.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions

[PATCH 1/2] staging: rtl8188eu: clear alignment style issues

2020-07-23 Thread Michael Straube
Clear checkpatch alignment style issues in rtl8188eu_recv.c. CHECK: Alignment should match open parenthesis The file is now checkpatch clean. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[PATCH 2/2] staging: rtl8188eu: cleanup whitespace in declarations

2020-07-23 Thread Michael Straube
Replace tabs with spaces in declarations to cleanup whitespace in rtl8188eu_recv.c. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c

staging: most: Build error since commit "drivers: most: add USB adapter driver"

2020-08-02 Thread Michael Straube
1763: _clean_drivers] Error 2 make: *** [Makefile:336: __build_one_by_one] Error 2 Did you forgot to remove the below line from drivers/staging/most/Makefile ? obj-$(CONFIG_MOST_USB) += usb/ Regards, Michael ___ devel mailing list de...@linuxdr

[PATCH] staging: rtl8723bs: remove 5 GHz code

2020-08-12 Thread Michael Straube
According to the TODO 5 GHz code should be removed. - find and remove remaining code valid only for 5 GHz. Most of the obvious ones have been removed, but things like channel > 14 still exist. Remove code for channels > 14 from rtw_get_center_ch(). Signed-off-by: Michael Straube --- d

[PATCH] staging: rtl8188eu: use __func__ in os_dep

2020-08-30 Thread Michael Straube
Use __func__ instead of hardcoded function names to clear checkpatch warnings. Signed-off-by: Michael Straube --- .../staging/rtl8188eu/os_dep/ioctl_linux.c| 80 +-- drivers/staging/rtl8188eu/os_dep/os_intfs.c | 36 - drivers/staging/rtl8188eu/os_dep/usb_intf.c

Re: BUG: scheduling while atomic 3.10.7 in ZRAM Swap

2013-08-18 Thread Michael wang
ify() should not use rw-lock which may goto sleep. CC folks related. Regards, Michael Wang > > The log include multiple messages similar to the following: > > [ 3019.011511] BUG: scheduling while atomic: cc1/23223/0x0001 > [ 3019.011517] Modules linked in: zram(C) nvidi

Overview of promotional materials

2023-09-22 Thread Michael Beutler
asing decisions. If you are interested in this topic, please reply, and we will get in touch with you. Kind regards Michael Beutler ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

RE: [PATCH AUTOSEL 6.1 3/7] x86/hyperv: Use slow_virt_to_phys() in page transition hypervisor callback

2024-03-12 Thread Michael Kelley
> > This seems to be preparation for something we don't plan to do in > -stable. Please drop. > As the author of the patch, I agree. Michael ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

RE: [PATCH 10/13] x86/hyper-v: Add HvFlushGuestAddressList hypercall support

2018-09-11 Thread Michael Kelley (EOSG)
sp->gfn, end_gfn); > + } Per the previous comment, if this loop really needs to walk a KVM data structure, look for a different way to organize things so that the handling of KVM-specific data structures is in code that’s part of KVM, rather than in H

RE: [PATCH] Drivers: hv: vmbus: include header for get_irq_regs()

2018-09-15 Thread Michael Kelley (EOSG)
()? Did you figure out exactly what line of code is causing the compile error? I'm wondering whether adding the #include of irq.h into hyperv_vmbus.h is really the right solution. More correct might be to have the file where get_irq_regs() is actually used to #include irq_regs.h. Michae

RE: [PATCH] x86/hyperv: suppress "PCI: Fatal: No config space access function found"

2018-09-19 Thread Michael Kelley (EOSG)
Dexuan Cui > Cc: K. Y. Srinivasan > Cc: Haiyang Zhang > Cc: Stephen Hemminger > --- > arch/x86/hyperv/hv_init.c | 19 +++ > 1 file changed, 19 insertions(+) > Reviewed-by: Michael Kelley ___ devel ma

RE: [PATCH V2 2/13] KVM/MMU: Add tlb flush with range helper function

2018-09-19 Thread Michael Kelley (EOSG)
ll_cpus_request(). I haven't traced all the details, but it seems like the comment should be updated, or the code isn't needed. Michael ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

RE: [PATCH V2 4/13] KVM/MMU: Flush tlb directly in the kvm_handle_hva_range()

2018-09-19 Thread Michael Kelley (EOSG)
gfn_start, > + gfn_end - gfn_start); Does the above need to be gfn_end - gfn_start + 1? > + ret = 0; > + } Michael ___ devel mailing list de..

RE: [PATCH V2 10/13] x86/hyper-v: Add HvFlushGuestAddressList hypercall support

2018-09-19 Thread Michael Kelley (EOSG)
From: Tianyu Lan Sent: Monday, September 17, 2018 8:19 PM > > #include > #include > #include > #include > +#include Hopefully asm/kvm_host.h does not need to be #included, given the new code structure. > > #include > > +/* > + * MAX_FLUSH_PAGES = "additional_pages" + 1. It's limite

RE: [PATCH V2 4/13] KVM/MMU: Flush tlb directly in the kvm_handle_hva_range()

2018-09-20 Thread Michael Kelley (EOSG)
From: Tianyu Lan Sent: Thursday, September 20, 2018 7:30 AM > On 9/20/2018 12:08 AM, Michael Kelley (EOSG) wrote: > > From: Tianyu Lan Sent: Monday, September 17, 2018 8:19 PM > >> + > >> + if (ret &&

RE: [PATCH -next] x86/hyper-v: Remove unused including

2018-09-23 Thread Michael Kelley (EOSG)
From: YueHaibing Sent: Sunday, September 23, 2018 1:20 AM > Remove including that don't need it. > > Signed-off-by: YueHaibing > --- > arch/x86/hyperv/hv_apic.c | 1 - > 1 file changed, 1 deletion(-) > Reviewed-by: Michael Kelley ___

RE: [PATCH V3 10/13] x86/hyper-v: Add HvFlushGuestAddressList hypercall support

2018-09-26 Thread Michael Kelley (EOSG)
From: Tianyu Lan Sent: Wednesday, September 26, 2018 8:50 PM > > Hyper-V provides HvFlushGuestAddressList() hypercall to flush EPT tlb > with specified ranges. This patch is to add the hypercall support. > > Signed-off-by: Lan Tianyu > Looks good! Reviewed-b

Re: [PATCH v1 1/8] mm: balloon: update comment about isolation/migration/compaction

2018-11-20 Thread Michael S. Tsirkin
ction.h contains quite some outdated information. Let's fix > this. > > Cc: Andrew Morton > Cc: Matthew Wilcox > Cc: Michal Hocko > Cc: "Michael S. Tsirkin" > Signed-off-by: David Hildenbrand Acked-by: Michael S. Tsirkin > --- > include/linux/balloo

Re: [PATCH v1 2/8] mm: convert PG_balloon to PG_offline

2018-11-20 Thread Michael S. Tsirkin
Cc: Vlastimil Babka > Cc: "Kirill A. Shutemov" > Cc: Stephen Rothwell > Cc: Matthew Wilcox > Cc: "Michael S. Tsirkin" > Cc: Michal Hocko > Cc: Pavel Tatashin > Cc: Alexander Duyck > Cc: Naoya Horiguchi > Cc: Miles Chen > Cc: David R

Re: [PATCH v1 3/8] kexec: export PG_offline to VMCOREINFO

2018-11-20 Thread Michael S. Tsirkin
aoquan He > Cc: Omar Sandoval > Cc: Arnd Bergmann > Cc: Matthew Wilcox > Cc: Michal Hocko > Cc: "Michael S. Tsirkin" > Cc: Lianbo Jiang > Cc: Borislav Petkov > Cc: Kazuhito Hagio > Signed-off-by: David Hildenbrand Acked-by: Michael S. Tsirkin &g

Question

2019-09-04 Thread Michael van Rooyen
industries. It shouldn't cost an arm and a leg to land a new client. The entire database is R2000. Let me know if you have any questions! All data is POPI Compliant. Have a lovely day! Let me know if you have any questions. -- Regards, Michael Van Rooyen 065 837 2339 cardsma...@gmai

[PATCH] Staging: lustre: obd: Fix a coding style issue

2014-12-08 Thread Dean Michael Ancajas
From: Dean Ancajas Fixed a brace coding style issue for functions. Signed-off-by: Dean Michael Ancajas --- drivers/staging/lustre/lustre/obdclass/cl_object.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/obdclass/cl_object.c b/drivers

[PATCH] Staging: rtl8723au: os_dep: Fixed a coding style issue.

2014-12-08 Thread Dean Michael Ancajas
Fixed a coding style issue for braces. Signed-off-by: Dean Michael Ancajas --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723au/os_dep

<    5   6   7   8   9   10   11   >