On 24 April 2015 at 15:46, Gujulan Elango, Hari Prasath (H.)
wrote:
> This patch avoids creating two variables in the final assembly output
> i.e. a string and a pointer to the string.
>
> Signed-off-by: Hari Prasath Gujulan Elango
> ---
> drivers/staging/lustre/lustre/
On 30 April 2015 at 19:54, gre...@linuxfoundation.org
wrote:
> On Fri, Apr 24, 2015 at 07:52:31AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
>> The fops structure is referenced only locally and hence could be made static
>>
>> Signed-off-by: Hari Prasath Gujulan El
On 30 April 2015 at 19:44, gre...@linuxfoundation.org
wrote:
> On Thu, Apr 23, 2015 at 04:09:28PM +0100, Alan Cox wrote:
>> On Thu, 2015-04-23 at 13:43 +, Gujulan Elango, Hari Prasath (H.)
>> wrote:
>> > This patch removes unwanted semicolon around close braces of code
On 9 June 2015 at 13:00, Gujulan Elango, Hari Prasath (H.)
wrote:
> From: Hari Prasath Gujulan Elango
>
> Cleanup the device entry,device class & unregister the character device
> in the module exit.All this cleanup is done already in the dgap_stop()
> function.We need
kmemdup can be used to replace kmalloc followed by a memcpy.This was
pointed out by the coccinelle tool.
Signed-off-by: Hari Prasath
---
drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git
a/drivers/staging
On 07-Jul-2017 5:25 PM, "Alan Cox" wrote:
On Fri, 2017-07-07 at 17:20 +0530, Hari Prasath wrote:
> kmemdup can be used to replace kmalloc followed by a memcpy.This was
> pointed out by the coccinelle tool.
And kstrdup could do the job even better I think ?
> Yes & thanks
kstrdup kernel primitive can be used to replace kmalloc followed by
string copy. This was reported by coccinelle tool
Signed-off-by: Hari Prasath
---
.../media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git
a
On 8 July 2017 at 16:31, Sakari Ailus wrote:
> Hi Hari,
>
> On Fri, Jul 07, 2017 at 08:15:21PM +0530, Hari Prasath wrote:
>> kstrdup kernel primitive can be used to replace kmalloc followed by
>> string copy. This was reported by coccinelle tool
>>
>
kstrdup kernel primitive can be used to replace kmalloc followed by
string copy. This was reported by coccinelle tool.
Signed-off-by: Hari Prasath
---
v1: Replace kmalloc followed by memcpy with kmemdup. Based on
review comments from Alan Cox, this could better be done
On 10 July 2017 at 01:22, Sakari Ailus wrote:
> On Sun, Jul 09, 2017 at 05:56:15PM +0530, hari prasath wrote:
>> On 8 July 2017 at 16:31, Sakari Ailus wrote:
>> > Hi Hari,
>> >
>> > On Fri, Jul 07, 2017 at 08:15:21PM +0530, Hari Prasath wrote:
>>
From: Hari Prasath
Adding missing indio_dev->dev.of_node references to allow iio consumers
to access the device channels.
Signed-off-by: Hari Prasath
---
drivers/staging/iio/adc/ad7192.c | 1 +
drivers/staging/iio/adc/ad7780.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/driv
Adding missing indio_dev->dev.of_node references to allow iio consumers
to access the device channels.
Signed-off-by: Hari Prasath
---
v2: Wrong from email ID in first version of patch
---
drivers/staging/iio/adc/ad7192.c | 1 +
drivers/staging/iio/adc/ad7780.c | 1 +
2 files chan
Kindly discard this patch versions. I will send a new one.
On 17 July 2017 at 17:49, Hari Prasath wrote:
> Adding missing indio_dev->dev.of_node references to allow iio consumers
> to access the device channels.
>
> Signed-off-by: Hari Prasath
> ---
> v2: Wrong f
Adding missing indio_dev->dev.of_node references to allow iio consumers
to access the device channels.
Signed-off-by: Hari Prasath
---
v2: Wrong from mail ID in first version of patch
---
drivers/staging/iio/adc/ad7192.c | 1 -
drivers/staging/iio/adc/ad7780.c | 1 -
2 files changed
.of_node = indio_dev->dev.parent->of_node;
>
> - Lars
>
> On 07/17/2017 02:34 PM, Hari Prasath wrote:
>> Adding missing indio_dev->dev.of_node references to allow iio consumers
>> to access the device channels.
>>
>> Signed-off-by: Hari Prasath
>>
Fix checkpatch warning to add space around the substraction operation
Signed-off-by: Hari Prasath
---
drivers/staging/iio/adc/ad7280a.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/iio/adc/ad7280a.c
b/drivers/staging/iio/adc/ad7280a.c
index d5ab83f
Remove explicit typecasting of return value in the interrupt handlers.
Signed-off-by: Hari Prasath
---
drivers/staging/pi433/pi433_if.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index ed737f4
lp improve the system]
>
> url:
> https://github.com/0day-ci/linux/commits/Hari-Prasath/Remove-explicit-return-type-cast/20170803-080312
> config: blackfin-allyesconfig (attached as .config)
> compiler: bfin-uclinux-gcc (GCC) 6.2.0
> reproduce:
> wget
> http
On 3 August 2017 at 18:53, Dan Carpenter wrote:
> On Thu, Aug 03, 2017 at 06:23:54PM +0530, hari prasath wrote:
>> On 3 August 2017 at 11:52, kbuild test robot wrote:
>> > Hi Hari,
>> >
>> > [auto build test WARNING on staging/staging-testing]
>> &
This patch removes the redundant static initialization of the .owner field from
this driver as it is being overidden by the call from the platform driver
register
Signed-off-by: Hari Prasath
---
drivers/staging/fsl-mc/bus/mc-bus.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers
This patch removes unwanted semicolon around close braces of code blocks
Signed-off-by: Hari Prasath
---
drivers/staging/i2o/iop.c | 44 ++--
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/i2o/iop.c b/drivers/staging/i2o
This patch removes a few lines of code & retains the same functionality
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/comedi/drivers/cb_pcimdda.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/comedi/drivers/cb_pcimdda.c
b/dri
This patch removes a stray semicolon around closing brace of an if code
block.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/emxx_udc/emxx_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c
b/drivers/staging/emxx_udc
This patch removes few lines of commented code.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/emxx_udc/emxx_udc.c | 33 -
1 file changed, 33 deletions(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c
b/drivers/staging/emxx_udc/emxx_udc.c
This patch removes commented code from this driver.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/comedi/drivers/gsc_hpdi.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/comedi/drivers/gsc_hpdi.c
b/drivers/staging/comedi/drivers/gsc_hpdi.c
index
The fops structure is referenced only locally and hence could be made static
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/lustre/lustre/mdc/lproc_mdc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/mdc/lproc_mdc.c
b/drivers
This patch avoids creating two variables in the final assembly output
i.e. a string and a pointer to the string.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/lustre/lustre/libcfs/linux/linux-tracefile.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
This patch replaces a condition check for time elapsea with a
simple time_after macro
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/rtl8192e/rtl8192e/rtl_ps.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c
b
This patch replaces the condition check for time elapsed with a
simplified time_before() macro
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/rtl8192e/rtl8192e/rtl_ps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c
Check the return value of function and handle error condition appropriately.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/iio/accel/lis3l02dq_core.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/iio/accel/lis3l02dq_core.c
b/drivers/staging/iio/accel
Should return ENOMEM if memory allocation occurs.There is a wrong code
jump here and this patch addresses this issue.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/comedi/comedi_fops.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers
The return value of memdup_user is a pointer to errno.Freeing it will cause
error.Hence set it to NULL before branching to free the pointer.smatch also
raises the same warning.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 1 +
1 file changed, 1
From: Julia Lawall
Sent: Thursday, April 30, 2015 12:12 AM
To: Gujulan Elango, Hari Prasath (H.)
Cc: sh...@linux.com; cristina.oprice...@gmail.com; hamohammed...@gmail.com;
vitaly.osi...@gmail.com; de...@driverdev.osuosl.org
Subject: Re: [PATCH] staging: rtl8712: Fix freeing ERR_PTR
On Wed, 29
The return value of memdup_user is a pointer to errno.Freeing it will cause
error.Hence set it to NULL before branching to free the pointer.smatch also
raises the same warning.
Signed-off-by: Hari Prasath Gujulan Elango
---
v2:Remove unnecessary goto and return error directly.Use goto
From: Dan Carpenter
Sent: Thursday, April 30, 2015 12:45 PM
To: Gujulan Elango, Hari Prasath (H.)
Cc: de...@driverdev.osuosl.org; julia.law...@lip6.fr;
florian.c.schilha...@googlemail.com; gre...@linuxfoundation.org; Babu,
Viswanathan (V.); larry.fin
The return value of memdup_user is a pointer to errno.Freeing it will cause
error.Hence set it to NULL before branching to free the pointer.smatch also
raises the same warning.
Signed-off-by: Hari Prasath Gujulan Elango
---
v2:Remove unnecessary goto and return error directly.Use goto
Signed-off-by: Hari Prasath Gujulan Elango
return error directly to avoid unwanted branching where no cleanup
is done.Also removes the ret variable.
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/staging
return error directly to avoid unwanted branching where no cleanup
is done.Also removes the ret variable.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/staging
From: gre...@linuxfoundation.org
Sent: Thursday, April 30, 2015 3:05 PM
To: Gujulan Elango, Hari Prasath (H.)
Cc: de...@driverdev.osuosl.org; julia.law...@lip6.fr; dan.carpen...@oracle.com;
larry.fin...@lwfinger.net; florian.c.schilha...@googlemail.com; Babu,
Viswanathan (V.)
Subject: Re
equivalent negative number as
per Larry Finger.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
b/drivers/staging/rtl8192e/rtl8192e
From: Dan Carpenter
Sent: Thursday, April 30, 2015 6:33 PM
To: Gujulan Elango, Hari Prasath (H.)
Cc: de...@driverdev.osuosl.org; julia.law...@lip6.fr;
gre...@linuxfoundation.org; wlan...@realtek.com; mateusz.kulikow...@gmail.com;
Babu, Viswanathan (V.); larry.fin...@lwfinger.net
Subject: Re
From: Larry Finger on behalf of Larry Finger
Sent: Thursday, April 30, 2015 11:03 PM
To: Gujulan Elango, Hari Prasath (H.); Dan Carpenter
Cc: de...@driverdev.osuosl.org; julia.law...@lip6.fr;
gre...@linuxfoundation.org; wlan...@realtek.com; mateusz.kulikow...@gmail.com;
Babu, Viswanathan (V
On Thu, Apr 30, 2015 at 02:09:13PM -0500, Larry Finger wrote:
> On 04/30/2015 12:50 PM, Gujulan Elango, Hari Prasath (H.) wrote:
> >
> >From: Larry Finger on behalf of Larry Finger
> >
> >Sent: Thursday, April 30, 2015 11:03 PM
> >To: Gujulan Elango, Hari Pras
On Fri, May 01, 2015 at 10:46:53AM +0300, Dan Carpenter wrote:
> The subject says "fix" but this does not fix a run time bug, it just
> silences a warning. It's still the correct thing according to Larry
> so that's good.
>
> On Thu, Apr 30, 2015 at 12:06:28PM
This patch addresses a spatch warning on assigning a negative
value to a unsigned integer.Similar patch has been submitted by
Larry Finger earlier to silence the same spatch warning in another
file.
Signed-off-by: Hari Prasath Gujulan Elango
---
v2: Address Dan Carpenter review comments
On Tue, May 05, 2015 at 12:19:57PM +0300, Dan Carpenter wrote:
> On Mon, May 04, 2015 at 10:17:09PM +0200, Mateusz Kulikowski wrote:
> > As far as I know (radio) noise is rarely above 0 dBm - if it is, you're
> > doing something wrong.
> > This means we can just change rtllib_rx_stats::noise to s8
Remove the goto and return error directly thereby removing a variable
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c
b
On Thu, May 07, 2015 at 03:19:34PM +0300, Dan Carpenter wrote:
> On Thu, May 07, 2015 at 08:03:06AM -0400, Jes Sorensen wrote:
> > "Gujulan Elango, Hari Prasath (H.)" writes:
> > > Remove the goto and return error directly thereby removing a variable
> > &
This patch replaces a condition check for time elapsed with a
simple time_after macro
Signed-off-by: Hari Prasath Gujulan Elango
---
v2:Fixes a build warning.time_after() macro requires both of
its arguments to be unsigned long.Build warning was missed & later
reported by the kbuild
This patch replaces the condition check for time elapsed with a
simplified time_before() macro
Signed-off-by: Hari Prasath Gujulan Elango
---
v2:Fixes a build warning.time_before() macro requires both of
its arguments to be unsigned long.Build warning was missed & later
reported by
The variable pHalData is initialized twice in this same function with
same value.So removing one of them.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723au/hal
On Thu, May 07, 2015 at 10:09:59AM -0400, Jes Sorensen wrote:
> "Gujulan Elango, Hari Prasath (H.)" writes:
> > On Thu, May 07, 2015 at 03:19:34PM +0300, Dan Carpenter wrote:
> >> On Thu, May 07, 2015 at 08:03:06AM -0400, Jes Sorensen wrote:
> >> > &qu
Fixed indentation issue in few lines.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/rtl8712/recv_linux.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8712/recv_linux.c
b/drivers/staging/rtl8712/recv_linux.c
index 799a0f9..4201ce7
check the return value of kzalloc before accessing the memory pointer
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/lustre/lustre/llite/llite_lib.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/lustre/lustre/llite/llite_lib.c
b/drivers/staging/lustre
check return value of kmalloc before accessing the memory pointer.This
function returns a non-zero value on failure hence a return value of 1
is used.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/wlan-ng/p80211conv.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a
On Wed, May 13, 2015 at 03:02:25PM +0300, Dan Carpenter wrote:
> On Wed, May 13, 2015 at 02:51:07PM +0300, Dan Carpenter wrote:
> > On Wed, May 13, 2015 at 11:32:50AM +, Gujulan Elango, Hari Prasath (H.)
> > wrote:
> > > check return value of kmalloc before accessing
check return value of kmalloc before accessing the memory pointer and
return -ENOMEM if allocation fails.
Signed-off-by: Hari Prasath Gujulan Elango
---
v2:Return -ENOMEM for memory allocation failure.
---
drivers/staging/wlan-ng/p80211conv.c | 2 ++
1 file changed, 2 insertions
On Wed, May 13, 2015 at 05:27:10PM +0300, Dan Carpenter wrote:
> On Wed, May 13, 2015 at 01:36:44PM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > On Wed, May 13, 2015 at 03:02:25PM +0300, Dan Carpenter wrote:
> > > On Wed, May 13, 2015 at 02:51:07PM +0300, Dan Carpen
remove an unwanted assignment to a variable which is overwritten in the
very next line.The first value assigned is not used.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/rtl8188eu/hal/usb_halinit.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu
The return value of copy_to_user() isn't checked for failure.Hence
return -EFAULT if it fails.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/lustre/lustre/lov/lov_pack.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/lustre/lustr
On Thu, May 14, 2015 at 12:47:19PM +0300, Dan Carpenter wrote:
> On Thu, May 14, 2015 at 09:22:01AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > The return value of copy_to_user() isn't checked for failure.Hence
> > return -EFAULT if it fails.
> >
> >
This trivial patch removes temporary variable to check return value of
a function and checks return value directly.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/rts5208/ms.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/rts5208/ms.c b
Use a temporary value to hold the SD lock status thereby making the code
readable.This also fixes a coding style violation with the braces around
the if block.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/rts5208/sd.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions
On Fri, May 15, 2015 at 04:09:42PM +0300, Dan Carpenter wrote:
> On Fri, May 15, 2015 at 12:09:42PM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > Use a temporary value to hold the SD lock status thereby making the code
> > readable.This also fixes a coding style violati
replace the printk with netdev subsystem debug infrastructure.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/rtl8192e/rtllib_rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtllib_rx.c
b/drivers/staging/rtl8192e/rtllib_rx.c
This macro defines the maximum sequence number for an IEEE802.11 frame.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/rtl8192e/rtllib.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8192e/rtllib.h
b/drivers/staging/rtl8192e/rtllib.h
index 3c8b708
replace the hard coded value for the maximum sequence number of a ieee
802.11 frame by a Macro.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/rtl8192e/rtllib_tx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib_tx.c
b
On Mon, May 18, 2015 at 03:47:58PM +0300, Dan Carpenter wrote:
> Fold this together with the other patch. Do 1 thing per patch, not half
> a thing per patch. This change makes no sense on its own.
>
> regards,
> dan carpenter
>
I didn't think of it. I am sending v2 with both the related change
replace the hard coded value of 4096 with macro which defines the
maximum sequence number of a ieee 802.11 frame.
Signed-off-by: Hari Prasath Gujulan Elango
---
v2: Previously send this as two different patches which is wrong
as the individual patches doesn't make sense.Resending
On Mon, May 18, 2015 at 10:29:55PM +0200, Mateusz Kulikowski wrote:
> Hi,
>
> On 18.05.2015 13:27, Gujulan Elango, Hari Prasath (H.) wrote:
> > replace the printk with netdev subsystem debug infrastructure.
> >
> > Signed-off-by: Hari Prasath Gujulan Elango
> >
replace kzalloc with devm_kzalloc thereby removing the corresponding
kfree.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/sm750fb/sm750.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/sm750fb/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/Kconfig b/drivers/staging/sm750fb/Kconfig
index c40d088..bfb3429 100644
--- a/drivers/staging/sm750fb/Kconfig
+++ b/drivers
On Wed, May 27, 2015 at 11:10:34AM +0530, Sudip Mukherjee wrote:
> On Tue, May 26, 2015 at 10:04:44AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > replace kzalloc with devm_kzalloc thereby removing the corresponding
> > kfree.
> your patch is corrupt and can not b
On Wed, May 27, 2015 at 11:32:11AM +0530, Sudip Mukherjee wrote:
> On Tue, May 26, 2015 at 02:50:30PM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > The Kconfig dependency for this driver should include the kernel
> > configuration FB_MODE_HELPERS which defi
On Wed, May 27, 2015 at 01:07:17PM +0530, Sudip Mukherjee wrote:
> On Wed, May 27, 2015 at 10:28:54AM +0300, Dan Carpenter wrote:
> > On Wed, May 27, 2015 at 11:10:34AM +0530, Sudip Mukherjee wrote:
> > > On Tue, May 26, 2015 at 10:04:44AM +, Gujulan Elango, Hari Prasath
The sm750fb driver has few Framebuffer configuration dependencies that
need to be selected in order to get compiled successfully.
Signed-off-by: Gujulan Elango Hari Prasath
---
v2:Addressed the review comments by Sudhip Mukherjee as I had
missed out a few other dependencies for this
The sm750fb driver has few Framebuffer configuration dependencies that
need to be selected in order to get compiled successfully.
Signed-off-by: Gujulan Elango Hari Prasath
---
v3: Fix alignment issues addressed by Dan Carpenter.
v2:Addressed the review comments by Sudhip
On Thu, May 28, 2015 at 11:45:28AM +0300, Dan Carpenter wrote:
> On Thu, May 28, 2015 at 08:40:41AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > diff --git a/drivers/staging/sm750fb/Kconfig
> > b/drivers/staging/sm750fb/Kconfig
> > index c40d088..59d7c52 100644
&
The sm750fb driver has few Framebuffer configuration dependencies that
need to be selected in order to get compiled successfully
Signed-off-by: Gujulan Elango Hari Prasath
---
v3: Fix alignment issues addressed by Dan Carpenter.
v2:Addressed the review comments by Sudhip
On Thu, May 28, 2015 at 11:57:54AM +0300, Dan Carpenter wrote:
> On Thu, May 28, 2015 at 08:54:12AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> >
> > I resend v3 but it seems there is a duplicate signature.Please dicard it
> > as well.I am sending v4 now.
>
&
remove redundant code in this function by introducing a new retval
variable.
Signed-off-by: Gujulan Elango Hari Prasath
---
drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
On Thu, May 28, 2015 at 01:08:36PM +0300, Dan Carpenter wrote:
> On Thu, May 28, 2015 at 09:38:23AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > remove redundant code in this function by introducing a new retval
> > variable.
> >
> > Signed-off-by: Gujula
remove redundant code in this function.remove return value check for
function that always return success.
Signed-off-by: Gujulan Elango Hari Prasath
---
v2:address review comments from Dan.Remove return value check
for the function gs_release_image as it always returns success and
On Thu, May 28, 2015 at 02:07:36PM +0300, Dan Carpenter wrote:
> On Thu, May 28, 2015 at 10:51:38AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > remove redundant code in this function.remove return value check for
> > function that always return success.
> >
&g
On Thu, May 28, 2015 at 02:37:43PM +0300, Dan Carpenter wrote:
> On Thu, May 28, 2015 at 11:32:21AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > The reason i did that was if the function doesn't hit any error
> > condition, then it needs to return 0. If
remove redundant code in this function.remove return value check for
function that always return success
Signed-off-by: Gujulan Elango Hari Prasath
---
v3:Remove initialization of the 'err' variable.
v2:address review comments from Dan.Remove return value check
Check the return value of kcalloc first and then use the pointer.
Signed-off-by: Gujulan Elango Hari Prasath
---
drivers/staging/dgnc/dgnc_driver.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.c
b/drivers/staging/dgnc/dgnc_driver.c
Check the return value of kzalloc & return error if it fails.
Signed-off-by: Gujulan Elango Hari Prasath
---
drivers/staging/dgnc/dgnc_driver.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/dgnc/dgnc_driver.c
b/drivers/staging/dgnc/dgnc_driver.c
index 935e297..2c7
On Thu, May 28, 2015 at 04:32:30PM +0300, Dan Carpenter wrote:
> On Thu, May 28, 2015 at 01:23:57PM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > Check the return value of kzalloc & return error if it fails.
> >
> > Signed-off-by: Gujulan Elango Hari Prasath
This patch deletes all references to 'flipbuf'.Memory is allocated and
freed but never used anywhere in the driver.Also deleted an ununsed
Macro defined in the header file.
Signed-off-by: Gujulan Elango Hari Prasath
---
drivers/staging/dgnc/dgnc_driver.c | 9 -
drivers/st
On Thu, May 28, 2015 at 09:39:14AM -0700, insop.s...@gainspeed.com wrote:
> On Thu, May 28, 2015 at 01:08:36PM +0300, Dan Carpenter wrote:
> > On Thu, May 28, 2015 at 09:38:23AM +, Gujulan Elango, Hari Prasath (H.)
> > wrote:
> > > remove redundant code in this funct
wrote:
> > > > On Thu, May 28, 2015 at 09:38:23AM +, Gujulan Elango, Hari Prasath
> > > > (H.) wrote:
> > > > > remove redundant code in this function by introducing a new retval
> > > > > variable.
> > > > >
> > > &g
check return value of kzalloc and return error if it fails.
Signed-off-by: Gujulan Elango Hari Prasath
---
drivers/staging/dgnc/dgnc_tty.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index ce4187f..2397c66 100644
Remove the unwanted else block
Signed-off-by: Gujulan Elango Hari Prasath
---
drivers/staging/dgnc/dgnc_tty.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index 2397c66..ca07b7f 100644
--- a/drivers/staging/dgnc
On Fri, May 29, 2015 at 11:54:09AM +0300, Dan Carpenter wrote:
> On Fri, May 29, 2015 at 07:44:11AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > check return value of kzalloc and return error if it fails.
> >
>
> There is a problem with your patch. See if yo
On Fri, May 29, 2015 at 01:52:28PM +0300, Dan Carpenter wrote:
> On Fri, May 29, 2015 at 10:06:48AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > On Fri, May 29, 2015 at 11:54:09AM +0300, Dan Carpenter wrote:
> > > On Fri, May 29, 2015 at 07:44:11AM +0000, Gujulan
On Sun, May 31, 2015 at 11:36:09AM +0900, gre...@linuxfoundation.org wrote:
> On Thu, May 28, 2015 at 08:51:06AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > The sm750fb driver has few Framebuffer configuration dependencies that
> > need to be selected in ord
From: Hari Prasath Gujulan Elango
The sm750fb driver has few Framebuffer configuration dependencies that
need to be selected in order to get compiled successfully
Signed-off-by: Hari Prasath Gujulan Elango
---
v4: Final version with From name & signed off by matching
v3:
On Sun, May 31, 2015 at 11:34:23AM +0900, gre...@linuxfoundation.org wrote:
> On Fri, May 15, 2015 at 11:33:53AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > This trivial patch removes temporary variable to check return value of
> > a function and checks ret
From: Hari Prasath Gujulan Elango
This trivial patch removes temporary variable to check return value of
a function and checks return value directly.
Signed-off-by: Hari Prasath Gujulan Elango
---
v2:signed off by and From names were not matching in previous
version as pointed out by
1 - 100 of 234 matches
Mail list logo
