Re: [PATCH] Add RIFFA PCIe driver to staging tree

2018-10-16 Thread gre...@linuxfoundation.org
On Tue, Oct 16, 2018 at 07:41:45AM +, Cheng Fei Phung wrote: > Patch changelog content: > > Add a PCIe linux driver called RIFFA to the linux staging tree. It has full > duplex capability compared to the original RIFFA linux driver that you can > easily find from https://github.com/KastnerRG

Re: [PATCH] Staging : Add RIFFA PCIe driver

2018-10-16 Thread gre...@linuxfoundation.org
On Tue, Oct 16, 2018 at 10:54:28AM +, Cheng Fei Phung wrote: > This patch adds RIFFA PCIe linux driver for > https://github.com/promach/riffa/tree/full_duplex/driver/linux > > TODO: > > 1) this driver needs further speed optimization although it can now achieve > defined PCIe speed grade >

Re: [PATCH V2 3/5] Drivers: hv: kvp: Fix the recent regression caused by incorrect clean-up

2018-11-01 Thread gre...@linuxfoundation.org
On Wed, Oct 31, 2018 at 11:23:54PM +, Dexuan Cui wrote: > > From: Michael Kelley > > Sent: Wednesday, October 24, 2018 08:38 > > From: k...@linuxonhyperv.com Sent: Wednesday, > > October 17, 2018 10:10 PM > > > From: Dexuan Cui > > > > > > In kvp_send_key(), we do need call process_ib_ipinf

Re: [PATCH V2 3/5] Drivers: hv: kvp: Fix the recent regression caused by incorrect clean-up

2018-11-01 Thread gre...@linuxfoundation.org
On Thu, Nov 01, 2018 at 07:22:28PM +, Dexuan Cui wrote: > > From: gre...@linuxfoundation.org > > Sent: Thursday, November 1, 2018 11:57 > > To: Dexuan Cui > > > > On Wed, Oct 31, 2018 at 11:23:54PM +, Dexuan Cui wrote: > > > > From: Michael K

Re: [PATCH] Staging : Add RIFFA PCIe driver

2018-11-07 Thread gre...@linuxfoundation.org
On Mon, Oct 22, 2018 at 03:41:05AM +, Cheng Fei Phung wrote: > This patch adds RIFFA PCIe linux driver for > https://github.com/promach/riffa/tree/full_duplex/driver/linux > This staging driver is modified from this upstream driver at > https://github.com/KastnerRG/riffa/tree/master/driver/l

Re: [PATCH V2 3/5] Drivers: hv: kvp: Fix the recent regression caused by incorrect clean-up

2018-11-11 Thread gre...@linuxfoundation.org
On Sun, Nov 11, 2018 at 04:18:03AM +, Dexuan Cui wrote: > > From: gre...@linuxfoundation.org > > Sent: Thursday, November 1, 2018 21:54 > > To: Dexuan Cui > > Cc: Michael Kelley ; KY Srinivasan > > ; linux-ker...@vger.kernel.org; > > de...@linux

Re: [PATCH] staging: vc04_services: bcm2835-audio: Fixed warnings

2018-11-12 Thread gre...@linuxfoundation.org
On Mon, Nov 12, 2018 at 07:00:20PM -0500, Arnold Chand wrote: > Fixed warnings provided by checkpatch.pl Please be much more specific as to what you changed or "fixed". Please fix this up and resend. thanks, greg k-h ___ devel mailing list de...@linux

Re: [PATCH] staging: vc04_services: bcm2835-audio: Fixed warnings, checks

2018-11-12 Thread gre...@linuxfoundation.org
On Mon, Nov 12, 2018 at 07:29:09PM -0500, Arnold Chand wrote: > Corrected warnings and checks issued by scripts/checkpatch.pl which includes: > alignment of > parenthesis, lines over 80 characters and mutex definition without comment. > Signed-off-by: Arnold Chand --- > .../vc04_services/bcm2835-au

Re: [PATCH v2] staging: vc04_services: bcm2835-audio: Fixed warnings, checks

2018-11-12 Thread gre...@linuxfoundation.org
On Mon, Nov 12, 2018 at 07:45:00PM -0500, Arnold Chand wrote: > Corrected warnings and checks provided by scripts/checkpatch.pl which > includes: alignment of parenthesis, lines over 80 characters and mutex > definition without comment. > > Signed-off-by: Arnold Chand > --- > .../vc04_services/b

Re: [PATCH V4] binder: ipc namespace support for android binder

2018-11-15 Thread gre...@linuxfoundation.org
On Thu, Nov 15, 2018 at 02:33:49PM -0800, Andrew Morton wrote: > On Mon, 12 Nov 2018 09:37:51 + chouryzhou(周威) > wrote: > > > Currently android's binder is not isolated by ipc namespace. Since binder > > is a form of IPC and therefore should be tied to ipc namespace. With this > > patch, w

Re: [PATCH] Staging : Add RIFFA PCIe driver

2018-11-20 Thread gre...@linuxfoundation.org
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? http://daringfireball.net

Re: [PATCH] staging: rtl8188eu: Fix off-by-one in core/rtw_mlme_ext.c

2018-11-26 Thread gre...@linuxfoundation.org
On Tue, Nov 27, 2018 at 07:29:07AM +, Yang Xiao wrote: > From: Young_X Please use your "full" name like you did in your from: line of your email > > The error at line 3267 was the result of an off-by-one error in > a for loop in line 3253. > If condition in line 3254 never satis

Re: [PATCH] [repost] Drivers: hv: vmbus: Offload the handling of channels to two workqueues

2018-11-28 Thread gre...@linuxfoundation.org
On Thu, Nov 29, 2018 at 04:36:43AM +, Dexuan Cui wrote: > > vmbus_process_offer() mustn't call channel->sc_creation_callback() > directly for sub-channels, because sc_creation_callback() -> > vmbus_open() may never get the host's response to the > OPEN_CHANNEL message (the host may rescind a c

Re: [PATCH] Staging : Add RIFFA PCIe driver

2018-11-30 Thread gre...@linuxfoundation.org
On Tue, Nov 27, 2018 at 05:59:48AM +, Cheng Fei Phung wrote: > This patch adds RIFFA PCIe linux driver for > https://github.com/promach/riffa/tree/full_duplex/driver/linux > > This staging driver is modified from this upstream driver at > https://github.com/KastnerRG/riffa/tree/master/driver

Re: [PATCH] [repost] Drivers: hv: vmbus: Offload the handling of channels to two workqueues

2018-12-01 Thread gre...@linuxfoundation.org
On Fri, Nov 30, 2018 at 06:09:54PM +, Dexuan Cui wrote: > > From: KY Srinivasan > > Sent: Friday, November 30, 2018 9:31 AM > > > From: Dexuan Cui > > > Sent: Thursday, November 29, 2018 12:17 AM > > > To: gre...@linuxfoundation.org > > > C

Re: [PATCH] [repost] Drivers: hv: vmbus: Offload the handling of channels to two workqueues

2018-12-02 Thread gre...@linuxfoundation.org
On Sun, Dec 02, 2018 at 08:47:03AM +, Dexuan Cui wrote: > Hi Greg, > Please use the attached patch: I rebased the patch to today's char-misc's > char-misc-linus branch. It can also cleanly apply to Linus's master branch > today. I can't use an attached patch, you know better. Please fix up an

Re: [PATCH] Staging : Add RIFFA PCIe staging driver

2018-12-03 Thread gre...@linuxfoundation.org
On Tue, Dec 04, 2018 at 02:19:38AM +, Cheng Fei Phung wrote: > This patch adds RIFFA PCIe linux driver for > https://github.com/promach/riffa/tree/full_duplex/driver/linux > > This staging driver is modified from this upstream driver at > https://github.com/KastnerRG/riffa/tree/master/driver

Re: [PATCH] v2 Staging : Add RIFFA PCIe staging driver

2018-12-04 Thread gre...@linuxfoundation.org
On Tue, Dec 04, 2018 at 08:13:10AM +, Cheng Fei Phung wrote: > > > For further details, please refer to > > https://github.com/KastnerRG/riffa/pull/31 > > That is not permanent, please provide the details here. > > This patch helps to enable bi-directional PCIe communication at PCIe gen2 >

Re: [PATCH v4] staging: gdm724x: Fix DMA from stack

2021-02-11 Thread gre...@linuxfoundation.org
On Thu, Feb 11, 2021 at 01:28:41PM +, David Laight wrote: > > Stack allocated buffers cannot be used for DMA > > on all architectures so allocate hci_packet buffer > > using kmalloc. > > I wonder if the usb stack ought/could support a short bounce > buffer within the memory is already has to a

Re: [PATCH v2 09/12] media: atomisp: Fix PARENTHESIS_ALIGNMENT

2020-12-14 Thread gre...@linuxfoundation.org
On Mon, Dec 14, 2020 at 11:49:56AM +, David Laight wrote: > From: Philipp Gerlesberger > > Sent: 14 December 2020 11:04 > > > > You can sum up the two lines, because the maximum line length of > > 100 columns is not exceeded. > > IIRC the 80 column limit is preferred. Not anymore, checkpatch

Re: linux-5.0-rc1/drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c:412]: (style) Expression is always false

2019-01-07 Thread gre...@linuxfoundation.org
On Mon, Jan 07, 2019 at 11:40:08AM +, David Binderman wrote: > > Hello there, > > linux-5.0-rc1/drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c:412]: > (style) Expression is always false because 'else if' condition matches > previous condition at line 410. > > Source code is > >

Re: [PATCH v2] staging: mt7621-eth/ethtool.c: Correction of SPDX license identifier

2019-01-30 Thread gre...@linuxfoundation.org
On Wed, Jan 30, 2019 at 02:48:27PM +, Carlos Henrique Lima Melara wrote: > This patch fix the checkpatch.p1 warning: > > WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 > +/* Why did you not fix up the indentation that was already mentioned? > It i

Re: [PATCH v2] staging: mt7621-eth/ethtool.c: Correction of SPDX license identifier

2019-01-30 Thread gre...@linuxfoundation.org
On Wed, Jan 30, 2019 at 05:38:17PM +0100, Andrew Lunn wrote: > On Wed, Jan 30, 2019 at 02:48:27PM +, Carlos Henrique Lima Melara wrote: > > This patch fix the checkpatch.p1 warning: > > > > WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 > > +/* > > > > It

Re: [PATCH v2] staging: mt7621-eth/ethtool.c: Correction of SPDX license identifier

2019-01-30 Thread gre...@linuxfoundation.org
On Wed, Jan 30, 2019 at 08:01:13PM +, Carlos Henrique Lima Melara wrote: > On 30/01/2019 13:29, gre...@linuxfoundation.org wrote: > > On Wed, Jan 30, 2019 at 02:48:27PM +, Carlos Henrique Lima Melara wrote: > >>This patch fix the checkpatch.p1 warning: > >>

Re: [PATCH] Staging: greybus: pwm: fixed a coding style issue

2019-03-17 Thread gre...@linuxfoundation.org
On Wed, Mar 13, 2019 at 02:09:15PM +, manuel.ram...@protonmail.com wrote: > Hello, > > this is my very first patch, very simple and check it, so it compiles > properly and also go no errors on the checkpatch script. > From c8a66a3bee14fe89ad2a03545a76953bc880b9e6 Mon Sep 17 00:00:00 2001 > F

Re: [PATCH v2 1/3] staging: wfx: replace uintXX_t to uXX and intXX_t to sXX

2019-11-11 Thread gre...@linuxfoundation.org
On Mon, Nov 11, 2019 at 05:04:49PM +, Jerome Pouiller wrote: > I know that uXX is prefered over uintXX_t. However, I dislike to change > 650 lines of code only for this purpose in one batch. It will generate > plenty of conflicts with branches currently in development. Now that the code is

Re: [PATCH 0/5] Tools: hv: fix compiler warnings and do minor cleanup

2014-12-10 Thread gre...@linuxfoundation.org
On Wed, Dec 10, 2014 at 10:22:40AM +0100, Vitaly Kuznetsov wrote: > Dexuan Cui writes: > > >> -Original Message- > >> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > >> Sent: Tuesday, December 9, 2014 23:48 PM > >> To: KY Srinivasan > >> Cc: Haiyang Zhang; de...@linuxdriverproject.o

Re: [PATCH 0/5] Tools: hv: fix compiler warnings and do minor cleanup

2015-01-09 Thread gre...@linuxfoundation.org
On Thu, Jan 08, 2015 at 05:04:20PM +, KY Srinivasan wrote: > > > > -Original Message- > > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > > Sent: Thursday, January 8, 2015 8:02 AM > > To: KY Srinivasan > > Cc: gre...@linuxfoundation.org; d

Re: [PATCH 0/5] Tools: hv: fix compiler warnings and do minor cleanup

2015-01-09 Thread gre...@linuxfoundation.org
On Fri, Jan 09, 2015 at 08:58:08PM +, KY Srinivasan wrote: > > Please resend everything, there has been a mess of different patches and > > discussions and I can't figure out what should be applied and what should > > not. I'll guess at a few easy ones, but getting the "correct" > > ones from

Re: [PATCH 00/37] staging: comedi: tidy up legacy DMA drivers

2015-01-13 Thread gre...@linuxfoundation.org
On Tue, Jan 13, 2015 at 04:08:29PM +, Hartley Sweeten wrote: > On Tuesday, January 13, 2015 5:54 AM, Ian Abbott wrote: > > On 12/01/15 17:55, H Hartley Sweeten wrote: > >> This series removes all the VIRT_TO_BUS dependancies from the legacy comedi > >> drivers. It also tidies up the allocation

Re: [PATCH] staging: kpc2000: Add DMA driver

2019-04-22 Thread 'gre...@linuxfoundation.org'
On Mon, Apr 22, 2019 at 02:37:59PM +, Matt Sickler wrote: > >From 6e70cb81c75ebb0ac7897d07c0f12d80505bb22b Mon Sep 17 00:00:00 2001 > From: Matt Sickler > Date: Mon, 22 Apr 2019 09:24:03 -0500 > Subject: [PATCH] staging: kpc2000: Add DMA driver > > Add Daktronics DMA driver. I've added the S

Re: [PATCH v2] staging: kpc2000: Add DMA driver

2019-04-25 Thread 'gre...@linuxfoundation.org'
On Mon, Apr 22, 2019 at 10:05:58PM +, Matt Sickler wrote: > Add Daktronics DMA driver. I've added the SPDX license identifiers, Kconfig > entry, and cleaned up as many of the warnings as I could. > > The AIO support code will be removed in a future patch. > > Signed-off-by: Matt Sickler Lo

Re: RFC: kpc2000 driver naming

2019-05-04 Thread 'gre...@linuxfoundation.org'
On Fri, May 03, 2019 at 10:24:00PM +, Matt Sickler wrote: > Hello, > > Recently Greg KH posted the first set of drivers for our PCIe device > (kpc2000) and shortly after that I posted the kpc2000_dma driver. I was > wondering about naming / structure standards in the Linux kernel. > First,

Re: RFC: kpc2000 driver naming

2019-05-05 Thread 'gre...@linuxfoundation.org'
On Sun, May 05, 2019 at 10:14:17PM +, Matt Sickler wrote: > > >-Original Message- > >From: 'gre...@linuxfoundation.org' > >On Fri, May 03, 2019 at 10:24:00PM +, Matt Sickler wrote: > >> Hello, > >> > >> Recently G

Re: RFC: kpc2000 driver naming

2019-05-06 Thread 'gre...@linuxfoundation.org'
On Mon, May 06, 2019 at 02:38:16PM +, Matt Sickler wrote: > >-Original Message- > >From: 'gre...@linuxfoundation.org' > >On Sun, May 05, 2019 at 10:14:17PM +, Matt Sickler wrote: > >> The I2C and SPI drivers don't depend on anything

Re: [PATCH v2] kpc_i2c: Remove unused file

2019-05-13 Thread 'gre...@linuxfoundation.org'
On Thu, May 09, 2019 at 02:47:50PM +, Matt Sickler wrote: > >-Original Message- > >From: Dan Carpenter > > > >Add Staging: to the subject. > > Added to my notes so I don't forget it next time. > > >[PATCH v2] Staging: kpc_i2c: Remove unused file fileops.c > > > >On Thu, May 09, 2019

Re: [PATCH] staging: isdn: To make hysdn_proc_entry static.

2019-06-09 Thread gre...@linuxfoundation.org
On Sun, Jun 09, 2019 at 12:24:59AM +, Rishiraj Manwatkar wrote: > Made hysdn_proc_entry static as suggested by Sparse tool. Why is this indented? > > Signed-off-by: Rishiraj Manwatkar > --- > drivers/staging/isdn/hysdn/hysdn_procconf.c | 2 +- > 1 file changed, 1 insertion(+), 1 dele

Re: [PATCH] staging: kpc2000: To make symbols static

2019-06-10 Thread gre...@linuxfoundation.org
On Mon, Jun 10, 2019 at 05:50:01AM +, Rishiraj Manwatkar wrote: > This patch makes 4 symbols static as suggested by Sparse tool. > > Signed-off-by: Rishiraj Manwatkar Your subject line is very odd, what does that really mean? > --- > drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c | 8 +++

Re: [PATCH] Adjust analogix chip driver location

2019-06-26 Thread gre...@linuxfoundation.org
On Wed, Jun 26, 2019 at 10:44:38AM +, Xin Ji wrote: > Move analogix chip ANX78XX bridge driver into "analogix" directory. > > Signed-off-by: Xin Ji > --- > drivers/gpu/drm/bridge/Kconfig | 10 - > drivers/gpu/drm/bridge/Makefile|3 +- > drivers/g

Re: [PATCH] staging: fsl-mc/dpio: Fix incorrect comparison

2017-09-28 Thread gre...@linuxfoundation.org
On Thu, Sep 28, 2017 at 01:07:48PM +, Ruxandra Ioana Radulescu wrote: > > -Original Message- > > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > > Sent: Thursday, September 28, 2017 3:49 PM > > To: Ruxandra Ioana Radulescu > > Cc:

Re: [REVIEW REQUEST] staging: unisys: review request for visorbus

2017-10-02 Thread gre...@linuxfoundation.org
On Mon, Oct 02, 2017 at 03:41:42PM +, Kershner, David A wrote: > Hey Greg, we think the code for visorbus is ready to be moved out > of staging, can you review it to see if we have missed anything? I think your html email got rejected by the list :( > The files include: > /dri

Re: [PATCH 2/2] uio: Prefer MSI(X) interrupts in PCI drivers

2017-10-06 Thread gre...@linuxfoundation.org
On Fri, Oct 06, 2017 at 01:33:32PM +, Stahl, Manuel wrote: > > Signed-off-by: Manuel Stahl > --- >  drivers/uio/uio_pci_dmem_genirq.c | 27 --- >  drivers/uio/uio_pci_generic.c | 24 ++-- >  2 files changed, 38 insertions(+), 13 deletions(-) I ca

Re: [PATCH 2/2] uio: Prefer MSI(X) interrupts in PCI drivers

2017-10-20 Thread gre...@linuxfoundation.org
On Fri, Oct 06, 2017 at 07:57:00AM -0700, Stephen Hemminger wrote: > On Fri, 6 Oct 2017 13:50:44 + > "Stahl, Manuel" wrote: > > > MSI(X) interrupts are not shared between devices. So when available > > those should be preferred over legacy interrupts. > > > > Signed-off-by: Manuel Stahl > >

[PATCH] staging: unisys: don't care about debugfs errors

2017-11-03 Thread gre...@linuxfoundation.org
A caller should never care about a debugfs error return value, and it should never abort its normal operation if something "odd" goes on. Fix up the unisys init code to not care if the root debugfs directory for the subsystem is created or not, as no place it is used will matter. Cc: David Kershn

Re: [REVIEW REQUEST] staging: unisys: review request for visorbus

2017-11-03 Thread gre...@linuxfoundation.org
On Mon, Oct 02, 2017 at 05:49:52PM +0200, gre...@linuxfoundation.org wrote: > On Mon, Oct 02, 2017 at 03:41:42PM +, Kershner, David A wrote: > > Hey Greg, we think the code for visorbus is ready to be moved out > > of staging, can you review it to see if we have missed anythin

Re: [REVIEW REQUEST] staging: unisys: review request for visorbus

2017-11-06 Thread gre...@linuxfoundation.org
On Mon, Nov 06, 2017 at 03:30:48PM +1100, Tobin C. Harding wrote: > On Mon, Oct 02, 2017 at 05:49:52PM +0200, gre...@linuxfoundation.org wrote: > > On Mon, Oct 02, 2017 at 03:41:42PM +, Kershner, David A wrote: > > > Hey Greg, we think the code for visorbus is ready to be

Re: [REVIEW REQUEST] staging: unisys: review request for visorbus

2017-11-06 Thread gre...@linuxfoundation.org
On Mon, Nov 06, 2017 at 07:17:11PM +1100, Tobin C. Harding wrote: > On Mon, Nov 06, 2017 at 09:02:21AM +0100, gre...@linuxfoundation.org wrote: > > On Mon, Nov 06, 2017 at 03:30:48PM +1100, Tobin C. Harding wrote: > > > On Mon, Oct 02, 2017 at 05:49:52PM +0200, gre...@l

Re: [PATCH v3] staging: fsl-mc: use 32bits to support 64K size mc-portals

2017-11-24 Thread gre...@linuxfoundation.org
On Wed, Nov 22, 2017 at 10:49:50AM +, Laurentiu Tudor wrote: > > > On 11/22/2017 09:48 AM, Bharat Bhushan wrote: > > As per APIs each mc-portal is of 64K size while currently > > 16bits (type u16) is used to store size of mc-portal. > > In these cases upper bit of portal size gets truncated.

Re: [PATCH] staging: lustre: Fix sparse, using plain integer as NULL pointer in lov_object_fiemap()

2017-12-06 Thread gre...@linuxfoundation.org
On Mon, Dec 04, 2017 at 12:44:32PM +0200, Andrii Vladyka wrote: > Change 0 to NULL in lov_object_fiemap() in order to fix warning produced by > sparse > > Signed-off-by: Andrii Vladyka > Signed-off-by: Andreas Dilger > --- > > diff --git a/drivers/staging/lustre/lustre/lov/lov_object.c > b/dri

Re: [PATCH 2/5] vmbus: add driver_override support

2018-08-13 Thread gre...@linuxfoundation.org
On Mon, Aug 13, 2018 at 07:30:50PM +, Michael Kelley (EOSG) wrote: > From: k...@linuxonhyperv.com Sent: Friday, August > 10, 2018 4:06 PM > > > From: Stephen Hemminger > > > > Add support for overriding the default driver for a VMBus device > > in the same way that it can be done for PCI

Re: [PATCH 08/29] drivers, md: convert mddev.active from atomic_t to refcount_t

2017-03-08 Thread gre...@linuxfoundation.org
On Wed, Mar 08, 2017 at 09:42:09AM +, Reshetova, Elena wrote: > > On Mon, Mar 06, 2017 at 04:20:55PM +0200, Elena Reshetova wrote: > > > refcount_t type and corresponding API should be > > > used instead of atomic_t when the variable is used as > > > a reference counter. This allows to avoid ac

Re: [REGRESSION][Stable][v3.12.y][v4.4.y][v4.9.y][v4.10.y][v4.11-rc1] scsi: storvsc: properly set residual data length on errors

2017-03-31 Thread gre...@linuxfoundation.org
Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Thu, Mar 30, 2017 at 09:51:53AM -0400, Cathy Avery wrote: > Hi, > > So which commit is moving

Re: [PATCH] Drivers: hv: vmbus: Removed an unnecessary cast from void *

2018-05-15 Thread 'gre...@linuxfoundation.org'
On Tue, May 15, 2018 at 12:25:01AM +, Dexuan Cui wrote: > > In C, we don't need such a cast. > > Fixes: ae20b254306a ("Drivers: hv: vmbus: enable VMBus protocol version 5.0") > Signed-off-by: Dexuan Cui > Cc: Stephen Hemminger Should be "Reported-by:", I'll go edit this by hand :( ___

Re: [PATCH] Drivers: hv: vmbus: Removed an unnecessary cast from void *

2018-05-15 Thread 'gre...@linuxfoundation.org'
On Tue, May 15, 2018 at 12:25:01AM +, Dexuan Cui wrote: > > In C, we don't need such a cast. > > Fixes: ae20b254306a ("Drivers: hv: vmbus: enable VMBus protocol version 5.0") > Reported-by: Stephen Hemminger > Signed-off-by: Dexuan Cui > Cc: K. Y. Srinivasan > --- > > Thanks Stephen Hemmi

Re: [PATCH] Staging: rtl8712: Removed unused variable

2015-04-23 Thread gre...@linuxfoundation.org
On Thu, Apr 23, 2015 at 02:12:44PM +, DHANAPAL, GNANACHANDRAN (G.) wrote: > This patch removes unused variable in this file. > > Signed-off-by: Gnanachandran Dhanapal > > Change-Id: I59cc869773d145239d62c3185018b275239fe812 The only thing I can do with a patch that has this line in it is de

Re: linux-4.1-rc1/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c:424: bad if test ?

2015-04-27 Thread gre...@linuxfoundation.org
On Mon, Apr 27, 2015 at 08:33:30AM +, David Binderman wrote: > Hello there Greg, > > Static analyser cppcheck says > >  [linux-4.1-rc1/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c:424]: > (style) Expression is always false because 'else if' condition matches > previous condition at

Re: [PATCH] staging: rtl8712: return error directly

2015-04-30 Thread gre...@linuxfoundation.org
On Thu, Apr 30, 2015 at 08:23:08AM +, Gujulan Elango, Hari Prasath (H.) wrote: > Signed-off-by: Hari Prasath Gujulan Elango > > return error directly to avoid unwanted branching where no cleanup > is done.Also removes the ret variable. signed-off-by goes below the description, not above it.

Re: [PATCH] staging: i2o: Remove unwanted semicolon

2015-04-30 Thread gre...@linuxfoundation.org
On Thu, Apr 23, 2015 at 04:09:28PM +0100, Alan Cox wrote: > On Thu, 2015-04-23 at 13:43 +, Gujulan Elango, Hari Prasath (H.) > wrote: > > This patch removes unwanted semicolon around close braces of code blocks > > > The i2o driver moved into staging ready to be deleted unless someone > steps

Re: [PATCH] staging: lustre: declare file operations structure as static

2015-04-30 Thread gre...@linuxfoundation.org
On Fri, Apr 24, 2015 at 07:52:31AM +, Gujulan Elango, Hari Prasath (H.) wrote: > The fops structure is referenced only locally and hence could be made static > > Signed-off-by: Hari Prasath Gujulan Elango > --- > drivers/staging/lustre/lustre/mdc/lproc_mdc.c | 2 +- > 1 file changed, 1 inse

Re: [PATCH] staging: i2o: Remove unwanted semicolon

2015-05-01 Thread gre...@linuxfoundation.org
On Thu, Apr 30, 2015 at 11:25:48PM +0100, One Thousand Gnomes wrote: > On Thu, 30 Apr 2015 16:14:06 +0200 > "gre...@linuxfoundation.org" wrote: > > > On Thu, Apr 23, 2015 at 04:09:28PM +0100, Alan Cox wrote: > > > On Thu, 2015-04-23 at 13:43 +, Gujulan Ela

Re: [PATCH] staging: i2o: Remove unwanted semicolon

2015-05-01 Thread gre...@linuxfoundation.org
On Fri, May 01, 2015 at 10:28:00AM +0100, Alan Cox wrote: > On Fri, 2015-05-01 at 09:41 +0200, gre...@linuxfoundation.org wrote: > > On Thu, Apr 30, 2015 at 11:25:48PM +0100, One Thousand Gnomes wrote: > > > On Thu, 30 Apr 2015 16:14:06 +0200 > > > "gr

Re: [PATCH] staging: rtl8192u: Modify if, else if conditions to remove unnecessary equality checks. This change was detected with the help of coccinelle tool.

2015-05-18 Thread gre...@linuxfoundation.org
On Mon, May 18, 2015 at 04:00:00PM +, Dhere, Chaitanya (C.) wrote: > Signed-off-by: Chaitanya Dhere Your subject line is too long :( Put some information in the change log area here please, above the signed-off-by line. > Reply-To: Why is this here? Please fix up and resend. thanks, gr

Re: [PATCH] staging: sm750fb: replace kzalloc with devm_kzalloc

2015-05-27 Thread gre...@linuxfoundation.org
On Wed, May 27, 2015 at 11:49:47AM +0530, Sudip Mukherjee wrote: > On Wed, May 27, 2015 at 05:56:27AM +, Gujulan Elango, Hari Prasath (H.) > wrote: > > On Wed, May 27, 2015 at 11:10:34AM +0530, Sudip Mukherjee wrote: > > > On Tue, May 26, 2015 at 10:04:44AM +, Gujulan Elango, Hari Prasath

Re: [PATCHv2] Staging: rtl8192e: Casting correct Endianness

2015-05-30 Thread gre...@linuxfoundation.org
On Tue, May 12, 2015 at 11:30:40AM +, DHANAPAL, GNANACHANDRAN (G.) wrote: > Casting correct Endianness for __le16 variable used in assignment and > condition check. > > Signed-off-by: Gnanachandran Dhanapal > --- > v2:Since previous version of the patch had build error.This > version ha

Re: [PATCH] staging: rtl8192e: replace printk with subsystem debug

2015-05-30 Thread gre...@linuxfoundation.org
On Mon, May 18, 2015 at 11:27:38AM +, Gujulan Elango, Hari Prasath (H.) wrote: > replace the printk with netdev subsystem debug infrastructure. > > Signed-off-by: Hari Prasath Gujulan Elango This name doesn't match up to the way you order it in the "From:" line of the patch. Can you please

Re: [PATCH] Staging: rtl8192e: Timer setup using macro rather assignment

2015-05-30 Thread gre...@linuxfoundation.org
On Mon, May 18, 2015 at 10:12:42PM +0530, Sudip Mukherjee wrote: > On Mon, May 18, 2015 at 09:26:03AM -0700, Joe Perches wrote: > > On Mon, 2015-05-18 at 21:35 +0530, Sudip Mukherjee wrote: > > > On Mon, May 18, 2015 at 02:44:15PM +, DHANAPAL, GNANACHANDRAN (G.) > > > wrote: > > > > setup_time

Re: [PATCH] staging: rtl8712: fix indentation issue

2015-05-30 Thread gre...@linuxfoundation.org
On Tue, May 12, 2015 at 12:25:22PM +, Gujulan Elango, Hari Prasath (H.) wrote: > Fixed indentation issue in few lines. > > Signed-off-by: Hari Prasath Gujulan Elango Same name problem :( ___ devel mailing list de...@linuxdriverproject.org http://d

Re: [PATCH] staging: emxx_udc: remove commented code

2015-05-30 Thread gre...@linuxfoundation.org
On Tue, May 12, 2015 at 01:56:31PM +, Ravindran, Madhusudhanan (M.) wrote: > removed the commented INFO lines. > > Signed-off-by: Madhusudhanan Ravindran The name here doesn't match the From: line above, please fix that up to match here. thanks, greg k-h ___

Re: FW: [PATCH] Staging: vt6655: Remove unnecessary equality checks in rxtx.c

2015-05-30 Thread gre...@linuxfoundation.org
On Fri, May 29, 2015 at 03:54:27PM +, Harisangam, Sharvari (S.) wrote: > Modified the if-else statements to remove unnecessary comparisons in rxtx.c. > This change was detected with the help of coccinelle tool > > Signed-off-by: Harisangam Sharvari > --- > drivers/staging/vt6655/rxtx.c |

Re: [PATCH] Staging: vt6655: Remove unnecessary equality checks for a bool variable

2015-05-30 Thread gre...@linuxfoundation.org
On Thu, May 28, 2015 at 06:10:26AM +, Harisangam, Sharvari (S.) wrote: > Modified the if-else statements to remove unnecessary comparisons. > This change was detected with the help of coccinelle tool > > Signed-off-by: Harisangam Sharvari Name doesn't match... _

Re: [PATCH] staging: rtl8192u: Patch to modify if, else conditions

2015-05-30 Thread gre...@linuxfoundation.org
On Tue, May 19, 2015 at 04:55:57PM +, Dhere, Chaitanya (C.) wrote: > In this patch: > 1. the if condition is modified to remove > the unnecessary equality check. > 2. The else if condition is replaced by an else condition > since the variable checked in the if statement is a bool > making the e

Re: [PATCH] Staging: lustre: Replace kzalloc followed by memcpy with kmemdup

2015-05-30 Thread gre...@linuxfoundation.org
On Sat, May 30, 2015 at 10:22:17AM +, Dighe, Niranjan (N.) wrote: > Replace kzalloc followed by memcpy by kmemdup. This patch was generated > by 'make coccicheck' > > Signed-off-by: Niranjan Dighe Your name here doesn't match the name in the From: line of your email. Please fix up your emai

Re: [PATCH] staging: rtl8188eu: remove unwanted assignment

2015-05-30 Thread gre...@linuxfoundation.org
On Thu, May 14, 2015 at 09:04:00AM +, Gujulan Elango, Hari Prasath (H.) wrote: > remove an unwanted assignment to a variable which is overwritten in the > very next line.The first value assigned is not used. > > Signed-off-by: Hari Prasath Gujulan Elango Your name doesn't match the From: li

Re: [PATCH] staging: Replace kzalloc and memcpy by kmemdup

2015-05-30 Thread gre...@linuxfoundation.org
On Wed, May 20, 2015 at 07:04:27AM +, Dumbre, Nitesh Dilip (N.) wrote: > This patch was generated by coccicheck and replaces kzalloc followed > by memcpy with kmemdup > > Signed-off-by: Nitesh Dumbre Name doesn't match the From: line, please fix your broken email client. WHat is up with thi

Re: [PATCH] staging: rts5208: remove variable and check directly

2015-05-30 Thread gre...@linuxfoundation.org
On Fri, May 15, 2015 at 11:33:53AM +, Gujulan Elango, Hari Prasath (H.) wrote: > This trivial patch removes temporary variable to check return value of > a function and checks return value directly. > > Signed-off-by: Hari Prasath Gujulan Elango Same name problem here, and on all of your ot

Re: [PATCHv3] staging: sm750fb: Add missing Kconfig dependency

2015-05-30 Thread gre...@linuxfoundation.org
On Thu, May 28, 2015 at 08:51:06AM +, Gujulan Elango, Hari Prasath (H.) wrote: > The sm750fb driver has few Framebuffer configuration dependencies that > need to be selected in order to get compiled successfully. > > Signed-off-by: Gujulan Elango Hari Prasath > --- > v3: Fix alignment

Re: [PATCH 1/3] Drivers: hv: vmbus: Use the vp_index map even for channels bound to CPU 0

2015-05-30 Thread gre...@linuxfoundation.org
On Fri, May 29, 2015 at 05:41:34PM +, KY Srinivasan wrote: > > > > -Original Message- > > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > > Sent: Friday, May 29, 2015 10:00 AM > > To: KY Srinivasan > > Cc: gre...@linuxfoundation.org;

Re: [PATCH] staging: Replace kzalloc and memcpy by kmemdup

2015-05-31 Thread gre...@linuxfoundation.org
On Sun, May 31, 2015 at 06:13:00AM -0700, Joe Perches wrote: > On Sun, 2015-05-31 at 11:35 +0900, gre...@linuxfoundation.org wrote: > > On Wed, May 20, 2015 at 07:04:27AM +, Dumbre, Nitesh Dilip (N.) wrote: > > > This patch was generated by coccicheck and replaces kzalloc

Re: [PATCH] staging: dgnc: remove ununsed Macro

2015-06-01 Thread gre...@linuxfoundation.org
On Mon, Jun 01, 2015 at 10:08:46AM +, Gujulan Elango, Hari Prasath (H.) wrote: > From: Hari Prasath Gujulan Elango > > Remove the ununsed Macro.This patch needs to be applied after my > previous patch is applied whose title is given below because this macro > becomes ununsed after that.This

Re: [PATCHv2 1/2] staging: dgnc: delete all references to 'flipbuf'

2015-06-01 Thread gre...@linuxfoundation.org
On Mon, Jun 01, 2015 at 11:29:44PM +0200, Konrad Zapalowicz wrote: > On 06/01, Gujulan Elango, Hari Prasath (H.) wrote: > > From: Hari Prasath Gujulan Elango > > The above line should not be here and it will appear as long as the > email client is not configured correctly. Just take a step back a

Re: [PATCH v2] staging: wilc1000: remove unwanted assignment

2015-06-02 Thread gre...@linuxfoundation.org
On Tue, Jun 02, 2015 at 11:37:11AM +, Gujulan Elango, Hari Prasath (H.) wrote: > >From : Hari Prasath Gujulan Elango You need to write this as "From: " not "From :", otherwise git will not work properly. Also, you sent me 5 patches for the same driver, yet no hint as to what order to apply

Re: [PATCH] Staging: vt6655: Remove unnecessary equality checks in rxtx.c

2015-06-08 Thread gre...@linuxfoundation.org
On Mon, Jun 01, 2015 at 04:16:50AM +, Harisangam, Sharvari (S.) wrote: > From: Sharvari Harisangam > > Modified the if-else statements to remove unnecessary comparisons in rxtx.c. > This change was detected with the help of coccinelle tool > > Signed-off-by: Sharvari Harisangam > --- > dr

Re: [PATCHv2 1/2] staging: dgnc: delete all references to 'flipbuf'

2015-06-08 Thread gre...@linuxfoundation.org
On Mon, Jun 01, 2015 at 01:06:15PM +, Gujulan Elango, Hari Prasath (H.) wrote: > From: Hari Prasath Gujulan Elango > > This patch deletes all references to 'flipbuf'.Memory is allocated and > freed but never used anywhere in the driver.Also deleted an ununsed > Macro defined in the header fi

Re: [PATCH v3] Staging: rtl8192e: Casting correct Endianness

2015-06-08 Thread gre...@linuxfoundation.org
On Tue, Jun 02, 2015 at 03:59:32PM +, DHANAPAL, GNANACHANDRAN (G.) wrote: > From: Gnanachandran Dhanapal > > Casting correct Endianness for __le16 variable used in assignment and > condition check > > Signed-off-by: Gnanachandran Dhanapal > --- > v3: Greg review comments addressed > > ---

Re: [PATCH] staging: wilc1000: fix build warning related to time_after_eq macro

2015-06-09 Thread gre...@linuxfoundation.org
On Tue, Jun 09, 2015 at 06:43:59AM +, Gujulan Elango, Hari Prasath (H.) wrote: > From: Hari Prasath Gujulan Elango > > This patch fixes a build warning related to the use of the time_after_eq > macro.Adding a typecast to the second argument suppresses the > warning.This warning was created b

Re: [PATCH] drivers: staging: Add support for nCipher HSM devices

2019-12-09 Thread gre...@linuxfoundation.org
On Mon, Dec 09, 2019 at 01:56:55PM +, Kim, David wrote: > > Hi everybody, > ​ > This patch introduces a driver for nCipher's Solo and Solo XC range of PCIe > hardware security modules (HSM), which provide key creation/management > and cryptography services. > > Upstreaming the nCipher driver

Re: [PATCH] drivers: staging: Add support for nCipher HSM devices

2019-12-09 Thread gre...@linuxfoundation.org
On Mon, Dec 09, 2019 at 03:41:51PM +, Kim, David wrote: > Hi Greg, > > Thanks for the speedy reply. I was hoping that setting my client to > plain text only would actually do plain text only but I will try again > with git send-email. > > This is our first driver upstreaming and we targeted s

Re: staging: Add MA USB Host driver

2020-01-21 Thread gre...@linuxfoundation.org
On Mon, Jan 20, 2020 at 09:30:43AM +, Vladimir Stankovic wrote: > MA-USB Host driver provides USB connectivity over an available > network, allowing host device to access remote USB devices attached > to one or more MA USB devices (accessible via network). > > This driver has been developed to

Re: [External] Re: staging: Add MA USB Host driver

2020-01-21 Thread gre...@linuxfoundation.org
On Wed, Jan 22, 2020 at 07:40:59AM +, Vladimir Stankovic wrote: > Hi Greg, > > Our intention was to follow Linux kernel development process and add our > driver to staging first. That's not the "normal" development process at all, where did you read that? staging is only for code that needs

Re: [External] Re: staging: Add MA USB Host driver

2020-01-22 Thread gre...@linuxfoundation.org
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I includ

Re: [RESEND PATCH] staging: exfat: Fix alignment warnings

2020-01-25 Thread gre...@linuxfoundation.org
On Sat, Jan 25, 2020 at 05:49:48PM +0530, Pragat Pandya wrote: > Fix checkpatch warning "Alignment should match open parenthesis". > > Signed-off-by: Pragat Pandya > --- > drivers/staging/exfat/exfat_blkdev.c | 4 ++-- > drivers/staging/exfat/exfat_core.c | 29 ++-- >

Re: [PATCH 1/2] staging: octeon: delete driver

2020-02-03 Thread gre...@linuxfoundation.org
On Tue, Feb 04, 2020 at 04:02:15AM +, Chris Packham wrote: > I'll pipe up on this thread too > > On Tue, 2019-12-10 at 02:42 -0800, Guenter Roeck wrote: > > On 12/10/19 1:15 AM, Greg Kroah-Hartman wrote: > > > This driver has been in the tree since 2009 with no real movement to get > > > it ou

Re: [PATCH 2/2] staging: octeon-usb: delete the octeon usb host controller driver

2020-02-03 Thread gre...@linuxfoundation.org
On Tue, Feb 04, 2020 at 04:06:51AM +, Chris Packham wrote: > On Tue, 2019-12-10 at 10:15 +0100, Greg Kroah-Hartman wrote: > > This driver was merged back in 2013 and shows no progress toward every > > being merged into the "correct" part of the kernel. The code doesn't > > even build for anyon

Re: [PATCH] staging/octeon: Mark Ethernet driver as BROKEN

2020-02-03 Thread gre...@linuxfoundation.org
On Tue, Feb 04, 2020 at 12:54:26AM +, Chris Packham wrote: > Hi Greg & All, > > On Mon, 2019-12-02 at 19:15 +0100, Greg Kroah-Hartman wrote: > > On Mon, Dec 02, 2019 at 09:36:20AM -0800, Guenter Roeck wrote: > > > On Mon, Dec 02, 2019 at 05:52:31PM +0100, Greg Kroah-Hartman wrote: > > > > On M

Re: [PATCH 1/2] staging: octeon: delete driver

2020-02-04 Thread gre...@linuxfoundation.org
On Tue, Feb 04, 2020 at 12:31:16PM -0800, Matthew Wilcox wrote: > On Tue, Feb 04, 2020 at 08:06:14PM +, Chris Packham wrote: > > On Tue, 2020-02-04 at 07:09 +, gre...@linuxfoundation.org wrote: > > > On Tue, Feb 04, 2020 at 04:02:15AM +, Chris Packham wrote: >

Re: [PATCH 2/2] uio: Prefer MSI(X) interrupts in PCI drivers

2020-03-04 Thread gre...@linuxfoundation.org
On Wed, Mar 04, 2020 at 03:19:55PM +, Stahl, Manuel wrote: > Hi Greg, > > so somehow this discussion stopped without any instructions how to proceed. What is "this discussion"? > I think this kind of driver helps every FPGA developer to interface > his design via PCIe to a Linux PC. > So if

Re: [PATCH v4] Add new uio device for PCI with dynamic memory allocation

2020-04-28 Thread gre...@linuxfoundation.org
On Tue, Apr 28, 2020 at 03:47:42PM +, Stahl, Manuel wrote: > > > > > + return err; > > > + } > > > + pci_set_master(pdev); > > > + > > > + dev_info(&pdev->dev, "Legacy IRQ: %i", pdev->irq); > > > > Again, remove, be quiet :) > > Use dev_dbg() or remove completely? If it helps in deb

Re: [PATCH v4] Add new uio device for PCI with dynamic memory allocation

2020-04-29 Thread gre...@linuxfoundation.org
On Wed, Apr 29, 2020 at 07:51:01AM +, Stahl, Manuel wrote: > On Di, 2020-04-28 at 15:54 +0200, gregkh @ linuxfoundation . org wrote: > > On Thu, Apr 16, 2020 at 06:38:30PM +0200, Manuel Stahl wrote: > > > > > > + * > > > + * Since the driver does not declare any device ids, you must allocate >

Re: [PATCH 41/48] staging: comedi: pcl812: use comedi_timeout()

2014-02-07 Thread gre...@linuxfoundation.org
On Fri, Feb 07, 2014 at 04:14:01PM +, Hartley Sweeten wrote: > On Friday, February 07, 2014 8:34 AM, Ian Abbott wrote: > > On 2014-02-06 23:49, H Hartley Sweeten wrote: > >> Use comedi_timeout() to wait for the analog input end-of-conversion. > >> > >> Combine the logic for the pcl812 and acl81

Re: [PATCH] Staging: comedi: Fix line length exceeding 80 characters

2014-02-25 Thread gre...@linuxfoundation.org
On Tue, Feb 25, 2014 at 09:46:19AM +, Ian Abbott wrote: > On 2014-02-24 16:49, Monam Agarwal wrote: > > Signed-off-by: Monam Agarwal > > --- > > drivers/staging/comedi/comedi_fops.c |3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/staging/comedi/co

  1   2   >