On Mon, Apr 22, 2019 at 02:37:59PM +0000, Matt Sickler wrote:
> >From 6e70cb81c75ebb0ac7897d07c0f12d80505bb22b Mon Sep 17 00:00:00 2001
> From: Matt Sickler <matt.sick...@daktronics.com>
> Date: Mon, 22 Apr 2019 09:24:03 -0500
> Subject: [PATCH] staging: kpc2000: Add DMA driver
> 
> Add Daktronics DMA driver.  I've added the SPDX license identifiers, Kconfig
> entry, and cleaned up as many of the warnings as I could.
> 
> I'm not sure what should be done about the AIO "support" code in this driver.
> It's currently guarded by an #ifdef CONFIG_KPC_DMA_AIO.  Even if that option
> was turned on, the code doesn't compile (aio_complete() was removed since
> the original version of this driver) and it probably doesn't work right even
> if it did compile.  Maybe it's best to just remove it completely?
> 
> ---

It's best to just remove the aio stuff entirely, but we can do that in a
follow-on patch.

This looks ok, but I need a signed-off-by line on the patch, in the
changelog text.  Can you fix that up and resend it?

thanks,

greg k-h
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to