On 11-02-21, 11:00, Greg KH wrote:
> On Thu, Feb 11, 2021 at 03:24:44PM +0530, Hemansh Agnihotri wrote:
> > This patch add fixes an checkpatch error for "Macros with multiple
> > statements
> > should be enclosed in a do - while loop"
> >
> > Signed-off-by: Hemansh Agnihotri
>
> Any reason you
freq/sfi-cpufreq.c | 127 --
> 3 files changed, 138 deletions(-)
> delete mode 100644 drivers/cpufreq/sfi-cpufreq.c
Acked-by: Viresh Kumar
--
viresh
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.
On 12-02-21, 09:54, Greg KH wrote:
> On Fri, Feb 12, 2021 at 09:44:04AM +0100, Johan Hovold wrote:
> > On Fri, Feb 12, 2021 at 01:48:35PM +0530, Pritthijit Nath wrote:
> > > Fixed the spelling of 'transfered' to 'transferred'.
> > >
> > > Signed-off-by: Pritthijit Nath
> > > ---
> > > drivers/st
On 12-02-21, 13:48, Pritthijit Nath wrote:
> This change fixes a checkpatch CHECK style issue for "Alignment should match
> open parenthesis".
>
> Signed-off-by: Pritthijit Nath
> ---
> drivers/staging/greybus/hid.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/dr
On 12-02-21, 10:17, Greg KH wrote:
> On Fri, Feb 12, 2021 at 02:39:26PM +0530, Viresh Kumar wrote:
> > On 12-02-21, 13:48, Pritthijit Nath wrote:
> > > This change fixes a checkpatch CHECK style issue for "Alignment should
> > > match
> > > open
On 12-02-21, 10:52, Johan Hovold wrote:
> But what will the checkpatch crew then work on?
Lol..
> Better staging than the rest of the kernel.
[ /me wondering on who stops them from sending patches for rest of the
kernel ? ]
--
viresh
___
devel mailin
xfer_delay = clamp_t(u16, xfer_delay, 0, U16_MAX);
> + gb_xfer->delay_usecs = cpu_to_le16(xfer_delay);
> gb_xfer->cs_change = xfer->cs_change;
> gb_xfer->bits_per_word = xfer->bits_per_word;
Acked-by: Viresh Kumar
--
viresh
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 25-03-21, 18:19, Jian Dong wrote:
> From: Jian Dong
>
> fixes coccicheck Error:
>
> drivers/staging/greybus/bootrom.c:301:41-45: ERROR:
> fw is NULL but dereferenced.
>
> if procedure goto label directly, ret will be nefative, so the fw is NULL
> and the if(condition) end with dereferen
On Thu, Nov 5, 2020 at 5:15 AM Dmitry Osipenko wrote:
> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> +static void sdhci_tegra_deinit_opp_table(void *data)
> +{
> + struct device *dev = data;
> + struct opp_table *opp_table;
> +
> + opp_table =
On 05-11-20, 10:45, Ulf Hansson wrote:
> + Viresh
Thanks Ulf. I found a bug in OPP core because you cc'd me here :)
> On Thu, 5 Nov 2020 at 00:44, Dmitry Osipenko wrote:
> I need some more time to review this, but just a quick check found a
> few potential issues...
>
> The "core-supply", that
On 05-11-20, 11:34, Ulf Hansson wrote:
> I am not objecting about scaling the voltage through a regulator,
> that's fine to me. However, encoding a power domain as a regulator
> (even if it may seem like a regulator) isn't. Well, unless Mark Brown
> has changed his mind about this.
>
> In this case
On 05-11-20, 11:56, Ulf Hansson wrote:
> On Thu, 5 Nov 2020 at 11:40, Viresh Kumar wrote:
> > Btw, how do we identify if it is a power domain or a regulator ?
To be honest, I was a bit afraid and embarrassed to ask this question,
and was hoping people to make fun of me in return :
On 05-11-20, 17:18, Dmitry Osipenko wrote:
> 05.11.2020 12:58, Viresh Kumar пишет:
> >> +static void sdhci_tegra_deinit_opp_table(void *data)
> >> +{
> >> + struct device *dev = data;
> >> + struct opp_table *opp_table;
> >> +
>
On 08-11-20, 15:19, Dmitry Osipenko wrote:
> I took a detailed look at the GENPD and tried to implement it. Here is
> what was found:
>
> 1. GENPD framework doesn't aggregate performance requests from the
> attached devices. This means that if deviceA requests performance state
> 10 and then devic
On 06-11-20, 21:41, Frank Lee wrote:
> On Fri, Nov 6, 2020 at 9:18 PM Dmitry Osipenko wrote:
> >
> > 06.11.2020 09:15, Viresh Kumar пишет:
> > > Setting regulators for count as 0 doesn't sound good to me.
> > >
> > > But, I understand that
On 09-11-20, 08:08, Dmitry Osipenko wrote:
> 09.11.2020 08:00, Viresh Kumar пишет:
> > On 06-11-20, 21:41, Frank Lee wrote:
> >> On Fri, Nov 6, 2020 at 9:18 PM Dmitry Osipenko wrote:
> >>>
> >>> 06.11.2020 09:15, Viresh Kumar пишет:
> >>>>
On 09-11-20, 08:10, Dmitry Osipenko wrote:
> 09.11.2020 07:47, Dmitry Osipenko пишет:
> > 09.11.2020 07:43, Viresh Kumar пишет:
> >> On 08-11-20, 15:19, Dmitry Osipenko wrote:
> >>> I took a detailed look at the GENPD and tried to implement it. Here is
> >>
On 09-11-20, 08:19, Dmitry Osipenko wrote:
> Thanks, I made it in a different way by simply adding helpers to the
> pm_opp.h which use devm_add_action_or_reset(). This doesn't require to
> add new kernel symbols.
I will prefer to add it in core.c itself, and yes
devm_add_action_or_reset() looks be
On 09-11-20, 08:44, Dmitry Osipenko wrote:
> 09.11.2020 08:35, Viresh Kumar пишет:
> > On 09-11-20, 08:19, Dmitry Osipenko wrote:
> >> Thanks, I made it in a different way by simply adding helpers to the
> >> pm_opp.h which use devm_add_action_or_reset(). This does
On 17-12-20, 21:05, Dmitry Osipenko wrote:
> Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs, which reduces
> power consumption and heating of the Tegra chips. Tegra SoC has multiple
> hardware units which belong to a core power domain of the SoC and share
> the core voltage. The voltage
On 17-12-20, 21:06, Dmitry Osipenko wrote:
> diff --git a/arch/arm/boot/dts/tegra20-peripherals-opp.dtsi
> b/arch/arm/boot/dts/tegra20-peripherals-opp.dtsi
> index b84afecea154..7e015cdfbc55 100644
> --- a/arch/arm/boot/dts/tegra20-peripherals-opp.dtsi
> +++ b/arch/arm/boot/dts/tegra20-peripherals
On 17-12-20, 21:06, Dmitry Osipenko wrote:
> +++ b/drivers/soc/tegra/core-power-domain.c
> @@ -0,0 +1,125 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * NVIDIA Tegra SoC Core Power Domain Driver
> + */
> +
> +#include
> +#include
> +#include
> +#include
> +#include
> +
> +#include
> +
On 17-12-20, 21:05, Dmitry Osipenko wrote:
> Extend OPP API with dev_pm_opp_sync_regulators() function, which syncs
> voltage state of regulators.
>
> Signed-off-by: Dmitry Osipenko
We shouldn't be doing this, details in patch 28.
--
viresh
___
devel
On 17-12-20, 21:06, Dmitry Osipenko wrote:
> Add dev_pm_opp_set_voltage() which allows OPP table users to set voltage
> in accordance to a given OPP. In particular this is needed for driving
> voltage of a generic power domain which uses OPPs and doesn't have a
> clock.
>
> Signed-off-by: Dmitry O
On 17-12-20, 21:06, Dmitry Osipenko wrote:
> Add a ceil version of the dev_pm_opp_find_level(). It's handy to have if
> levels don't start from 0 in OPP table and zero usually means a minimal
> level.
>
> Signed-off-by: Dmitry Osipenko
Why doesn't the exact version work for you here ?
--
vires
On Mon, 9 Nov 2020 at 16:51, Frank Lee wrote:
> On Mon, Nov 9, 2020 at 1:53 PM Viresh Kumar wrote:
> > > devm_pm_opp_set_supported_hw()
> > > devm_pm_opp_set_regulators() [if we won't use GENPD]
> > > devm_pm_opp_set_clkname()
> > > devm_pm_opp_of_add
On 17-12-20, 21:06, Dmitry Osipenko wrote:
> Add resource-managed versions of OPP API functions. This removes a need
> from drivers to store and manage OPP table pointers.
>
> Signed-off-by: Dmitry Osipenko
> ---
> drivers/opp/core.c | 173 +
> drivers
On 17-12-20, 21:06, Dmitry Osipenko wrote:
> A required OPP may not be available, and thus, all OPPs which are using
> this required OPP should be unavailable too.
>
> Signed-off-by: Dmitry Osipenko
> ---
> drivers/opp/core.c | 11 ++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
P
On 17-12-20, 21:06, Dmitry Osipenko wrote:
> Support set_opp() customization without requiring to use regulators. This
> is needed by drivers which want to use dev_pm_opp_set_rate() for changing
> rates of a multiple clocks and don't need to touch regulator.
>
> One example is NVIDIA Tegra30/114 S
On 17-12-20, 21:06, Dmitry Osipenko wrote:
> Fix adding OPP entries in a wrong (opposite) order if OPP rate is
> unavailable. The OPP comparison is erroneously skipped if OPP rate is
> missing, thus OPPs are left unsorted.
>
> Signed-off-by: Dmitry Osipenko
> ---
> drivers/opp/core.c | 23 ++
On 17-12-20, 21:06, Dmitry Osipenko wrote:
> diff --git a/arch/arm/boot/dts/tegra30-peripherals-opp.dtsi
> b/arch/arm/boot/dts/tegra30-peripherals-opp.dtsi
> index cbe84d25e726..983db1a06682 100644
> --- a/arch/arm/boot/dts/tegra30-peripherals-opp.dtsi
> +++ b/arch/arm/boot/dts/tegra30-peripherals
On 18-12-20, 16:51, Dmitry Osipenko wrote:
> Alright, although I haven't pretended that v2 patches should be merged
> right away since they are fundamentally different from v1, and thus, all
> patches need to be reviewed first.
I agree. I have done some basic review for the stuff.
> If the curren
On 22-12-20, 22:15, Dmitry Osipenko wrote:
> 22.12.2020 09:42, Viresh Kumar пишет:
> > On 17-12-20, 21:06, Dmitry Osipenko wrote:
> >> Add a ceil version of the dev_pm_opp_find_level(). It's handy to have if
> >> levels don't start from 0 in OPP table and ze
On 22-12-20, 22:17, Dmitry Osipenko wrote:
> 22.12.2020 11:59, Viresh Kumar пишет:
> > On 17-12-20, 21:06, Dmitry Osipenko wrote:
> >> A required OPP may not be available, and thus, all OPPs which are using
> >> this required OPP should be unavailable too.
> >>
On 22-12-20, 22:19, Dmitry Osipenko wrote:
> 22.12.2020 12:12, Viresh Kumar пишет:
> > On 17-12-20, 21:06, Dmitry Osipenko wrote:
> >> Fix adding OPP entries in a wrong (opposite) order if OPP rate is
> >> unavailable. The OPP comparison is erroneously skipped if OPP
On 22-12-20, 22:39, Dmitry Osipenko wrote:
> 22.12.2020 22:21, Dmitry Osipenko пишет:
> >>> + if (IS_ERR(opp)) {
> >>> + dev_err(&genpd->dev, "failed to find OPP for level %u: %pe\n",
> >>> + level, opp);
> >>> + return PTR_ERR(opp);
> >>> + }
> >>> +
> >>> + err = d
On 17-12-20, 21:06, Dmitry Osipenko wrote:
> Support set_opp() customization without requiring to use regulators. This
> is needed by drivers which want to use dev_pm_opp_set_rate() for changing
> rates of a multiple clocks and don't need to touch regulator.
>
> One example is NVIDIA Tegra30/114 S
On 23-12-20, 23:38, Dmitry Osipenko wrote:
> Well, there is no "same structure", the opp_table->set_opp_data is NULL
> there.
Right, I saw that yesterday. What I meant was that we need to start allocating
the structure for this case now.
--
viresh
___
On 23-12-20, 23:36, Dmitry Osipenko wrote:
> 23.12.2020 07:34, Viresh Kumar пишет:
> > On 22-12-20, 22:19, Dmitry Osipenko wrote:
> >> 22.12.2020 12:12, Viresh Kumar пишет:
> >>> rate will be 0 for both the OPPs here if rate_not_available is true and
> >
On 23-12-20, 23:37, Dmitry Osipenko wrote:
> 23.12.2020 07:19, Viresh Kumar пишет:
> > On 22-12-20, 22:15, Dmitry Osipenko wrote:
> >> 22.12.2020 09:42, Viresh Kumar пишет:
> >>> On 17-12-20, 21:06, Dmitry Osipenko wrote:
> >>>> Add a ceil version of th
On 23-12-20, 23:37, Dmitry Osipenko wrote:
> 23.12.2020 08:57, Viresh Kumar пишет:
> > What's wrong with getting the regulator in the driver as well ? Apart from
> > the
> > OPP core ?
>
> The voltage syncing should be done for each consumer regulator
> individ
On 24-12-20, 16:00, Dmitry Osipenko wrote:
> In a device driver I want to set PD to the lowest performance state by
> removing the performance vote when dev_pm_opp_set_rate(dev, 0) is
> invoked by the driver.
>
> The OPP core already does this, but if OPP levels don't start from 0 in
> a device-tr
On 28-12-20, 17:03, Dmitry Osipenko wrote:
> 28.12.2020 09:22, Viresh Kumar пишет:
> > On 24-12-20, 16:00, Dmitry Osipenko wrote:
> >> In a device driver I want to set PD to the lowest performance state by
> >> removing the performance vote when dev_pm_opp_set_rate(dev
ager_module_descriptor *desc)
> int err;
>
> id = ida_simple_get(&module_id, 0, 0, GFP_KERNEL);
> + if (id < 0)
> + return id;
> +
> err = gb_audio_manager_module_create(&module, manager_kset,
>
> Signed-off-by: Greg Kroah-Hartman
> ---
> drivers/staging/greybus/hd.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
Acked-by: Viresh Kumar
--
viresh
___
devel mailing list
de...@linuxdriverproject.org
http://driverd
On 25-08-19, 07:54, Greg Kroah-Hartman wrote:
> When these files originally got an SPDX tag, I used // instead of /* */
> for the .h files. Fix this up to use // properly.
>
> Cc: Viresh Kumar
> Cc: Johan Hovold
> Cc: Alex Elder
> Cc: greybus-...@list
Vaibhav Agarwal
> Cc: Mark Greer
> Cc: Viresh Kumar
> Cc: "Bryan O'Donoghue"
> Cc: greybus-...@lists.linaro.org
> Cc: de...@driverdev.osuosl.org
> Signed-off-by: Greg Kroah-Hartman
> ---
> .../Documentation/firmware/authenticate.c | 46 -
> Cc: Vaibhav Agarwal
> Cc: Mark Greer
> Cc: Viresh Kumar
> Cc: Rui Miguel Silva
> Cc: David Lin
> Cc: "Bryan O'Donoghue"
> Cc: greybus-...@lists.linaro.org
> Cc: de...@driverdev.osuosl.org
> Signed-off-by: Greg Kroah-Hartman
Acked-by: Viresh Kumar
-
(kfifo_alloc(&gb->kfifo_lat, kfifo_depth * sizeof(u32),
> - GFP_KERNEL)) {
> + GFP_KERNEL)) {
> retval = -ENOMEM;
> goto out_conn;
> }
Acked-by: Viresh Kumar
--
viresh
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
undle *bundle,
> return -ENOMEM;
>
> connection = gb_connection_create(bundle, le16_to_cpu(cport_desc->id),
> - gb_log_request_handler);
> + gb_log_request_handler);
> if (IS_ERR(connection)) {
> retval = PTR_ERR(connection);
>
> - dev_err(&intf->dev, "manifest too small (%zu < %zu)\n",
> - size, sizeof(*desc_header));
> + dev_err(&intf->dev, "manifest too small (%zu < %zu)\n", size,
> + sizeof(
Kconfig | 11 ---
> drivers/staging/greybus/Makefile | 5 -
> 6 files changed, 24 insertions(+), 17 deletions(-)
> rename drivers/{staging => }/greybus/arpc.h (100%)
> rename drivers/{staging => }/greybus/es2.c (99%)
Acked-by: Viresh Kumar
--
viresh
___
ompanies, it is time to get the core greybus code
> out of staging as it really is going to be with us for a while.
>
> Cc: Johan Hovold
> Cc: Alex Elder
> Cc: linux-ker...@vger.kernel.org
> Cc: greybus-...@lists.linaro.org
> Signed-off-by: Greg Kroah-Hartman
Ac
On 16-04-19, 17:13, Madhumitha Prabakaran wrote:
> Fix a blank line after structure declarations. Also, convert
> macros into inline functions in order to maintain Linux kernel
> coding style based on which the inline function is
> preferable over the macro.
>
> Blank line fixes are suggested by c
> EXPORT_SYMBOL_GPL(gb_spilib_master_init);
> @@ -558,7 +561,6 @@ void gb_spilib_master_exit(struct gb_connection
> *connection)
> struct spi_master *master = gb_connection_get_data(connection);
>
> spi_unregister_master(master);
> - spi_master_put(master);
>
On 29-10-17, 13:51, Johan Hovold wrote:
> That's right, and I already posted a fix for that use-after-free:
>
> https://lkml.kernel.org/r/20171029115625.32385-1-jo...@kernel.org
Great :)
--
viresh
___
devel mailing list
de...@linuxdriverproject.
that helper
> in the future.
>
> Signed-off-by: Arnd Bergmann
> ---
> drivers/staging/greybus/loopback.c | 42
> --
> 1 file changed, 18 insertions(+), 24 deletions(-)
Reviewed-by: Viresh Kumar
--
viresh
-
> drivers/staging/greybus/loopback.c | 27 +++
> 1 file changed, 3 insertions(+), 24 deletions(-)
Reviewed-by: Viresh Kumar
--
viresh
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproj
Cc: Vaibhav Hiremath
> Cc: Johan Hovold
> Cc: Alex Elder
> Cc: Greg Kroah-Hartman
> Cc: Vaibhav Agarwal
> Cc: Mark Greer
> Cc: Viresh Kumar
> Cc: Rui Miguel Silva
> Cc: David Lin
> Cc: "Bryan O'Donogh
: Alex Elder
> Cc: Greg Kroah-Hartman
> Cc: Vaibhav Hiremath
> Cc: Vaibhav Agarwal
> Cc: Mark Greer
> Cc: Viresh Kumar
> Cc: Rui Miguel Silva
> Cc: David Lin
> Cc: "Bryan O'Donoghue"
> Cc: Thomas Gleixner
> Cc: Kate Stewart
> Cc: Ph
Hi Tobin,
On Wed, Feb 15, 2017 at 5:39 AM, Tobin C. Harding wrote:
> Greybus currently uses strncpy() coupled with a check for '\0' on the
> last byte of various buffers. strncpy() is passed size parameter equal
> to the size of the buffer in all instances. If the source string is
> larger than t
mailing list, moved changelog to summary body
> v5
> -correctly placed changelog
>
> drivers/staging/greybus/tools/loopback_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
You can still include my
Acked-by: Viresh Kumar
:)
--
viresh
ivers/staging/greybus/uart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Viresh Kumar
--
viresh
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Fri, Apr 6, 2018 at 3:39 PM, Gaurav Dhingra
wrote:
Why did you remove the commit log? You had the right one in v1.
> Signed-off-by: Gaurav Dhingra
> ---
> Changes in v2:
> - use correct format for multiline comment
> ---
> drivers/staging/greybus/audio_codec.h | 5 -
> 1 file change
On 06-04-18, 16:02, Gaurav Dhingra wrote:
> I didn't realize that it would be necessary to add it to this patch set. I
> thought you guys will do squashing of the commits (v2 and v1) and using just
> one commit message (and will take it from last commit), seems like I was
> wrong. Now I've understo
t; drivers/staging/greybus/arche-platform.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Acked-by: Viresh Kumar
--
viresh
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
0);
> - if (arche_pdata->svc_refclk_req < 0) {
> + if (!gpio_is_valid(arche_pdata->svc_refclk_req)) {
> dev_err(dev, "failed to get svc clock-req gpio\n");
> return arche_pdata->svc_refclk_req;
> }
Acked-by: Viresh Kumar
--
viresh
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
IXME Reset the interface here */
>
> return 0;
Don't you get a new error after removing this, i.e "reset set but unused" ? Or
the sizeof() operation on that suppresses those warnings ..
Acked-by: Viresh Kumar
--
viresh
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
t;Invalid kcontrol count=%d for %s\n",
> w->ncontrols, w->name);
> return ret;
> }
Acked-by: Viresh Kumar
--
viresh
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
fs operation %s create failed (%ld)\n",
> - entry->name, PTR_ERR(dentry));
> - return PTR_ERR(dentry);
> + debugfs_create_file(entry->name, entry->mask,
> + gcam->debugfs.root, gcam,
> +
On 03-06-18, 08:52, Janani Sankara Babu wrote:
> This patch replaces comparison of var to NULL with !var
>
> Signed-off-by: Janani Sankara Babu
> ---
> drivers/staging/greybus/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/core.c b/driver
rivers/staging/greybus/loopback.c
> -F: drivers/staging/greybus/timesync.c
> -F: drivers/staging/greybus/timesync_platform.c
>
> GREYBUS PLATFORM DRIVERS
> M: Vaibhav Hiremath
Acked-by: Viresh Kumar
--
viresh
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
ch_entry_safe(module, next, &modules_list, list) {
> list_del(&module->list);
> - kobject_put(&module->kobj);
> ida_simple_remove(&module_id, module->id);
> + kobject_put(&module->kobj);
> }
>
> is
opback *gb, bool error);
>
> static u32 gb_loopback_nsec_to_usec_latency(u64 elapsed_nsecs)
> {
> - u32 lat;
> -
> do_div(elapsed_nsecs, NSEC_PER_USEC);
> - lat = elapsed_nsecs;
> - return lat;
> + return elapsed_nsecs;
> }
>
> static u64 _
lights = kzalloc(glights->lights_count *
> + glights->lights = kcalloc(glights->lights_count,
> sizeof(struct gb_light), GFP_KERNEL);
> if (!glights->lights) {
> ret = -ENOMEM;
Acked-by: Viresh Kumar
--
viresh
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
ould have kept my Ack in this patch, as I have already given it earlier.
Anyway, here it is again.
Acked-by: Viresh Kumar
>
> diff --git a/drivers/staging/greybus/power_supply.c
> b/drivers/staging/greybus/power_supply.c
> index e85c988b7034..20cac20518d7 100644
> --- a/dr
On 18-05-17, 15:28, Arnd Bergmann wrote:
> Enabling the arche platform for compile testing showed a harmless
> warning with CONFIG_PM=n:
>
> drivers/staging/greybus/arche-platform.c:632:12: error:
> 'arche_platform_resume' defined but not used [-Werror=unused-function]
> drivers/staging/greybus/a
notation avoids both problems and also gives
> better build time coverage, so that's what I tend to use.
Thanks for the explanation Arnd. I hope these unused routines will not
be part of the binary that gets generated. Right?
Reviewed-by: Vi
n"
Cc: Haiyang Zhang
Cc: de...@linuxdriverproject.org
Signed-off-by: Viresh Kumar
---
drivers/hv/hv.c | 45 +++--
1 file changed, 19 insertions(+), 26 deletions(-)
diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
index d3943bceecc3..76e519ec2e51 1006
IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there
is no need to do that again from its callers. Drop it.
This also replaces an IS_ERR(x) + (x == NULL) check to IS_ERR_OR_NULL
check.
Signed-off-by: Viresh Kumar
---
drivers/staging/android/ashmem.c
There is no need to verify that its an error, as we are anyway going to
match the error value to -ENOENT. Drop the redundant check.
Reported-by: "Kirill A. Shutemov"
Signed-off-by: Viresh Kumar
---
drivers/staging/lustre/lustre/obdclass/lu_object.c | 2 +-
1 file changed, 1 inser
On Tue, Dec 6, 2016 at 7:39 PM, Srikant Ritolia wrote:
> All kmalloc-based functions print enough information on failure
>
> Signed-off-by: Srikant Ritolia
> ---
> Changes in v2:
> - Added driver name in the subject for better readability.
Acke
> GREYBUS AUDIO PROTOCOLS DRIVERS
> M: Vaibhav Agarwal
Reviewed-by: Viresh Kumar
--
viresh
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wed, Jan 11, 2017 at 6:25 AM, Abdul Rauf wrote:
> Fix the following warnings:
> braces {} are not necessary for any arm of this statement
>
> Signed-off-by: Abdul Rauf
> ---
> drivers/staging/greybus/loopback.c | 7 +++
> 1 file changed, 3 insertions(+), 4 deletions
ertion(+), 1 deletion(-)
Acked-by: Viresh Kumar
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
-
> drivers/staging/greybus/loopback.c | 2 +-
> 2 files changed, 13 insertions(+), 13 deletions(-)
I think checkpatch should rather not warn about it. Using 'unsigned' instead of
'unsigned int' isn't that bad :)
Acked-by: Viresh Kumar
--
viresh
__
is only necessary in stable
> 4.9.x.
>
> v1->v2:
>- add Fixes tag to changelog
>Johan Hovold:
> - for symmetry with the lock, adjust the unlock_bus function
> accordantly.
Reviewed-by: Viresh Kumar
--
viresh
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
_serial_info(struct gb_tty *gb_tty,
> struct serial_struct tmp;
>
> memset(&tmp, 0, sizeof(tmp));
> - tmp.flags = ASYNC_LOW_LATENCY | ASYNC_SKIP_TEST;
> tmp.type = PORT_16550A;
> tmp.line = gb_tty->minor;
> tmp.xmit_fifo_size = 16;
Reviewed-by: V
On 25-01-17, 18:38, Franck Demathieu wrote:
> It fixes the following issue reported by checkpatch.pl:
> Prefer kernel type 'u32' over 'uint32_t'
>
> Signed-off-by: Franck Demathieu
> ---
> drivers/staging/greybus/sdio.c | 2 +-
> 1 file changed, 1 inse
Move all greybus documentation to the top level Documentation/
directory, as that's the obvious place where everyone will look for it.
Signed-off-by: Viresh Kumar
---
.../Documentation => Documentation/greybus}/firmware/authenticate.c | 0
.../Documentation => Documentat
On 07-02-17, 09:02, Greg Kroah-Hartman wrote:
> On Tue, Feb 07, 2017 at 11:15:29AM +0530, Viresh Kumar wrote:
> > Move all greybus documentation to the top level Documentation/
> > directory, as that's the obvious place where everyone will look for it.
>
> No, not unti
gc->irqdomain);
> }
>
> - if (ggc->irqchip) {
> + if (ggc->irqchip)
> ggc->irqchip = NULL;
> - }
> }
>
> /**
Acked-by: Viresh Kumar
___
devel mailing list
de...@linuxdri
case GREYBUS_TYPE_INVALID:
> return "invalid";
> case GREYBUS_TYPE_STRING:
Acked-by: Viresh Kumar
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
"%d:Error in %s for %s\n", ret,
> __func__, kcontrol->id.name);
> + return ret;
> }
> }
>
> - return ret;
> + return 0;
> }
>
> #define
On 27 September 2016 at 15:03, Quentin Lambert
wrote:
>
>
> On 27/09/2016 11:31, Viresh Kumar wrote:
>>
>> On Tue, Sep 27, 2016 at 2:50 PM, Quentin Lambert
>> wrote:
>>>
>>> Checkpatch printed a style ERROR concerning a missing space befire '(&#
On Fri, Sep 30, 2016 at 3:25 PM, Dan Carpenter wrote:
> Hello Rui Miguel Silva,
>
> The patch 3b6ecd6de6b4: "greybus: sdio: extend sdio implementation"
> from Jun 22, 2015, leads to the following static checker warning:
>
> drivers/staging/greybus/sdio.c:481 gb_sdio_command()
> war
+ if (*delay_on)
> channel->active = true;
> else
> channel->active = false;
Acked-by: Viresh Kumar
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
t;
> /* no response expected */
> - if (cmd_flags & GB_SDIO_RSP_NONE)
> + if (cmd_flags == GB_SDIO_RSP_NONE)
> goto out;
>
> /* long response expected */
Acked-by: Viresh Kumar
___
devel mailing list
; - channel->attrs = kcalloc(size + 1, sizeof(**channel->attrs),
> -GFP_KERNEL);
> + channel->attrs = kcalloc(size + 1, sizeof(*channel->attrs),
> GFP_KERNEL);
> if (!channel->attrs)
> return -ENOMEM
; +
> mutex_lock(&channel->lock);
> ret = gb_pm_runtime_get_sync(bundle);
> if (ret < 0)
Acked-by: Viresh Kumar
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
1 - 100 of 126 matches
Mail list logo
