On Fri, Sep 30, 2016 at 3:25 PM, Dan Carpenter <dan.carpen...@oracle.com> wrote: > Hello Rui Miguel Silva, > > The patch 3b6ecd6de6b4: "greybus: sdio: extend sdio implementation" > from Jun 22, 2015, leads to the following static checker warning: > > drivers/staging/greybus/sdio.c:481 gb_sdio_command() > warn: bitwise AND condition is false here > > drivers/staging/greybus/sdio.c > 474 ret = gb_operation_sync(host->connection, > GB_SDIO_TYPE_COMMAND, > 475 &request, sizeof(request), &response, > 476 sizeof(response)); > 477 if (ret < 0) > 478 goto out; > 479 > 480 /* no response expected */ > 481 if (cmd_flags & GB_SDIO_RSP_NONE) > ^^^^^^^^^^^^^^^^ > This is zero.
Oh yes.. The macro is set to 0 and this is obviously wrong :( _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
