staging: lustre/lustre/lov: Cleanup style issues in lov_request.c

Hello, This patch series fixes two coding style issues and removes an unneeded 'if' statement in lov_request.c. Thanks, riccardo ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-deve

[PATCH 2/3] staging: lustre/lustre/lov: Add a blank line after declarations in lov_request.c

Fix the following checkpatch.pl issue in lov_request.c: WARNING: Missing a blank line after declarations Signed-off-by: Riccardo Lucchese --- drivers/staging/lustre/lustre/lov/lov_request.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre

[PATCH 1/3] staging: lustre/lustre/lov: Remove unneeded 'if' statement in lov_request.c/lov_check_set()

It is silly to go through an if statement to set a single boolean value in function of a single boolean expression. In the function lov_check_set, assign the return value directly. Signed-off-by: Riccardo Lucchese --- drivers/staging/lustre/lustre/lov/lov_request.c | 11 +-- 1 file

[PATCH 3/3] staging: lustre/lustre/lov: Add a space before open braces '{' in lov_request.c

Fix the following checkpatch.pl issue in lov_request.c: ERROR: space required before the open brace '{' Signed-off-by: Riccardo Lucchese --- drivers/staging/lustre/lustre/lov/lov_request.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/lus

Re: [PATCH 1/3] staging: lustre/lustre/lov: Remove unneeded 'if' statement in lov_request.c/lov_check_set()

On Sat, Jul 19, 2014 at 12:59:22PM -0700, Joe Perches wrote: > On Sat, 2014-07-19 at 21:34 +0200, Riccardo Lucchese wrote: > > It is silly to go through an if statement to set a single boolean > > value in function of a single boolean expression. In the function > > lov_

Re: [PATCH 1/3] staging: lustre/lustre/lov: Remove unneeded 'if' statement in lov_request.c/lov_check_set()

Dan, On Sun, Jul 20, 2014 at 07:52:53AM +0300, Dan Carpenter wrote: > On Sat, Jul 19, 2014 at 09:34:56PM +0200, Riccardo Lucchese wrote: > > It is silly to go through an if statement to set a single boolean > > value in function of a single boolean expression. In the function &g

Re: [PATCH 1/3] staging: lustre/lustre/lov: Remove unneeded 'if' statement in lov_request.c/lov_check_set()

On Sun, Jul 20, 2014 at 02:37:47PM +0300, Dan Carpenter wrote: > On Sun, Jul 20, 2014 at 01:08:36PM +0200, Riccardo Lucchese wrote: > > Dan, > > > > On Sun, Jul 20, 2014 at 07:52:53AM +0300, Dan Carpenter wrote: > > > On Sat, Jul 19, 2014 at 09:34:56PM

[PATCH v2 2/3] staging: lustre: lov: Add a blank line after declarations in lov_request.c

Fix the following checkpatch.pl issue in lov_request.c: WARNING: Missing a blank line after declarations Signed-off-by: Riccardo Lucchese Acked-by: Julia Lawall --- Changes in v2: - Changed the subject line to follow the same convention used by previous commits to the same file. - Added

staging: lustre: lov: Cleanup style issues in lov_request.c

Hello, This patch series contains one cleanup and two coding style fixes for lov_request.c. This iteration addresses the review comments received by v1. Changes in v2: - Improved the commit messages. - Introduced a local variable in lov_check_set() to make the code clearer. Thanks, riccardo

[PATCH v2 1/3] staging: lustre: lov: Cleanup lov_check_set() in lov_request.c

Make the code clearer by introducing a local variable and removing the unnecessary 'if' statement. Signed-off-by: Riccardo Lucchese Acked-by: Julia Lawall --- Changes in v2: - Improved the commit message: - changed the subject line to follow the same convention used by

[PATCH v2 3/3] staging: lustre: lov: Add a space before open braces '{' in lov_request.c

Fix the following checkpatch.pl issue in lov_request.c: ERROR: space required before the open brace '{' Signed-off-by: Riccardo Lucchese Acked-by: Julia Lawall --- Changes in v2: - Changed the subject line to follow the same convention used by previous commits to the same file

Re: [PATCH v2 1/3] staging: lustre: lov: Cleanup lov_check_set() in lov_request.c

On Sun, Jul 20, 2014 at 08:30:23AM -0700, Joe Perches wrote: > On Sun, 2014-07-20 at 15:22 +0200, Riccardo Lucchese wrote: > > Make the code clearer by introducing a local variable and removing the > > unnecessary 'if' statement. > > > > Signed-off-by: R

[PATCH v3 1/3] staging: lustre: lov: Cleanup lov_check_set() in lov_request.c

Make the code clearer by introducing a local variable and removing the unnecessary 'if' statement. Signed-off-by: Riccardo Lucchese Acked-by: Julia Lawall --- Changes in v3: - Renamed the local variable 'desc' to 'tgt' to be consistent with other definitions

staging: lustre: lov: Cleanup style issues in lov_request.c

Hello, This patch series contains one cleanup and two coding style fixes for lov_request.c. This iteration addresses the review comments received by v2. Changes in v3: - Renamed the local variable introduced in v2-1/3 to be consistent with other definitions in the driver. Changes in v2: -

[PATCH v3 2/3] staging: lustre: lov: Add a blank line after declarations in lov_request.c

Fix the following checkpatch.pl issue in lov_request.c: WARNING: Missing a blank line after declarations Signed-off-by: Riccardo Lucchese Acked-by: Julia Lawall --- No changes in v3. Changes in v2: - Changed the subject line to follow the same convention used by previous commits to the

[PATCH v3 3/3] staging: lustre: lov: Add a space before open braces '{' in lov_request.c

Fix the following checkpatch.pl issue in lov_request.c: ERROR: space required before the open brace '{' Signed-off-by: Riccardo Lucchese Acked-by: Julia Lawall --- No changes in v3. Changes in v2: - Changed the subject line to follow the same convention used by previous commits t