On Thu, 11 Dec 2014 09:43:24 +0800
kbuild test robot wrote:
> drivers/staging/fpga/socfpga.c:655:25: sparse: symbol 'socfpga_fpga_ops' was
> not declared. Should it be static?
>
> Signed-off-by: Fengguang Wu
Ought to be const as well by the look of it - we don't want function
pointers in patc
On Sat, 13 Dec 2014 17:29:26 +0100
Loic Pefferkorn wrote:
> Hello,
>
> The convention for checking for NULL pointers is !ptr and not ptr == NULL.
> This patch fixes such occurences in goldfish driver, it applies against
> next-20141212
>
>
> Signed-off-by: Loic Pefferkorn
Pointless churn. I
On Sat, 13 Dec 2014 11:46:47 -0800
Jeremiah Mahler wrote:
> Loïc,
>
> On Sat, Dec 13, 2014 at 07:22:38PM +0100, Loic Pefferkorn wrote:
> > > Whose convention is this? I can't find any mention in
> > > Documention/CodingStyle. checkpatch.pl doesn't complain about them.
> > > And there are almost
On Sat, 13 Dec 2014 22:20:52 +0100
Loic Pefferkorn wrote:
> On Sat, Dec 13, 2014 at 07:07:05PM +0000, One Thousand Gnomes wrote:
> >
> > Pointless churn. It makes it less readable if anything, and it removes
> > the type safety as you are now checking against 0 not (
> Then configure udev to load right firmware for you, or ln -s
> image-i-want-now socfpga-fpga-image to select the one to read...?
Your conceptual model is wrong. FPGA firmware is dynamic. There are
already people who lazy reload FPGA firmware on taskswitches. This
proposed fpga manager is broken
On Mon, 12 Jan 2015 11:06:08 -0700
Jason Gunthorpe wrote:
> On Sun, Jan 11, 2015 at 10:29:00AM -0600, atull wrote:
> > the FPGA image. If someone wants there to be only one FPGA image on
> > the FGPA forever, they will probably not be using this framework; their
> > FPGA will probably be loaded
On Mon, 12 Jan 2015 14:43:14 -0700
Jason Gunthorpe wrote:
> On Mon, Jan 12, 2015 at 09:01:34PM +0000, One Thousand Gnomes wrote:
> > There are plenty of people today who treat the FPGA as an entirely
> > dynamic resource. It's not like flashing a controller, its near
> >
> Those people have failed to show up and provide input and/or code.
That doesn't excuse failing to design the code properly.
>
> >> It is one thing to context switch a maths algorithm that is built to
> >> be stateless, it is quite another to context switch between, say an
> >> ethernet core wi
> The request_firmware interface should be for the DT overlay path, and
> other schemes shouldn't use it. The name should come from the DT and
> no place else.
For the static bindings agreed (or ACPI but that's a detail) or other
dynamic discovery post boot.
> 2) The bootloader starts the kernel
On Wed, 14 Jan 2015 11:12:58 -0700
Jason Gunthorpe wrote:
> On Wed, Jan 14, 2015 at 04:06:17PM +0000, One Thousand Gnomes wrote:
>
> > and I think you effectively have the user usage covered here for such
> > things. It much like GPIO pins - we can describe them but we can als
On Thu, 15 Jan 2015 11:47:26 -0700
Jason Gunthorpe wrote:
> It is a novel idea, my concern would be that embedding the FPGA in the
> DT makes it permanent unswappable kernel memory.
> Not having the kernel hold the FPGA is best for many uses.
If you have a filesysytem before the FPGA is set up th
On Thu, 30 Apr 2015 16:14:06 +0200
"gre...@linuxfoundation.org" wrote:
> On Thu, Apr 23, 2015 at 04:09:28PM +0100, Alan Cox wrote:
> > On Thu, 2015-04-23 at 13:43 +, Gujulan Elango, Hari Prasath (H.)
> > wrote:
> > > This patch removes unwanted semicolon around close braces of code blocks
> >
On Wed, 13 May 2015 14:58:13 -0700
colincronin wrote:
> Fixed a spelling error in comments.
>
> Signed-off-by: Colin Cronin
> ---
> drivers/staging/i2o/i2o_scsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
i2o is going away - please just drop the i2o ones from your patching.
Ala
On Wed, 20 May 2015 17:46:44 +0200
Richard Weinberger wrote:
> On Wed, May 20, 2015 at 5:27 PM, Sudip Mukherjee
> wrote:
> > Lets give the parport subsystem a proper name and start
> > maintaining the files.
>
> Excuse me, but usually someone takes over the maintainer role after
> proving that
On Fri, 7 Feb 2014 09:15:40 +
Mark Einon wrote:
> On Wed, Feb 05, 2014 at 09:56:41PM +0800, Zhao, Gang wrote:
> > > @@ -2124,7 +2124,11 @@ static int et131x_rx_dma_memory_alloc(struct
> > > et131x_adapter *adapter)
> > >
> > > /* Alloc memory for the lookup table */
> > > rx_ring->fbr[
On Wed, 19 Feb 2014 09:14:19 +0800
"Zhao\, Gang" wrote:
> Alan, thanks for resending this patch. But it seems you overlooked
> something we discussed earlier.
>
> On Mon, 2014-02-17 at 22:13:08 +0800, Alan wrote:
> > We should check the ring allocations don't fail.
> > If we get a fail we need t
On Tue, 8 Apr 2014 09:15:22 +0300
Tuomas Tynkkynen wrote:
> If misc_register failed in goldfish_audio_probe, the already requested
> IRQ wouldn't get freed. Add a call to free_irq() like there is in
> goldfish_audio_remove().
>
> Signed-off-by: Tuomas Tynkkynen
Acked-by: Alan Cox
___
> Reviewed-by: John L. Hammond
> Reviewed-by: Isaac Huang
> Signed-off-by: Oleg Drokin
> ---
> drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
> b/drivers/stagi
> if (cmd != SIOCWMIOCTL)
> return -EOPNOTSUPP;
> @@ -482,8 +483,16 @@ static int gdm_wimax_ioctl(struct net_device *dev,
> struct ifreq *ifr, int cmd)
> /* NOTE: gdm_update_fsm should be called
>* before gdm_wimax_i
On Fri, 11 Dec 2015 00:47:38 +0100
Wim de With wrote:
> On Thu, Dec 10, 2015 at 02:44:45PM +0000, One Thousand Gnomes wrote:
> > (except that you mean sizeof(struct fsm_s) and it doesn't compile at the
> > moment!
>
> Oops, sloppy mistake.
Compile/test/send - even w
On Fri, 1 Jan 2016 18:20:39 +0100
Samuel Thibault wrote:
> Previously, speakup would always read the bottom part of the screen,
> even when the VT is scrolled back with shift-page. This patch makes
> vt.c export screen_pos so that speakup can use it to properly access
> the content of the scroll
> +* Implement ACPI hot-lug for SGX.
hot-plug
Also with an upstream hat on I would add being able to check the keys on
the enclave against a kernel keychain because not everyone will want to
solely trust whatever keys the hardware thinks it wants to trust.
Alan
__
> Replay Protected Memory Block. It's a device that allows someone to
> write to it and confirm that the write happened and the old contents
> is no longer available. You could use it to implement an enclave that
> checks a password for your disk but only allows you to try a certain
> number of t
> > Storing your ssh private key encrypted such that even someone who
> > completely compromises your system can't get the actual private key
>
> Well, if someone gets root on my system, he can get my ssh private
> key right?
Potentially not. If you are using a TPM or other TEE (such as SGX
> But... that will mean that my ssh will need to be SGX-aware, and that
> I will not be able to switch to AMD machine in future. ... or to other
> Intel machine for that matter, right?
I'm not privy to AMD's CPU design plans.
However I think for the ssl/ssh case you'd use the same interfaces
curr
> These results for Toeplitz are not plausible. Given random input you
> cannot expect any hash function to produce such uniform results. I
> suspect either your input data is biased or how your applying the hash
> is.
>
> When I run 64 random IPv4 3-tuples through Toeplitz and Jenkins I get
> som
On Mon, 01 Feb 2016 11:33 +0100
Arnd Bergmann wrote:
> The goldfish nand driver divides a signed 64-bit number (loff_t)
> in multiple places using the do_div() function. This has always
> been unreliable but now produces a compiler warning (since 4.5-rc1):
>
> goldfish/goldfish_nand.c: In functi
On Mon, 01 Feb 2016 11:33 +0100
Arnd Bergmann wrote:
> The goldfish nand driver divides a signed 64-bit number (loff_t)
> in multiple places using the do_div() function. This has always
> been unreliable but now produces a compiler warning (since 4.5-rc1):
>
> goldfish/goldfish_nand.c: In functi
On Fri, 12 Jun 2015 13:43:27 -0700
Greg KH wrote:
> On Fri, Jun 12, 2015 at 10:20:38PM +0200, julien.de...@gmail.com wrote:
> > From: Julien Dehee
> >
> > comedi/comedi_fops.c
> > use ENODEV following open manual
That should probably be ENXIO by a strict reading, but Linux has always
used
On Thu, 15 Jan 2015 22:54:46 +0200
Pantelis Antoniou wrote:
> Hi Alan,
>
> > On Jan 15, 2015, at 22:45 , One Thousand Gnomes
> > wrote:
> >
> > On Thu, 15 Jan 2015 11:47:26 -0700
> > Jason Gunthorpe wrote:
> >> It is a novel idea, my concern wo
On Wed, 4 Dec 2013 10:35:54 -0800
Greg KH wrote:
> On Wed, Dec 04, 2013 at 06:09:41PM +, Serban Constantinescu wrote:
> > +#define size_helper(x) ({ \
> > + size_t __size; \
> > + if (!is_com
> None of this (the patch series or the original code) is mine. My
Sorry mistraced the attribution sequence
> question was more of a general one on designing ioctls, as well as
> concerns with changing the existing 32-bit api.
I think in general my advice would be:
If its already been screwed
On Wed, 3 Sep 2014 13:13:44 +0200
Loic Pefferkorn wrote:
> Coding style: document spinlock usage
>
> Signed-off-by: Loic Pefferkorn
> ---
> drivers/staging/goldfish/goldfish_audio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/goldfish/goldfish_aud
> Do we really need someone to do more work that has been done on it in
> the past as an official "maintainer"? I'll be glad to do it, as I doubt
> it will require any time at all.
Well every time in the past that Al Viro looked in its direction he broke
it so probably. Someone is going to have t
On Tue, 21 Oct 2014 13:49:00 +0200
Matej Mužila wrote:
> From: Matej Mužila
>
> Check if cpmsg->size is in limits of DATA_FRAGMENT
>
> Signed-off-by: Matej Mužila
> Acked-by: K. Y. Srinivasan
> ---
> If corrupted data are read from /dev/vmbus/hv_fcopy, pwrite can
> read from memory outside
On Wed, 23 Jul 2014 08:16:39 +0200
Robin Schroer wrote:
> Fix a pointer check to use NULL instead of 0
>
> Warning:
> drivers/staging/goldfish/goldfish_audio.c:300:34: warning: Using plain
> integer as NULL pointer
>
> Signed-off-by: Robin Schroer
Acked-by: Alan Cox
36 matches
Mail list logo
