[PATCH 7/8] staging/lustre: release MGC device if connect fails

2016-08-23 Thread Oleg Drokin
.intel.com/browse/LU-8297 Reviewed-by: Andreas Dilger Reviewed-by: Mike Pershin Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/obdclass/obd_mount.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/obdclass/obd_mount.c b/drivers/stag

[PATCH 2/8] staging/lustre/mdc: fix panic at mdc_free_open()

2016-08-23 Thread Oleg Drokin
wed-on: http://review.whamcloud.com/17495 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5282 Reviewed-by: Alex Zhuravlev Reviewed-by: Andreas Dilger Signed-off-by: Oleg Drokin --- .../staging/lustre/lustre/include/obd_support.h| 1 + drivers/staging/lustre/lustre/mdc/mdc_request.c| 50 +

[PATCH 8/8] staging/lustre/o2iblnd: handle mixed page size configurations.

2016-08-23 Thread Oleg Drokin
Weber Signed-off-by: Oleg Drokin --- .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c| 14 +++--- .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h| 13 ++--- .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c | 55 ++ 3 files changed, 41 insertions(+), 41 deletions

Re: [PATCH 2/8] staging/lustre/mdc: fix panic at mdc_free_open()

2016-08-23 Thread Oleg Drokin
Actually, please do not apply this one, there was a testing error that made me not noticing there's a bug in this one that insta-crashes everything on access. I tested the rest nd the rest are good without this one too. Sorry about this. On Aug 23, 2016, at 5:11 PM, Oleg Drokin wrote: &

[PATCH v2 4/8] staging/lustre/llite: check return value for obd_set_info_async

2016-08-24 Thread Oleg Drokin
Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/llite_lib.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/staging/lustre/lustre/llite/llite_lib.c b/drivers/staging/lustre/lustre/llite/llite_lib.c index 72ff7c4..1ff788e 100644 --- a/drivers/staging/lustre

[PATCH v2 0/8] Lustre fixes

2016-08-24 Thread Oleg Drokin
Here are some more recent Lustre fixes and a cleanup. This resend fixes the "fix panic at mdc_free_open()" patch to actually work. Please consider. Alexander Boyko (1): staging/lustre/mdc: fix panic at mdc_free_open() Andrew Perepechko (1): staging/lustre: avoid clearing i_nlink for inodes

[PATCH v2 7/8] staging/lustre: release MGC device if connect fails

2016-08-24 Thread Oleg Drokin
.intel.com/browse/LU-8297 Reviewed-by: Andreas Dilger Reviewed-by: Mike Pershin Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/obdclass/obd_mount.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/obdclass/obd_mount.c b/drivers/stag

[PATCH v2 2/8] staging/lustre/mdc: fix panic at mdc_free_open()

2016-08-24 Thread Oleg Drokin
wed-on: http://review.whamcloud.com/17495 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5282 Reviewed-by: Alex Zhuravlev Reviewed-by: Andreas Dilger Signed-off-by: Oleg Drokin --- .../staging/lustre/lustre/include/obd_support.h| 1 + drivers/staging/lustre/lustre/mdc/mdc_request.c| 56 +

[PATCH v2 3/8] staging/lustre: avoid clearing i_nlink for inodes in use

2016-08-24 Thread Oleg Drokin
wrong i_nlink value into st_nlink Signed-off-by: Andrew Perepechko Seagate-bug-id: MRP-3271 Reviewed-on: http://review.whamcloud.com/19164 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7925 Reviewed-by: Wally Wang Reviewed-by: Lai Siyao Signed-off-by: Oleg Drokin --- drivers/staging

[PATCH v2 5/8] staging/lustre/llite: Fix suspicious dereference of pointer 'vma->vm_file'

2016-08-24 Thread Oleg Drokin
L. Hammond Reviewed-by: Bob Glossman Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/llite_mmap.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/llite/llite_mmap.c b/drivers/staging/lustre/lustre/llite/llite_mmap.c index 9d03e79..37f82ed 1

[PATCH v2 8/8] staging/lustre/o2iblnd: handle mixed page size configurations.

2016-08-24 Thread Oleg Drokin
Weber Signed-off-by: Oleg Drokin --- .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c| 14 +++--- .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h| 13 ++--- .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c | 55 ++ 3 files changed, 41 insertions(+), 41 deletions

[PATCH v2 6/8] staging/lustre/llite: changes to avoid cache corruption

2016-08-24 Thread Oleg Drokin
: Ashish Purkar Reviewed-by: Andrew Perepechko Tested-by: Parinay Vijayprakash Kondekar Reviewed-on: http://review.whamcloud.com/17732 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7613 Reviewed-by: Niu Yawei Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/namei.c | 3

[PATCH v2 1/8] staging/lustre: const correct set_lock_data()

2016-08-24 Thread Oleg Drokin
ago Reviewed-by: James Simmons Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/obd.h | 3 ++- drivers/staging/lustre/lustre/include/obd_class.h| 3 ++- drivers/staging/lustre/lustre/llite/file.c | 2 +- drivers/staging/lustre/lustre/llite/llite_i

[PATCH] staging/lustre: Fix max_dirty_mb output in sysfs

2016-08-25 Thread Oleg Drokin
%ul definitely was supposed to be %lu in the format string, so we print long unsigned int value, not just unsigned int with a letter l added at the end. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c | 5 +++-- 1 file changed, 3 insertions(+), 2

Re: [PATCH] staging/lustre: avoid zero buf for the first time

2016-08-26 Thread Oleg Drokin
Hello! On Aug 22, 2016, at 6:04 AM, Greg Kroah-Hartman wrote: > On Mon, Aug 22, 2016 at 04:46:04PM +0800, Shawn Lin wrote: >> We only need to zero it when repeating in order to >> avoid old garbage. Let's improve it by moving this >> before we repeat the calculation to save some cpu >> cycle. >>

[PATCH] staging/lustre/llite: Move unstable_stats from sysfs to debugfs

2016-10-16 Thread Oleg Drokin
It's multiple values per file, so it has no business being in sysfs, besides it was assuming seqfile anyway. Introduced by commit d806f30e639b ("staging: lustre: osc: revise unstable pages accounting") Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/lpr

Re: [PATCH 57/80] staging: lustre: osc: revise unstable pages accounting

2016-10-16 Thread Oleg Drokin
t;> Reviewed-on: http://review.whamcloud.com/10003 >> Reviewed-by: Andreas Dilger >> Reviewed-by: Lai Siyao >> Reviewed-by: Oleg Drokin >> Signed-off-by: James Simmons >> --- >> drivers/staging/lustre/lustre/include/cl_object.h | 35 +++- >> .../st

[PATCH 00/14] Lustre fixes

2016-11-02 Thread Oleg Drokin
re/ldlm: engage ELC for all ldlm enqueue req Jinshan Xiong (2): staging/lustre: Get rid of cl_env hash table staging/lustre/llite: do not clear uptodate bit in page delete Niu Yawei (1): staging/lustre/llite: clear inode timestamps after losing UPDATE lock Oleg Drokin (3): staging/lust

[PATCH 01/14] staging/lustre/ldlm: Drop unused blocking_refs flock field

2016-11-02 Thread Oleg Drokin
blocking_refs is only used on the server, so drop it on the client. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_dlm.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/include/lustre_dlm.h b/drivers/staging/lustre/lustre/include

[PATCH 03/14] staging/lustre: conflicting PW & PR extent locks on a client

2016-11-02 Thread Oleg Drokin
-id: https://jira.hpdd.intel.com/browse/LU-8175 Reviewed-by: Jinshan Xiong Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/obd_support.h | 3 +++ drivers/staging/lustre/lustre/ldlm/ldlm_extent.c| 20 drivers/staging/lustre/lustre/ldlm/ldlm_request.c | 4 ++-

[PATCH 02/14] staging/lustre/ldlm: fix export reference problem

2016-11-02 Thread Oleg Drokin
http://review.whamcloud.com/22031 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8500 Reviewed-by: James Simmons Reviewed-by: Bobi Jam Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ldlm/ldlm_lib.c | 3 +++ drivers/staging/lustre/lustre/ptlrpc/import.c | 19 ++- 2 files ch

[PATCH 04/14] staging/lustre/llite: clear inode timestamps after losing UPDATE lock

2016-11-02 Thread Oleg Drokin
://jira.hpdd.intel.com/browse/LU-8446 Reviewed-by: Bobi Jam Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/namei.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/staging/lustre/lustre/llite/namei.c b/drivers/staging/lustre/lustre/llite/namei.c index 74d9b73..c268f32

[PATCH 06/14] staging/lustre/llite: drop_caches hangs in cl_inode_fini()

2016-11-02 Thread Oleg Drokin
: http://review.whamcloud.com/22745 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8509 Reviewed-by: Jinshan Xiong Reviewed-by: Bobi Jam Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/rw26.c | 36 -- 1 file changed, 19 insertions(+), 17

[PATCH 05/14] staging/lustre: Get rid of cl_env hash table

2016-11-02 Thread Oleg Drokin
-off-by: Jinshan Xiong Reviewed-on: http://review.whamcloud.com/20254 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4257 Reviewed-by: Andreas Dilger Reviewed-by: Bobi Jam Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/cl_object.h | 22 -- drivers/staging/lustre

[PATCH 08/14] staging/lustre/ldlm: engage ELC for all ldlm enqueue req

2016-11-02 Thread Oleg Drokin
: Hongchao Zhang Reviewed-on: http://review.whamcloud.com/21739 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8209 Reviewed-by: Andreas Dilger Reviewed-by: Vitaly Fertman Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ldlm/ldlm_request.c | 21 - 1 file changed

[PATCH 07/14] staging/lustre/ldlm: Reinstate ldlm_enqueue_pack()

2016-11-02 Thread Oleg Drokin
The function becomes used again with the next patch, so bring it back from dead, only this time make it static. Reverts: bf2a033360f7 ("staging/lustre/ldlm: Remove unused ldlm_enqueue_pack()") Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ldlm/ldlm_requ

[PATCH 10/14] staging/lustre/llite: protect from accessing NULL lli_clob

2016-11-02 Thread Oleg Drokin
From: Bobi Jam Need to check file's lli_clob object before calling lov_read_and_clear_async_rc(). Signed-off-by: Bobi Jam Reviewed-by: Jinshan Xiong Reviewed-by: Oleg Drokin Reviewed-on: http://review.whamcloud.com/23031 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8682 Signed-o

[PATCH 14/14] staging/lustre: Get rid of LIBLUSTRE_CLIENT and its users

2016-11-02 Thread Oleg Drokin
This define only made sense in a userspace library client, not in the kernel. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_lib.h | 2 -- drivers/staging/lustre/lustre/ldlm/ldlm_request.c | 15 +-- 2 files changed, 1 insertion(+), 16 deletions

[PATCH 11/14] staging/lustre/ptlrpc: Correctly calculate hrp->hrp_nthrs

2016-11-02 Thread Oleg Drokin
8492 Reviewed-by: Liang Zhen Reviewed-by: Doug Oucharek Reviewed-by: James Simmons Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ptlrpc/service.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/ptlrpc/service.c b/drivers/stagi

[PATCH 12/14] staging/lustre/llite: update ras window correctly

2016-11-02 Thread Oleg Drokin
window length later, the presumption does not hold. This patch resets the stride IO as well in this case. Signed-off-by: Bobi Jam Reviewed-on: http://review.whamcloud.com/23032 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8683 Reviewed-by: wangdi Reviewed-by: Jinshan Xiong Signed-off-by: Oleg

[PATCH 09/14] staging/lustre/ptlrpc: Suppress error for flock requests

2016-11-02 Thread Oleg Drokin
viewed-on: http://review.whamcloud.com/22856 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8658 Reviewed-by: Andreas Dilger Reviewed-by: Bob Glossman Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ptlrpc/client.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/

[PATCH 13/14] staging/lustre/llite: do not clear uptodate bit in page delete

2016-11-02 Thread Oleg Drokin
ine doesn't make the same assumption. Signed-off-by: Jinshan Xiong Reviewed-on: http://review.whamcloud.com/22827 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8633 Reviewed-by: Li Dongyang Reviewed-by: Bobi Jam Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/vvp_page

Re: [PATCH 2/2] staging: lustre: obdclass: Add handling of error returned by lustre_cfg_new

2016-11-06 Thread Oleg Drokin
Hello! On Nov 6, 2016, at 12:11 PM, Christophe JAILLET wrote: > 'lustre_cfg_new()' can return ERR_PTR(-ENOMEM). > Handle these errors and propagate the error code to the callers. > > Error handling has been rearranged in 'lustre_process_log()' with the > addition of a label in order to free some

Re: [lustre-devel] [PATCH 1/2] staging: lustre: replace uses of class_devno_max by MAX_OBD_DEVICES

2016-11-06 Thread Oleg Drokin
On Nov 4, 2016, at 4:37 AM, Aya Mahfouz wrote: > > On Thu, Nov 3, 2016 at 1:05 AM, Dilger, Andreas > wrote: > On Oct 25, 2016, at 10:47, Aya Mahfouz wrote: > > > > On Mon, Oct 17, 2016 at 10:38:31PM +, Dilger, Andreas wrote: > >> On Oct 17, 2016, at 15:46, Aya Mahfouz > >> wrote: > >>>

Re: [PATCH 2/2] staging: lustre: obdclass: Add handling of error returned by lustre_cfg_new

2016-11-07 Thread Oleg Drokin
On Nov 7, 2016, at 4:33 PM, Dilger, Andreas wrote: > On Nov 6, 2016, at 10:26, Drokin, Oleg wrote: >> >> Hello! >> >> On Nov 6, 2016, at 12:11 PM, Christophe JAILLET wrote: >> >>> 'lustre_cfg_new()' can return ERR_PTR(-ENOMEM). >>> Handle these errors and propagate the error code to the calle

[PATCH 0/2] Lustre fixes

2016-11-16 Thread Oleg Drokin
With multiple metadata RPCs code in now, these two fixes become important. Please consider. Niu Yawei (2): staging/lustre/ptlrpc: track unreplied requests staging/lustre/ptlrpc: update imp_known_replied_xid on resend-replay .../staging/lustre/lustre/include/lustre_import.h | 5 + drivers

[PATCH 1/2] staging/lustre/ptlrpc: track unreplied requests

2016-11-16 Thread Oleg Drokin
make sure the known replied XID is increased only on both server & client side. Signed-off-by: Niu Yawei Reviewed-on: http://review.whamcloud.com/16759 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5951 Reviewed-by: Gregoire Pichon Reviewed-by: Alex Zhuravlev Signed-off-by: Ole

[PATCH 2/2] staging/lustre/ptlrpc: update imp_known_replied_xid on resend-replay

2016-11-16 Thread Oleg Drokin
://jira.hpdd.intel.com/browse/LU-8645 Reviewed-by: Alex Zhuravlev Reviewed-by: Fan Yong Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ptlrpc/recover.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/ptlrpc/recover.c b/drivers

[PATCH] staging/lustre: Use proper number of bytes in copy_from_user

2016-11-20 Thread Oleg Drokin
Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c index 8a2f02f3

Re: [PATCH] stating: lustre: fix sparse error: incompatible types in comparison expression

2017-07-12 Thread Oleg Drokin
eturn -EFAULT; > > - if (tmp.next == head_up) > - return 0; > - > next = tmp.next; So the assignment is fine, but comparison is not? Strange. I guess this is fine by me if that makes the warning go away. Acked-by: Oleg Drokin

Re: [PATCH] staging: lustre: fix spelling mistake, "grranted" -> "granted"

2017-07-14 Thread Oleg Drokin
On Jul 14, 2017, at 9:26 AM, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in CERROR error message > > Signed-off-by: Colin Ian King > --- > drivers/staging/lustre/lustre/ptlrpc/import.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dr

Re: [PATCH][V2] staging: lustre: fix spelling mistake, "grranted" -> "granted"

2017-07-14 Thread Oleg Drokin
On Jul 14, 2017, at 5:33 PM, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in CERROR error message. Also > clean up the grammar. > > Signed-off-by: Colin Ian King Reviewed-by: Oleg Drokin > --- > drivers/staging/lustre/lustre/ptlrpc/

Re: [PATCH 66/73] staging/lustre: remove lots of dead code

2015-09-28 Thread Oleg Drokin
On Sep 28, 2015, at 10:08 PM, Greg Kroah-Hartman wrote: > On Mon, Sep 28, 2015 at 11:36:01AM +0200, Arnd Bergmann wrote: >> On Sunday 27 September 2015 16:46:06 gr...@linuxhacker.ru wrote: >>> From: Oleg Drokin >>> >>> This is a large patch to remove all de

[PATCH 5/5] lustre: add myself to list of people to CC on lustre patches

2014-01-23 Thread Oleg Drokin
Signed-off-by: Oleg Drokin --- drivers/staging/lustre/TODO | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/TODO b/drivers/staging/lustre/TODO index 22742d6..0a2b6cb 100644 --- a/drivers/staging/lustre/TODO +++ b/drivers/staging/lustre/TODO @@ -9,5

[PATCH 2/5] staging/lustre/lnet: Fix use after free in ksocknal_send

2014-01-23 Thread Oleg Drokin
Signed-off-by: Oleg Drokin Reviewed-on: http://review.whamcloud.com/8667 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4360 Reviewed-by: Liang Zhen Reviewed-by: Amir Shehata --- drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c | 5 +++-- 1 file changed, 3 insertions(+), 2 d

[PATCH 0/5] Lustre fixes from my testing

2014-01-23 Thread Oleg Drokin
, obviously. Also adding myself as one of the people who others would hopefully CC all lustre patches to. Please consider. Oleg Drokin (5): staging/lustre: fix compile warning with is_vmalloc_addr staging/lustre/lnet: Fix use after free in ksocknal_send lustre: Account for changelog_ext_rec

[PATCH 1/5] staging/lustre: fix compile warning with is_vmalloc_addr

2014-01-23 Thread Oleg Drokin
:41: include/linux/mm.h:336:59: note: expected ‘const void *’ but argument is of type ‘long unsigned int’ static inline int is_vmalloc_addr(const void *x) Signed-off-by: Oleg Drokin CC: Laura Abbott --- drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c | 2 +- 1 file changed, 1 insertion

[PATCH 4/5] lustre: Correct KUC code max changelog msg size

2014-01-23 Thread Oleg Drokin
, KUC_CHANGELOG_MSG_MAXSIZE. Signed-off-by: Christopher J. Morrone Reviewed-on: http://review.whamcloud.com/7406 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3587 Reviewed-by: Andreas Dilger Reviewed-by: jacques-Charles Lafoucriere Reviewed-by: Oleg Drokin Signed-off-by: Oleg Drokin --- drivers/staging

[PATCH 3/5] lustre: Account for changelog_ext_rec in CR_MAXSIZE

2014-01-23 Thread Oleg Drokin
trip an assertion. Signed-off-by: Christopher J. Morrone Reviewed-on: http://review.whamcloud.com/6993 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3587 Reviewed-by: Niu Yawei Reviewed-by: Lai Siyao Reviewed-by: Oleg Drokin Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre

Re: [PATCH 5/5] lustre: add myself to list of people to CC on lustre patches

2014-01-23 Thread Oleg Drokin
Hello! > +STAGING - LUSTRE > +M: Andreas Dilger > +M: Oleg Drokin > +M: Peng Tao . > +L: hpdd-discuss > +S: Odd Fixes Actually we are at least Maintained here, if not outright Supported. Bye, Oleg ___ dev

Re: [PATCH 5/5] lustre: add myself to list of people to CC on lustre patches

2014-01-24 Thread Oleg Drokin
Hello! On Jan 24, 2014, at 3:55 AM, Geert Uytterhoeven wrote: > On Fri, Jan 24, 2014 at 6:51 AM, Oleg Drokin wrote: >>> +STAGING - LUSTRE >>> +M: Andreas Dilger >>> +M: Oleg Drokin >>> +M: Peng Tao . >>> +L: hpdd-discuss >>> +

Re: [PATCH 41/47] staging/lustre/llite: remove dead code

2014-04-29 Thread Oleg Drokin
Hello! On Apr 29, 2014, at 7:02 AM, Dan Carpenter wrote: >> diff --git a/drivers/staging/lustre/lustre/llite/statahead.c >> b/drivers/staging/lustre/lustre/llite/statahead.c >> index 51c5327..1b47774 100644 >> --- a/drivers/staging/lustre/lustre/llite/statahead.c >> +++ b/drivers/staging/lustre/

Re: [PATCH 11/47] staging/lustre/ptlrpc: add rpc_cache

2014-04-29 Thread Oleg Drokin
Hello! On Apr 29, 2014, at 5:46 AM, Dan Carpenter wrote: >> >> +/* Fall through */ >> case 7: >> sptlrpc_fini(); >> -case 5: >> +/* Fall through */ >> +case 6: >> ldlm_exit(); >> -case 4: >> +/* Fall through */ >> +

Re: [PATCH 18/47] staging/lustre/hsm: HSM requests not delivered

2014-04-29 Thread Oleg Drokin
On Apr 29, 2014, at 5:08 AM, Dan Carpenter wrote: > On Sun, Apr 27, 2014 at 01:06:42PM -0400, Oleg Drokin wrote: >> diff --git a/drivers/staging/lustre/lustre/llite/dir.c >> b/drivers/staging/lustre/lustre/llite/dir.c >> index 7fbc18e..c391b60 100644 >> --- a/drivers/

Re: [PATCH] staging/lustre: Replace jobid acquiring with per node setting

2014-05-03 Thread Oleg Drokin
On May 3, 2014, at 7:29 PM, Greg Kroah-Hartman wrote: > On Sun, Apr 27, 2014 at 10:21:52PM -0400, Oleg Drokin wrote: >> Insted of meddling directly in process environment variables >> (which is also not possible on certain platforms due to not exported >> symbols), create jo

[PATCH] sysctl: Fix division by zero in percpu_pagelist_fraction handler

2014-05-03 Thread Oleg Drokin
<48> f7 f1 ba 01 00 00 00 49 89 c5 48 c1 e8 02 48 85 c0 48 0f 44 Signed-off-by: Oleg Drokin CC: Rohit Seth --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 5dba293..91d0265 100644 --- a/mm/page_alloc.c ++

Re: [PATCH] staging/lustre: Replace jobid acquiring with per node setting

2014-05-03 Thread Oleg Drokin
Hello! On May 3, 2014, at 10:33 PM, Greg Kroah-Hartman wrote: >> I don't think I saw complaints about proc files, the complaints I saw were >> mostly about >> reading env variables directly and the like so that was the focus of this >> patch. >> Did I miss some side discussion? Any pointers? > N

Re: [PATCH] sysctl: Fix division by zero in percpu_pagelist_fraction handler

2014-06-02 Thread Oleg Drokin
Hello! On Jun 2, 2014, at 9:40 PM, David Rientjes wrote: >> diff --git a/mm/page_alloc.c b/mm/page_alloc.c >> index 5dba293..91d0265 100644 >> --- a/mm/page_alloc.c >> +++ b/mm/page_alloc.c >> @@ -5854,7 +5854,7 @@ int percpu_pagelist_fraction_sysctl_handler(ctl_table >> *table, int write, >>

Re: [PATCH] sysctl: Fix division by zero in percpu_pagelist_fraction handler

2014-06-02 Thread Oleg Drokin
Hello! On Jun 2, 2014, at 11:57 PM, David Rientjes wrote: > I'm pretty sure we want to allow users to restore the kernel default > behavior if they've already written to this file and now want to change it > back. > > What do you think about doing it like this instead? > --- > Documentation/sys

Re: [patch] mm, pcp: allow restoring percpu_pagelist_fraction default

2014-06-03 Thread Oleg Drokin
Hello! On Jun 3, 2014, at 9:22 PM, David Rientjes wrote: > > @@ -5849,21 +5850,32 @@ int lowmem_reserve_ratio_sysctl_handler(ctl_table > *table, int write, > int percpu_pagelist_fraction_sysctl_handler(ctl_table *table, int write, > void __user *buffer, size_t *length, loff_t *ppos) > { >

Re: [patch v2] mm, pcp: allow restoring percpu_pagelist_fraction default

2014-06-04 Thread Oleg Drokin
Hello! On Jun 4, 2014, at 8:34 PM, David Rientjes wrote: > @@ -5850,23 +5851,39 @@ int percpu_pagelist_fraction_sysctl_handler(ctl_table > *table, int write, > void __user *buffer, size_t *length, loff_t *ppos) > { > struct zone *zone; > - unsigned int cpu; > + int old_percpu_

[PATCH 03/18] staging/lustre/llite: Only kill SGID/SUID bits

2014-06-22 Thread Oleg Drokin
Reviewed-by: Andreas Dilger Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/llite_lib.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/llite/llite_lib.c b/drivers/staging/lustre/lustre/llite/llite_lib.c index deca27e

[PATCH 05/18] staging/lustre/ptlrpc: fix NULL pointer dereference of {exp, imp}_obd

2014-06-22 Thread Oleg Drokin
Eremin Reviewed-on: http://review.whamcloud.com/10062 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629 Reviewed-by: John L. Hammond Reviewed-by: Mike Pershin Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ptlrpc/niobuf.c | 7 +++ drivers/staging/lustre/lustre/ptlrpc/se

[PATCH 01/18] staging/lustre/libcfs: revert changes to libcfs_sock_ioctl

2014-06-22 Thread Oleg Drokin
: Oleg Drokin CC: Fredrick John Berchmans --- .../lustre/lustre/libcfs/linux/linux-tcpip.c| 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linux-tcpip.c b/drivers/staging/lustre/lustre/libcfs/linux/linux

[PATCH 00/18] Lustre fixes

2014-06-22 Thread Oleg Drokin
d Li Xi (1): staging/lustre/llite: fix a flag bug of vvp_io_kernel_fault() Nathaniel Clark (1): staging/lustre/llite: Only kill SGID/SUID bits Oleg Drokin (2): staging/lustre/libcfs: revert changes to libcfs_sock_ioctl staging/lustre/ptlrpc: Protect request buffer changing Patrick Farrell (1

[PATCH 09/18] staging/lustre/mgc: replace hard-coded MGC_ENQUEUE_LIMIT value

2014-06-22 Thread Oleg Drokin
Reviewed-by: Ryan Haasken Reviewed-by: Dmitry Eremin Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/mgc/mgc_request.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/mgc/mgc_request.c b/drivers/staging/lustre/lustre/mgc

[PATCH 07/18] staging/lustre/osc: get rid of old checksum initial value

2014-06-22 Thread Oleg Drokin
/browse/LU-4937 Reviewed-by: Andreas Dilger Reviewed-by: Bob Glossman Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/osc/osc_request.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/lustre/lustre/osc/osc_request.c b/drivers/staging/lustre

[PATCH 06/18] staging/lustre/mgc: mgc import reconnect race

2014-06-22 Thread Oleg Drokin
967 Xyratex-bug-id: MRP-1746 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4913 Reviewed-by: Mike Pershin Reviewed-by: Lai Siyao Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/obdclass/obd_mount.c | 13 ++- drivers/staging/lustre/lustre/ptlrpc/

[PATCH 04/18] staging/lustre: fix frong ldlm flags type used

2014-06-22 Thread Oleg Drokin
From: Dmitry Eremin Fixed implicit conversion from 'unsigned long long' to 'int'. Signed-off-by: Dmitry Eremin Reviewed-on: http://review.whamcloud.com/7799 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4023 Reviewed-by: Andreas Dilger Signed-off-by: Oleg Drokin

[PATCH 02/18] staging/lustre/ptlrpc: Protect request buffer changing

2014-06-22 Thread Oleg Drokin
to this request under imp_lock, take imp_lock to protect against them in *_enlarge_reqbuf Signed-off-by: Oleg Drokin Reviewed-on: http://review.whamcloud.com/10074 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU- Reviewed-by: Mike Pershin Reviewed-by: Andreas Dilger --- drivers/stagin

[PATCH 08/18] staging/lustre/ptlrpc: race at req processing

2014-06-22 Thread Oleg Drokin
6 Reviewed-by: Andreas Dilger Reviewed-by: Mike Pershin Reviewed-by: Chris Horn Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ptlrpc/client.c | 11 ++- drivers/staging/lustre/lustre/ptlrpc/events.c | 2 ++ drivers/staging/lustre/lustre/ptlrpc/niobuf.c | 2 ++ 3 file

[PATCH 13/18] staging/lustre/llite: Fix uninitialized variable

2014-06-22 Thread Oleg Drokin
p://review.whamcloud.com/10663 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629 Reviewed-by: Andreas Dilger Reviewed-by: James Simmons Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/xattr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/lustre/l

[PATCH 14/18] staging/lustre/ptlrpc: unlink request buffer correctly

2014-06-22 Thread Oleg Drokin
-id: https://jira.hpdd.intel.com/browse/LU-5073 Reviewed-by: Mike Pershin Reviewed-by: Liang Zhen Reviewed-by: Isaac Huang Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_net.h | 6 -- drivers/staging/lustre/lustre/ptlrpc/client.c | 11 ++- drivers/stag

[PATCH 15/18] staging/lustre/obdclass: runtime load lustre client when needed

2014-06-22 Thread Oleg Drokin
ohn L. Hammond Reviewed-by: James Simmons Reviewed-by: Yang Sheng Reviewed-by: Andreas Dilger Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/obdclass/obd_mount.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/obdclass/obd_mount

[PATCH 17/18] staging/lustre/llite: fix a flag bug of vvp_io_kernel_fault()

2014-06-22 Thread Oleg Drokin
From: Li Xi After vvp_io_kernel_fault() locked the page, it should set VM_FAULT_LOCKED. Signed-off-by: Li Xi Reviewed-on: http://review.whamcloud.com/10740 Reviewed-by: Jinshan Xiong Reviewed-by: Emoly Liu Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/vvp_io.c | 2

[PATCH 18/18] staging/lustre/lnet: abort messages whose MD has been unlinked

2014-06-22 Thread Oleg Drokin
Reviewed-by: Doug Oucharek Signed-off-by: Oleg Drokin --- .../staging/lustre/include/linux/lnet/lib-types.h | 1 + drivers/staging/lustre/lnet/lnet/lib-md.c | 10 ++--- drivers/staging/lustre/lnet/lnet/lib-me.c | 11 ++--- drivers/staging/lustre/lnet/lnet/lib-move.c| 49

[PATCH 16/18] staging/lustre/vvp: release mmap_sem in error case

2014-06-22 Thread Oleg Drokin
://jira.hpdd.intel.com/browse/LU-5221 Reviewed-by: Andreas Dilger Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/vvp_io.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/llite/vvp_io.c b/drivers/staging/lustre/lustre/llite/vvp_io.c index

[PATCH 11/18] staging/lustre/obdclass: Fix uninitialized variables

2014-06-22 Thread Oleg Drokin
.com/10613 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629 Reviewed-by: James Simmons Reviewed-by: John L. Hammond Reviewed-by: Andreas Dilger Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/obdclass/capa.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/lu

[PATCH 10/18] staging/lustre/ptlrpc: Add schedule point to ptlrpc_check_set()

2014-06-22 Thread Oleg Drokin
times) of cycles through the loop before a resched is allowed. Signed-off-by: Christopher J. Morrone Reviewed-on: http://review.whamcloud.com/10358 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5053 Reviewed-by: Liang Zhen Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ptlrp

[PATCH 12/18] staging/lustre/osc: osc_extent_truncate()) ASSERTION( !ext->oe_urgent ) failed

2014-06-22 Thread Oleg Drokin
r OES_INV. osc_cache_truncate_end() will set oe_urgent and call osc_io_unplug_async() Signed-off-by: Andriy Skulysh Reviewed-on: http://review.whamcloud.com/10204 Xyratex-bug-id: LELUS-239 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4852 Reviewed-by: Jinshan Xiong Signed-off-by: Ol

[PATCH 1/4] staging/lustre/obdclass: remove unused file md_attrs.c

2014-08-28 Thread Oleg Drokin
It's only used by server side luster for on-disk structure swabbing. And also remove forward declarations for its functions from md_object.h and lustre_idl.h Signed-off-by: Oleg Drokin --- .../lustre/lustre/include/lustre/lustre_idl.h | 6 - drivers/staging/lustre/lustre/in

[PATCH 3/4] staging/lustre/obdclass: remove unused file linkea.c

2014-08-28 Thread Oleg Drokin
Also unused header file lustre_linkea.h Signed-off-by: Oleg Drokin --- .../staging/lustre/lustre/include/lustre_linkea.h | 57 -- drivers/staging/lustre/lustre/obdclass/linkea.c| 194 - 2 files changed, 251 deletions(-) delete mode 100644 drivers/staging/lustre

[PATCH 0/4] Remove unused lustre files

2014-08-28 Thread Oleg Drokin
. Please consider for inclusion. Oleg Drokin (4): staging/lustre/obdclass: remove unused file md_attrs.c staging/lustre/obdclass: remove unused file llog_lvfs.c staging/lustre/obdclass: remove unused file linkea.c staging/lustre: remove unused request policies. .../lustre/lustre/include

[PATCH 4/4] staging/lustre: remove unused request policies.

2014-08-28 Thread Oleg Drokin
Client policies do not make much sense to have in client-only code, so remove all references to everything but fifo. This also removes lustre/libcfs/heap.c and its header, since it was only used by certain request policies (crr and orr). Signed-off-by: Oleg Drokin --- drivers/staging/lustre

[PATCH 2/4] staging/lustre/obdclass: remove unused file llog_lvfs.c

2014-08-28 Thread Oleg Drokin
This contains server-side llog operations. Also remove declaration of public structure from lustre_log.h Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_log.h | 3 - drivers/staging/lustre/lustre/obdclass/llog_lvfs.c | 847 - 2 files changed

[PATCH 05/12] staging/lustre/obdclass: remove lu_ucred.c

2014-08-30 Thread Oleg Drokin
From: "John L. Hammond" The functions exported by lustre/obdclass/lu_ucred.c are not used so remove that file. Signed-off-by: John L. Hammond --- drivers/staging/lustre/lustre/obdclass/Makefile | 3 +- drivers/staging/lustre/lustre/obdclass/lu_ucred.c | 107 -- 2 files

[PATCH 04/12] staging/lustre/obdclass: remove idmap.c

2014-08-30 Thread Oleg Drokin
From: "John L. Hammond" The functions defined in lustre/include/lustre_idmap.h are not used so remove them. Signed-off-by: John L. Hammond Signed-off-by: Oleg Drokin --- .../staging/lustre/lustre/include/lustre_idmap.h | 104 - drivers/staging/lustre/lustre/obdclass/Makefil

[PATCH 06/12] staging/lustre/obdclass: remove mea.c

2014-08-30 Thread Oleg Drokin
From: "John L. Hammond" The functions exported by lustre/obdclass/mea.c are not used so remove them. Signed-off-by: John L. Hammond --- drivers/staging/lustre/lustre/include/obd_class.h | 4 - drivers/staging/lustre/lustre/obdclass/Makefile | 2 +- drivers/staging/lustre/lustre/obdclass/

[PATCH 01/12] staging/lustre: Remove unused header libcfs_heap.h

2014-08-30 Thread Oleg Drokin
With removal of libcfs/heap.c, it's header can also go away now. Signed-off-by: Oleg Drokin --- .../staging/lustre/include/linux/libcfs/libcfs.h | 1 - .../lustre/include/linux/libcfs/libcfs_heap.h | 200 - drivers/staging/lustre/lustre/include/lustre_net.h

[PATCH 03/12] staging/lustre/obdecho: remove #if 0-ed out regions

2014-08-30 Thread Oleg Drokin
Reviewed-by: Andreas Dilger Reviewed-by: Oleg Drokin --- .../staging/lustre/lustre/obdecho/echo_client.c| 50 -- 1 file changed, 50 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdecho/echo_client.c b/drivers/staging/lustre/lustre/obdecho/echo_client.c ind

[PATCH 00/12] lustre: continues dead code removal

2014-08-30 Thread Oleg Drokin
: remove md_object.h staging/lustre/mgc: remove server specific handlers staging/lustre/obdclass: remove llog_test.ko staging/lustre/obdclass: remove llog_osd.c staging/lustre/mdc: remove obsolete llog ioctl handlers Oleg Drokin (2): staging/lustre: Remove unused header libcfs_heap.h

[PATCH 08/12] staging/lustre/mgc: remove server specific handlers

2014-08-30 Thread Oleg Drokin
From: "John L. Hammond" Remove the server specific set_info handlers (KEY_REGISTER_TARGET, KEY_SET_FS, KEY_CLEAR_FS) and supporting functions. Signed-off-by: John L. Hammond Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/mgc/mgc_request.c | 177 --

[PATCH 02/12] staging/lustre/obdecho: remove metadata echo client

2014-08-30 Thread Oleg Drokin
-by: Nathaniel Clark Signed-off-by: Oleg Drokin --- .../staging/lustre/lustre/obdecho/echo_client.c| 1053 +--- 1 file changed, 46 insertions(+), 1007 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdecho/echo_client.c b/drivers/staging/lustre/lustre/obdecho

[PATCH 07/12] staging/lustre: remove md_object.h

2014-08-30 Thread Oleg Drokin
From: "John L. Hammond" The declarations from lustre/include/md_object.h are not used so remove them. Signed-off-by: John L. Hammond Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/fid/lproc_fid.c | 1 - drivers/staging/lustre/lustre/fld/fld_cache.c | 1

[PATCH 12/12] staging/lustre: remove unused som_attrs and hsm_attrs structures

2014-08-30 Thread Oleg Drokin
These structures are only used server-side to parse relevant attributes. Signed-off-by: Oleg Drokin --- .../lustre/lustre/include/lustre/lustre_idl.h | 37 - drivers/staging/lustre/lustre/ptlrpc/wiretest.c| 48 -- 2 files changed, 85 deletions

[PATCH 10/12] staging/lustre/obdclass: remove llog_osd.c

2014-08-30 Thread Oleg Drokin
From: "John L. Hammond" llog_osd_ops is not used so remove it and its supporting methods. Signed-off-by: John L. Hammond --- drivers/staging/lustre/lustre/include/lustre_log.h |9 - drivers/staging/lustre/lustre/obdclass/Makefile|2 +- drivers/staging/lustre/lustre/obdclass/llog_os

[PATCH 09/12] staging/lustre/obdclass: remove llog_test.ko

2014-08-30 Thread Oleg Drokin
From: "John L. Hammond" The llog_test module requires server support (it needs a local MGS to function) and should not have been included. Signed-off-by: John L. Hammond --- drivers/staging/lustre/lustre/obdclass/Makefile|2 +- drivers/staging/lustre/lustre/obdclass/llog_test.c | 1072

[PATCH 11/12] staging/lustre/mdc: remove obsolete llog ioctl handlers

2014-08-30 Thread Oleg Drokin
From: "John L. Hammond" In mdc_iocontrol() remove the handlers for the obsolete llog ioctls OBD_IOC_PARSE, OBD_IOC_LLOG_INFO, and OBD_IOC_LLOG_PRINT. Signed-off-by: John L. Hammond Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/mdc/mdc_request.c | 15 -

[PATCH 2/2] staging/lustre: remove unused function is_osp_on_mdt

2014-09-08 Thread Oleg Drokin
This function is no longer used anywhere. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/obd.h | 29 - 1 file changed, 29 deletions(-) diff --git a/drivers/staging/lustre/lustre/include/obd.h b/drivers/staging/lustre/lustre/include/obd.h index

[PATCH 0/2] Lustre: get rid of is_osp_on_mdt

2014-09-08 Thread Oleg Drokin
Hugues has recently discovered a possibility of buffer underflow in is_osp_on_mdt. Instead of fixing it up, let's just get rid of this function altogether, since it's no longer needed. Mikhail Pershin (1): staging/lustre: use osc_reply_portal for OUT services Oleg Drokin (1): stag

<    1   2   3   4   5   >