Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 2 +-
drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c| 3 ++-
drivers/staging/lustre/lustre/ldlm/ldlm_request.c | 2 +-
drivers/staging/lustre/lustre/ldlm/ldlm_resource.c | 2 +-
drivers/staging/lustre/lustre
They are just one-liners, so no point in having them exported
and called through a different module.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lustre_intent.h | 15 +++
drivers/staging/lustre/lustre/include/lustre_mdc.h| 3 ---
drivers/staging/lustre
: https://jira.hpdd.intel.com/browse/LU-7422
Reviewed-by: John L. Hammond
Reviewed-by: Andreas Dilger
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/llite_lib.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/llite
extracted from mdt_body through cl_fid_build_ino().
Signed-off-by: John Hammond
Signed-off-by: akam kumar bharathi
Reviewed-on: http://review.whamcloud.com/17618
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5954
Reviewed-by: Andreas Dilger
Signed-off-by: Oleg Drokin
---
drivers/staging/lus
/browse/LU-7403
Reviewed-by: James Simmons
Reviewed-by: Dmitry Eremin
Reviewed-by: Frank Zago
Signed-off-by: Oleg Drokin
---
.../staging/lustre/lustre/include/lustre_intent.h | 15 ++--
drivers/staging/lustre/lustre/llite/dcache.c | 26 +++
drivers/staging/lustre/lustre/llite/dir.c
eviewed-by: James Simmons
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lustre_dlm.h | 18 +-
drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 14 +++---
drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c| 2 +-
drivers/staging/lustre/l
From: Oleg Drokin
Mark dentries that came to us via NFS in a special way so that
we can tell them apart during open and activate open cache
(we really don't want to do open/close RPC for every NFS IO).
This became needed since dentry revlidate no longer reimplements
any RPCs for lookup, a
312
Signed-off-by: Andriy Skulysh
Reviewed-on: http://review.whamcloud.com/18738
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7829
Reviewed-by: Jinshan Xiong
Reviewed-by: Bobi Jam
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/osc/osc_request.c | 8 ++--
1 file changed
commit ac5b14810952 ("staging: lustre: osc: Track and limit
"unstable" pages") added a new sysfs variable, but corresponding bit of
documentation was not forgotten.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/sysfs-fs-lustre | 8
1 file changed, 8 inserti
-by: Andreas Dilger
Reviewed-by: John L. Hammond
Reviewed-by: Chris Horn
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/ptlrpc/client.c | 34 ++-
1 file changed, 13 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/lustre/lustre/ptlrpc/client.c
b
eviewed-by: James Simmons
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lustre_intent.h | 2 +-
drivers/staging/lustre/lustre/llite/dcache.c | 6 +++---
drivers/staging/lustre/lustre/llite/dir.c | 2 +-
drivers/staging/lustre/lustre/llite/file.c
Reviewed-by: James Simmons
Reviewed-by: Frank Zago
Reviewed-by: John L. Hammond
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/osc/osc_cl_internal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/osc/osc_cl_internal.h
b/drivers/s
: Lai Siyao
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/lcommon_misc.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/lcommon_misc.c
b/drivers/staging/lustre/lustre/llite/lcommon_misc.c
index 8a508ed..f6be105
http://review.whamcloud.com/19953
Reviewed-by: Chris Horn
Reviewed-by: Ann Koehler
Reviewed-by: Andreas Dilger
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lustre_net.h | 48 +---
.../staging/lustre/lustre/include/obd_support.h| 3 +
drivers/staging/lu
From: Oleg Drokin
There are a couple of cases in ll_revalidate_dentry() where
we are pretty sure the dentry is valid, so check for them early
and save more expensive checks for later.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/dcache.c | 11 +++
1 file changed
igned-off-by: Niu Yawei
Reviewed-on: http://review.whamcloud.com/19932
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8041
Reviewed-by: Andreas Dilger
Reviewed-by: Jinshan Xiong
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/mdc/mdc_lib.c | 12
1 file change
NULL NI on that
failure path.
Signed-off-by: Doug Oucharek
Reviewed-on: http://review.whamcloud.com/19614
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8022
Reviewed-by: Dmitry Eremin
Reviewed-by: James Simmons
Reviewed-by: Matt Ezell
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lne
-id: https://jira.hpdd.intel.com/browse/LU-7402
Reviewed-by: Dmitry Eremin
Reviewed-by: Lai Siyao
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/namei.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/namei.c
b/drive
: Oleg Drokin
---
drivers/staging/lustre/lustre/osc/osc_lock.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/lustre/lustre/osc/osc_lock.c
b/drivers/staging/lustre/lustre/osc/osc_lock.c
index 42def38..d856775 100644
--- a/drivers/staging/lustre
When imprting clio simplification patch, the check for
pbject got reversed by mistake when converting from
if (obj == NULL) it somehow became (if (obj) which is obviously wrong,
and so when it does hit, a crash was happening as result.
Fix the condition and all if fine now.
Signed-off-by: Oleg
These are just doing spin_lock/unlock on inode's i_lock,
so just do the spinlock directly to make the code more clear
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/dcache.c | 4 ++--
drivers/staging/lustre/lustre/llite/llite_internal.h | 10 --
dr
aging/lustre/ldlm: const qualify struct lustre_handle * params
Liang Zhen (2):
staging/lustre/ptlrpc: reorganize ptlrpc_request
staging/lustre/ptlrpc: missing wakeup for ptlrpc_check_set
Niu Yawei (1):
staging/lustre/mdc: Zero atime in close RPC
Oleg Drokin (7):
staging/lustre/llite: Get r
memory, it also can reduce memory footprint while
processing.
Signed-off-by: Liang Zhen
Reviewed-on: http://review.whamcloud.com/8806
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-181
Reviewed-by: Andreas Dilger
Reviewed-by: Bobi Jam
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre
https://jira.hpdd.intel.com/browse/LU-7973
Reviewed-by: Lai Siyao
Reviewed-by: Yang Sheng
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/file.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/llite/file.c
b/drivers/staging/
cache
- cl_cache_incref(): increase cl_cache refcount
- cl_cache_decref(): decrease cl_cache refcount and free the cache
if refcount=0.
Signed-off-by: Emoly Liu
Reviewed-on: http://review.whamcloud.com/13746
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6173
Reviewed-by: Niu Yawei
Signed-off-by: Oleg D
http://review.whamcloud.com/18934
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7434
Reviewed-by: Chris Horn
Reviewed-by: Andreas Dilger
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/ptlrpc/events.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/lu
nlinked"
Signed-off-by: Liang Zhen
Reviewed-on: http://review.whamcloud.com/12158
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5696
Reviewed-by: Johann Lombardi
Reviewed-by: Li Wei
Reviewed-by: Mike Pershin
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lustre_ne
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 2 +-
drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c| 3 ++-
drivers/staging/lustre/lustre/ldlm/ldlm_request.c | 2 +-
drivers/staging/lustre/lustre/ldlm/ldlm_resource.c | 2 +-
drivers/staging/lustre/lustre
http://review.whamcloud.com/19953
Reviewed-by: Chris Horn
Reviewed-by: Ann Koehler
Reviewed-by: Andreas Dilger
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lustre_net.h | 48 +---
.../staging/lustre/lustre/include/obd_support.h| 3 +
drivers/staging/lu
-by: Andreas Dilger
Reviewed-by: John L. Hammond
Reviewed-by: Chris Horn
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/ptlrpc/client.c | 34 ++-
1 file changed, 13 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/lustre/lustre/ptlrpc/client.c
b
: https://jira.hpdd.intel.com/browse/LU-7422
Reviewed-by: John L. Hammond
Reviewed-by: Andreas Dilger
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/llite_lib.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/llite
eviewed-by: James Simmons
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lustre_dlm.h | 18 +-
drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 14 +++---
drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c| 2 +-
drivers/staging/lustre/l
: Lai Siyao
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/lcommon_misc.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/lcommon_misc.c
b/drivers/staging/lustre/lustre/llite/lcommon_misc.c
index 8a508ed..f6be105
They are just one-liners, so no point in having them exported
and called through a different module.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lustre_intent.h | 15 +++
drivers/staging/lustre/lustre/include/lustre_mdc.h| 3 ---
drivers/staging/lustre
312
Signed-off-by: Andriy Skulysh
Reviewed-on: http://review.whamcloud.com/18738
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7829
Reviewed-by: Jinshan Xiong
Reviewed-by: Bobi Jam
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/osc/osc_request.c | 8 ++--
1 file changed
igned-off-by: Niu Yawei
Reviewed-on: http://review.whamcloud.com/19932
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8041
Reviewed-by: Andreas Dilger
Reviewed-by: Jinshan Xiong
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/mdc/mdc_lib.c | 12
1 file change
eviewed-by: James Simmons
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lustre_intent.h | 2 +-
drivers/staging/lustre/lustre/llite/dcache.c | 6 +++---
drivers/staging/lustre/lustre/llite/dir.c | 2 +-
drivers/staging/lustre/lustre/llite/file.c
From: Oleg Drokin
Mark dentries that came to us via NFS in a special way so that
we can tell them apart during open and activate open cache
(we really don't want to do open/close RPC for every NFS IO).
This became needed since dentry revlidate no longer reimplements
any RPCs for lookup, a
dreas Dilger
Reviewed-by: Alex Zhuravlev
Reviewed-by: John L. Hammond
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lu_object.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/include/lu_object.h
b/drivers/staging/lustre/l
Reviewed-by: James Simmons
Reviewed-by: Frank Zago
Reviewed-by: John L. Hammond
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/osc/osc_cl_internal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/osc/osc_cl_internal.h
b/drivers/s
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/llite_mmap.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/llite_mmap.c
b/drivers/staging/lustre/lustre/llite/llite_mmap.c
index fb1c3b6..66ee5db 100644
--- a/drivers/staging/lus
e MGC callpath, since it will always
be held first, and none of the other obd_device locks should ever
be held concurrently.
Signed-off-by: Andreas Dilger
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/obd.h | 6 ++
drivers/staging/lustre/lustre/mgc/mgc_r
extracted from mdt_body through cl_fid_build_ino().
Signed-off-by: John Hammond
Signed-off-by: akam kumar bharathi
Reviewed-on: http://review.whamcloud.com/17618
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5954
Reviewed-by: Andreas Dilger
Signed-off-by: Oleg Drokin
---
drivers/staging/lus
/browse/LU-7403
Reviewed-by: James Simmons
Reviewed-by: Dmitry Eremin
Reviewed-by: Frank Zago
Signed-off-by: Oleg Drokin
---
.../staging/lustre/lustre/include/lustre_intent.h | 15 ++--
drivers/staging/lustre/lustre/llite/dcache.c | 26 +++
drivers/staging/lustre/lustre/llite/dir.c
From: Oleg Drokin
There are a couple of cases in ll_revalidate_dentry() where
we are pretty sure the dentry is valid, so check for them early
and save more expensive checks for later.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/dcache.c | 11 +++
1 file changed
kthread_run might sleep during an allocation, and so
it's considered unsafe to call with a state that's not
RUNNABLE.
Move the state setting to after kthread_run call.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lnet/libcfs/debug.c | 2 +-
1 file changed, 1 insertion(+),
commit ac5b14810952 ("staging: lustre: osc: Track and limit
"unstable" pages") added a new sysfs variable, but corresponding bit of
documentation was not forgotten.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/sysfs-fs-lustre | 8
1 file changed, 8 inserti
NAK.
On Jun 23, 2016, at 1:24 PM, Lidza Louina wrote:
> The code attempted to add an unsigned int to a an unsigned 64-bit
> integer. This patch casts the unsigned regular int to suppress
> smatch warnings.
>
> Signed-off-by: Lidza Louina
> ---
> drivers/staging/lustre/lnet/lnet/api-ni.c | 2 +-
On Jun 23, 2016, at 2:07 PM, Lidza Louina wrote:
> The smatch warning was "drivers/staging/lustre/lnet/lnet/api-ni.c:516
> lnet_res_lh_initialize() warn: should '1 << ibits' be a 64 bit type?"
I think you misinterpreted it, it has nothing to do with the addition.
What it actually means is:
1 i
On Jun 23, 2016, at 2:56 PM, Lidza Louina wrote:
> The code attempted to add an unsigned int to a an unsigned 64-bit
> integer. This patch makes the code use the correct type of int to
> suppress a smatch warning.
I think you might want to update the commit message too, because
it does not reall
On Jun 23, 2016, at 3:27 PM, Lidza Louina wrote:
>
> - Original Message -
> From: oleg.dro...@intel.com
> To: lidza.lou...@oracle.com
> Cc: gre...@linuxfoundation.org, lustre-de...@lists.lustre.org,
> de...@driverdev.osuosl.org, andreas.dil...@intel.com
> Sent: Thursday, June 23, 2016 1
On Jun 23, 2016, at 5:03 PM, Lidza Louina wrote:
>
> - Original Message -
> From: oleg.dro...@intel.com
> To: lidza.lou...@oracle.com
> Cc: de...@driverdev.osuosl.org, gre...@linuxfoundation.org,
> lustre-de...@lists.lustre.org
> Sent: Thursday, June 23, 2016 12:50:01 PM GMT -08:00 US/C
t all,
just return ENOENT and make the race go away completely.
Signed-off-by: Oleg Drokin
---
This problem was introduced during current development cycle, with
parallel openers now possible for non-creates due to vfs changes,
so it would be great if this could go into Linus' tree separat
From: Al Viro
... by using ITER_BVEC recvmsg
Signed-off-by: Al Viro
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.h| 6 +-
.../lustre/lnet/klnds/socklnd/socklnd_lib.c| 98 ++
2 files changed, 12 insertions(+), 92 deletions(-)
diff --git a/drivers/staging/l
From: Al Viro
Signed-off-by: Al Viro
---
.../lustre/lnet/klnds/socklnd/socklnd_lib.c| 22 +-
1 file changed, 5 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib.c
b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_li
e: Fix unnecessary parentheses around variables
staging/lustre: Make alignment match open parenthesis
Oleg Drokin (2):
staging/lustre: Always return EEXIST on mkdir for existing names
staging/lustre: Remove unused cp_error from struct cl_page
.../staging/lustre/include/linux/libcfs/libcfs.h
From: Al Viro
Signed-off-by: Al Viro
Signed-off-by: James Simmons
Signed-off-by: Oleg Drokin
---
.../staging/lustre/include/linux/lnet/lib-lnet.h | 57 +---
.../staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c | 36 +--
drivers/staging/lustre/lnet/lnet/lib-move.c| 309
From: Al Viro
Signed-off-by: Al Viro
---
.../staging/lustre/include/linux/lnet/lib-lnet.h | 28 +++---
drivers/staging/lustre/lnet/lnet/lib-move.c| 20
2 files changed, 24 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/lustre/include/linu
From: Al Viro
Signed-off-by: Al Viro
---
drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h
b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h
index d5efb42..84a915c 100644
--- a/driv
From: Al Viro
Signed-off-by: Al Viro
---
drivers/staging/lustre/include/linux/lnet/types.h | 16 +
.../staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c | 10 +--
.../staging/lustre/lnet/klnds/socklnd/socklnd_cb.c | 16 ++---
.../lustre/lnet/klnds/socklnd/socklnd_lib.c| 42 +--
From: Al Viro
Signed-off-by: Al Viro
---
drivers/staging/lustre/lnet/lnet/lib-socket.c | 21 +++--
1 file changed, 7 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/lustre/lnet/lnet/lib-socket.c
b/drivers/staging/lustre/lnet/lnet/lib-socket.c
index 891fd59..4e6dd51
From: Emoly Liu
This patch fixes all checkpatch occurences of
"CHECK: Unnecessary parentheses around xxx"
in Lustre code.
Signed-off-by: Emoly Liu
Signed-off-by: Oleg Drokin
---
.../staging/lustre/lustre/include/lustre/lustre_user.h | 2 +-
drivers/staging/lustre/lustre/lov
From: Al Viro
Signed-off-by: Al Viro
---
.../lustre/lnet/klnds/socklnd/socklnd_lib.c| 29 --
1 file changed, 5 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib.c
b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_li
cp_error member is not really set anywhere, so kill
it and the only printing user of it too.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/cl_object.h | 2 --
drivers/staging/lustre/lustre/obdclass/cl_page.c | 4 ++--
2 files changed, 2 insertions(+), 4 deletions
sting directory.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/namei.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/namei.c
b/drivers/staging/lustre/lustre/llite/namei.c
index 2c4dc69..d219d06 100644
--- a/dr
From: Al Viro
Signed-off-by: Al Viro
---
.../staging/lustre/include/linux/lnet/lib-types.h | 5 +---
.../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h| 3 +-
.../staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c | 32 --
.../staging/lustre/lnet/klnds/socklnd/socklnd.h|
From: Al Viro
Signed-off-by: Al Viro
---
.../lustre/lnet/klnds/socklnd/socklnd_lib.c| 38 ++
1 file changed, 10 insertions(+), 28 deletions(-)
diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib.c
b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_l
From: Emoly Liu
This patch fixes all checkpatch occurences of
"CHECK: spaces preferred around that '{+,-,*,/,|,<<,>>,&}' (ctx:VxV)"
in Lustre code.
Signed-off-by: Emoly Liu
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lu_object.h
From: Emoly Liu
This patch fixes most of checkpatch occurences of
"CHECK: Alignment should match open parenthesis"
in Lustre code.
Signed-off-by: Emoly Liu
Signed-off-by: Oleg Drokin
---
.../staging/lustre/include/linux/libcfs/libcfs.h | 6 +-
.../lustre/include/li
On Jul 23, 2016, at 1:31 PM, Joe Perches wrote:
> On Sat, 2016-07-23 at 02:37 -0400, Oleg Drokin wrote:
>> From: Emoly Liu
>
> unrelated trivial notes:
>
>> diff --git a/drivers/staging/lustre/lustre/obdecho/echo_internal.h
>> b/drivers/staging/lustre/
On Jul 26, 2016, at 3:05 PM, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Tue, 26 Jul 2016 14:23:23 +0200
>
> Return a constant error code without storing it in the local variable "rc"
> after a failed memory allocation at the beginning of this function.
>
> Signed-off-by: Markus El
On Jul 26, 2016, at 3:02 PM, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Tue, 26 Jul 2016 13:40:47 +0200
>
> The kobject_put() function was called in a few cases by the
> class_register_type() function during error handling even if the passed
> data structure element did not contain
On Jul 26, 2016, at 3:11 PM, Oleg Drokin wrote:
>
> On Jul 26, 2016, at 3:05 PM, SF Markus Elfring wrote:
>
>> From: Markus Elfring
>> Date: Tue, 26 Jul 2016 14:23:23 +0200
>>
>> Return a constant error code without storing it in the local variable "rc&q
On Jul 26, 2016, at 3:56 PM, SF Markus Elfring wrote:
>> But kobject_put() already checks for NULL, right?
>
> Yes. - Such an input parameter validation is performed by the
> function implementation.
>
>
>> you just submitted another batch about that in other area.
>
> I sent update suggestio
On Jul 28, 2016, at 1:53 AM, SF Markus Elfring wrote:
>> This function is called several times during lustre module insert.
>> Namely it's called 5 times for 5 types:
>> osc, mdc, lov, lmv, mgc.
>
> Will any extra memory accesses matter for the successful execution
> in this use case?
I doubt i
_{k,}iov2iter(), kill
lnet_copy_{k,}iov2{k,}iov()
Emoly Liu (3):
staging/lustre: Add spaces preferred around that '{+,-,*,/,|,<<,>>,&}'
staging/lustre: Fix unnecessary parentheses around variables
staging/lustre: Make alignment match open parenthesis
Oleg Drokin
From: Al Viro
Signed-off-by: Al Viro
Signed-off-by: Oleg Drokin
---
.../lustre/lnet/klnds/socklnd/socklnd_lib.c| 38 ++
1 file changed, 10 insertions(+), 28 deletions(-)
diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib.c
b/drivers/staging/lustre
sting directory.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/namei.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/namei.c
b/drivers/staging/lustre/lustre/llite/namei.c
index 09e1801..8350943 100644
--- a/dr
From: Al Viro
Signed-off-by: Al Viro
Signed-off-by: Oleg Drokin
---
.../staging/lustre/include/linux/lnet/lib-lnet.h | 28 +++---
drivers/staging/lustre/lnet/lnet/lib-move.c| 20
2 files changed, 24 insertions(+), 24 deletions(-)
diff --git a
From: Al Viro
Signed-off-by: Al Viro
Signed-off-by: James Simmons
Signed-off-by: Oleg Drokin
---
.../staging/lustre/include/linux/lnet/lib-lnet.h | 57 +---
.../staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c | 37 ++-
drivers/staging/lustre/lnet/lnet/lib-move.c| 314
From: Al Viro
Signed-off-by: Al Viro
Signed-off-by: Oleg Drokin
---
.../lustre/lnet/klnds/socklnd/socklnd_lib.c| 22 +-
1 file changed, 5 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib.c
b/drivers/staging/lustre
From: Al Viro
Signed-off-by: Al Viro
Signed-off-by: Oleg Drokin
---
.../lustre/lnet/klnds/socklnd/socklnd_lib.c| 29 --
1 file changed, 5 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib.c
b/drivers/staging/lustre
From: Al Viro
Signed-off-by: Al Viro
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h
b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h
index
From: Al Viro
Signed-off-by: Al Viro
Signed-off-by: Oleg Drokin
---
.../staging/lustre/include/linux/lnet/lib-types.h | 5 +---
.../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h| 3 +-
.../staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c | 32 --
.../staging/lustre/lnet
From: Emoly Liu
This patch fixes all checkpatch occurences of
"CHECK: Unnecessary parentheses around xxx"
in Lustre code.
Signed-off-by: Emoly Liu
Signed-off-by: Oleg Drokin
---
.../staging/lustre/lustre/include/lustre/lustre_user.h | 2 +-
drivers/staging/lustre/lustre/lov
From: Emoly Liu
This patch fixes all checkpatch occurences of
"CHECK: spaces preferred around that '{+,-,*,/,|,<<,>>,&}' (ctx:VxV)"
in Lustre code.
Signed-off-by: Emoly Liu
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lu_object.h
James Simmons is also spendign a lot of efforts on
cleaning up staging tree Lustre code and also
helps to sync up all the missing changes from the other tree.
Signed-off-by: Oleg Drokin
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index a306795
cp_error member is not really set anywhere, so kill
it and the only printing user of it too.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/cl_object.h | 2 --
drivers/staging/lustre/lustre/obdclass/cl_page.c | 4 ++--
2 files changed, 2 insertions(+), 4 deletions
From: Emoly Liu
This patch fixes most of checkpatch occurences of
"CHECK: Alignment should match open parenthesis"
in Lustre code.
Signed-off-by: Emoly Liu
Signed-off-by: Oleg Drokin
---
.../staging/lustre/include/linux/libcfs/libcfs.h | 6 +-
.../lustre/include/li
Acked-by: Oleg Drokin
On Aug 20, 2016, at 10:44 PM, Shawn Lin wrote:
> We have got a zero buffer for in_data as we use
> kzalloc here. So let's remove it anyway.
>
> Signed-off-by: Shawn Lin
> ---
>
> drivers/staging/lustre/lustre/llite/file.c | 1 -
> 1 file cha
Here are the three patches rebased after merge conflict
with some other patches that were accepted first.
Oleg Drokin (3):
staging/lustre: Add spaces preferred around that '{+,-,*,/,|,<<,>>,&}'
staging/lustre: Make alignment match open parenthesis
staging/lustre: R
cp_error member is not really set anywhere, so kill
it and the only printing user of it too.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/cl_object.h | 2 --
drivers/staging/lustre/lustre/obdclass/cl_page.c | 4 ++--
2 files changed, 2 insertions(+), 4 deletions
This patch fixes most of checkpatch occurences of
"CHECK: Alignment should match open parenthesis"
in Lustre code.
Signed-off-by: Emoly Liu
Signed-off-by: Oleg Drokin
---
.../staging/lustre/include/linux/libcfs/libcfs.h | 6 +-
.../lustre/include/linux/libcfs/libcfs_debug.h
This patch fixes all checkpatch occurences of
"CHECK: spaces preferred around that '{+,-,*,/,|,<<,>>,&}' (ctx:VxV)"
in Lustre code.
Signed-off-by: Emoly Liu
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lu_object.h | 3 ++-
.../lustr
HEre are some more recent Lustre fixes and a cleanup.
Alexander Boyko (1):
staging/lustre/mdc: fix panic at mdc_free_open()
Andrew Perepechko (1):
staging/lustre: avoid clearing i_nlink for inodes in use
Dmitry Eremin (1):
staging/lustre/llite: Fix suspicious dereference of pointer
'vm
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/llite_lib.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/staging/lustre/lustre/llite/llite_lib.c
b/drivers/staging/lustre/lustre/llite/llite_lib.c
index 72ff7c4..1ff788e 100644
--- a/drivers/staging/lustre
wrong
i_nlink value into st_nlink
Signed-off-by: Andrew Perepechko
Seagate-bug-id: MRP-3271
Reviewed-on: http://review.whamcloud.com/19164
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7925
Reviewed-by: Wally Wang
Reviewed-by: Lai Siyao
Signed-off-by: Oleg Drokin
---
drivers/staging
: Ashish Purkar
Reviewed-by: Andrew Perepechko
Tested-by: Parinay Vijayprakash Kondekar
Reviewed-on: http://review.whamcloud.com/17732
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7613
Reviewed-by: Niu Yawei
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/namei.c | 3
L. Hammond
Reviewed-by: Bob Glossman
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/llite_mmap.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/llite_mmap.c
b/drivers/staging/lustre/lustre/llite/llite_mmap.c
index 9d03e79..37f82ed 1
ago
Reviewed-by: James Simmons
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/obd.h | 3 ++-
drivers/staging/lustre/lustre/include/obd_class.h| 3 ++-
drivers/staging/lustre/lustre/llite/file.c | 2 +-
drivers/staging/lustre/lustre/llite/llite_i
201 - 300 of 434 matches
Mail list logo