It should never be NULL because our interface list is up to date,
and even if it does, we'll just crash anyway so we are no better off.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/st
L. Hammond
Reviewed-by: Isaac Huang
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c
b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2
From: Dmitry Eremin
Local variable 'hash' is never used
found by Klocwork Insight tool
Signed-off-by: Dmitry Eremin
Reviewed-on: http://review.whamcloud.com/9386
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629
Reviewed-by: John L. Hammond
Reviewed-by: Isaac Huang
Signed-of
Pointer 'ni' checked for NULL at line 1569 may be passed to
function and may be dereferenced there by passing argument 1 to
function 'lnet_ni_notify_locked' at line 1621.
found by Klocwork Insight tool
Signed-off-by: Oleg Drokin
CC: Dmitry Eremin
CC: Liang Zhen
---
drivers
/lnet: fix potential null pointer dereference in
kiblnd_rejected
Oleg Drokin (2):
staging/lustre/lnet: Drop useless LASSERT in ksocknal_select_ips
staging/lustre/lnet: fix potential null pointer dereference
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c | 8 ++--
drivers
/browse/LU-3221
Reviewed-by: Andreas Dilger
Reviewed-by: Li Wei
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/lov/lov_pack.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/lustre/lustre/lov/lov_pack.c
b/drivers/staging/lustre/lustre/lov/lov_pack.c
index
On May 29, 2017, at 10:28 AM, Greg Kroah-Hartman wrote:
> On Fri, May 26, 2017 at 11:40:33PM -0400, Oleg Drokin wrote:
>> lov_getstripe() calls set_fs(KERNEL_DS) so that it can handle a struct
>> lov_user_md pointer from user- or kernel-space. This changes the
>> behavior o
Hello!
On May 31, 2017, at 3:57 AM, Jia-Ju Bai wrote:
> The driver may sleep under a spin lock, and the function call path is:
> cfs_wi_deschedule (acquire the lock by spin_lock)
> LASSERT
>lbug_with_loc
> libcfs_debug_dumplog
>schedule and kthread_run --> may sleep
>
> To fix
Hello!
On May 31, 2017, at 4:00 AM, Jia-Ju Bai wrote:
> The driver may sleep under a spin lock, and the function call path is:
> cfs_wi_exit (acquire the lock by spin_lock)
> LASSERT
>lbug_with_loc
> libcfs_debug_dumplog
>schedule and kthread_run --> may sleep
>
> To fix it, al
On Jan 4, 2016, at 4:55 AM, Dan Carpenter wrote:
> On Sun, Jan 03, 2016 at 12:05:35PM -0500, gr...@linuxhacker.ru wrote:
>> diff --git a/drivers/staging/lustre/lustre/include/lustre_lib.h
>> b/drivers/staging/lustre/lustre/include/lustre_lib.h
>> index 428469f..7daf954 100644
>> --- a/drivers/st
On Jan 4, 2016, at 12:45 PM, Simmons, James A. wrote:
>> From: Oleg Drokin
>>
>> IOC_LIBCFS_DEBUG_PEER was added back in the stone ages to print debug
>> statistics on a peer when peer timeout happens.
>> Redo it properly as a separate LNet API call,
>> als
On Mar 30, 2016, at 7:13 PM, kbuild test robot wrote:
> Hi John,
>
> [auto build test ERROR on staging/staging-testing]
> [also build test ERROR on next-20160330]
> [cannot apply to v4.6-rc1]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improving the system
On Feb 7, 2016, at 4:39 PM, Greg Kroah-Hartman wrote:
> On Sat, Feb 06, 2016 at 02:01:49AM -0500, gr...@linuxhacker.ru wrote:
>> From: Oleg Drokin
>>
>> These two patches tie some loose ends from the Lustre debugfs conversion,
>> but while investigating them I also
On Feb 16, 2016, at 12:55 AM, Joe Perches wrote:
> On Tue, 2016-02-16 at 00:47 -0500, gr...@linuxhacker.ru wrote:
>> From: Oleg Drokin
>>
>> This pacifies checkpatch amongst other things, also is shorter to write
>> and avoiding calls to printk_ratelimit() is also
LL and encode a file handle accordingly.
>>
>> Reviewed-on: http://review.whamcloud.com/8347
>> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4231
>> Reviewed-by: Fan Yong
>> Reviewed-by: James Simmons
>> Reviewed-by: Jian Yu
>> Signed-off-by: Dmitry Eremin
On Feb 26, 2016, at 1:10 AM, Greg Kroah-Hartman wrote:
> On Wed, Feb 24, 2016 at 10:00:43PM -0500, gr...@linuxhacker.ru wrote:
>> From: Oleg Drokin
>>
>> This mostly fixes checkpatch complaints about
>> "Alignment should match open parenthesis"
>>
On Feb 26, 2016, at 1:13 AM, Greg Kroah-Hartman wrote:
> On Mon, Feb 22, 2016 at 09:34:17PM -0500, Oleg Drokin wrote:
>>
>> On Feb 14, 2016, at 7:58 PM, Greg Kroah-Hartman wrote:
>>
>>> On Sun, Feb 14, 2016 at 07:13:52PM -0500, gr...@linuxhacker.ru w
2013-05-02 2754 flags =
> LDLM_FL_BLOCK_NOWAIT;
> d7e09d039 Peng Tao 2013-05-02 2755 break;
> d7e09d039 Peng Tao 2013-05-02 2756 case F_GETLK:
> d7e09d039 Peng Tao 2013-05-02 @2757 case F_GETLK64:
>
On Jun 10, 2015, at 3:08 AM, Sudip Mukherjee wrote:
> On Wed, Jun 10, 2015 at 12:41:22AM -0400, gr...@linuxhacker.ru wrote:
>> From: Oleg Drokin
>>
>> It uses getname in unsafe manner and since it's to deal with corrupted
>> or inconsistent filesystem, we are pr
On Jun 10, 2015, at 3:52 AM, Dan Carpenter wrote:
> On Wed, Jun 10, 2015 at 12:41:23AM -0400, gr...@linuxhacker.ru wrote:
>> From: Oleg Drokin
>>
>> strncpy_from_user could return negative values on error,
>> so need to take those into account.
>> Since l
On Jul 8, 2015, at 4:28 AM, Dan Carpenter wrote:
> On Mon, Jul 06, 2015 at 12:48:53PM -0400, gr...@linuxhacker.ru wrote:
>> +static int param_set_uint_minmax(const char *val,
>> + const struct kernel_param *kp,
>> + unsigned int min, unsigne
On Jul 13, 2015, at 10:43 PM, Greg Kroah-Hartman wrote:
> On Wed, Jul 08, 2015 at 11:45:59AM +0300, Dan Carpenter wrote:
>> On Mon, Jul 06, 2015 at 12:48:56PM -0400, gr...@linuxhacker.ru wrote:
>>> +static int libcfs_param_debug_mb_set(const char *val,
>>> +const s
On Jul 13, 2015, at 10:46 PM, Greg Kroah-Hartman wrote:
> On Mon, Jul 06, 2015 at 12:48:56PM -0400, gr...@linuxhacker.ru wrote:
>> From: Oleg Drokin
>>
>> It's just a fancy libcfs_debug_mb module parameter wrapper,
>> so just add debug buffer size
On Jul 13, 2015, at 10:49 PM, Greg Kroah-Hartman wrote:
> On Mon, Jul 06, 2015 at 12:48:56PM -0400, gr...@linuxhacker.ru wrote:
>> From: Oleg Drokin
>>
>> It's just a fancy libcfs_debug_mb module parameter wrapper,
>> so just add debug buffer size
On Jul 31, 2015, at 7:00 PM, Greg Kroah-Hartman wrote:
> On Thu, Jul 30, 2015 at 06:27:57PM -0400, gr...@linuxhacker.ru wrote:
>> From: Oleg Drokin
>>
>> SEEK_DATA and SEEK_HOLE are always defined in the kernel,
>> drop the definition checks
> This code rem
On Dec 3, 2016, at 7:52 AM, Pan Bian wrote:
> From: Pan Bian
>
> At the end of function lstcon_group_info(), "return 0" seems improper.
> It may be better to return the value of rc.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188811
>
> Signed
On Dec 4, 2016, at 9:21 PM,
wrote:
> From: Sandeep Jain
>
> Fix following sparse warning.
> mgc_request.c:376:1:
> warning: symbol 'llog_process_lock' was not declared. Should it be static?
>
> Signed-off-by: Sandeep Jain
Acked-by: Oleg Drokin
> ---
&
nids'
> redeclared with different type...
>
> Signed-off-by: Sandeep Jain
Acked-by: Oleg Drokin
> ---
> drivers/staging/lustre/lustre/include/lprocfs_status.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/lustre/lust
On Dec 2, 2016, at 12:33 PM, Quentin Lambert wrote:
> lnet_ipif_enumerate was assigning a pointer from kernel space to user
> space. This patch uses copy_to_user to properly do that assignment.
I guess it's a false positive?
While lnet_sock_ioctl()->kernel_sock_unlocked_ioctl() does call into t
On Dec 5, 2016, at 3:55 PM, Dan Carpenter wrote:
> On Fri, Dec 02, 2016 at 07:53:11PM -0500, James Simmons wrote:
>> @@ -3183,8 +3182,10 @@ static int discard_cb(const struct lu_env *env,
>> struct cl_io *io,
>> /* page is top page. */
>> info->oti_next_index = osc_index(ops) + 1;
>>
On Nov 23, 2016, at 7:29 AM, Dan Carpenter wrote:
> Hi Lustre Devs,
>
> The patch d7e09d0397e8: "staging: add Lustre file system client
> support" from May 2, 2013, leads to the following static checker
> warning:
>
> drivers/staging/lustre/lnet/selftest/console.c:1336 lstcon_test_add()
>
On Dec 6, 2016, at 6:02 AM, Dan Carpenter wrote:
> On Mon, Dec 05, 2016 at 06:43:37PM -0500, Oleg Drokin wrote:
>>
>> On Nov 23, 2016, at 7:29 AM, Dan Carpenter wrote:
>>
>>> Hi Lustre Devs,
>>>
>>> The patch d7e09d0397e8: "staging: add Lu
On Dec 6, 2016, at 1:37 PM, Dan Carpenter wrote:
> On Tue, Dec 06, 2016 at 10:44:54AM -0500, Oleg Drokin wrote:
>> I see, indeed, it all makes sense now.
>> So basically if we unconditionally check for the size to be > 0, we should be
>> fine then, I imagine.
>
aging: lustre: osc: Use list_for_each_entry_safe")
CC: Bhaktipriya Shridhar
Signed-off-by: Oleg Drokin
---
I also do not see this patch in any of the mailing lists I am subscribed to.
I wonder if there's a way to subscribe to those Greg's
"This is a note to let you know that
Highlighted by checkpatch:
+ if (!ps->ps_net) /* intialized? */
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
b/drivers/stag
checkpatch highlighted missing space before assignment
for lock variable.
+ spinlock_t *lock= &kiblnd_data.kib_connd_lock;
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dri
checkpatch highlighted there are 8 spaces that could be converted to a tab:
ERROR: code indent should use tabs where possible
+^I^I^I^I^I */$
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
These patches fix some more of the low hanging fruits
in the style problems highlighted by checkpatch.
Now only false positive ERRORs are left.
This also converts all bare unsigneds into unsigned ints
and a couple of spelling fixes.
Please consider.
Oleg Drokin (5):
staging/lustre/o2iblnd: Add
Highlighted by checkpatch:
WARNING: 'attemps' may be misspelled - perhaps 'attempts'?
#20278: FILE: drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:3272:
+ * reconnection attemps.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c |
Highlighted by relatively new checkpatch test, warnings like:
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/include/linux/lnet/lnetst.h | 6 +-
.../staging/lustre/lustre/include/lprocfs_status.h | 3 +-
dr
er is
not present.
Reported-by: Dan Carpenter
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lnet/selftest/conctl.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/lustre/lnet/selftest/conctl.c
b/drivers/staging/lustre/lnet/selftest/conctl.c
index 02847bf..9438302 1
On Dec 7, 2016, at 5:40 AM, Greg Kroah-Hartman wrote:
> On Tue, Dec 06, 2016 at 10:53:48PM -0500, Oleg Drokin wrote:
>> I have been having a lot of unexplainable crashes in osc_lru_shrink
>> lately that I could not see a good explanation for and then I found
>> this patc
On Dec 7, 2016, at 10:33 AM, Dan Carpenter wrote:
> Lustre is kind of a mess with regards to keeping user and kernel
> pointers separate. It's not going to be easy to fix.
Actually I believe I made significant inroads in properly cleaning (almost?)
everything
in this area about a year ago (to
On Dec 7, 2016, at 10:20 AM, Quentin Lambert wrote:
> Hi all,
>
> I am looking at the drivers/staging/lustre/lustre/llite/dir.c:
>
> 1469 /* Call mdc_iocontrol */
> 1470 rc = obd_iocontrol(LL_IOC_FID2MDTIDX, exp, sizeof(fid),
> &fid,
> 1471
On Dec 7, 2016, at 3:37 PM, Greg Kroah-Hartman wrote:
> On Wed, Dec 07, 2016 at 11:29:36AM -0500, Oleg Drokin wrote:
>>
>> On Dec 7, 2016, at 5:40 AM, Greg Kroah-Hartman wrote:
>>
>>> On Tue, Dec 06, 2016 at 10:53:48PM -0500, Oleg Drokin wrote:
>>>>
It's not used anywhere outside of this file.
Highlighted by sparse.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/lov/lov_pack.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/lov/lov_pack.c
b/drivers/staging/lustre/lustr
As per interval_search() prototype, the callback should return
enum, not int.
This fixes correspondign sparse warning.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre
It's not used anywhere out of this file.
Highlighted by sparse.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/llite/file.c
b/drivers/staging/lustre/lustre/llite/f
This avoids frowned upon extern in the C file, and also
shuts down a sparse warning of
drivers/staging/lustre/lustre/osc/osc_dev.c:55:22: warning: symbol 'osc_caches'
was not declared. Should it be static?
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/osc/osc_inte
ncies of root squash feature"
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/lproc_llite.c | 27 +--
1 file changed, 15 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/lproc_llite.c
b/drivers/staging/lustre/lu
Make the declaration in a header, not as an extern in a C file,
that is frowned upon.
This also makes sparse a little bit more happy.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lu_object.h | 3 +++
drivers/staging/lustre/lustre/obdclass/cl_object.c | 3 +--
2 files
This set of fixes aims at sparse warnings.
Most of the patches are just moving declarations around
to deal with the
warning: symbol 'xxx' was not declared. Should it be static?
kind of messages.
Also a screwup with root_squash sysfs control is fixed.
Oleg Drokin (8):
staging/lustre/l
Move it to obd.h, so that it's included from both the users and
the actual definition, making sure they never get out of sync.
This also silences a sparse warning.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/obd.h| 3 +++
drivers/staging/lustre/lustre/
This avoids having an extern definition in a C file which is bad,
and also silences sparse complaint as well.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/ptlrpc/nrs.c | 3 ---
drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h | 3 +++
2 files changed, 3
On Dec 7, 2016, at 6:46 PM, Al Viro wrote:
> On Wed, Dec 07, 2016 at 05:41:26PM -0500, Oleg Drokin wrote:
>> This set of fixes aims at sparse warnings.
>
> Speaking of the stuff sparse catches there: class_process_proc_param().
> I've tried to describe what I thin
On Dec 13, 2016, at 3:31 AM, Dan Carpenter wrote:
> It used to be that great swathes of Lustre were used in both user space
> and kernel space. We had huge unused modules in the kernel that were
> only used for user space.
Huh?
There was nothing of the sort.
There were huge parts of code that w
On Jan 1, 2017, at 11:35 AM, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Sun, 1 Jan 2017 15:40:29 +0100
>
> Some data were printed into a sequence by two separate function calls.
> Print the same data by a single function call instead.
>
> This issue was detected by using the Cocci
On Jan 1, 2017, at 11:38 AM, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Sun, 1 Jan 2017 16:26:36 +0100
>
> Some data were printed into a sequence by two separate function calls.
> Print the same data by a single function call instead.
>
> This issue was detected by using the Cocci
hink it could go above 32 possibly.
>
> Signed-off-by: Dan Carpenter
Reviewed-by: Oleg Drokin
> ---
> I have not tested this change.
>
> diff --git a/drivers/staging/lustre/lustre/ptlrpc/events.c
> b/drivers/staging/lustre/lustre/ptlrpc/events.c
> index 49f3e63..ae1
Hello!
On Feb 2, 2015, at 10:44 AM, Greg Kroah-Hartman wrote:
> On Mon, Feb 02, 2015 at 04:02:31PM +0300, Dan Carpenter wrote:
>> On Sun, Feb 01, 2015 at 09:52:05PM -0500, gr...@linuxhacker.ru wrote:
>>> From: Dmitry Eremin
>>>
>>> Expression if (size != (ssize_t)size) is always false.
>>> Ther
On Feb 2, 2015, at 3:51 PM, Greg Kroah-Hartman wrote:
> On Mon, Feb 02, 2015 at 03:25:58PM -0500, Oleg Drokin wrote:
>>> What is this code supposed to be protecting from? And -1? That should
>>> never be a return value…
>>
>> Why is -1 a bad return value if a
Hello!
On Mar 6, 2015, at 7:06 PM, Greg Kroah-Hartman wrote:
>> .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c| 4 +-
>> .../staging/lustre/lustre/libcfs/linux/linux-cpu.c | 102
>> +++--
>> drivers/staging/lustre/lustre/ptlrpc/ptlrpcd.c | 8 +-
>> drivers/staging/lustre
From: Nathaniel Clark
Fix all multiple assignments on lustre/lov directory.
Signed-off-by: Nathaniel Clark
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/lov/lov_obd.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/lustre/lustre/lov
From: Nathaniel Clark
Fix all multiple assignments on lustre/osc directory.
Signed-off-by: Nathaniel Clark
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/osc/osc_cache.c | 6 --
drivers/staging/lustre/lustre/osc/osc_io.c | 12
drivers/staging/lustre
From: Nathaniel Clark
Fix all multiple assignments on lustre/llite directory.
Signed-off-by: Nathaniel Clark
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/llite_lib.c | 3 ++-
drivers/staging/lustre/lustre/llite/namei.c | 3 ++-
drivers/staging/lustre/lustre/llite
From: Nathaniel Clark
Fix all multiple assignments on lustre/fid directory.
Signed-off-by: Nathaniel Clark
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/fid/fid_request.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre
From: Nathaniel Clark
Fix all multiple assignments on lustre/ldlm directory.
Signed-off-by: Nathaniel Clark
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/ldlm/ldlm_lib.c | 3 ++-
drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c | 8 +---
2 files changed, 7 insertions
From: Nathaniel Clark
Fix all multiple assignments on lustre/obdclass directory.
Signed-off-by: Nathaniel Clark
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/obdclass/llog.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre
These patches remove multiple assignments in Lustre, that makes
checkpatch (somewhat understandably) unhappy.
Nathaniel Clark (8):
staging/lustre/osc: Fix Multiple Assignment Warnings
staging/lustre/fid: Fix Multiple Assignments
staging/lustre/ldlm: Fix Multiple Assignments
staging/lustre/
From: Nathaniel Clark
Fix all multiple assignments on lustre/ptlrpc directory.
Signed-off-by: Nathaniel Clark
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/ptlrpc/client.c | 6 --
drivers/staging/lustre/lustre/ptlrpc/import.c | 3 ++-
drivers/staging/lustre
From: Nathaniel Clark
Fix all multiple assignments on lustre/lmv directory.
Signed-off-by: Nathaniel Clark
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/lmv/lmv_obd.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/lmv
On Jun 14, 2016, at 7:20 PM, Xose Vazquez Perez wrote:
> On 06/15/2016 12:55 AM, Greg KH wrote:
>
>> On Wed, Jun 15, 2016 at 12:25:17AM +0200, Xose Vazquez Perez wrote:
>>> It should be resolved ASAP.
>>
>> Why? What's the rush, let the people who work for the companies
>> involved change this
n even bigger mess I assume.
Oleg Drokin (5):
staging/lustre: Remove the "Please contact SUN for GPL" from headers
staging/lustre: Replace sun.com GPLv2 URL with gnu.org one.
staging/lustre/lov: Fix gpl URL in lov_pool.c
staging/lustre: Remove stray line from selftest/selftest.h
The "Please contact Oracle Corporation" lines are removed since not
only Oracle has nothing to do with Lustre anymore, there's a pointer
to GPL already that's independent of any particular company.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/include/linux/libc
There's no longer a matching sun.com URL, so refer to
gnu.org copy.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/lov/lov_pool.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/lov/lov_pool.c
b/drivers/staging/lustre/l
The 'copy of GPLv2]' is an ending from template that's no longer needed,
so remove it to avoid any extra confusion.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lnet/selftest/selftest.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/lustre/lnet/self
http://www.sun.com/software/products/lustre/docs/GPLv2.pdf is no
longer around, so replace it with (hopefully more permanent)
http://http://www.gnu.org/licenses/gpl-2.0.html
Signed-off-by: Oleg Drokin
Reported-by: Xose Vazquez Perez
---
drivers/staging/lustre/include/linux/libcfs/curproc.h
On Jun 14, 2016, at 11:11 PM, Xose Vazquez Perez wrote:
> Oleg Drokin wrote:
>
>> http://www.sun.com/software/products/lustre/docs/GPLv2.pdf is no
>> longer around, so replace it with (hopefully more permanent)
>> http://http://www.gnu.o
The "Please contact Oracle Corporation" lines are removed since not
only Oracle has nothing to do with Lustre anymore, there's a pointer
to GPL already that's independent of any particular company.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/include/linux/libc
n even bigger mess I assume.
Changelog:
V2 to fix double http:// in front of gnu.org url
Oleg Drokin (5):
staging/lustre: Remove the "Please contact SUN for GPL" from headers
staging/lustre: Replace sun.com GPLv2 URL with gnu.org one.
staging/lustre/lov: Fix gpl URL in lov_pool.c
The 'copy of GPLv2]' is an ending from template that's no longer needed,
so remove it to avoid any extra confusion.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lnet/selftest/selftest.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/lustre/lnet/self
There's no longer a matching sun.com URL, so refer to
gnu.org copy.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/lov/lov_pool.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/lov/lov_pool.c
b/drivers/staging/lustre/l
http://www.sun.com/software/products/lustre/docs/GPLv2.pdf is no
longer around, so replae it with (hopefully more permanent)
http://http://www.gnu.org/licenses/gpl-2.0.html
Signed-off-by: Oleg Drokin
Reported-by: Xose Vazquez Perez
---
drivers/staging/lustre/include/linux/libcfs/curproc.h
When OpenSFS took over lustre.org, there was some reshuffling.
FIDs on ZFS document is now at
http://wiki.old.lustre.org/index.php/Architecture_-_Interoperability_fids_zfs
instead of the old location, so update comments accordingly.
Signed-off-by: Oleg Drokin
Reported-by: Xose Vazquez Perez
From: Emoly Liu
This patch fixes all checkpatch occurences of
"CHECK: Logical continuations should be on the previous line"
in Lustre code.
Signed-off-by: Emoly Liu
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/ldlm/ldlm_flock.c | 9 -
drivers/staging/lus
These are just some more cleanups in Lustre styel and comments
Emoly Liu (2):
staging/lustre: Fix blank line before EXPORT_SYMBOL()
staging/lustre: Keep logical continuations on the previous line
Oleg Drokin (2):
staging/lustre: Remove unnecessary space after a cast
staging/lustre
This patch fixes all checkpatch occurences of
"CHECK: No space is necessary after a cast"
in Lustre code.
Signed-off-by: Emoly Liu
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/include/linux/lnet/lib-dlc.h | 2 +-
drivers/staging/lustre/include/linux/lnet/types.h
From: Emoly Liu
This patch fixes one checkpatch warning in lustre:
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
Signed-off-by: Emoly Liu
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c | 1 -
1 file changed, 1 deletion
-id: https://jira.hpdd.intel.com/browse/LU-7402
Reviewed-by: Dmitry Eremin
Reviewed-by: Lai Siyao
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/namei.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/namei.c
b/drive
cache
- cl_cache_incref(): increase cl_cache refcount
- cl_cache_decref(): decrease cl_cache refcount and free the cache
if refcount=0.
Signed-off-by: Emoly Liu
Reviewed-on: http://review.whamcloud.com/13746
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6173
Reviewed-by: Niu Yawei
Signed-off-by: Oleg D
https://jira.hpdd.intel.com/browse/LU-7973
Reviewed-by: Lai Siyao
Reviewed-by: Yang Sheng
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/file.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/llite/file.c
b/drivers/staging/
ing/lustre/ptlrpc: missing wakeup for ptlrpc_check_set
Niu Yawei (1):
staging/lustre/mdc: Zero atime in close RPC
Oleg Drokin (6):
staging/lustre/llite: Get rid of ll_lock_dcache/ll_unlock_dcache
staging/lustre/osc: Fix reverted condition in osc_lock_weight
staging/lustre: Inline Lus
nlinked"
Signed-off-by: Liang Zhen
Reviewed-on: http://review.whamcloud.com/12158
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5696
Reviewed-by: Johann Lombardi
Reviewed-by: Li Wei
Reviewed-by: Mike Pershin
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lustre_ne
These are just doing spin_lock/unlock on inode's i_lock,
so just do the spinlock directly to make the code more clear
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/dcache.c | 4 ++--
drivers/staging/lustre/lustre/llite/llite_internal.h | 10 --
dr
When importing clio simplification patch, the check for
object got reversed by mistake when converting from
if (obj == NULL) it somehow became if (obj) which is obviously wrong,
and so when it does hit, a crash was happening as result.
Fix the condition and all if fine now.
Signed-off-by: Oleg
: Oleg Drokin
---
drivers/staging/lustre/lustre/osc/osc_lock.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/lustre/lustre/osc/osc_lock.c
b/drivers/staging/lustre/lustre/osc/osc_lock.c
index 42def38..d856775 100644
--- a/drivers/staging/lustre
memory, it also can reduce memory footprint while
processing.
Signed-off-by: Liang Zhen
Reviewed-on: http://review.whamcloud.com/8806
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-181
Reviewed-by: Andreas Dilger
Reviewed-by: Bobi Jam
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre
http://review.whamcloud.com/18934
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7434
Reviewed-by: Chris Horn
Reviewed-by: Andreas Dilger
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/ptlrpc/events.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/lu
dreas Dilger
Reviewed-by: Alex Zhuravlev
Reviewed-by: John L. Hammond
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lu_object.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/include/lu_object.h
b/drivers/staging/lustre/l
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/llite_mmap.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/llite_mmap.c
b/drivers/staging/lustre/lustre/llite/llite_mmap.c
index fb1c3b6..66ee5db 100644
--- a/drivers/staging/lus
101 - 200 of 434 matches
Mail list logo
