I don't know if there is a problem here. Please check the lines mentiond
below, ie lines 839 and 1003.
julia
-- Forwarded message --
Date: Tue, 11 Sep 2018 17:17:15 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: [staging:staging-next 11
erved lock leaking. h...
>
> If I am wrong, please point out thanks...
It's fine. Sorry for the wrong report. Coccinelle can't analyze
conditional tests and that level, and I missed the unlocked when I looked
at it.
julia
>
> Thanks,
> Gao Xiang
>
> On 2018/9/1
Hello,
Please check whether an unlock is needed before line 386.
thanks,
julia
-- Forwarded message --
Date: Sun, 30 Sep 2018 01:57:53 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: [staging:staging-next 433/443]
drivers/staging/vboxvideo
On Mon, 22 Oct 2018, Shayenne da Luz Moura wrote:
> This patch fixes the checkpatch.pl check:
>
> vbox_main.c:119: CHECK: Unnecessary parentheses around 'rects[i].x2 <
> crtc->x'
> vbox_main.c:119: CHECK: Unnecessary parentheses around 'rects[i].y2 <
> crtc->y'
Please use the imperative, in th
On Wed, 24 Oct 2018, Russell King - ARM Linux wrote:
> On Wed, Oct 24, 2018 at 12:45:44PM +0200, Matthias Brugger wrote:
> > Hi Kiberly,
> >
> > Thanks for adding all the emails in CC.
> > I would encourage you for your next patch to distinguish between CC and TO.
> > You should send your patch
[Adding Joe Perches]
On Fri, 26 Oct 2018, Sasha Levin wrote:
> On Fri, Oct 26, 2018 at 04:04:45PM -0300, Shayenne da Luz Moura wrote:
> > This change was suggested by checkpath.pl. Use unsigned int with bitfield
> > allocate only one bit to the boolean variable.
> >
> > CHECK: Avoid using bool st
On Sat, 27 Oct 2018, Joe Perches wrote:
> On Fri, 2018-10-26 at 22:54 +0200, Julia Lawall wrote:
> > [Adding Joe Perches]
> >
> > On Fri, 26 Oct 2018, Sasha Levin wrote:
> >
> > > On Fri, Oct 26, 2018 at 04:04:45PM -0300, Shayenne da Luz Moura wrote:
> The "possible alignement issues" in CHECK report is difficult to figure
> out by just doing a glance analysis. :)
>
> Linus also suggested to use bool as the base type i.e., `bool x:1` but
> again sizeof(_Bool) is implementation defined ranging from 1-4 bytes.
If bool x:1 has the size of bool, t
On Sun, 28 Oct 2018, Himanshu Jha wrote:
> On Sun, Oct 28, 2018 at 09:47:15AM +0100, Julia Lawall wrote:
> > > The "possible alignement issues" in CHECK report is difficult to figure
> > > out by just doing a glance analysis. :)
> > >
> > > Linu
On Tue, 30 Oct 2018, Shayenne Moura wrote:
> Hi,
>
> > On Sun, 28 Oct 2018, Himanshu Jha wrote:
> >
> > > On Sun, Oct 28, 2018 at 09:47:15AM +0100, Julia Lawall wrote:
> > > > > The "possible alignement issues" in CHECK report is difficul
On Tue, 30 Oct 2018, Shayenne Moura wrote:
> On 10/30, Greg Kroah-Hartman wrote:
> > On Tue, Oct 23, 2018 at 02:43:04PM -0300, Shayenne da Luz Moura wrote:
> > > Remove unneeded parentheses around the arguments of ||. This reduces
> > > clutter and code behave in the same way.
> > > Change sugg
On Sat, 17 Oct 2020, Joe Perches wrote:
> On Sat, 2020-10-17 at 09:09 -0700, t...@redhat.com wrote:
> > From: Tom Rix
> >
> > This is a upcoming change to clean up a new warning treewide.
> > I am wondering if the change could be one mega patch (see below) or
> > normal patch per file about 10
On Mon, 19 Oct 2020, Ian Abbott wrote:
> On 18/10/2020 20:49, Deepak R Varma wrote:
> > Instructions split on multiple lines can be combined on a single line
> > for improved readability of the code.
> >
> > Signed-off-by: Deepak R Varma
> > ---
> > .../staging/comedi/drivers/tests/ni_routes
On Wed, 21 Oct 2020, Deepak R Varma wrote:
> Replace bit masking by BIT macro. This resolves checkpatch issue
Replace bit masking by the BIT macro. This resolves the checkpatch issue
> "CHECK: Prefer using the BIT macro"
>
> Signed-off-by: Deepak R Varma
> ---
> drivers/staging/kpc2000/kpc2
On Thu, 22 Oct 2020, izabela.bakoll...@gmail.com wrote:
> From: Izabela Bakollari
>
> Rearrange comment that exceeds 100 columns length. Issue reported
> by checkpatch.pl
>
> Signed-off-by: Izabela Bakollari
> ---
> drivers/staging/wlan-ng/cfg80211.c | 3 ++-
> 1 file changed, 2 insertions(+
On Thu, 22 Oct 2020, izabela.bakoll...@gmail.com wrote:
> From: Izabela Bakollari
>
> Fix code alignment. Issue reported by checkpatch.pl
Try to find something other than "Fix" to describe what you have done.
What kind of change have you made and why is it a good idea?
>
> Signed-off-by: Izab
On Fri, 23 Oct 2020, Elena Afanasova wrote:
> kmalloc() and memset() calls can be replaced with kzalloc().
It would be nice to say why the change is correct.
julia
> Found with Coccinelle.
>
> Signed-off-by: Elena Afanasova
> ---
> drivers/staging/rtl8192e/rtllib_tx.c | 4 +---
> 1 file ch
The above is not the right subject line for this file (ie the part to the
left of the colon). You should use git log --oneline on this file to see
what others have done.
julia
On Fri, 23 Oct 2020, Elena Afanasova wrote:
> kmalloc() and memset() calls can be replaced with kzalloc().
> Found with
On Fri, 23 Oct 2020, Elena Afanasova wrote:
> Correct the code style for comparison to NULL. Reported by checkpatch.pl.
I have the impression that the subject line is too detailed, and the log
message is not detailed enough. The subject line should just orient the
reader, so they can decide w
In the subject line, there should not a space before the colon.
Thanks for improving the subjects and messages otherwise.
julia
On Fri, 23 Oct 2020, Elena Afanasova wrote:
> The coding style (!bar) is more common than (bar == NULL). Reported by
> checkpatch.pl.
>
> Signed-off-by: Elena Afanaso
On Sun, 25 Oct 2020, Elena Afanasova wrote:
> Replace kmalloc + memset 0 by a call to kzalloc which zeroes memory too.
> Found with Coccinelle.
>
> Signed-off-by: Elena Afanasova
> ---
> Changes in v3:
> - use array_size()
> Changes in v2:
> - correct the subject line
>
These patches fix cases where a subsequent statement is aligned
with the right hand side of an assignment rather than the left
hand side. This was done using the following semantic match
(http://coccinelle.lip6.fr/). It has a lot of false positives,
because Coccinelle doesn't record the differenc
Delete tab aligning a statement with the right hand side of a
preceding assignment rather than the left hand side.
Found with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff
On Wed, 20 Feb 2019, Himadri Pandya wrote:
> Decrement the reference count on port while returning out of the loop.
I don't think you sent this to the right people. You need to send it to
the people indicated in get_maintainer.pl. This is not updating a staging
driver.
julia
>
> Signed-off
On Tue, 12 Mar 2019, maowenan wrote:
>
>
> On 2019/3/12 14:35, Joe Perches wrote:
> > On Tue, 2019-03-12 at 14:29 +0800, maowenan wrote:
> >> ping...
> >>
> >> On 2019/3/9 11:26, Mao Wenan wrote:
> >>> Using is_zero_ether_addr() instead of directly use
> >>> memcmp() to determine if the etherne
You can drop the if on line 3490.
julia
-- Forwarded message --
Date: Tue, 3 Sep 2019 04:28:35 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: [staging:staging-testing 268/273]
drivers/staging/exfat/exfat_super.c:3491:2-7: WARNING: NULL check
On Thu, 3 Oct 2019, Nachammai Karuppiah wrote:
> Avoid typedefs to maintain kernel coding style. Issue found by
> checkpatch.pl
>
> Replace the enum typedef VCHIQ_REASON_T with vchiq_reason.
Would it be possible to get rid of them all? They seem to all go
together, since they start with the s
Hello,
Is an unlock needed on line 53?
julia
-- Forwarded message --
Date: Fri, 4 Oct 2019 19:14:33 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: [staging:staging-testing 50/59] drivers/staging/wfx/hif_tx.c:53:2-8:
preceding lock on line 38
CC
On Sun, 6 Oct 2019, Joe Perches wrote:
> On Sun, 2019-10-06 at 11:50 +0200, Greg KH wrote:
> > On Sat, Oct 05, 2019 at 06:00:46PM -0300, Gabriela Bittencourt wrote:
> > > Fix CHECK: add blank line after declarations
> []
> > > diff --git a/drivers/staging/greybus/control.h
> > > b/drivers/stag
On Sun, 6 Oct 2019, Jules Irenge wrote:
> Capitalize RANGE_mA to fix camelcase check warning.
> Issue reported by checkpatch.pl
I guess mA means something, so it would be better to keep it?
julia
>
> Signed-off-by: Jules Irenge
> ---
> drivers/staging/comedi/comedidev.h | 2 +-
>
On Mon, 7 Oct 2019, Jules Irenge wrote:
> Add comment to spinlock declaration to fix warning issued by checkpatch.pl
> "CHECK: spinlock_t definition without comment".
Since it is not apparent from the shown code, it would be helpful to
describe what evidence you used to choose this comment.
t
On Mon, 7 Oct 2019, Nachammai Karuppiah wrote:
> Remove NULL comparison. Issue found using checkpatch.pl
This introduces compiler warnings, which you should try very hard not to
do.
julia
>
> Signed-off-by: Nachammai Karuppiah
>
> ---
>
> Changes in V2
>- Remove all NULL comparisons in
; +return
> e;
> -return ret;
>
> Signed-off-by: Wambui Karuga
Acked-by: Julia Lawall
> ---
> drivers/staging/kpc2000/kpc2000_spi.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/kpc2000/kpc2000_spi.c
> b/drivers/s
On Wed, 9 Oct 2019, Jules Irenge wrote:
> Fix multiple assignments warning " check
> issued by checkpatch.pl tool:
> "CHECK: multiple assignments should be avoided".
>
> Signed-off-by: Jules Irenge
> ---
> drivers/staging/qlge/qlge_dbg.c | 6 --
> 1 file changed, 4 insertions(+), 2 delet
On Wed, 9 Oct 2019, Jules Irenge wrote:
> Correct misspelled word " check
Why is there a " in the above line?
You don't need to put a newline after check.
> issued by checkpatch.pl tool:
> "CHECK: serveral may be misspelled - perhaps several?".
It's not reall necessary to give the checkpat
On Wed, 9 Oct 2019, Joe Perches wrote:
> On Wed, 2019-10-09 at 22:48 +0200, Julia Lawall wrote:
> > On Wed, 9 Oct 2019, Jules Irenge wrote:
> > > Fix multiple assignments warning " check
> > > issued by checkpatch.pl tool:
> > > "CHECK: multiple a
On Fri, 11 Oct 2019, Wambui Karuga wrote:
> Remove typedef declaration from struct cvmx_wqe_t in
You can remove the _t from the name as well.
> drivers/staging/octeon/octeon-stubs.h.
It's not really necessary to give the name of the file in the log message,
as it can easily be seen below.
j
On Fri, 11 Oct 2019, Jules Irenge wrote:
> Fix warning of lines should not end with open parenthesis.
> Issue detected by checkpatch tool.
>
> Signed-off-by: Jules Irenge
> ---
> .../bcm2835-camera/bcm2835-camera.c | 38 ---
> 1 file changed, 16 insertions(+), 22 del
On Fri, 11 Oct 2019, Jules Irenge wrote:
> Fix warning of logical continuations should be on the previous line.
> Issue detected by checkpatch tool.
There seem to be several changes mixed together in this patch.
Don't have a subject line that is identical to a line in the log message.
The sub
On Fri, 11 Oct 2019, Gabriela Bittencourt wrote:
> Cleans up checks of "Alignment should match open parenthesis" in tree sm750fb
>
> Signed-off-by: Gabriela Bittencourt
> ---
> drivers/staging/sm750fb/ddk750_display.c | 2 +-
> drivers/staging/sm750fb/sm750_accel.c| 2 +-
> drivers/stag
rnet-tx.c | 4 +-
> drivers/staging/octeon/ethernet.c| 6 +--
> drivers/staging/octeon/octeon-ethernet.h | 2 +-
> drivers/staging/octeon/octeon-stubs.h| 56
> 7 files changed, 43 insertions(+), 41 deletions(-)
For the series:
Acked-by: Julia Lawal
On Sat, 12 Oct 2019, Wambui Karuga wrote:
> Remove typedef declaration for enum cvmx_fau_reg_32.
> Also replace its previous uses with new declaration format.
> Issue found by checkpatch.pl
>
> Signed-off-by: Wambui Karuga
> ---
> drivers/staging/octeon/octeon-stubs.h | 14 --
> 1
On Sun, 13 Oct 2019, Wambui Karuga wrote:
> Use the DIV_ROUND_UP macro to replace open-coded divisor calculation
> to improve readability.
> Issue found using coccinelle:
> @@
> expression n,d;
> @@
> (
> - ((n + d - 1) / d)
> + DIV_ROUND_UP(n,d)
> |
> - ((n + (d - 1)) / d)
> + DIV_ROUND_UP(n,d
On Sun, 13 Oct 2019, Jules Irenge wrote:
> Fix lines ending with open parenthesis. Issue detected by checkpatch tool.
> In the process, change driver functions name in the multiple files from:
> vchiq_mmal_port_parameter_set to vmp_prmtr_set
> vchiq_mmal_component_disable to vm_cmpnt_disable
>
(d - 1)) / d)
> + DIV_ROUND_UP(n,d)
> )
>
> Signed-off-by: Wambui Karuga
Acked-by: Julia Lawall
> ---
> Changes in v2:
> - Remove comment that explained previously used calculation.
Maybe it is not very important for a comment, but remember that what is
below the -
On Tue, 15 Oct 2019, Wambui Karuga wrote:
> Remove unnecessary casts in pointer types passed to kfree.
>
> Signed-off-by: Wambui Karuga
Acked-by: Julia Lawall
> ---
> drivers/staging/rtl8723bs/core/rtw_mlme.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-
> #ifndef VCHI_BULK_GRANULARITY
> # if __VCCOREVER__ >= 0x0400
> -# define VCHI_BULK_GRANULARITY 32 // Allows for the need to do cache
> cleans
> +#define VCHI_BULK_GRANULARITY 32 // Allows for the need of cache cleans
> # else
> # define VCHI_BULK_GRANULARITY 16
> #
On Sat, 19 Oct 2019, Jules Irenge wrote:
>
>
> On Sat, 19 Oct 2019, Dan Carpenter wrote:
>
> > On Sat, Oct 19, 2019 at 03:07:15PM +0100, Jules Irenge wrote:
> > > diff --git a/drivers/staging/wfx/bh.c b/drivers/staging/wfx/bh.c
> > > index 3355183fc86c..573216b08042 100644
> > > --- a/drivers/s
On Sun, 20 Oct 2019, Dan Carpenter wrote:
> On Sat, Oct 19, 2019 at 01:02:31PM -0700, Joe Perches wrote:
> > diff -u -p a/rtl8723bs/core/rtw_mlme_ext.c b/rtl8723bs/core/rtw_mlme_ext.c
> > --- a/rtl8723bs/core/rtw_mlme_ext.c
> > +++ b/rtl8723bs/core/rtw_mlme_ext.c
> > @@ -1132,7 +1132,7 @@ unsig
On Sun, 20 Oct 2019, Joe Perches wrote:
> On Sun, 2019-10-20 at 22:17 +0300, Dan Carpenter wrote:
> > On Sat, Oct 19, 2019 at 01:02:31PM -0700, Joe Perches wrote:
> > > diff -u -p a/rtl8723bs/core/rtw_mlme_ext.c b/rtl8723bs/core/rtw_mlme_ext.c
> []
> > > @@ -1132,7 +1132,7 @@ unsigned int OnAut
On Sun, 20 Oct 2019, Joe Perches wrote:
> On Sun, 2019-10-20 at 22:17 +0300, Dan Carpenter wrote:
> > On Sat, Oct 19, 2019 at 01:02:31PM -0700, Joe Perches wrote:
> > > diff -u -p a/rtl8723bs/core/rtw_mlme_ext.c b/rtl8723bs/core/rtw_mlme_ext.c
> []
> > > @@ -1132,7 +1132,7 @@ unsigned int OnAut
On Sun, 20 Oct 2019, Joe Perches wrote:
> On Sun, 2019-10-20 at 21:52 +0200, Julia Lawall wrote:
> > On Sun, 20 Oct 2019, Joe Perches wrote:
> []
> > > There's probably a generic cocci mechanism to check function
> > > prototypes and then remove uses of unne
> btw2:
>
> I really dislike all the code inconsistencies and
> unnecessary code duplication with miscellaneous changes
> in the rtl staging drivers
>
> Horrid stuff.
I'm not sure what you mean by "miscellaneous changes". Do you mean that
all issues should be fixed for one file before moving
> If you're making significant changes to this driver, please test them
> using the MIPS cavium_octeon_defconfig which is where this driver is
> actually used.
>
> This driver has broken builds a few times recently which makes me very
> tempted to ask that we stop allowing it to be built with COMPI
>
> On Thu, Oct 24, 2019 at 01:00:20PM +0300, Wambui Karuga wrote:
> > On Thu, Oct 24, 2019 at 07:26:59AM +0200, Julia Lawall wrote:
> > > > If you're making significant changes to this driver, please test them
> > > > using the MIPS cavium_octeon_defconfig
On Fri, 25 Oct 2019, Cristiane Naves wrote:
> Fix line ending with a '('
>
> Signed-off-by: Cristiane Naves
Acked-by: Julia Lawall
> ---
> drivers/staging/gasket/gasket_ioctl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> d
On Fri, 25 Oct 2019, Cristiane Naves wrote:
> Fix lines ending with a '('. Issue found by checkpatch.
You sent another patch on this file (the one I acked) and they are notin a
series, so Greg won't know how to apply them. Please collect the whole
thing again, and either put both changes in t
On Sat, 26 Oct 2019, Cristiane Naves wrote:
> Fix alignment should match open parenthesis. Issue found by checkpatch.
>
> Signed-off-by: Cristiane Naves
> ---
> drivers/staging/rtl8712/rtl8712_recv.c | 30 +++---
> 1 file changed, 15 insertions(+), 15 deletions(-)
>
>
On Mon, 28 Oct 2019, Dan Carpenter wrote:
> On Sat, Oct 26, 2019 at 07:24:53PM -0300, Cristiane Naves wrote:
> > Remove unneeded variable used to store return value. Issue found by
> > coccicheck.
> >
> > Signed-off-by: Cristiane Naves
> > ---
> > drivers/staging/octeon/octeon-stubs.h | 4 +--
On Mon, 28 Oct 2019, Gabriela Bittencourt wrote:
> Cleans up checks of "Avoid CamelCase" in file xd.c
>
> Signed-off-by: Gabriela Bittencourt
> ---
> drivers/staging/rts5208/xd.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rts5208/xd.c b/dr
On Tue, 29 Oct 2019, Gabriela Bittencourt wrote:
> Fixing typo in word 'and'.
>
> Signed-off-by: Gabriela Bittencourt
Acked-by: Julia Lawall
> ---
> drivers/staging/sm750fb/sm750_accel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> di
On Wed, 30 Oct 2019, Gabriela Bittencourt wrote:
> Cleans up checks of "Avoid CamelCase" in file sd.h
>
> Signed-off-by: Gabriela Bittencourt
> ---
> drivers/staging/rts5208/sd.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rts5208/sd.h b/drivers/st
On Wed, 30 Oct 2019, Gabriela Bittencourt wrote:
> Cleans up checks of "Avoid CamelCase" in files xd.{h,c}
>
> Signed-off-by: Gabriela Bittencourt
Acked-by: Julia Lawall
> ---
> drivers/staging/rts5208/xd.c | 8
> drivers/staging/rts5208/xd.h | 6
On Wed, 30 Oct 2019, Gabriela Bittencourt wrote:
> Cleans up checks of "Avoid CamelCase" in files ms.{h,c}
I think that these should be converted to all upper case rather than all
lower case.
julia
>
> Signed-off-by: Gabriela Bittencourt
> ---
> drivers/staging/rts5208/ms.c | 86 ++
The return at line 747 may need an unlock.
julia
-- Forwarded message --
Date: Sun, 3 Nov 2019 09:21:22 +0800
From: kbuild test robot
To: kbu...@lists.01.org
Cc: Julia Lawall
Subject: [staging:staging-testing 275/291]
drivers/staging/exfat/exfat_super.c:747:5-11: preceding
Remove final uses of the GOTO macro, and remove the associated macro and
underlying function.
drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h | 12
drivers/staging/lustre/lustre/libcfs/debug.c |8
drivers/staging/lustre/lustre/osc/osc_cache.c | 168 +
From: Julia Lawall
Remove the goto logging function, as it is no longer used.
Signed-off-by: Julia Lawall
---
drivers/staging/lustre/lustre/libcfs/debug.c |8
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/lustre/lustre/libcfs/debug.c
b/drivers/staging/lustre
From: Julia Lawall
Remove the GOTO macro, as it is no longer used.
Signed-off-by: Julia Lawall
---
drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h
b
From: Julia Lawall
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
//
@@
identifier lbl;
identifier rc;
constant c;
@@
- GOTO(lbl,\(rc\|c\));
+ goto lbl;
@@
identifier lbl;
expression rc;
@@
- GOTO(lbl,rc);
+ rc;
+ goto lbl;
//
In one case (OES_INV
> > This is especially true if you have trained yourself to know that
> > free_netdev() can't accept NULL pointers.
>
> Do you need to adjust your concerns a bit over time when function variants
> provide a corresponding safety check in their implementations?
There would not seem to be any _need_
> diff --git a/drivers/staging/rtl8188eu/core/rtw_efuse.c
> b/drivers/staging/rtl8188eu/core/rtw_efuse.c
> index 697876b..359f169 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_efuse.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_efuse.c
[...]
> -exit:
> +cleanup2:
> + kfree(eFuseWord);
> +
>
On Wed, 12 Nov 2014, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Wed, 12 Nov 2014 20:25:49 +0100
>
> The functions kfree(), rtw_free_netdev() and vfree() test whether their
> argument is NULL and then return immediately. Thus the test around the call
> is not needed.
>
> This issue
From: Julia Lawall
Delete a local structure that is only used to be initialized by memset.
A semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
//
@@
identifier x,i;
@@
{
... when any
-struct i x;
<+... when != x
- memset(&x,...);
...+>
}
//
Sig
Remove an array or structure that only serves as the first argument to
memset. The complete semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
//
@@
identifier x;
type T;
@@
{
... when any
-T x[...];
<+... when != x
- memset(x,...);
...+>
}
@@
identifier x,i;
@@
These patches replace what appears to be a reference to the name of the
current function but is misspelled in some way by either the name of the
function itself, or by %s and then __func__ in an argument list.
//
// sudo apt-get install python-pip
// sudo pip install python-Levenshtein
// spatch
Replace a misspelled function name by %s and then __func__.
This is the get function, not the set function, as was indicated by the
string.
This was done using Coccinelle, including the use of Levenshtein distance,
as proposed by Rasmus Villemoes.
Signed-off-by: Julia Lawall
---
The semantic
On Mon, 8 Dec 2014, Julian Calaby wrote:
> Hi Julia,
>
> On Mon, Dec 8, 2014 at 6:20 AM, Julia Lawall wrote:
> > These patches replace what appears to be a reference to the name of the
> > current function but is misspelled in some way by either the name of the
> > fu
On Fri, 26 Apr 2019, Vatsala Narang wrote:
> Remove return in void function to get rid of checkpatch warning.
>
> Signed-off-by: Vatsala Narang
Acked-by: Julia Lawall
> ---
> drivers/staging/rtl8723bs/core/rtw_xmit.c | 2 --
> 1 file changed, 2 deletions(-)
>
&
> @@ -5828,8 +5822,6 @@ void survey_timer_hdl(struct timer_list *t)
>
>
> exit_survey_timer_hdl:
> -
> - return;
> }
Are you sure that you compiled this code? I'm not sure that it is possible
to have a label without a subsequent statement.
julia
On Fri, 28 Jun 2019, Fuqian Huang wrote:
> Use zeroing allocator rather than allocator followed with memset 0.
Maybe it would be better to just change these to the appropriate kmalloc
and kzalloc calls.
You will need to check on whether locks are held to know whether the secon
argument should
On Sun, 10 Sep 2017, Harsha Sharma wrote:
> Use one space around most binary operators
>
> Signed-off-by: Harsha Sharma
Acked-by: Julia Lawall
> ---
> drivers/staging/rtl8723bs/os_dep/os_intfs.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
&
On Sun, 10 Sep 2017, Harsha Sharma wrote:
> Use one space around (on each side of) '=' operator
>
> Signed-off-by: Harsha Sharma
Acked-by: Julia Lawall
> ---
> drivers/staging/rtl8723bs/os_dep/os_intfs.c | 20 ++--
> 1 file changed, 10
On Sun, 10 Sep 2017, Harsha Sharma wrote:
> Use spaces around most binary operators
>
> Signed-off-by: Harsha Sharma
Acked-by: Julia Lawall
> ---
> drivers/staging/rtl8723bs/os_dep/os_intfs.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
&
On Sun, 10 Sep 2017, Harsha Sharma wrote:
> No spaces at the start of a line
>
> Signed-off-by: Harsha Sharma
Acked-by: Julia Lawall
> ---
> drivers/staging/rtl8723bs/os_dep/os_intfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/
On Sun, 10 Sep 2017, Harsha Sharma wrote:
> Use spaces between concatenated strings
Perhaps all the entry/exit ones could be dropped, and the ohters could be
rewritten to use more standard kernel debugging functionalities.
julia
>
> Signed-off-by: Harsha Sharma
> ---
> drivers/staging/rtl87
On Sun, 10 Sep 2017, Harsha Sharma wrote:
> Space required after ','
>
> Signed-off-by: Harsha Sharma
Acked-by: Julia Lawall
> ---
> drivers/staging/rtl8723bs/os_dep/os_intfs.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff
On Mon, 11 Sep 2017, Srishti Sharma wrote:
> Remove extra blank line.
>
> Signed-off-by: Srishti Sharma
Acked-by: Julia Lawall
> ---
> drivers/staging/rtl8712/rtl8712_event.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/rtl8
On Mon, 11 Sep 2017, Srishti Sharma wrote:
> The use of volatile for the variable monitor_lock is unnecessary.
You need to give more evidence of why this is the case. How is the
variable used? I guess this comes from checkpatch, but checkpatch has
only a local view of things, and doesn't know
On Mon, 11 Sep 2017, Srishti Sharma wrote:
> On Mon, Sep 11, 2017 at 9:34 PM, Greg KH wrote:
> > On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote:
> >> The use of volatile for the variable monitor_lock is unnecessary.
> >>
> >> Signed-off-by: Srishti Sharma
> >> ---
> >> drivers
On Tue, 12 Sep 2017, Daniel Baluta wrote:
> Hi Himanshi,
>
> On Tue, Sep 12, 2017 at 1:43 AM, Himanshi Jain
> wrote:
> > Fixed IIO_DEVICE_ATTR_NAMED API to take name as a
> > string instead of implicit conversion to string using
> > preprocessors. Added double quotes around names in
> > existi
It'sa small detail, but perhaps you could fix the spelling of unnecessary
(1 c and 2 s's).
julia
On Tue, 12 Sep 2017, Harsha Sharma wrote:
> Remove space between function name and open parenthesis '('
> Remove space before ';', '++', ','
>
> Signed-off-by: Harsha Sharma
> ---
> Change in v2:
>
gt; Space required before '&', '*'
> Space is required after ',', ';'
>
> Signed-off-by: Harsha Sharma
Acked-by: Julia Lawall
> ---
> drivers/staging/rtl8723bs/os_dep/mlme_linux.c | 30
> +--
> 1 file chan
e;
> -return ret;
>
> Signed-off-by: Srishti Sharma
Acked-by: Julia Lawall
> ---
> drivers/staging/media/atomisp/i2c/ov5693/ov5693.c | 11 ++-
> 1 file changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/i2c/ov5693/ov5693
e;
> -return ret;
>
> Signed-off-by: Srishti Sharma
Acked-by: Julia Lawall
> ---
> drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c | 6 +-
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm
On Tue, 12 Sep 2017, himanshi wrote:
> Thanks for the review Daniel! I will change the imperative mood for the commit
> message once the other changes are finalised too and as suggested by Julia,
> would try to make the description specific than general.
>
> I tried to think of adding subsystem
. };
>
> @@
> identifier r.i, r.s, rr.fld;
> position r.p;
> @@
> (
> -pr_err@p
> +netdev_err
> (
> + i->fld,
> ...)
> |
> -pr_info@p
> +netdev_info
> (
> + i->fld,
> ...)
> |
> -pr_debug@p
> +netdev_dbg
> (
> + i->f
On Wed, 13 Sep 2017, Himanshi Jain wrote:
> This patchset is to rewrite the IIO_DEVICE_ATTR_NAMED API to pass name
> as string.
You need to indicate what has changed in the v2, either here or in the
individual patches.
julia
>
> Himanshi Jain (2):
> include: linux: sysfs: Add __ATTR_NAMED
On Wed, 13 Sep 2017, Joe Perches wrote:
> On Thu, 2017-09-14 at 00:43 +0300, Dan Carpenter wrote:
> > He was exagerating a bit to call it a "static checker" warning...
>
> Not really.
>
> False positives and false negatives exist in just about
> every static
> checker.
>
> > It's just checkpatch
edef
> struct
> + T2
> { ... }
> -T
> ;
>
> @r3@
> type r1.T;
> identifier c1.T2;
> @@
> -T
> +struct T2
>
> Signed-off-by: Haneen Mohammed
Acked-by: Julia Lawall
> ---
> drivers/staging/irda/include/net/irda/qos.h | 20 ++--
> 1 fi
On Thu, 14 Sep 2017, Harsha Sharma wrote:
> Merge assignment with return statement to directly return the value.
> Done using following coccinelle semantic patch
>
> @@
> local idexpression ret;
> expression e;
> @@
>
> -ret =
> +return
> e;
> -return re
1 - 100 of 696 matches
Mail list logo
