On Wed, 5 Jun 2019 20:24:09 -0700
Randy Dunlap wrote:
> On 6/5/19 7:05 PM, Fabio Estevam wrote:
> > On x86_64 when GPIOLIB is not set the following build errors
> > are seen:
> >
> > drivers/staging/iio/addac/adt7316.c:947:3: error: implicit declaration of
> > function 'gpiod_set_value' [-Werro
On Fri, 14 Jun 2019 13:50:59 -0300
Melissa Wen wrote:
> Remove idiom and use ternary operator for consistently trigger 0/1 value
> on variable declaration.
>
> Signed-off-by: Melissa Wen
Hi Melissa,
In general I would consider this unnecessary churn as, whilst
it's no longer a favoured idiom,
On Fri, 14 Jun 2019 13:32:21 -0300
Melissa Wen wrote:
> Use the bitfield macro FIELD_GET, and GENMASK to do the shift and mask in
> one go. This makes the code more readable than explicit masking followed
> by a shift.
>
> Signed-off-by: Melissa Wen
Applied to the togreg branch of iio.git and p
On Fri, 14 Jun 2019 13:33:19 -0300
Melissa Wen wrote:
> General cleaning of comments to remove useless information or improve
> description.
>
> Signed-off-by: Melissa Wen
Applied,
Thanks,
Jonathan
> ---
> drivers/staging/iio/cdc/ad7150.c | 11 ++-
> 1 file changed, 2 insertions(+),
On Fri, 14 Jun 2019 13:32:54 -0300
Melissa Wen wrote:
> Since i2c_smbus_write_byte_data returns no-positive value, this commit
> making the treatment of its return value less verbose.
>
> Signed-off-by: Melissa Wen
Applied to the togreg branch of iio.git and pushed out as testing for
the autobu
On Fri, 14 Jun 2019 23:28:46 +0800
YueHaibing wrote:
> Fix build error:
>
> drivers/staging/iio/addac/adt7316.c: In function adt7316_store_update_DAC:
> drivers/staging/iio/addac/adt7316.c:949:3: error: implicit declaration of
> function gpiod_set_value; did you mean gpio_set_value?
> [-Werror
On Fri, 14 Jun 2019 13:43:02 -0600
Rob Herring wrote:
> On Fri, 24 May 2019 22:26:30 -0300, Renato Lui Geh wrote:
> > This patch adds a YAML binding for the Analog Devices AD7780/1 and
> > AD7170/1 analog-to-digital converters.
> >
> > Signed-off-by: Renato Lui Geh
> > ---
> > Changes in v2:
>
On Mon, 17 Jun 2019 13:09:20 +0200
Arnd Bergmann wrote:
> When building without CONFIG_GPIOLIB, we get a compile-time failure:
>
> drivers/staging/iio/addac/adt7316.c:947:3: error: implicit declaration of
> function 'gpiod_set_value' [-Werror,-Wimplicit-function-declaration]
> g
On Sat, 8 Jun 2019 12:30:39 +0100
Jonathan Cameron wrote:
> On Mon, 27 May 2019 15:56:49 +0300
> Beniamin Bia wrote:
>
> > Support for ad7616 running in software was added. In order
> > to activate the software mode, HW_RNGSEL pins must be pulled low.
> > Oversampli
On Mon, 17 Jun 2019 11:40:34 +0300
Dan Carpenter wrote:
> On Sun, Jun 16, 2019 at 11:15:16AM +0100, Jonathan Cameron wrote:
> > On Fri, 14 Jun 2019 13:50:59 -0300
> > Melissa Wen wrote:
> >
> > > Remove idiom and use ternary operator for consistently trigg
On Fri, 28 Jun 2019 16:49:22 -0300
Bárbara Fernandes wrote:
> Create list of compatible device ids to be matched with those stated in
> the device tree.
>
> Signed-off-by: Bárbara Fernandes
> Signed-off-by: Wilson Sales
> Co-developed by: Wilson Sales
> ---
Patch is fine and applied to the to
On Fri, 26 Jul 2019 14:59:16 -0300
Matheus Tavares Bernardino wrote:
> On Fri, Jul 26, 2019 at 2:30 AM Ardelean, Alexandru
> wrote:
> >
> > On Fri, 2019-07-26 at 01:38 +0530, Kartik Kulkarni wrote:
> > > Add the of_device_id struct and the respective
> > > of_match_device entry to complete dev
On Fri, 26 Jul 2019 12:36:08 +
"Ardelean, Alexandru" wrote:
> On Fri, 2019-07-26 at 19:07 +0800, Chuhong Yuan wrote:
> > [External]
> >
> > Use device-managed API to simplify the code.
> > The remove function is redundant now and can
> > be deleted.
>
> Reviewed-by: Alexandru Ardelean
Th
On Wed, 13 Sep 2017 14:14:07 +0530
Himanshi Jain wrote:
> Add __ATTR_NAMED macro similar to __ATTR but taking name as a
> string instead of implicit conversion of argument to string using
> the macro _stringify(_name).
>
> Signed-off-by: Himanshi Jain
> ---
> include/linux/sysfs.h | 7 +++
On Wed, 13 Sep 2017 10:46:59 +0200 (CEST)
Julia Lawall wrote:
> On Wed, 13 Sep 2017, Himanshi Jain wrote:
>
> > This patchset is to rewrite the IIO_DEVICE_ATTR_NAMED API to pass name
> > as string.
>
> You need to indicate what has changed in the v2, either here or in the
> individual patches
On 13 September 2017 12:23:31 GMT-07:00, Lars-Peter Clausen
wrote:
>On 09/13/2017 08:58 PM, Greg KH wrote:
>> On Wed, Sep 13, 2017 at 06:03:10PM +0100, Jonathan Cameron wrote:
>>> On Wed, 13 Sep 2017 14:14:07 +0530
>>> Himanshi Jain wrote:
>>>
>>>&
On 13 September 2017 14:58:23 GMT-07:00, Joe Perches wrote:
>On Thu, 2017-09-14 at 00:43 +0300, Dan Carpenter wrote:
>> He was exagerating a bit to call it a "static checker" warning...
>
>Not really.
>
>False positives and false negatives exist in just about
>every static
>checker.
>
>> It's ju
On Sat, 16 Sep 2017 14:18:52 +0200
Paolo Cretaro wrote:
> On 16/09/2017 13:37, Dan Carpenter wrote:
> > On Sat, Sep 16, 2017 at 01:11:29PM +0200, Paolo Cretaro wrote:
> >> Hi Dan,
> >> just minor nitpicking on the commit message:
> >>
> >> On 08/09/2017 12:53, Dan Carpenter wrote:
> >>> The b
On Thu, 14 Sep 2017 16:31:06 +0200
Michael Hennerich wrote:
> On 14.09.2017 15:50, Stefan Popa wrote:
> > SPI host drivers can use DMA to transfer data, so the buffer should be
> > properly allocated.
> > Keeping it on the stack could cause an undefined behavior.
> >
> > The dedicated reset fun
On Sat, 16 Sep 2017 15:22:23 -0700
Jonathan Cameron wrote:
> On Thu, 14 Sep 2017 16:31:06 +0200
> Michael Hennerich wrote:
>
> > On 14.09.2017 15:50, Stefan Popa wrote:
> > > SPI host drivers can use DMA to transfer data, so the buffer should be
> > > proper
On Mon, 18 Sep 2017 16:19:07 +0530
Himanshi Jain wrote:
> On Thu, Sep 14, 2017 at 2:20 AM, Jonathan Cameron
> wrote:
> >
> >
> > On 13 September 2017 12:23:31 GMT-07:00, Lars-Peter Clausen
> > wrote:
> >>On 09/13/2017 08:58 PM, Greg KH wrote:
> &g
On Wed, 13 Sep 2017 18:02:02 +0100
Colin King wrote:
> From: Colin Ian King
>
> The current shift of st->rx[2] left shifts a u8 24 bits left,
> promotes the integer to a an int and then to a unsigned u64. If
> the top bit of st->rx[2] is set then we end up with all the upper
> bits being set to
On Tue, 26 Sep 2017 23:56:15 +0530
Harsha Sharma wrote:
> The contents of the header file are used only by this single source file.
> Moved content into iio-trig-bfin-timer.c and removed iio-trig-bfin-timer.h
>
> Signed-off-by: Harsha Sharma
Hmm. This one again. Sometimes you need to not just
On Fri, 29 Sep 2017 21:09:21 -0400
Brian Masney wrote:
> The sysfs attributes in_intensity0_thresh_period and
> in_proximity0_thresh_period are currently directly created by the driver.
> This patch migrates the creation of these sysfs attributes from the driver
> to using the IIO core via iio_ev
On Fri, 29 Sep 2017 21:09:20 -0400
Brian Masney wrote:
> The driver explicitly creates the in_illuminance0_integration_time sysfs
> attribute outside the IIO core. This attribute is available in the IIO
> core so this patches migrates the attribute to be created by
> the iio_chan_spec.
>
> Signe
On Fri, 29 Sep 2017 21:09:19 -0400
Brian Masney wrote:
> The length of the 'tsl2x7x_settings' variable within the tsl2X7X_chip
> structure makes some of the line lengths greater than 80 characters for
> upcoming patches. This patch shortens the name of the 'tsl2x7x_settings'
> variable in this st
On Thu, 19 Oct 2017 16:06:20 -0400
Brian Masney wrote:
> The sysfs attributes in_intensity0_thresh_period and
> in_proximity0_thresh_period are currently directly created by the driver.
> This patch migrates the creation of these sysfs attributes from the driver
> to using the IIO core via iio_ev
On Thu, 19 Oct 2017 16:06:21 -0400
Brian Masney wrote:
> The structure tsl2x7x_parse_result is not used so this patch removes its
> definition.
>
> Signed-off-by: Brian Masney
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.
Thanks,
Jonat
On Thu, 19 Oct 2017 16:06:22 -0400
Brian Masney wrote:
> Sort the #include statements for increased code readability.
>
> Signed-off-by: Brian Masney
Applied.
Thanks,
Jonathan
> ---
> drivers/staging/iio/light/tsl2x7x.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
>
On Thu, 19 Oct 2017 16:06:23 -0400
Brian Masney wrote:
> tsl2x7x.h has a blank definition for 'struct iio_dev' that is not
> needed. This patch removes that definition.
>
> Signed-off-by: Brian Masney
Applied
Thanks,
Jonathan
> ---
> drivers/staging/iio/light/tsl2x7x.h | 2 --
> 1 file chang
On Thu, 19 Oct 2017 16:06:24 -0400
Brian Masney wrote:
> Some of the existing #defines have tabs between the name, and the value,
> while others have spaces. The alignment of the values mostly has a
> consistent layout, but there are some that don't. Change all of the
> defines so that the name a
On Thu, 19 Oct 2017 16:06:25 -0400
Brian Masney wrote:
> The sysfs attribute in_proximity0_calibscale_available is currently
> created by using DEVICE_ATTR_RO(). Convert this over to use
> IIO_CONST_ATTR().
>
> Signed-off-by: Brian Masney
Applied.
> ---
> drivers/staging/iio/light/tsl2x7x.c |
On Thu, 19 Oct 2017 16:06:26 -0400
Brian Masney wrote:
> This patch fixes the error 'Unnecessary parentheses around 'XXX' from
> checkpatch.pl. It also fixes several other places with unnecessary
> parentheses that checkpatch.pl did not detect.
>
> Signed-off-by: Brian Masney
Some of these are
On Thu, 19 Oct 2017 16:06:27 -0400
Brian Masney wrote:
> Correct error from checkpatch.pl to improve code readibility: Alignment
> should match open parenthesis. This involved shortening the name of
> tsl2x7x_als_gainadj and tsl2x7x_prx_gainadj to tsl2x7x_als_gain and
> tsl2x7x_prx_gain respectiv
On Thu, 19 Oct 2017 16:06:28 -0400
Brian Masney wrote:
> Correct error from checkpatch.pl to improve code readibility: Alignment
> should match open parenthesis. An unnecessary cast to 'struct
> tsl2x7x_lux *' was removed and the return value of static definition of
> in_illuminance0_calibscale_a
On Thu, 19 Oct 2017 16:06:29 -0400
Brian Masney wrote:
> The LED power defines are named like TSL2X7X_mAXXX. Rename these values
> to TSL2X7X_XXX_mA to improve code readability.
>
> Signed-off-by: Brian Masney
Applied
> ---
> drivers/staging/iio/light/tsl2x7x.c | 10 +-
> 1 file change
On Thu, 19 Oct 2017 16:06:30 -0400
Brian Masney wrote:
> Correct the alignment of the break statements to match the alignment of
> the rest of the code within the case statements.
>
> Signed-off-by: Brian Masney
Applied.
> ---
> drivers/staging/iio/light/tsl2x7x.c | 4 ++--
> 1 file changed, 2
On Thu, 19 Oct 2017 16:06:31 -0400
Brian Masney wrote:
> The functions tsl2x7x_invoke_change() and tsl2x7x_prox_calculate() are
> short enough that the return value and static declaration can be moved
> onto the same line with the function name. This patch makes that change
> to increase code rea
On Thu, 19 Oct 2017 16:06:32 -0400
Brian Masney wrote:
> This patch adds a return_max label for the two cases that need to set
> the lux to TSL2X7X_LUX_CALC_OVER_FLOW and return.
>
> Signed-off-by: Brian Masney
Sorry - don't like this last one. I think it hurts readability. Leave
this as it w
On Fri, 3 Nov 2017 09:09:21 +0100
SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Fri, 3 Nov 2017 09:00:25 +0100
>
> * Add a jump target so that a call of the function "mutex_unlock" is stored
> only twice in this function implementation.
>
> * Replace two calls by goto statements.
>
On Fri, 3 Nov 2017 09:33:57 +0100
SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Fri, 3 Nov 2017 09:26:28 +0100
>
> * Add a jump target so that a call of the function "mutex_unlock" is stored
> only twice in this function implementation.
>
> * Replace two calls by goto statements.
>
On Thu, 30 Nov 2017 21:13:34 +0530
Arvind Yadav wrote:
> The platform_get_irq() function returns negative if an error occurs.
> zero or positive number on success. platform_get_irq() error checking
> for zero is not correct.
>
> Signed-off-by: Arvind Yadav
Applied to the togreg branch of iio.gi
On Mon, 18 Jun 2018 19:44:50 +0200
Karim Eshapa wrote:
> Use sign_extend32 kernel function instead of code duplication,
> Safe also for 16 bit. and remove declaration of bits variable not needed.
>
> Signed-off-by: Karim Eshapa
Applied, thanks.
Jonathan
> ---
> drivers/staging/iio/accel/adi
On Mon, 25 Jun 2018 21:11:23 +0200
Karim Eshapa wrote:
> Doing some macro replacement to start an array of structures
> so it can be reused by manipulating it with different values.
>
> Signed-off-by: Karim Eshapa
There are all sorts of issues with the ABI this driver is providing to
userspace,
On 12/02/17 07:22, Derek Robson wrote:
> Change permissions to octal style.
> Found using checkpatch
>
> Signed-off-by: Derek Robson
Applied to the togreg branch of iio.git and pushed out as testing for the
autobuilders
to play with it.
Jonathan
> ---
> drivers/staging/iio/impedance-analyzer/a
On 12/02/17 10:55, Brian Masney wrote:
> The sysfs attribute in_proximity_sampling_frequency_available currently
> shows the values 1 3 5 10 13 20 83 100. These values are supposed to
> correspond to the sleep values 800 400 200 100 75 50 12 0 (all in ms).
> When passing in a sampling frequency of
On 12/02/17 11:04, Brian Masney wrote:
> On Sun, Feb 12, 2017 at 05:55:34AM -0500, Brian Masney wrote:
>> Move ISL29028 ALS / Proximity Sensor out of staging and into mainline.
>>
>> Signed-off-by: Brian Masney
>
> Sorry, Jonathan, I forgot to run git format-patch with --no-renames and
> didn't r
On 28/02/17 18:51, simran singhal wrote:
> The contents of the header file are used only by this single
> source file. Move content into .c and remove .h.
>
> Signed-off-by: simran singhal
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.
Tha
On 28/02/17 19:17, Jonathan Cameron wrote:
> On 28/02/17 18:51, simran singhal wrote:
>> The contents of the header file are used only by this single
>> source file. Move content into .c and remove .h.
>>
>> Signed-off-by: simran singhal
> Applied to the togreg branc
On 01/03/17 18:37, Arushi Singhal wrote:
> The contents of the header file are used only by this single
> source file. Move content into .c and remove .h.
>
> Signed-off-by: Arushi Singhal
> ---
> drivers/staging/iio/frequency/ad9832.c | 100 +-
> drivers/staging/iio/freq
On 01/03/17 18:37, Arushi Singhal wrote:
> The contents of the header file are used only by this single
> source file. Move content into .c and remove .h.
>
> Signed-off-by: Arushi Singhal
Just noticed that I have another series doing this change waiting for
review so probably going to have alrea
On 28/02/17 19:49, simran singhal wrote:
> The contents of the header file are used only by this single
> source file. Move content into .c and remove .h.
>
> Signed-off-by: simran singhal
Hi Simran,
Good follow up but as I'd already applied it I made the mods directly to
the original patch. Ple
On 05/03/17 06:59, Derek Robson wrote:
> Changed file permission to octal style.
> Found using checkpatch
>
> Signed-off-by: Derek Robson
Hi Derek,
I've already applied a similar patch to the iio.git tree. It just hasn't made
it to the main staging tree quite yet.
Thanks,
Joanthan
> ---
> dr
On 10/03/17 03:57, Bo Yu wrote:
> The following Coccinelle script was used to detect this:
>
> @@
> local idexpression ret;
> expression e;
> @@
>
> -ret =
> +return
> e;
> -return ret;
A bit of fuzz on this one. Presumably things moving around in other recent
changes.
Anyhow, applied to
On 11/03/17 14:26, simran singhal wrote:
> This patch-series removes exceptional & on functions name.
>
> v1:
> -Change the commit message of all the patches of the patch-series
Usual convention is to call the first (unlabelled) revision v1
implicitly which would have made this V2. Doesn't real
On 11/03/17 14:26, simran singhal wrote:
> Remove & from function pointers to conform to the style found elsewhere
> in the file. Done using the following semantic patch
>
> //
> @r@
> identifier f;
> @@
>
> f(...) { ... }
> @@
> identifier r.f;
> @@
>
> - &f
> + f
> //
>
> Signed-off-by: si
On 11/03/17 14:26, simran singhal wrote:
> Remove & from function pointers to conform to the style found elsewhere
> in the file. Done using the following semantic patch
>
> //
> @r@
> identifier f;
> @@
>
> f(...) { ... }
> @@
> identifier r.f;
> @@
>
> - &f
> + f
> //
>
> Signed-off-by: si
On 11/03/17 14:26, simran singhal wrote:
> Remove & from function pointers to conform to the style found elsewhere
> in the file. Done using the following semantic patch
>
> //
> @r@
> identifier f;
> @@
>
> f(...) { ... }
> @@
> identifier r.f;
> @@
>
> - &f
> + f
> //
>
> Signed-off-by: si
On 11/03/17 14:26, simran singhal wrote:
> Remove & from function pointers to conform to the style found elsewhere
> in the file. Done using the following semantic patch
>
> //
> @r@
> identifier f;
> @@
>
> f(...) { ... }
> @@
> identifier r.f;
> @@
>
> - &f
> + f
> //
>
> Signed-off-by: si
On 11/03/17 14:26, simran singhal wrote:
> Remove & from function pointers to conform to the style found elsewhere
> in the file. Done using the following semantic patch
>
> //
> @r@
> identifier f;
> @@
>
> f(...) { ... }
> @@
> identifier r.f;
> @@
>
> - &f
> + f
> //
>
> Signed-off-by: si
On 11/03/17 14:26, simran singhal wrote:
> Remove & from function pointers to conform to the style found elsewhere
> in the file. Done using the following semantic patch
>
> //
> @r@
> identifier f;
> @@
>
> f(...) { ... }
> @@
> identifier r.f;
> @@
>
> - &f
> + f
> //
>
> Signed-off-by: si
On 11/03/17 14:26, simran singhal wrote:
> Remove & from function pointers to conform to the style found elsewhere
> in the file. Done using the following semantic patch
>
> //
> @r@
> identifier f;
> @@
>
> f(...) { ... }
> @@
> identifier r.f;
> @@
>
> - &f
> + f
> //
>
> Signed-off-by: si
On 11/03/17 14:26, simran singhal wrote:
> Remove & from function pointers to conform to the style found elsewhere
> in the file. Done using the following semantic patch
>
> //
> @r@
> identifier f;
> @@
>
> f(...) { ... }
> @@
> identifier r.f;
> @@
>
> - &f
> + f
> //
>
> Signed-off-by: si
On 11/03/17 14:26, simran singhal wrote:
> Remove & from function pointers to conform to the style found elsewhere
> in the file. Done using the following semantic patch
>
> //
> @r@
> identifier f;
> @@
>
> f(...) { ... }
> @@
> identifier r.f;
> @@
>
> - &f
> + f
> //
>
> Signed-off-by: si
On 11/03/17 14:26, simran singhal wrote:
> Remove & from function pointers to conform to the style found elsewhere
> in the file. Done using the following semantic patch
>
> //
> @r@
> identifier f;
> @@
>
> f(...) { ... }
> @@
> identifier r.f;
> @@
>
> - &f
> + f
> //
>
> Signed-off-by: si
On 11/03/17 18:48, Jonathan Cameron wrote:
> On 11/03/17 14:26, simran singhal wrote:
>> Remove & from function pointers to conform to the style found elsewhere
>> in the file. Done using the following semantic patch
>>
>> //
>> @r@
>> identifier f;
>
On 13/03/17 19:53, Alison Schofield wrote:
> On Mon, Mar 13, 2017 at 10:01:07PM +0530, simran singhal wrote:
>> The IIO subsystem is redefining iio_dev->mlock to be used by
>> the IIO core only for protecting device operating mode changes.
>> ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* mo
On 18/03/17 17:34, SIMRAN SINGHAL wrote:
> On Thu, Mar 16, 2017 at 3:23 AM, Jonathan Cameron wrote:
>> On 13/03/17 19:53, Alison Schofield wrote:
>>> On Mon, Mar 13, 2017 at 10:01:07PM +0530, simran singhal wrote:
>>>> The IIO subsystem is redefining iio_dev->mloc
On 18/03/17 18:46, SIMRAN SINGHAL wrote:
> On Sat, Mar 18, 2017 at 11:51 PM, Jonathan Cameron wrote:
>> On 18/03/17 17:34, SIMRAN SINGHAL wrote:
>>> On Thu, Mar 16, 2017 at 3:23 AM, Jonathan Cameron wrote:
>>>> On 13/03/17 19:53, Alison Schofield wrote:
>>&g
On 18/03/17 18:44, simran singhal wrote:
> The IIO subsystem is redefining iio_dev->mlock to be used by
> the IIO core only for protecting device operating mode changes.
> ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
>
> In this driver, mlock was being used to protect hardware stat
On 17/03/17 09:32, Gargi Sharma wrote:
> On Mon, Mar 13, 2017 at 5:30 PM, Lars-Peter Clausen wrote:
>>
>> On 03/12/2017 02:32 PM, simran singhal wrote:
>>> The IIO subsystem is redefining iio_dev->mlock to be used by
>>> the IIO core only for protecting device operating mode changes.
>>> ie. Chang
On 16/03/17 14:28, Miguel Robles wrote:
> Fix checkpatch warning:
> Statements should start on a tabstop.
>
> Signed-off-by: Miguel Robles
Applied with the part name added to the patch title.
Jonathan
> ---
> drivers/staging/iio/resolver/ad2s1210.c | 4 ++--
> 1 file changed, 2 insertions(+), 2
On 19/03/17 13:16, Gargi Sharma wrote:
> On Sun, Mar 19, 2017 at 4:01 PM, Jonathan Cameron wrote:
>> On 17/03/17 09:32, Gargi Sharma wrote:
>>> On Mon, Mar 13, 2017 at 5:30 PM, Lars-Peter Clausen wrote:
>>>>
>>>> On 03/12/2017 02:32 PM, simran singhal wr
On 19/03/17 17:14, Gargi Sharma wrote:
> On Sun, Mar 19, 2017 at 6:20 PM, simran singhal
> wrote:
>> The IIO subsystem is redefining iio_dev->mlock to be used by
>> the IIO core only for protecting device operating mode changes.
>> ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
>>
>>
On 21 March 2017 17:27:02 GMT+00:00, Julia Lawall wrote:
>
>
>On Tue, 21 Mar 2017, Arushi Singhal wrote:
>
>>
>>
>> On Tue, Mar 21, 2017 at 10:32 PM, Alison Schofield
>
>> wrote:
>> On Tue, Mar 21, 2017 at 05:39:38PM +0100, Julia Lawall wrote:
>> >
>> >
>> > On Tue, 21 Ma
8 Barry Song 2010-10-27 5 *
>> e071f6b8 Barry Song 2010-10-27 6 * Licensed under the GPL-2 or
>> later.
>> e071f6b8 Barry Song 2010-10-27 7 */
>> e071f6b8 Barry Song 2010-10-27 8
>> 45296236 Paul Gortmaker 2011-08-30 @9 #include
On 21/03/17 15:06, Arushi Singhal wrote:
> Typedefs are removed in sm750fb driver.
>
> Arushi Singhal (2):
> staging: sm750fb: Remove typedef from "typedef struct _mode_parameter_t"
> staging: sm750fb: Remove typedef from "typedef enum _spolarity_t"
>
> drivers/staging/sm750fb/ddk750_mode.c
On 20/03/17 12:53, simran singhal wrote:
> The IIO subsystem is redefining iio_dev->mlock to be used by
> the IIO core only for protecting device operating mode changes.
> ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
>
> In this driver, mlock was being used to protect hardware stat
On 22/03/17 16:20, simran singhal wrote:
> The IIO subsystem is redefining iio_dev->mlock to be used by
> the IIO core only for protecting device operating mode changes.
> ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
>
> In this driver, mlock was being used to protect hardware stat
On 22/03/17 16:42, Arushi Singhal wrote:
> This patch replaces bit shifting on 1 with the BIT(x) macro.
> This was done with coccinelle:
> @@
> constant c;
> @@
>
> -1 << c
> +BIT(c)
>
> Signed-off-by: Arushi Singhal
Applied to the togreg branch of iio.git and pushed out as testing for
the autob
On 22/03/17 20:00, kbuild test robot wrote:
> Hi simran,
>
> [auto build test WARNING on iio/togreg]
> [also build test WARNING on v4.11-rc3 next-20170322]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improve the system]
>
> url:
> https://github.com/0da
On 20/03/17 15:15, simran singhal wrote:
> The contents of ade7754.h are only used in ade7754.c.
> Move the header contents to the implementation file,
> and delete the header file.
>
> Signed-off-by: simran singhal
Unfortunately already done by sayli karnik back on the 8th of March.
Jonathan
>
On 20/03/17 15:15, simran singhal wrote:
> Alphabetize and separate kernel and subsystem headers.
>
> Signed-off-by: simran singhal
Applied to the togreg branch of iio.git and pushed out as testing for the
autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/staging/iio/meter/ade7754
On 21/03/17 18:03, simran singhal wrote:
> This patch removes trailing whitespaces in order to follow the Linux
> coding style.
>
> Signed-off-by: simran singhal
Applied and pushed out as testing...
Jonathan
> ---
> drivers/staging/iio/meter/ade7753.c | 8
> 1 file changed, 4 insertion
On 21/03/17 18:03, simran singhal wrote:
> The IIO subsystem is redefining iio_dev->mlock to be used by
> the IIO core only for protecting device operating mode changes.
> ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
>
> In this driver, mlock was being used to protect hardware stat
On 20/03/17 19:51, Arushi Singhal wrote:
> The IIO subsystem is redefining iio_dev->mlock to be used by
> the IIO core only for protecting device operating mode changes.
> ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
>
> In this driver, mlock was being used to protect hardware stat
On 20/03/17 16:09, Arushi Singhal wrote:
> The IIO subsystem is redefining iio_dev->mlock to be used by
> the IIO core only for protecting device operating mode changes.
> ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
>
> In this driver, mlock was being used to protect hardware stat
On 20/03/17 14:12, Arushi Singhal wrote:
> The IIO subsystem is redefining iio_dev->mlock to be used by
> the IIO core only for protecting device operating mode changes.
> ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
>
> In this driver, mlock was being used to protect hardware stat
On 22 March 2017 19:22:20 GMT+00:00, Jonathan Cameron wrote:
>On 22/03/17 16:20, simran singhal wrote:
>> The IIO subsystem is redefining iio_dev->mlock to be used by
>> the IIO core only for protecting device operating mode changes.
>> ie. Changes between INDIO_DI
On 23 March 2017 18:12:33 GMT+00:00, SIMRAN SINGHAL
wrote:
>On Thu, Mar 23, 2017 at 1:55 AM, Jonathan Cameron
>wrote:
>> On 21/03/17 18:03, simran singhal wrote:
>>> The IIO subsystem is redefining iio_dev->mlock to be used by
>>> the IIO core only for protect
On 24/03/17 13:55, Arushi Singhal wrote:
> Remove the extra parenthesis remove the checkpatch issue.
>
> Signed-off-by: Arushi Singhal
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/staging/iio/cdc/ad7746
On 23/03/17 06:18, Mark Stenglein wrote:
> Fixes three checkpatch warnings due to braces used when single
> statements are sufficient.
>
> Signed-off-by: Mark Stenglein
Applied to the togreg branch of iio.git - initially pushed
out as testing for the autobuilders to play with it.
Thanks,
Jonath
On 23/03/17 09:20, simran singhal wrote:
> The IIO subsystem is redefining iio_dev->mlock to be used by
> the IIO core only for protecting device operating mode changes.
> ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
>
> In this driver, mlock was being used to protect hardware stat
On 29 March 2017 16:38:28 BST, Julia Lawall wrote:
>
>
>On Wed, 29 Mar 2017, Arushi Singhal wrote:
>
>> Remove the extra parenthesis remove the checkpatch issue.
>
>Is this a patch on the current state of the staging tree? When I do a
>pull and then look at the code, the line numbers are all of
On 29 March 2017 17:05:51 BST, Arushi Singhal
wrote:
>Remove the extra parenthesis remove the checkpatch issue.
>
>Signed-off-by: Arushi Singhal
Patch doesn't need resending as already applied.
If it did the description is now incorrect!
>---
>changes in v2
> -done the changes according to th
On 28/03/17 18:37, Arushi Singhal wrote:
> The IIO subsystem is redefining iio_dev->mlock to be used by
> the IIO core only for protecting device operating mode changes.
> ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
>
> In this driver, mlock was being used to protect hardware stat
On 28/03/17 13:01, Andrea della Porta wrote:
> Coding style issue resolved.
>
> Signed-off-by: Andrea della Porta
Please include the driver name in the title. Subsystem also good.
staging:iio:accel:adis16029 drop braces around single element if block
or something along those lines would be good.
On 28/03/17 19:37, Alison Schofield wrote:
> On Tue, Mar 28, 2017 at 10:55:17PM +0530, SIMRAN SINGHAL wrote:
>> On Fri, Mar 24, 2017 at 12:51 AM, Alison Schofield
>> wrote:
>>> On Fri, Mar 24, 2017 at 12:05:20AM +0530, simran singhal wrote:
The IIO subsystem is redefining iio_dev->mlock to b
On 30 March 2017 19:44:26 BST, SIMRAN SINGHAL wrote:
>On Fri, Mar 31, 2017 at 12:02 AM, Jonathan Cameron
>wrote:
>> On 28/03/17 19:37, Alison Schofield wrote:
>>> On Tue, Mar 28, 2017 at 10:55:17PM +0530, SIMRAN SINGHAL wrote:
>>>> On Fri, Mar 24, 2017 at 1
On 01/04/17 03:28, simran singhal wrote:
> As the event_attrs field of iio_info structures is constant, so these
> attribute_group structures can also be declared constant.
>
> File size before:
>text data bss dec hex filename
> 15064 1528 0 1659240d
301 - 400 of 1076 matches
Mail list logo