checked all these drivers to ensure that all ioctl arguments
> are used as pointers or are ignored, but are not interpreted as integer
> values.
>
> Signed-off-by: Arnd Bergmann
> ---
For IIO part.
Acked-by: Jonathan Cameron
Thanks,
> diff --git a/drivers/iio/industri
On Mon, 1 Oct 2018 16:35:33 +0300
Dan Carpenter wrote:
> On Mon, Oct 01, 2018 at 02:54:55PM +0200, Lars-Peter Clausen wrote:
> > On 10/01/2018 02:52 PM, Dan Carpenter wrote:
> > > On Mon, Oct 01, 2018 at 02:28:34PM +0200, Slawomir Stepien wrote:
> > >> The checkpatch.pl tool detected coding s
On Fri, 5 Oct 2018 22:24:26 -0300
Matheus Tavares Bernardino wrote:
> This patch fixes all "Assignment operator '=' should be on the previous
> line" checks found in ad2s1210.c by checkpatch.pl.
>
> Signed-off-by: Matheus Tavares
Hi Matheus,
Good change, but unfortunately your email client as
On Fri, 5 Oct 2018 10:04:44 +0200
Slawomir Stepien wrote:
> By using the copy of channel attribute, we can now make the lines short
> enough to eliminate the checkpatch.pl problem:
>
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Slawomir Stepien
Applied to the togreg
On Fri, 5 Oct 2018 10:05:15 +0200
Slawomir Stepien wrote:
> These lines were misaligned, but the checkpatch.pl didn't indicate them
> as such.
>
> Signed-off-by: Slawomir Stepien
Applied to the togreg branch of iio.git and pushed out as
testing for the autobuilders to play with it.
Thanks,
Jo
On Thu, 4 Oct 2018 20:06:55 -0300
Renato Lui Geh wrote:
> This patch fixes all "Alignment should match open parenthesis" check
> warnings found by checkpatch.pl in the addac/adt7316 driver.
>
> Signed-off-by: Renato Lui Geh
Hi,
Mostly good, but alignment doesn't override other considerations s
On Mon, 8 Oct 2018 00:29:38 -0300
Matheus Tavares wrote:
> This patch fixes all "Assignment operator '=' should be on the previous
> line" checks found in ad2s1210.c with checkpatch.pl.
>
> Signed-off-by: Matheus Tavares
Great, thanks for sorting this out and coming back with a V2 so quickly.
On Mon, 8 Oct 2018 19:12:05 -0300
Renato Lui Geh wrote:
> This patch fixes most "Alignment should match open parenthesis" check
> warnings found by checkpatch.pl in the addac/adt7316 driver.
>
> Signed-off-by: Renato Lui Geh
> ---
Please in future put a description here (below the ---) of the c
On Wed, 17 Oct 2018 22:31:47 -0300
Marcelo Schmitt wrote:
> Change close parenthesis alignment to match respective open parenthesis at
> iio/drivers/staging/iio/adc/ad7606.c line 379.
> This makes the file more compliant with the preferred coding style for the
> linux kernel.
Hi Marcelo,
Nice cl
On Thu, 18 Oct 2018 09:40:00 +0200
Lars-Peter Clausen wrote:
> On 10/18/2018 09:28 AM, Phil Reid wrote:
> [...]
> >> + chip->rdwr_pin = devm_gpiod_get(&spi_dev->dev, "rdwr", GPIOD_IN);
> >> + if (IS_ERR(chip->rdwr_pin)) {
> >> + ret = PTR_ERR(chip->rdwr_pin);
> >> + dev_err(&s
On Thu, 18 Oct 2018 12:10:32 +0300
Stefan Popa wrote:
> Move ad7606 ADC driver out of staging and into the mainline.
>
> Signed-off-by: Stefan Popa
Hi Stefan,
Great to be moving forward on this. A few comments inline. There are
some somewhat old school structures in here we can do better no
On Sun, 28 Oct 2018 13:21:25 +0530
Nishad Kamdar wrote:
> Use the gpiod interface instead of the deprecated old non-descriptor
> interface.
>
> Signed-off-by: Nishad Kamdar
Hi Nishad,
Sorry it took me most of the week to get to this. It's a trade off when you
want to make fast progress, but I
On Sun, 28 Oct 2018 13:23:23 +0530
Nishad Kamdar wrote:
> Replace platform data with device tree support.
>
> Signed-off-by: Nishad Kamdar
The whole gpio in or out thing makes less and less sense to
me and seems to contradict the datasheet.
If I'm not missing something I would just get rid of
On Sat, 27 Oct 2018 17:49:03 +0200
Slawomir Stepien wrote:
> Hi
>
> On paź 26, 2018 18:55, Nishad Kamdar wrote:
> > Add device tree table for matching vendor ID
> > and support for retrieving platform data
> > from device tree.
>
> So maybe you should make 2 commits?
>
> > Signed-off-by: Nis
On Wed, 24 Oct 2018 22:03:54 +0530
Nishad Kamdar wrote:
> On Mon, Oct 22, 2018 at 11:22:15PM +0530, Shreeya Patel wrote:
> > On Mon, 2018-10-22 at 22:44 +0530, Nishad Kamdar wrote:
> > > Use the gpiod interface instead of the deprecated old non-descriptor
> > > interface for ldac_pin.
> > >
>
On Mon, 22 Oct 2018 17:40:25 -0300
Victor Colombo wrote:
> This patch fixes the checkpatch.pl warning:
>
> WARNING: No space is necessary after a cast
>
> Signed-off-by: Victor Colombo
Applied to the togreg branch of iio.git and pushed out as testing for the
autobuilders to play with it and se
On Mon, 22 Oct 2018 17:41:27 -0300
Victor Colombo wrote:
> This patch fixes the checkpatch.pl warning:
>
> WARNING: Blank lines aren't necessary before a close brace '}'
>
> Signed-off-by: Victor Colombo
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to
On Thu, 25 Oct 2018 19:30:04 -0300
Renato Lui Geh wrote:
> The ad7780 driver previously did not read the correct device output, as
> it read an outdated value set at initialization. It now updates its
> voltage on read.
>
> Signed-off-by: Renato Lui Geh
> ---
> drivers/staging/iio/adc/ad7780.c
On Thu, 25 Oct 2018 19:30:37 -0300
Renato Lui Geh wrote:
> Variable val subtracted an uninitialized value on IIO_CHAN_INFO_OFFSET.
> This was fixed by assigning the correct value instead.
>
> Signed-off-by: Renato Lui Geh
It obviously doesn't make much difference, but as you are respinning any
On Fri, 26 Oct 2018 23:00:00 -0300
Matheus Tavares wrote:
> Previously, when spi_read returned an error code inside ad2s90_read_raw,
> the code was ignored and IIO_VAL_INT was returned. This patch makes the
> function return the error code returned by spi_read when it fails.
>
> Signed-off-by: M
On Fri, 26 Oct 2018 23:00:01 -0300
Matheus Tavares wrote:
> Previously, ad2s90_probe ignored the return code from spi_setup, not
> handling its possible failure. This patch makes ad2s90_probe check if
> the code is an error code and, if so, do the following:
>
> - Call dev_err with an appropriat
On Fri, 26 Oct 2018 23:00:04 -0300
Matheus Tavares wrote:
> This patch adds the IIO_CHAN_INFO_SCALE mask to ad2s90_chan and
> implements the relative read behavior at ad2s90_read_raw.
>
> Signed-off-by: Victor Colombo
> Signed-off-by: Matheus Tavares
Hi,
A suggestion inline. This is a commo
On Fri, 26 Oct 2018 22:59:59 -0300
Matheus Tavares wrote:
> This patch set adds scale info to ad2s90's single channel, improve
> error handling in it's functions and fix a possible race condition
> issue.
>
> The goal with this patch set is to address the points discussed in the
> mailing list i
On Sun, 28 Oct 2018 13:52:32 -0300
Renato Lui Geh wrote:
> Hi Jonathan,
>
> Thank you for the review.
>
> >> + voltage_uv = regulator_get_voltage(st->reg);
> >> + if (voltage_uv)
> >> + st->int_vref_mv = voltage_uv/1000;
> >>*val = st->int_vref_mv
On Fri, 2 Nov 2018 10:49:59 -0300
Matheus Tavares wrote:
> On 10/28/18 1:40 PM, Jonathan Cameron wrote:
> > On Fri, 26 Oct 2018 23:00:00 -0300
> > Matheus Tavares wrote:
> >
> >> Previously, when spi_read returned an error code inside ad2s90_read_raw,
> >&g
On Fri, 2 Nov 2018 10:59:06 -0300
Matheus Tavares wrote:
> On 10/28/18 1:43 PM, Jonathan Cameron wrote:
> > On Fri, 26 Oct 2018 23:00:01 -0300
> > Matheus Tavares wrote:
> >
> >> Previously, ad2s90_probe ignored the return code from spi_setup, not
> >&
On Thu, 1 Nov 2018 21:05:09 +0530
Himanshu Jha wrote:
> On Wed, Oct 31, 2018 at 09:30:36PM +0530, Nishad Kamdar wrote:
> > Add device tree table for matching vendor ID.
> >
> > Signed-off-by: Nishad Kamdar
> > ---
> > drivers/staging/iio/resolver/ad2s1210.c | 7 +++
> > 1 file changed, 7 i
On Wed, 31 Oct 2018 21:28:52 +0530
Nishad Kamdar wrote:
> Use the gpiod interface instead of the deprecated old non-descriptor
> interface.
>
> Signed-off-by: Nishad Kamdar
It would have been less 'noisy' to do these in the reverse order (drop
the flag and support first, then do the gpiod conve
On Wed, 31 Oct 2018 21:29:53 +0530
Nishad Kamdar wrote:
> Drop gpioin flag which decides how the GPIOs
> are controlled as the GPIOs must be outputs
> for the host as per the datasheet.
>
> Signed-off-by: Nishad Kamdar
Whilst this does the right thing, it doesn't take advantage
of opportunities
On Thu, 1 Nov 2018 15:02:32 +
"Ardelean, Alexandru" wrote:
> Good catch.
>
> Acked-by: Alexandru Ardelean
On the basis this has been broken for a long time, and you are clearly
doing other nearby not fix work, I'm going to take this through the togreg
tree rather than via the quicker fix pa
On Thu, 1 Nov 2018 15:20:55 +
"Ardelean, Alexandru" wrote:
> On Thu, 2018-11-01 at 11:43 -0300, Renato Lui Geh wrote:
> > The ad7780 driver previously did not read the correct device output, as
> > it read an outdated value set at initialization. It now updates its
> > voltage on read.
> >
>
On Sat, 3 Nov 2018 12:39:27 +
Jonathan Cameron wrote:
> On Thu, 1 Nov 2018 21:05:09 +0530
> Himanshu Jha wrote:
>
> > On Wed, Oct 31, 2018 at 09:30:36PM +0530, Nishad Kamdar wrote:
> > > Add device tree table for matching vendor ID.
> > >
&
On Thu, 1 Nov 2018 15:28:19 +
"Ardelean, Alexandru" wrote:
> On Thu, 2018-11-01 at 11:43 -0300, Renato Lui Geh wrote:
> > This patch removes the unnecessary field int_vref_mv in ad7780_state
> > referring to the device's voltage.
> >
> > Signed-off-by: Renato Lui Geh
> > ---
> > Changes in
On Sat, 3 Nov 2018 12:45:09 +
Jonathan Cameron wrote:
> On Wed, 31 Oct 2018 21:28:52 +0530
> Nishad Kamdar wrote:
>
> > Use the gpiod interface instead of the deprecated old non-descriptor
> > interface.
> >
> > Signed-off-by: Nishad Kamdar
> It woul
On Sat, 3 Nov 2018 13:06:19 -0300
Renato Lui Geh wrote:
> On Thu, 1 Nov 2018 15:20:55 +
> "Ardelean, Alexandru" wrote:
> >
> > This looks wrong.
> > I admit this was done in the same way in the probe function, but that looks
> > a bit wrong as well.
> >
> > Typically, the return value of `re
On Sat, 3 Nov 2018 12:59:16 -0300
Renato Lui Geh wrote:
> Hi,
>
> >On Thu, 1 Nov 2018 15:02:32 +
> >"Ardelean, Alexandru" wrote:
> >
> >> Good catch.
>
> That was actually Jonathan's catch. :)
>
> >> Acked-by: Alexandru Ardelean
>
> I read up on Acked-by on the kernel docs, as I d
On Sat, 3 Nov 2018 13:04:04 -0300
Matheus Tavares Bernardino wrote:
> On Sun, Oct 28, 2018 at 1:50 PM Jonathan Cameron wrote:
> >
> > On Fri, 26 Oct 2018 23:00:04 -0300
> > Matheus Tavares wrote:
> >
> > > This patch adds the IIO_CHAN_INFO_SCALE mask to
On Sat, 3 Nov 2018 19:49:43 -0300
Matheus Tavares wrote:
> Previously, when spi_read returned an error code inside ad2s90_read_raw,
> the code was ignored and IIO_VAL_INT was returned. This patch makes the
> function return the error code returned by spi_read when it fails.
>
> Signed-off-by: M
On Sat, 3 Nov 2018 19:49:44 -0300
Matheus Tavares wrote:
> Previously, ad2s90_probe ignored the return code from spi_setup, not
> handling its possible failure. This patch makes ad2s90_probe check if
> the code is an error code and, if so, do the following:
>
> - Call dev_err with an appropriat
On Sat, 3 Nov 2018 19:49:45 -0300
Matheus Tavares wrote:
> This patch removes an initial assignment to the variable ret at probe,
> that was always overwritten.
>
> Signed-off-by: Matheus Tavares
Applied to the togreg branch of iio.git and pushed out as testing to
see if we are both wrong and
On Sat, 3 Nov 2018 19:49:46 -0300
Matheus Tavares wrote:
> Previously, devm_iio_device_register was being called before the
> spi_setup call and the spi_device's max_speed_hz and mode assignments.
> This could lead to a race condition since the driver was still being
> set up after it was alread
On Sat, 3 Nov 2018 19:49:47 -0300
Matheus Tavares wrote:
> This patch adds the IIO_CHAN_INFO_SCALE mask to ad2s90_chan and
> implements the relative read behavior at ad2s90_read_raw.
>
> Signed-off-by: Victor Colombo
> Signed-off-by: Matheus Tavares
Hi Matheus,
Somewhere in the process, the
On Sat, 3 Nov 2018 19:49:48 -0300
Matheus Tavares wrote:
> This patch adds a channel type check at the beginning of the
> ad2s90_read_raw function. Since ad2s90 has only one channel, it just
> checks if the given channel is the expected one and if not, return
> -EINVAL.
>
> Signed-off-by: Mathe
On Fri, 9 Nov 2018 20:00:44 -0200
Matheus Tavares wrote:
> Move ad2s90 resolver driver out of staging to the main tree.
>
> Signed-off-by: Matheus Tavares
> Signed-off-by: Victor Colombo
For a move out of staging patch, please disable move detection.
It let's us see the whole driver and perf
On Fri, 9 Nov 2018 20:00:38 -0200
Matheus Tavares wrote:
> This patch set adds device tree support to ad2s90, with standard
> device tree id table, adds the respective dt-binding documentation,
> solves a codestyle warning and move the driver out of staging.
>
> This patch set completes all the
On Fri, 9 Nov 2018 20:00:40 -0200
Matheus Tavares wrote:
> The ad2s90 driver currently sets some spi settings (max_speed_hz and
> mode) at ad2s90_probe. This should, instead, be handled via device tree.
> This patch removes these configurations from the probe function.
>
> Note: The way in whic
On Fri, 9 Nov 2018 20:00:41 -0200
Matheus Tavares wrote:
> This patch adds a max frequency check at the beginning of ad2s90_probe
> function so that when it is set to a value above 0.83Mhz, dev_err is
> called with an appropriate message and -EINVAL is returned.
>
> The defined limit is 0.83Mhz
On Fri, 9 Nov 2018 20:00:42 -0200
Matheus Tavares wrote:
> This patch adds the device tree binding documentation for the ad2s90
> resolver-to-digital converter.
>
> Signed-off-by: Matheus Tavares
> ---
> .../bindings/iio/resolver/ad2s90.txt | 26 +++
> 1 file changed,
On Fri, 9 Nov 2018 13:05:17 +0530
Nishad Kamdar wrote:
> Use the gpiod interface for rdwr_pin, convert_pin and busy_pin
> instead of the deprecated old non-descriptor interface.
>
> Signed-off-by: Nishad Kamdar
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilde
On Sun, 11 Nov 2018 12:24:05 +
Jonathan Cameron wrote:
> On Fri, 9 Nov 2018 13:05:17 +0530
> Nishad Kamdar wrote:
>
> > Use the gpiod interface for rdwr_pin, convert_pin and busy_pin
> > instead of the deprecated old non-descriptor interface.
> >
>
On Fri, 9 Nov 2018 13:06:24 +0530
Nishad Kamdar wrote:
> AD7818 does not support busy_pin functionality as per datasheet.
> Hence drop busy_pin when AD7818 is used.
>
> Signed-off-by: Nishad Kamdar
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play wi
On Fri, 9 Nov 2018 13:07:18 +0530
Nishad Kamdar wrote:
> The RD/WR pin and CONVST pin are logical inputs to the AD78xx
> chip as per the datasheet. Hence convert them to outputs.
>
> Signed-off-by: Nishad Kamdar
Hi Nishad,
Applied to the togreg branch of iio.git and pushed out as testing
for t
On Fri, 9 Nov 2018 08:11:57 +
"Ardelean, Alexandru" wrote:
> On Fri, 2018-11-09 at 13:08 +0530, Nishad Kamdar wrote:
> > Add device tree table for matching vendor ID.
>
> One comment inline for this.
>
> Thanks
> Alex
>
> >
> > Signed-off-by: Nishad Kamdar
> > ---
> > drivers/staging/
On Thu, 8 Nov 2018 13:44:17 +
"Ardelean, Alexandru" wrote:
> On Thu, 2018-11-08 at 11:03 -0200, Giuliano Belinassi wrote:
> > Only the ad778x have the 'gain' status bit. Check it before updating
> > through a new variable is_ad778x in chip_info.
> >
>
> Looks good.
Alex, formal tags defin
On Fri, 9 Nov 2018 20:15:45 -0200
Giuliano Augusto Faulin Belinassi wrote:
> > Just some random though. Instead of introducing extra level of indentation
> > you
> > can simply check whether is_ad778x is asserted and simply return.
>
> I agree that the patch would be smaller if I do that, but
On Fri, 9 Nov 2018 20:18:58 -0200
Giuliano Augusto Faulin Belinassi wrote:
> Hi
>
> >While I agree that it looks nicer to indent all these to the same level,
> >you also need to think about the fact that the kernel git repo is already
> >pretty big as-is, so it's a good idea if a patch adds as m
On Tue, 6 Nov 2018 09:24:44 +
"Ardelean, Alexandru" wrote:
> On Mon, 2018-11-05 at 17:14 -0200, Renato Lui Geh wrote:
> > The ad7780 driver previously did not read the correct device output, as
> > it read an outdated value set at initialization. It now updates its
> > voltage on read.
> >
On Tue, 6 Nov 2018 09:25:27 +
"Ardelean, Alexandru" wrote:
> On Mon, 2018-11-05 at 17:16 -0200, Renato Lui Geh wrote:
> > This patch removes the unnecessary field int_vref_mv in ad7780_state
> > referring to the device's voltage.
> >
>
> Looks good from my side.
Applied to the togreg bran
On Thu, 15 Nov 2018 19:55:06 +0530
Nishad Kamdar wrote:
> On Thu, Nov 15, 2018 at 08:16:03AM +, Ardelean, Alexandru wrote:
> > On Wed, 2018-11-14 at 23:16 +0530, Nishad Kamdar wrote:
> > > Add device tree table for matching vendor ID.
> > >
> >
> > This could have been just one patch.
>
On Mon, 12 Nov 2018 07:57:24 +
"Ardelean, Alexandru" wrote:
> On Sun, 2018-11-11 at 14:30 +0000, Jonathan Cameron wrote:
> > On Tue, 6 Nov 2018 09:24:44 +
> > "Ardelean, Alexandru" wrote:
> >
> > > On Mon, 2018-11-05 at 17:14 -0200,
On Mon, 12 Nov 2018 07:57:58 +
"Ardelean, Alexandru" wrote:
> On Sun, 2018-11-11 at 12:58 +0000, Jonathan Cameron wrote:
> > On Thu, 8 Nov 2018 13:44:17 +
> > "Ardelean, Alexandru" wrote:
> >
> > > On Thu, 2018-11-08 at 11:03 -0200, G
On Thu, 15 Nov 2018 12:44:39 -0200
Matheus Tavares Bernardino wrote:
> On Sun, Nov 11, 2018 at 9:42 AM Jonathan Cameron wrote:
> >
> > On Fri, 9 Nov 2018 20:00:40 -0200
> > Matheus Tavares wrote:
> >
> > > The ad2s90 driver currently sets some spi setti
On Sat, 17 Nov 2018 04:19:07 +0530
Shreeya Patel wrote:
> adt7316_i2c_read function nowhere sets the data field.
> It is necessary to have an appropriate value for it.
> Hence, assign the value stored in 'ret' variable to data field.
>
> Signed-off-by: Shreeya Patel
I have amended the descripti
On Sat, 17 Nov 2018 04:21:32 +0530
Shreeya Patel wrote:
> ret = 0 indicates a case of no error but no data read from
> the bus which is an invalid case. This case doesn't ever happen
> in reality. It should perhaps be handled for correctness though.
>
> Signed-off-by: Shreeya Patel
Applied to t
On Sat, 17 Nov 2018 04:25:37 +0530
Shreeya Patel wrote:
> When the kernel starts up, it kicks off compiled-in drivers
> that match “compatible” entries it finds in the device tree.
> At a later stage (when /lib/modules is available), all kernel modules
> that match “compatible” entries in the dev
On Sat, 17 Nov 2018 04:27:32 +0530
Shreeya Patel wrote:
> Make the driver use device tree instead of the platform data.
> Hence, use devm_gpiod_get_optional function to get the data from
> device tree for ldac-pin and accordingly make the needed changes
> in the driver.
>
> Signed-off-by: Shreey
On Sat, 17 Nov 2018 04:34:55 +0530
Shreeya Patel wrote:
> ADT7316 driver no more uses platform data and hence use device tree
> data instead of platform data for assigning irq_type field.
> Switch case figures out the type of irq and if it's the default case
> then assign the default value to the
On Tue, 20 Nov 2018 21:59:19 -0200
Matheus Tavares Bernardino wrote:
> On Mon, Nov 19, 2018 at 6:09 AM Ardelean, Alexandru
> wrote:
> >
> > On Sun, 2018-11-18 at 02:25 -0200, Matheus Tavares wrote:
> > > This patch adds device tree support to ad2s90 with standard
> > > device tree id table.
>
On Fri, 23 Nov 2018 22:23:12 -0200
Matheus Tavares wrote:
> Move ad2s90 resolver driver out of staging to the main tree.
>
> Signed-off-by: Matheus Tavares
> Signed-off-by: Victor Colombo
Hi.
One totally trivial comment inline, but if you want to clean
that up, do it after we have moved this
On Sat, 24 Nov 2018 11:18:57 -0200
Marcelo Schmitt wrote:
> Add a of_device_id struct variable and subsequent call to
> MODULE_DEVICE_TABLE macro to complete device tree support.
>
> Signed-off-by: Marcelo Schmitt
Applied to the togreg branch of iio.git and pushed out as testing
for the autobui
On Thu, 22 Nov 2018 10:53:47 -0200
Marcelo Schmitt wrote:
> Previously, there was an implicit creation of a kfifo which was replaced
> by a call to triggered_buffer_setup, which is already implemented in iio
> infrastructure.
>
> Signed-off-by: Marcelo Schmitt
I'm a little surprised that this
On Thu, 22 Nov 2018 11:01:00 +
"Popa, Stefan Serban" wrote:
> On Mi, 2018-11-21 at 16:04 -0200, Giuliano Belinassi wrote:
> > Previously, the AD7780 driver only supported gpio for the 'powerdown'
> > pin. This commit adds suppport for the 'gain' and 'filter' pin.
> Hey,
>
> Comments inline
On Tue, 20 Nov 2018 17:43:46 +0200
Stefan Popa wrote:
> Move ad7606 ADC driver out of staging and into the mainline.
>
> Signed-off-by: Stefan Popa
One idle thought, how much would the performance suffer if we moved
the parallel path over to the new gpiod_get/set_raw_array_value and friends?
On Tue, 20 Nov 2018 22:22:30 +0530
Shreeya Patel wrote:
> When the kernel starts up, it kicks off compiled-in drivers
> that match “compatible” entries it finds in the device tree.
> At a later stage (when /lib/modules is available), all kernel modules
> that match “compatible” entries in the dev
On Tue, 20 Nov 2018 22:24:36 +0530
Shreeya Patel wrote:
> Make the driver use device tree instead of the platform data.
> Hence, use devm_gpiod_get_optional function to get the data from
> device tree for ldac-pin and accordingly make the needed changes
> in the driver.
>
> Signed-off-by: Shreey
On Tue, 20 Nov 2018 22:26:58 +0530
Shreeya Patel wrote:
> There is no need to store irq_flags into the structure as it
> is always set to the same thing. Hence switch irq_flags to a
> local variable.
>
> Signed-off-by: Shreeya Patel
Applied to the togreg branch of iio.git and pushed out as test
On Tue, 20 Nov 2018 22:28:36 +0530
Shreeya Patel wrote:
> Most of the drivers in IIO uses irq_type as the name for
> storing the interrupt type and hence change the name from
> irq_flags to irq_type for maintaining the consistency.
>
> Signed-off-by: Shreeya Patel
Applied to the togreg branch o
On Wed, 21 Nov 2018 15:02:52 +0530
Shreeya Patel wrote:
> On Wed, 2018-11-21 at 08:21 +, Ardelean, Alexandru wrote:
> > On Tue, 2018-11-20 at 22:30 +0530, Shreeya Patel wrote:
> > > ADT7316 driver no more uses platform data and hence use device tree
> > > data instead of platform data for a
On Thu, 29 Nov 2018 12:19:08 +
"Ardelean, Alexandru" wrote:
> On Tue, 2018-11-27 at 06:11 -0500, Popa, Stefan Serban wrote:
> > On Lu, 2018-11-26 at 17:24 -0200, Giuliano Belinassi wrote:
> > Hi, please see bellow
> >
>
> One note from me here.
>
> > > Hi, thank you for the review
> > >
On Fri, 23 Nov 2018 22:23:07 -0200
Matheus Tavares wrote:
> The ad2s90 driver currently sets some spi settings (max_speed_hz and
> mode) at ad2s90_probe. Since the maximum frequency is a required element
> in DT binding for spi slave devices and because the spi mode for the
> device can be either
On Fri, 23 Nov 2018 22:23:06 -0200
Matheus Tavares wrote:
> This patch adds device tree support to ad2s90 with standard
> device tree id table.
>
> Signed-off-by: Matheus Tavares
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.
Thanks,
Jo
On Fri, 23 Nov 2018 22:23:08 -0200
Matheus Tavares wrote:
> From: Alexandru Ardelean
>
> This patch adds a max frequency check at the beginning of ad2s90_probe
> function so that when it is set to a value above 0.83Mhz, dev_err is
> called with an appropriate message and -EINVAL is returned.
>
On Mon, 26 Nov 2018 19:52:27 -0600
Rob Herring wrote:
> On Fri, 23 Nov 2018 22:23:09 -0200, Matheus Tavares wrote:
> > This patch adds the device tree binding documentation for the ad2s90
> > resolver-to-digital converter.
> >
> > Signed-off-by: Matheus Tavares
> > ---
> > Changes in v3:
> > -
On Fri, 23 Nov 2018 22:23:10 -0200
Matheus Tavares wrote:
> This patch removes the license boilerplate text at the top of ad2s90.c
> and, instead, adds the SPDX GPL-2.0 license identifier, which solves the
> checkpatch.pl warning:
> "WARNING: Missing or malformed SPDX-License-Identifier tag in li
On Fri, 23 Nov 2018 22:23:11 -0200
Matheus Tavares wrote:
> From: Victor Colombo
>
> Fix the checkpatch.pl issue:
> "CHECK: struct mutex definition without comment".
>
> Signed-off-by: Victor Colombo
> Signed-off-by: Matheus Tavares
Applied, thanks
Jonathan
> ---
> Changes in v3:
> - none
On Mon, 26 Nov 2018 07:34:35 +
"Ardelean, Alexandru" wrote:
> On Fri, 2018-11-23 at 22:23 -0200, Matheus Tavares wrote:
> > Move ad2s90 resolver driver out of staging to the main tree.
> >
>
> Acked-by: Alexandru Ardelean
Hi Alexandru,
I took that to apply to the whole series, hope you
On Tue, 27 Nov 2018 18:05:04 +0100
Nicholas Mc Guire wrote:
> devm_kasprintf() may return NULL on failure of internal allocation thus
> the assignments to attr.name are not safe if not checked. On error
> ad7280_attr_init() returns a negative return so -ENOMEM should be
> OK here (passed on as
On Wed, 28 Nov 2018 16:16:34 -0200
Giuliano Belinassi wrote:
> Move ad7780 sigma-delta adc out of staging to the main tree
Please add a few details here on what the device is and what interfaces
are provided. It's nice for anyone whose first encounter with this
driver is this patch (as they don'
On Thu, 29 Nov 2018 11:02:46 -0200
Giuliano Augusto Faulin Belinassi wrote:
> Hi
A few follow ups from me having read the result in patch 2.
Jonathan
>
> On Thu, Nov 29, 2018 at 9:18 AM Popa, Stefan Serban
> wrote:
> >
> > On Mi, 2018-11-28 at 16:15 -0200, Giuliano Belinassi wrote:
> > > Pr
On Thu, 29 Nov 2018 18:56:39 +0200
Stefan Popa wrote:
> Move ad7606 ADC driver out of staging and into the mainline.
>
> Signed-off-by: Stefan Popa
Hi Stefan,
This has fallen into the usual trap that if I take 'just one last look'
at something I always find just one more thing (well 2 here) t
On Sun, 2 Dec 2018 16:10:45 -0200
Marcelo Schmitt wrote:
> On 11/25, Jonathan Cameron wrote:
> > On Thu, 22 Nov 2018 10:53:47 -0200
> > Marcelo Schmitt wrote:
> >
> > > Previously, there was an implicit creation of a kfifo which was replaced
> > > by
On Sun, 2 Dec 2018 14:57:12 -0200
Marcelo Schmitt wrote:
> Add a devicetree documentation for the ad5933 and ad5934 impedance
> converter, network analyzer.
>
> Co-Developed-by: Gabriel Capella
Put this in line below Gabriel's sign off - it makes script
parsing of these easier.
Signed-off-by:
On Sun, 02 Dec 2018 15:22:15 -0800
Joe Perches wrote:
> On Mon, 2018-12-03 at 00:20 +0530, Himanshu Jha wrote:
> > On Sun, Dec 02, 2018 at 02:57:12PM -0200, Marcelo Schmitt wrote:
> > > Add a devicetree documentation for the ad5933 and ad5934 impedance
> > > converter, network analyzer.
> > >
On Sat, 08 Dec 2018 00:07:21 +0530
Shreeya Patel wrote:
> On Thu, 2018-12-06 at 15:40 +0300, Dan Carpenter wrote:
> > On Wed, Dec 05, 2018 at 02:59:53PM -0700, Jeremy Fertic wrote:
> > > On Thu, Dec 06, 2018 at 01:25:55AM +0530, Shreeya Patel wrote:
> > > > On Tue, 2018-12-04 at 18:49 -0700,
On Thu, 6 Dec 2018 11:10:51 +0200
Mircea Caprioru wrote:
> This patch adds a clock to the state structure of ad7192 for getting the
> external clock frequency. This modifications is in accordance with clock
> framework dt bindings documentation.
>
> Signed-off-by: Mircea Caprioru
+cc Rob and t
On Thu, 6 Dec 2018 11:10:52 +0200
Mircea Caprioru wrote:
> When using the internal clock the device has an option in which the clock
> output is available on MCLK2 pin. This patch adds a dt binding for enabling
> this property.
>
> Signed-off-by: Mircea Caprioru
I'd rather we looked at getting
On Thu, 6 Dec 2018 15:38:30 +0200
Mircea Caprioru wrote:
> From: Stefan Popa
>
> The AD5310R is a single channel DAC with 10-bit precision, which is
> part of the same family as AD5311R, except that it uses the spi interface
> instead of i2c. The device has a built-in 2.5V reference which is en
On Thu, 6 Dec 2018 15:53:15 +0200
Mircea Caprioru wrote:
> This patch solves the register readback issue with the bit shift. When the
> dac resolution was lower than the register size (ex. 12 bits out of 16
> bits) the readback value was not shifted with the difference in bits and
> the value was
On Sat, 8 Dec 2018 20:46:37 +0530
Shreeya Patel wrote:
> There is a function adt7316_irq_setup() where irq_type is being
> set. It would be good to move devm_request_threaded_irq() function
> and assignment of chip->config1 in adt7316_irq_setup() to unclutter
> the code in probe function.
>
> S
On Sat, 8 Dec 2018 16:19:59 -0200
Marcelo Schmitt wrote:
> Add a devicetree documentation for the ad5933 and ad5934 impedance
> converter, network analyzer.
>
> Signed-off-by: Marcelo Schmitt
> Signed-off-by: Gabriel Capella
> Co-Developed-by: Gabriel Capella
Device tree binding patches need
1 - 100 of 1076 matches
Mail list logo
