On Sun, Dec 15, 2019 at 08:42:47PM -0600, Navid Emamdoost wrote:
> Hi Johan,
>
> On Sun, Dec 15, 2019 at 7:23 AM Johan Hovold wrote:
> >
> > On Sat, Dec 14, 2019 at 05:05:58PM -0600, Navid Emamdoost wrote:
> > > In the implementation of alloc_rtllib() the allocated
On Sat, Jan 25, 2020 at 02:14:03PM +0530, Saurav Girepunje wrote:
> fix uninitialized variables issue found using static code analysis tool
Which tool is that?
> (error) Uninitialized variable: offset
> (error) Uninitialized variable: size
>
> Signed-off-by: Saurav Girepunje
> ---
> drivers/st
On Sun, Jan 26, 2020 at 02:01:30PM +0530, Saurav Girepunje wrote:
> Fix the warning reported by cocci check.
>
> Changes:
>
> In queue_work fw dereference before it actually get assigned.
> move queue_work before gb_bootrom_set_timeout.
Nope. As I said yesterday, you need to verify the output of
On Tue, Feb 11, 2020 at 03:12:19PM -0600, Gustavo A. R. Silva wrote:
> The current codebase makes use of the zero-length array language
> extension to the C90 standard, but the preferred mechanism to declare
> variable-length types such as these ones is a flexible array member[1][2],
> introduced i
On Wed, Mar 11, 2020 at 10:19:06AM +0100, Takashi Iwai wrote:
> Since snprintf() returns the would-be-output size instead of the
> actual output size, the succeeding calls may go beyond the given
> buffer limit. Fix it by replacing with scnprintf().
>
> Signed-off-by: Takashi Iwai
> ---
> drive
On Wed, Mar 11, 2020 at 11:02:33AM +0100, Takashi Iwai wrote:
> On Wed, 11 Mar 2020 10:58:14 +0100,
> Johan Hovold wrote:
> >
> > On Wed, Mar 11, 2020 at 10:19:06AM +0100, Takashi Iwai wrote:
> > > Since snprintf() returns the would-be-output size instead of the
&g
y: Takashi Iwai
> ---
>
> Just corrected the subject prefix per request.
Acked-by: Johan Hovold
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wed, Mar 11, 2020 at 12:01:26PM +0100, Takashi Iwai wrote:
> On Wed, 11 Mar 2020 11:09:03 +0100,
> Johan Hovold wrote:
> >
> > On Wed, Mar 11, 2020 at 11:02:33AM +0100, Takashi Iwai wrote:
> > > On Wed, 11 Mar 2020 10:58:14 +0100,
> > > Johan Hovold wrote:
&
On Wed, Mar 11, 2020 at 11:09:59AM +0100, Johan Hovold wrote:
> On Wed, Mar 11, 2020 at 11:05:35AM +0100, Takashi Iwai wrote:
> > Since snprintf() returns the would-be-output size instead of the
> > actual output size, the succeeding calls may go beyond the given
> > buf
On Wed, Mar 11, 2020 at 05:45:31PM +0100, Takashi Iwai wrote:
> On Wed, 11 Mar 2020 17:40:02 +0100, Johan Hovold wrote:
> > But isn't the first snprintf() in such a sequence as much a part of the
> > problem as the following ones?
> >
> > If the first pos = snp
A scripted conversion from userland POLL* to kernel EPOLL* constants
mistakingly replaced the poll flags in the loopback_test tool, which
therefore no longer builds.
Fixes: a9a08845e9ac ("vfs: do bulk POLL* -> EPOLL* replacement")
Cc: stable # 4.16
Signed-off-by: Johan Hovold
The loopback_test tool hasn't received much love lately. In fact, it has
failed to build for the past two years after a scripted EPOLL*
conversion.
Newer GCC also started warning for potential string truncation of
generated path names; the last two patches addresses that.
Johan
Johan Hovo
6b0658f68786 ("greybus: tools: Add tools directory to greybus repo and
add loopback")
Signed-off-by: Johan Hovold
---
drivers/staging/greybus/tools/loopback_test.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/greybus/tools
Fix this by making sure the buffer is large enough the concatenated
strings.
Fixes: 6b0658f68786 ("greybus: tools: Add tools directory to greybus repo and
add loopback")
Fixes: 9250c0ee2626 ("greybus: Loopback_test: use poll instead of inotify&
On Thu, Mar 12, 2020 at 05:51:11PM +0300, Dan Carpenter wrote:
> On Wed, Mar 11, 2020 at 10:58:14AM +0100, Johan Hovold wrote:
> > On Wed, Mar 11, 2020 at 10:19:06AM +0100, Takashi Iwai wrote:
> > > Since snprintf() returns the would-be-output size instead of the
> > &
On Wed, Apr 29, 2020 at 03:00:44PM -0500, Alex Elder wrote:
> On 4/29/20 2:00 PM, Arnd Bergmann wrote:
> > gcc-10 points out an uninitialized variable use:
>
> Wow, nice, checking individual uninitialized fields within
> the structure.
>
> The structure should really be zero-initialized anyway; i
tally
made the structures match again.
Signed-off-by: Johan Hovold
---
drivers/staging/greybus/uart.c | 19 ---
1 file changed, 4 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c
index 55c51143bb09..84de56800a21 100644
---
Make sure to deregister the USB driver before releasing the tty driver
to avoid use-after-free in the USB disconnect callback where the tty
devices are deregistered.
Fixes: 61e121047645 ("staging: gdm7240: adding LTE USB driver")
Cc: stable # 3.12
Cc: Won Kang
Signed-off-by: Jo
breakage.
Johan
Johan Hovold (2):
staging: greybus: arche: remove timesync remains
staging: greybus: enable compile testing of arche driver
drivers/staging/greybus/Kconfig | 10 +++
drivers/staging/greybus/Makefile | 2 +-
drivers/staging/greybus/arche-apb-ctrl.c | 11
Add Arche platform-driver config option and allow the driver to be
compile tested also without the usb3613 driver.
Signed-off-by: Johan Hovold
---
drivers/staging/greybus/Kconfig | 10 ++
drivers/staging/greybus/Makefile | 2 +-
drivers/staging/greybus/arche-platform.c
Remove the remaining timesync bits that were left in the arche platform
driver and which prevented the driver from being compiled.
Fixes: bdfb95c4baab ("staging: greybus: remove timesync protocol support")
Signed-off-by: Johan Hovold
---
drivers/staging/greybus/arche-apb-ct
On Mon, May 15, 2017 at 04:17:55PM +0100, Bryan O'Donoghue wrote:
> On 15/05/17 15:26, Johan Hovold wrote:
> > Remove the remaining timesync bits that were left in the arche platform
> > driver and which prevented the driver from being compiled.
> >
> > Fixes:
On Mon, May 15, 2017 at 09:49:51AM -0700, Randy Dunlap wrote:
> On 05/15/17 07:26, Johan Hovold wrote:
> > Add Arche platform-driver config option and allow the driver to be
> > compile tested also without the usb3613 driver.
> >
> > Signed-off-by: Johan Hovold
&
On Mon, May 15, 2017 at 10:22:15PM +0100, Bryan O'Donoghue wrote:
> On 15/05/17 17:10, Johan Hovold wrote:
> > On Mon, May 15, 2017 at 04:17:55PM +0100, Bryan O'Donoghue wrote:
> >> On 15/05/17 15:26, Johan Hovold wrote:
> >>> Remove the remaining timesync b
breakage.
Johan
Changes in v2
- fix usb3613 Kconfig dependency (Randy Dunlap)
Johan Hovold (2):
staging: greybus: arche: remove timesync remains
staging: greybus: enable compile testing of arche driver
drivers/staging/greybus/Kconfig | 10 +++
drivers/staging/greybus/Makefile
Add Arche platform-driver config option and allow the driver to be
compile tested also without the out-of-tree usb3613 driver.
Signed-off-by: Johan Hovold
---
drivers/staging/greybus/Kconfig | 10 ++
drivers/staging/greybus/Makefile | 2 +-
drivers/staging/greybus
Remove the remaining timesync bits that were left in the arche platform
driver and which prevented the driver from being compiled.
Fixes: bdfb95c4baab ("staging: greybus: remove timesync protocol support")
Signed-off-by: Johan Hovold
---
drivers/staging/greybus/arche-apb-ct
ybus: enable compile testing of arche
> driver")
> Signed-off-by: Arnd Bergmann
Acked-by: Johan Hovold
Thanks for fixing this.
Johan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
module: remove redundant OOM
message").
Fix that up and you can add my
Acked-by: Johan Hovold
Thanks,
Johan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tue, Dec 06, 2016 at 07:39:36PM +0530, Srikant Ritolia wrote:
> All kmalloc-based functions print enough information on failure
>
> Signed-off-by: Srikant Ritolia
Acked-by: Johan Hovold
> ---
> Changes in v2:
> - Added driver name in the subject for better readabil
On Tue, Dec 20, 2016 at 01:12:08AM +, Bryan O'Donoghue wrote:
> Currently the greybus-loopback thread logic spins around waiting for
> send_count == iteration_max which on real hardware doesn't make a
> difference to us but in simulation is excruciatingly slow, anti-social and
> bad manners. Us
On Wed, Dec 21, 2016 at 04:38:26PM +0100, Emmanuil Chatzipetru wrote:
> Fix coding style issue caught by checkpatch.pl related to the following
> warning:
> - "WARNING: char * array declaration might be better as static const"
>
> Signed-off-by: Emmanuil Chatzipetru
> ---
> drivers/staging
e).
> timesync_svc->ktime_timer.expires = jiffies + GB_TIMESYNC_KTIME_UPDATE;
> - timesync_svc->ktime_timer.data = (unsigned long)timesync_svc;
> add_timer(×ync_svc->ktime_timer);
> done:
> mutex_unlock(&gb_timesync_svc_list_mutex);
When rese
trl_suspend(struct device *dev)
> ^~
>
> Adding __maybe_unused to the declaration of these functions removes the
> warnings.
>
> Signed-off-by: Jérémy Lefaure
Acked-by: Johan Hovold
Thanks,
Johan
___
arious other function pointers.
Yeah, I allowed for some inconsistency here given that these callbacks
are mandatory on our current platform.
No harm in checking this way though (well, at least as long as we
remember to set the pointers).
> Signed-off-by: Jason Hrycay
Acked-by: Johan Hovold
On Thu, Dec 22, 2016 at 04:22:02PM +0100, Emmanuil Chatzipetru wrote:
> Fix coding style issue caught by checkpatch.pl related to the following
> warning:
> - "CHECK: spaces preferred around that '*' (ctx:VxV) "
>
> Signed-off-by: Emmanuil Chatzipetru
o printk(KERN_ERR ."
>
> Signed-off-by: Emmanuil Chatzipetru
> ---
> v2: Add svc_watchdog to the subject line
Thanks for the update.
Acked-by: Johan Hovold
> drivers/staging/greybus/svc_watchdog.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
l and
> bad manners. Use the existing gb_loopback_async_wait_all() function to gate
> continuing when the send_count == iteration_max and go to sleep until
> there's something worthwhile to-do.
>
> Signed-off-by: Bryan O'Donoghue
Reviewed-by: Johan Hovold
_
Adding Axel on CC.
On Thu, Dec 22, 2016 at 12:37:29AM +, Bryan O'Donoghue wrote:
> commit 9250c0ee2626 ("greybus: Loopback_test: use poll instead of
> inotify") changes the flow of determining when to break out of a loop
> polling for loopback test completion.
>
> The clause is_complete() whi
On Tue, Dec 27, 2016 at 01:01:35PM +, Bryan O'Donoghue wrote:
> Later patches don't want or need to serialize the cancellation of an
> operation. This patch adds gb_operation_cancel_async() as a simple subset
> of the existing gb_operation_cancel() sans the synchronous wait on the
> cancellatio
On Tue, Jan 03, 2017 at 09:23:29AM +, Bryan O'Donoghue wrote:
> On 02/01/17 16:16, Johan Hovold wrote:
> > On Tue, Dec 27, 2016 at 01:01:35PM +, Bryan O'Donoghue wrote:
> >> Later patches don't want or need to serialize the cancellation of a
On Tue, Jan 03, 2017 at 03:33:03PM +0100, chatzi.eman...@gmail.com wrote:
> From: Emmanuil Chatzipetru
>
> Fix coding style issue caught by checkpatch.pl related to the following
> warning:
> - CHECK: Please don't use multiple blank lines
>
> Signed-off-by: Emmanuil Chatzipetru
> ---
> d
On Tue, Jan 03, 2017 at 03:33:04PM +0100, chatzi.eman...@gmail.com wrote:
> From: Emmanuil Chatzipetru
>
> Fix coding style issue caught by checkpatch.pl related to the following
> warning:
> - CHECK: Alignment should match open parenthesis
This is not even a warning (hint: "CHECK") and no
On Tue, Jan 03, 2017 at 03:33:05PM +0100, chatzi.eman...@gmail.com wrote:
> From: Emmanuil Chatzipetru
>
> This warning is caught by checkpatch.pl:
> - CHECK: 'begining' may be misspelled - perhaps 'beginning'?
>
> Signed-off-by: Emmanui
hatzipetru
Acked-by: Johan Hovold
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tue, Jan 03, 2017 at 03:33:10PM +0100, chatzi.eman...@gmail.com wrote:
> From: Emmanuil Chatzipetru
>
> Fix coding style issue caught by checkpatch.pl related to the following
> warning:
> - CHECK: Comparison to NULL could be written "!token"
Again, not a warning, and something that is
On Tue, Jan 03, 2017 at 03:33:12PM +0100, chatzi.eman...@gmail.com wrote:
> From: Emmanuil Chatzipetru
>
> Fix coding style issue caught by checkpatch.pl related to the following
> warning:
> - CHECK: Please don't use multiple blank lines
Again not a warning, and perfectly valid. Please dr
On Tue, Jan 03, 2017 at 03:33:16PM +0100, chatzi.eman...@gmail.com wrote:
> From: Emmanuil Chatzipetru
>
> Fix coding style issue caught by checkpatch.pl related to the following
> warning:
> - CHECK: Comparison to NULL could be written "!id"
Current code is fine.
Johan
__
On Tue, Jan 03, 2017 at 01:46:09PM -0600, Jason Hrycay wrote:
> On Mon, Jan 02, 2017 at 02:54:37PM +0100, Johan Hovold wrote:
> > On Tue, Dec 20, 2016 at 02:49:27PM -0600, Jason Hrycay wrote:
> > > Add sanity checks for cport_quiesce and cport_clear before invoking the
> &
On Wed, Jan 04, 2017 at 03:07:31PM +0100, Emmanuil Chatzipetru wrote:
> Fix coding style issue caught by checkpatch.pl related to the following
> warning:
> - "CHECK: spaces preferred around that '*' (ctx:VxV) "
>
> Signed-off-by: Emmanuil C
On Wed, Jan 04, 2017 at 03:07:32PM +0100, Emmanuil Chatzipetru wrote:
> Fix coding style issue caught by checkpatch.pl related to the following
> warning:
> - CHECK: WARNING: line over 80 characters
>
> Signed-off-by: Emmanuil Chatzipetru
> ---
> drivers/staging/greybus/log.c | 2 +-
> 1 f
On Wed, Jan 04, 2017 at 04:14:45PM +0100, Emmanuil Chatzipetru wrote:
> Fix coding style issue caught by checkpatch.pl related to the following
> warning:
> - CHECK: WARNING: line over 80 characters
This commit message should be expanded to explain how this is done (e.g.
"by dropping a redun
On Wed, Jan 04, 2017 at 05:08:18PM +0100, Emmanuil Chatzipetru wrote:
> Fix coding style issue caught by checkpatch.pl related to the following
> warning:
> - "CHECK: spaces preferred around that '*' (ctx:VxV) "
>
> Signed-off-by: Emmanuil C
specifier
> in dev_err(); to "%zu" instead of "%d", in order to silence the warnings of
> the
> compiler.
>
> Also, while at it, drop the redundant cast in the comparison as well to
> maintain
> consistency.
>
> Signed-off-by: Emmanuil Chatzipetru
from.
>
> Signed-off-by: Greg Kroah-Hartman
Reviewed-by: Johan Hovold
> Note, there are some remants in the arche-platform driver, but that's
> probably next on the chopping block, so I didn't unwind it from there as
> it's a bit more complex, and it never gets
On Fri, Jan 06, 2017 at 08:20:03AM +0100, Greg Kroah-Hartman wrote:
> From: Greg Kroah-Hartman
>
> The Greybus driver subsystem has a mailing list, so list it in the
> MAINTAINERS file so that people know to send patches there as well.
>
> Signed-off-by: Greg Kroah-Hartman
On Sun, Jan 08, 2017 at 03:27:18PM +, Bryan O'Donoghue wrote:
> commit e854ff58ed70 ("greybus: loopback: add runtime pm support")
> introduces pm runtime support to the loopback code. If a
> gb_pm_runtime_get_sync() fails, currently we immediately return from the
> loopback thread.
>
> Alexand
On Sun, Jan 08, 2017 at 03:27:19PM +, Bryan O'Donoghue wrote:
> Doing an rmmod gb_loopback will cause an oops with the following backtrace.
>
> Call Trace:
> debugfs_remove+0xaf/0x180
> gb_loopback_disconnect+0x36/0x160 [gb_loopback]
> greybus_remove+0x87/0x1a0 [greybus]
> device_release_d
On Mon, Jan 09, 2017 at 11:29:50AM +, Bryan O'Donoghue wrote:
> On January 9, 2017 11:19:09 AM GMT+00:00, Johan Hovold
> wrote:
> >On Sun, Jan 08, 2017 at 03:27:18PM +, Bryan O'Donoghue wrote:
> >> commit e854ff58ed70 ("greybus: loopback: add run
On Fri, Jan 06, 2017 at 08:43:57PM +1300, Derek Robson wrote:
> Changed permissions to be in octal style.
> Found by checkpatch.
>
> Signed-off-by: Derek Robson
> ---
>
> This version of patch also make the file type part of the mask with the
> permissions, as per recommendation from Greg K-H
>
On Tue, Jan 10, 2017 at 05:21:24PM +0100, Roman Sommer wrote:
> From: Christian Bewermeyer
>
> Note that this patch does not fix all checkpatch warnings for
> gpio.c
Fair enough, but you are fixing all of these new "unsigned int"
warnings in that driver, right?
How about fixing the sole remaini
On Wed, Jan 11, 2017 at 01:29:36AM +, Abdul Rauf wrote:
> Fix the following Errors:
> Bad function definition - void abort() should probably be void abort(void)
>
> Signed-off-by: Abdul Rauf
Acked-by: Johan Hovold
___
devel mai
On Wed, Jan 11, 2017 at 02:48:38PM +0100, Roman Sommer wrote:
> Note that this patch does not fix all checkpatch warnings for the
> affected files.
>
> Signed-off-by: Christian Bewermeyer
> Signed-off-by: Roman Sommer
You forgot to fix the Subject prefix ("staging: greybus: ").
Care to fix tha
your subject since
that's not a (greybus) component. You could have rephrased the summary
as "fix checkpatch unsigned warnings" or similar instead.
Reviewed-by: Johan Hovold
Thanks,
Johan
___
devel mailing list
de...@linuxdriverproject.org
On Thu, Jan 12, 2017 at 10:05:10AM +0300, Dan Carpenter wrote:
> On Wed, Jan 11, 2017 at 04:00:35PM +0100, Roman Sommer wrote:
> > Note that this patch does not fix all checkpatch warnings for the
> > affected files.
> >
>
> A lot of ways that display git commits put the changelog and the summary
On Thu, Jan 12, 2017 at 05:59:40PM +1300, Derek Robson wrote:
> Changed permissions to be in octal style.
> Found by checkpatch.
>
> Signed-off-by: Derek Robson
> ---
Acked-by: Johan Hovold
Next time, please include a module prefix in your Subject (i.e.
"staging: greybus:
r
> Signed-off-by: Roman Sommer
Reviewed-by: Johan Hovold
Thanks,
Johan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wed, Jan 18, 2017 at 06:21:23PM -0800, Igor Pylypiv wrote:
> checkpatch.pl warning:
> Symbolic permissions are not preferred. Consider using octal permissions.
>
> Signed-off-by: Igor Pylypiv
Reviewed-by: Johan Hovold
___
devel mai
On Thu, Jan 19, 2017 at 10:07:42AM +0100, Greg Kroah-Hartman wrote:
> On Wed, Jan 04, 2017 at 12:11:17AM +, Bryan O'Donoghue wrote:
> > V3:
> > Picard: "Let's make sure history never forgets the name ... Enterprise."
> > Drop gb_operation_cancel_async. The sync version works just as well - Joha
On Wed, Jan 04, 2017 at 12:11:18AM +, Bryan O'Donoghue wrote:
> This patch adds a generic mechanism for handling timeouts of asynchronous
> operations to operation.c. After doing a gb_operation_request_send() it
> schedules a delayed worker. When the delayed worker's timer expires the
> worker
On Wed, Jan 04, 2017 at 12:11:20AM +, Bryan O'Donoghue wrote:
> Loopback has its own internal method for tracking and timing out
> asynchronous operations however previous patches make it possible to use
> functionality provided by operation.c to do this instead. Using the code in
> operation.c
> microseconds-to-milliseconds. The new minimum timeout will be one
> millisecond as opposed to one jiffy.
You also reduced the maximum in a similar way (1 ms <= 1 jiffie). You
could mention that here as well.
> Signed-off-by: Bryan O'Donoghue
Reviewed-by: Johan Hovold
&
Add a struct timer_list to struct gb_operation and use that to implement
generic operation timeouts.
This simplifies the synchronous operation handling somewhat while also
providing a generic timeout mechanism that drivers can use for
asynchronous operations.
Signed-off-by: Johan Hovold
on.h and get/set
s/operation.h/struct gb_operation/
> methods to access that pointer.
>
> Signed-off-by: Bryan O'Donoghue
Reviewed-by: Johan Hovold
> ---
> drivers/staging/greybus/operation.h | 13 +
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/
On Mon, Jan 23, 2017 at 02:32:48PM +, Bryan O'Donoghue wrote:
> On 23/01/17 12:04, Johan Hovold wrote:
>
> > +static void gb_operation_timeout(unsigned long arg)
> > +{
> > + struct gb_operation *operation = (void *)arg;
> > +
> > + if (gb_o
On Mon, Jan 23, 2017 at 02:22:44PM +, Rui Miguel Silva wrote:
> When tearingdown timesync, and not in arche platform, the state platform
> callback is not initialized. That will trigger the following NULL
> dereferencing.
> CallTrace:
>
> ? gb_timesync_platform_unlock_bus+0x11/0x20 [greybus]
_work+0x3b0/0x3b0
> kthread+0xc4/0xe0
> ? kthread_park+0xb0/0xb0
> ret_from_fork+0x22/0x30
>
> So, fix that by adding checks before use the callback.
>
> Fixes: 970dc85bd95d ("greybus: timesync: Add timesync core driver")
> Cc: # 4.9.x
> Signed-off-by: Rui Miguel S
On Mon, Jan 23, 2017 at 03:39:43PM +, Bryan O'Donoghue wrote:
> On 23/01/17 15:13, Johan Hovold wrote:
> > On Mon, Jan 23, 2017 at 02:32:48PM +, Bryan O'Donoghue wrote:
> >> On 23/01/17 12:04, Johan Hovold wrote:
> >>
> >>> +s
On Mon, Jan 23, 2017 at 05:50:23PM +0100, Johan Hovold wrote:
> On Mon, Jan 23, 2017 at 03:39:43PM +, Bryan O'Donoghue wrote:
> > Have you run this through loopback without any # of in-flight operations
> > constrained ?
>
> No, not yet as that would require also yo
This driver does not have a low-latency mode and should not report
anything else.
Also drop the skip-test flag which isn't used either.
Signed-off-by: Johan Hovold
---
drivers/staging/greybus/uart.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/greybus/uart.c b/dr
oseconds")
Signed-off-by: Johan Hovold
---
drivers/staging/greybus/loopback.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/loopback.c
b/drivers/staging/greybus/loopback.c
index 6c2a41c638c3..a8329daf1e57 100644
--- a/drivers/st
On Fri, Jan 27, 2017 at 03:29:30PM +0300, Dan Carpenter wrote:
> On Fri, Jan 27, 2017 at 11:11:21AM +0100, mrossibel...@gmail.com wrote:
> > From: Maxime Rossi Bellom
> >
> > Split line before funtion argument.
> >
> > Error was reported by checkpatch.pl as
> > WARNING: line over 80 characters
>
On Fri, Jan 27, 2017 at 03:47:21PM +0300, Dan Carpenter wrote:
> The name sucks is what I'm saying. Please fix it eventually.
I disagree. The name uses a common prefix that reflects the object it is
working on. This should not be changed. As it is currently named, the
function is also self-docume
On Fri, Jan 27, 2017 at 04:24:47PM +0300, Dan Carpenter wrote:
> On Fri, Jan 27, 2017 at 02:08:06PM +0100, Johan Hovold wrote:
> > On Fri, Jan 27, 2017 at 03:47:21PM +0300, Dan Carpenter wrote:
> > > The name sucks is what I'm saying. Please fix it eventually.
> >
&g
On Mon, Jan 23, 2017 at 01:04:14PM +0100, Johan Hovold wrote:
> Add a struct timer_list to struct gb_operation and use that to implement
> generic operation timeouts.
>
> This simplifies the synchronous operation handling somewhat while also
> providing a generic timeout mechani
On Tue, Feb 07, 2017 at 02:31:04PM +, Bryan O'Donoghue wrote:
> On 07/02/17 14:19, Johan Hovold wrote:
> > On Mon, Jan 23, 2017 at 01:04:14PM +0100, Johan Hovold wrote:
> >> Add a struct timer_list to struct gb_operation and use that to implement
> >> generic op
On Wed, Feb 08, 2017 at 11:43:57AM +, Bryan O'Donoghue wrote:
> On 08/02/17 09:43, Johan Hovold wrote:
> > On Tue, Feb 07, 2017 at 02:31:04PM +, Bryan O'Donoghue wrote:
> >> On 07/02/17 14:19, Johan Hovold wrote:
> >>> On Mon, Jan 23, 2017
On Wed, Feb 08, 2017 at 02:05:15PM +, Bryan O'Donoghue wrote:
> On 08/02/17 11:55, Johan Hovold wrote:
> > On Wed, Feb 08, 2017 at 11:43:57AM +, Bryan O'Donoghue wrote:
> >> On 08/02/17 09:43, Johan Hovold wrote:
> >>> On Tue, Feb 07, 2017 at
On Thu, Feb 09, 2017 at 01:01:18PM +, Colin King wrote:
> From: Colin Ian King
>
> Currently newline.flow_control is uninitialized, so it can contain
> any garbage from the stack. I believe it should be initialized with
> GB_SERIAL_AUTO_RTSCTS_EN enabled if the termios c_cflag is CRTSCTS
> e
On Fri, Feb 10, 2017 at 11:16:37PM -0500, Nathan Howard wrote:
> Fix checkpatch.pl issue of the form:
> "CHECK: Please don't use multiple blank lines".
Don't take checkpatch too seriously. Using double blank lines as a
separator is perfectly fine.
Thanks,
Johan
___
On Mon, Oct 03, 2016 at 04:21:09PM +0530, Sidhant Gupta wrote:
> Fixes a comment coding style warning by adding 2 blank lines. Issue
> found by checkpatch.
>
> Signed-off-by: Sidhant Gupta
Acked-by: Johan Hovold
Thanks,
Johan
___
devel
; + * and then enter FW flashing state
> + */
> poweroff_seq(pdev);
> ret = fw_flashing_seq(pdev);
> } else {
Patch looks fine, but note that someone just sent a patch for this
second chunk the other day.
Acked-by: Joha
On Fri, Oct 14, 2016 at 10:18:21PM +0300, Dan Carpenter wrote:
> We should release ->interfaces[0] as well.
Indeed. Thanks for the fix.
> Fixes: b15d97d77017 ("greybus: core: add module abstraction")
> Signed-off-by: Dan Carpenter
Acked-by
5682142016 drivers/staging/greybus/uart.o
>
> File size after:
>text data bss dec hex filename
>7710 448 5682142016 drivers/staging/greybus/uart.o
>
> Signed-off-by: Bhumika Goyal
Acked-by: Johan Hovold
> ---
>
On Mon, Oct 10, 2016 at 10:39:32AM +0200, Linus Walleij wrote:
> Greybus GPIO seems to reimplement the already existing generic
> gpiolib irqchip. Also use gpiochip_get_data(). Also use
> devm_gpiochip_add_data().
>
> Cc: Viresh Kumar
> Cc: Axel Haslam
> Cc: Johan Hovold
On Wed, Oct 12, 2016 at 08:02:21AM +0530, Viresh Kumar wrote:
> Some of the print messages are using the incorrect device pointer, fix
> them.
>
> Signed-off-by: Viresh Kumar
Acked-by: Johan Hovold
___
devel mailing list
de...@linuxdrive
On Wed, Oct 12, 2016 at 08:02:22AM +0530, Viresh Kumar wrote:
> Some of the print messages are using the incorrect device pointer, fix
> them.
>
> Signed-off-by: Viresh Kumar
Acked-by: Johan Hovold
___
devel mailing list
de...@linuxdrive
[+CC: staging list ]
On Sun, Oct 16, 2016 at 02:19:48PM +0530, sayli karnik wrote:
> This patch replaces kmalloc and memcpy with kmemdup for duplication of
> memory.
>
> Signed-off-by: sayli karnik
Acked-by: Johan Hovold
> ---
> drivers/staging/greybus/es2.c | 3 +--
&g
On Sun, Oct 16, 2016 at 03:29:14PM +0530, Pankaj Bharadiya wrote:
> gb_audio_manager_module_descriptor's cport field is actually used to
> manage and pass interface id to user space.
>
> Thus rename gb_audio_manager_module_descriptor's 'cport' field and
> few other things to avoid confusion.
Plea
inelle semantic patch.
>
> Signed-off-by: Wei Yongjun
This code is going away eventually, but still.
Acked-by: Johan Hovold
Thanks,
Johan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
101 - 200 of 223 matches
Mail list logo
