Re: [PATCH 0/2] Follow-up patches for Cedrus v9

2018-09-08 Thread Hans Verkuil
On 09/07/2018 06:33 PM, Paul Kocialkowski wrote: > This brings the requested modifications on top of version 9 of the > Cedrus VPU driver, that implements stateless video decoding using the > Request API. > > Paul Kocialkowski (2): > media: cedrus: Fix error reporting in request validation > m

Re: [PATCH 0/2] Follow-up patches for Cedrus v9

2018-09-08 Thread Hans Verkuil
On 09/08/2018 12:22 PM, Chen-Yu Tsai wrote: > On Sat, Sep 8, 2018 at 6:06 PM Hans Verkuil wrote: >> >> On 09/07/2018 06:33 PM, Paul Kocialkowski wrote: >>> This brings the requested modifications on top of version 9 of the >>> Cedrus VPU driver, that implements s

Re: [PATCH 0/2] Follow-up patches for Cedrus v9

2018-09-09 Thread Hans Verkuil
On 09/08/2018 09:42 PM, Paul Kocialkowski wrote: > Hi, > > Le samedi 08 septembre 2018 à 13:24 +0200, Hans Verkuil a écrit : >> On 09/08/2018 12:22 PM, Chen-Yu Tsai wrote: >>> On Sat, Sep 8, 2018 at 6:06 PM Hans Verkuil wrote: >>>> >>>> On 09/07/20

Re: [PATCH v2 4/4] media: cedrus: Select the sunxi SRAM driver in Kconfig

2018-09-10 Thread Hans Verkuil
On 09/09/2018 09:10 PM, Paul Kocialkowski wrote: > Since the sunxi SRAM driver is required to build the Cedrus driver, > select it in Kconfig. > > Signed-off-by: Paul Kocialkowski > --- > drivers/staging/media/sunxi/cedrus/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers

Re: [PATCH v9 2/9] media: v4l: Add definitions for MPEG-2 slice format and metadata

2018-09-10 Thread Hans Verkuil
On 09/07/2018 12:24 AM, Paul Kocialkowski wrote: > From: Paul Kocialkowski > > Stateless video decoding engines require both the MPEG-2 slices and > associated metadata from the video stream in order to decode frames. > > This introduces definitions for a new pixel format, describing buffers > w

Re: [PATCH v9 2/9] media: v4l: Add definitions for MPEG-2 slice format and metadata

2018-09-10 Thread Hans Verkuil
On 09/07/2018 12:24 AM, Paul Kocialkowski wrote: > From: Paul Kocialkowski > > Stateless video decoding engines require both the MPEG-2 slices and > associated metadata from the video stream in order to decode frames. > > This introduces definitions for a new pixel format, describing buffers > w

Re: [PATCH v9 2/9] media: v4l: Add definitions for MPEG-2 slice format and metadata

2018-09-10 Thread Hans Verkuil
On 09/10/2018 11:47 AM, Paul Kocialkowski wrote: > Hi, > > Le lundi 10 septembre 2018 à 11:41 +0200, Hans Verkuil a écrit : >> On 09/07/2018 12:24 AM, Paul Kocialkowski wrote: >>> From: Paul Kocialkowski >>> >>> Stateless video decoding engines require

Re: [PATCH v9 5/9] media: platform: Add Cedrus VPU decoder driver

2018-09-12 Thread Hans Verkuil
On 09/12/2018 09:23 AM, Maxime Ripard wrote: > On Tue, Sep 11, 2018 at 12:46:25PM -0300, Mauro Carvalho Chehab wrote: >> Em Fri, 7 Sep 2018 00:24:38 +0200 >> Paul Kocialkowski escreveu: >> >>> From: Paul Kocialkowski >>> >>> This introduces the Cedrus VPU driver that supports the VPU found in >>

Re: [PATCH] davinci_vpfe: add a missing break

2018-11-06 Thread Hans Verkuil
ough [-Wimplicit-fallthrough=] >switch (isif_port_if) { >^~ > drivers/staging/media/davinci_vpfe/dm365_ipipeif.c:314:2: note: here > case IPIPEIF_SDRAM_YUV: > ^~~~ > > There is a missing break for the raw format. > > Signed-off-by: Mauro Carvalho Chehab Nacked-by:

Re: [PATCH] media: dm365_ipipeif: better annotate a fall though

2018-11-06 Thread Hans Verkuil
; > Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans Verkuil Thanks! Hans > --- > drivers/staging/media/davinci_vpfe/dm365_ipipeif.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipeif.c > b/drivers/stag

Re: [PATCH v7 00/12] media: staging/imx7: add i.MX7 media driver

2018-11-07 Thread Hans Verkuil
Hi Rui, On 08/10/18 16:20, Rui Miguel Silva wrote: > Hi, > This series introduces the Media driver to work with the i.MX7 SoC. it uses > the > already existing imx media core drivers but since the i.MX7, contrary to > i.MX5/6, do not have an IPU and because of that some changes in the imx media >

Re: [PATCH] media: staging: tegra-vde: print long unsigned using %lu format specifier

2018-11-09 Thread Hans Verkuil
On 11/08/18 12:02, Colin King wrote: > From: Colin Ian King > > The frame.flags & FLAG_B_FRAME is promoted to a long unsigned because > of the use of the BIT() macro when defining FLAG_B_FRAME and causing a > build warning. Fix this by using the %lu format specifer. > > Cleans up warning: > driv

Re: [PATCH][staging-next] drivers: staging: cedrus: find ctx before dereferencing it ctx

2018-11-14 Thread Hans Verkuil
On 11/02/18 20:01, Colin King wrote: > From: Colin Ian King > > Currently if count is an invalid value the v4l2_info message will > dereference a null ctx pointer to get the dev information. Fix > this by finding ctx first and then checking for an invalid count, > this way ctxt will be non-null h

Re: [PATCH v8 00/12] media: staging/imx7: add i.MX7 media driver

2018-11-21 Thread Hans Verkuil
On 11/21/2018 12:15 PM, Rui Miguel Silva wrote: > Hi, > This series introduces the Media driver to work with the i.MX7 SoC. it uses > the > already existing imx media core drivers but since the i.MX7, contrary to > i.MX5/6, do not have an IPU and because of that some changes in the imx media > cor

Re: [PATCH v2 1/2] media: v4l: Add definitions for the HEVC slice format and controls

2018-12-05 Thread Hans Verkuil
On 11/23/18 14:02, Paul Kocialkowski wrote: > This introduces the required definitions for HEVC decoding support with > stateless VPUs. The controls associated to the HEVC slice format provide > the required meta-data for decoding slices extracted from the bitstream. > > This interface comes with

Re: [PATCH] media: rockchip/vpu: fix a few alignments

2018-12-05 Thread Hans Verkuil
On 12/05/2018 07:43 PM, Mauro Carvalho Chehab wrote: > As reported by checkpatch.pl, some function calls have a wrong > alignment. > > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/staging/media/rockchip/vpu/rk3288_vpu_hw_jpeg_enc.c | 4 ++-- > drivers/staging/media/rockchip/vpu/rk3399_vp

Re: [PATCH] media: cedrus: don't initialize pointers with zero

2018-12-07 Thread Hans Verkuil
On 12/07/2018 11:56 AM, Mauro Carvalho Chehab wrote: > A common mistake is to assume that initializing a var with: > struct foo f = { 0 }; > > Would initialize a zeroed struct. Actually, what this does is > to initialize the first element of the struct to zero. > > According to C99 Standard

Re: [PATCH] media: cedrus: don't initialize pointers with zero

2018-12-07 Thread Hans Verkuil
On 12/07/2018 12:31 PM, Mauro Carvalho Chehab wrote: > Em Fri, 7 Dec 2018 12:14:50 +0100 > Hans Verkuil escreveu: > >> On 12/07/2018 11:56 AM, Mauro Carvalho Chehab wrote: >>> A common mistake is to assume that initializing a var with: >>> struct foo f =

Re: [PATCH v9 01/13] media: staging/imx: refactor imx media device probe

2018-12-07 Thread Hans Verkuil
On 11/22/2018 04:18 PM, Rui Miguel Silva wrote: > Refactor and move media device initialization code to a new common > module, so it can be used by other devices, this will allow for example > a near to introduce imx7 CSI driver, to use this media device. > > Signed-off-by: Rui Miguel Silva > ---

Re: [PATCH v9 05/13] media: dt-bindings: add bindings for i.MX7 media driver

2018-12-07 Thread Hans Verkuil
On 11/22/2018 04:18 PM, Rui Miguel Silva wrote: > Add bindings documentation for i.MX7 media drivers. > The imx7 MIPI CSI2 and imx7 CMOS Sensor Interface. > > Signed-off-by: Rui Miguel Silva > Reviewed-by: Rob Herring > Acked-by: Sakari Ailus Please move this patch to the beginning of the seri

Re: [PATCH v9 00/13] media: staging/imx7: add i.MX7 media driver

2018-12-07 Thread Hans Verkuil
gt; but that I think not related with the sensor driver but with the testing and > core. > > The csi and mipi-csi entities pass all compliance tests. > > Cheers, > Rui > > v8->v9: > Hans Verkuil: > - Fix issues detected by checkpatch strict, still some le

Re: [PATCH AUTOSEL 5.10 14/36] media: rkisp1: uapi: change hist_bins array type from __u16 to __u32

2021-02-08 Thread Hans Verkuil
ld > Acked-by: Helen Koike > Signed-off-by: Hans Verkuil > Signed-off-by: Mauro Carvalho Chehab > Signed-off-by: Sasha Levin > --- > drivers/staging/media/rkisp1/uapi/rkisp1-config.h | 13 + > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/

Re: [PATCH AUTOSEL 5.10 14/36] media: rkisp1: uapi: change hist_bins array type from __u16 to __u32

2021-02-09 Thread Hans Verkuil
On 09/02/2021 14:02, Greg Kroah-Hartman wrote: > On Tue, Feb 09, 2021 at 01:45:35PM +0100, Dafna Hirschfeld wrote: >> >> >> Am 08.02.21 um 21:46 schrieb Hans Verkuil: >>> On 08/02/2021 18:57, Sasha Levin wrote: >>>> From: Daf

Re: [PATCH v8 01/13] dt-bindings: mfd: Add 'nxp,imx8mq-vpu-ctrl' to syscon list

2021-04-06 Thread Hans Verkuil
Hi Benjamin, The commit logs in this series have a few too many grammatical mistakes. And since I want some other changes as well, I'll just review the text so it can be fixed in v9. On 01/04/2021 17:59, Benjamin Gaignard wrote: > Add 'nxp,imx8mq-vpu-ctrl' in the list of possible syscon. in -> t

Re: [PATCH v8 02/13] dt-bindings: media: nxp,imx8mq-vpu: Update the bindings for G2 support

2021-04-06 Thread Hans Verkuil
On 01/04/2021 17:59, Benjamin Gaignard wrote: > Introducing G2 hevc video decoder lead to modify the bindings to allow > to get one node per VPUs. Introducing the G2 hevc video decoder requires modifications of the bindings to allow one node per VPU. > VPUs share one hardware control block which

Re: [PATCH v9 03/13] media: hantro: Use syscon instead of 'ctrl' register

2021-04-20 Thread Hans Verkuil
On 20/04/2021 11:10, Benjamin Gaignard wrote: > > Le 16/04/2021 à 17:14, Lucas Stach a écrit : >> Am Freitag, dem 16.04.2021 um 15:08 +0200 schrieb Benjamin Gaignard: >>> Le 16/04/2021 à 12:54, Lucas Stach a écrit : Am Mittwoch, dem 07.04.2021 um 09:35 +0200 schrieb Benjamin Gaignard: > I

Re: [PATCH v9 03/13] media: hantro: Use syscon instead of 'ctrl' register

2021-04-20 Thread Hans Verkuil
On 20/04/2021 11:31, Benjamin Gaignard wrote: > > Le 20/04/2021 à 11:16, Hans Verkuil a écrit : >> On 20/04/2021 11:10, Benjamin Gaignard wrote: >>> Le 16/04/2021 à 17:14, Lucas Stach a écrit : >>>> Am Freitag, dem 16.04.2021 um 15:08 +0200 schrieb Benjamin Gaig

Re: [PATCH] media: atomisp: silence "dubious: !x | !y" warning

2021-04-20 Thread Hans Verkuil
Hi Ashish, On 18/04/2021 03:26, Ashish Kalra wrote: > On Sat, Apr 17, 2021 at 08:56:13PM +0200, Mauro Carvalho Chehab wrote: >> Em Sat, 17 Apr 2021 21:06:27 +0530 >> Ashish Kalra escreveu: >> >>> Upon running sparse, "warning: dubious: !x | !y" is brought to notice >>> for this file. Logical and

Re: [RFC RESEND 0/3] vp9 v4l2 stateless uapi

2021-04-26 Thread Hans Verkuil
Hi Andrzej, Thank you for working on this! On 21/04/2021 12:00, Andrzej Pietrasiewicz wrote: > Dear All, > > This is an RFC on stateless uapi for vp9 decoding with v4l2. This work is > based on https://lkml.org/lkml/2020/11/2/1043, but has been substantially > reworked. The important change is

Re: [RFC RESEND 0/3] vp9 v4l2 stateless uapi

2021-04-29 Thread Hans Verkuil
On 27/04/2021 01:34, Ezequiel Garcia wrote: > On Mon, 26 Apr 2021 at 14:38, Nicolas Dufresne wrote: >> >> Le lundi 26 avril 2021 à 09:38 +0200, Hans Verkuil a écrit : >>> Hi Andrzej, >>> >>> Thank you for working on this! >>> >>> On

Re: [RFC RESEND 2/3] media: uapi: Add VP9 stateless decoder controls

2021-04-29 Thread Hans Verkuil
On 21/04/2021 12:00, Andrzej Pietrasiewicz wrote: > Add the VP9 stateless decoder controls plus the documentation that goes > with it. > > Signed-off-by: Boris Brezillon > Signed-off-by: Ezequiel Garcia > Signed-off-by: Adrian Ratiu > Signed-off-by: Andrzej Pietrasiewicz > --- > .../userspace

Re: [RFC RESEND 3/3] media: rkvdec: Add the VP9 backend

2021-04-29 Thread Hans Verkuil
On 21/04/2021 12:00, Andrzej Pietrasiewicz wrote: > From: Boris Brezillon > > The Rockchip VDEC supports VP9 profile 0 up to 4096x2304@30fps. Add > a backend for this new format. > > Signed-off-by: Boris Brezillon > Signed-off-by: Ezequiel Garcia > Signed-off-by: Adrian Ratiu > Signed-off-by:

Re: [RFC RESEND 0/3] vp9 v4l2 stateless uapi

2021-04-30 Thread Hans Verkuil
Hi Nicolas, On 29/04/2021 21:38, Nicolas Dufresne wrote: > Le jeudi 29 avril 2021 à 11:23 +0200, Hans Verkuil a écrit : >> On 27/04/2021 01:34, Ezequiel Garcia wrote: >>> On Mon, 26 Apr 2021 at 14:38, Nicolas Dufresne wrote: >>>> >>>> Le lundi 26 avri

Re: [PATCH v10 0/9] Add HANTRO G2/HEVC decoder support for IMX8MQ

2021-05-05 Thread Hans Verkuil
Hi Benjamin, On 20/04/2021 14:10, Benjamin Gaignard wrote: > The IMX8MQ got two VPUs but until now only G1 has been enabled. > This series aim to add the second VPU (aka G2) and provide basic > HEVC decoding support. > > To be able to decode HEVC it is needed to add/update some of the > structur

Re: [PATCH v10 8/9] media: hantro: Introduce G2/HEVC decoder

2021-05-05 Thread Hans Verkuil
Hi Benjamin, Some comments: On 20/04/2021 14:10, Benjamin Gaignard wrote: > Implement all the logic to get G2 hardware decoding HEVC frames. > It supports up level 5.1 HEVC stream. > It doesn't support yet 10 bits formats or the scaling feature. > > Add HANTRO HEVC dedicated control to skip some

Re: [PATCH v10 6/9] media: uapi: Add a control for HANTRO driver

2021-05-05 Thread Hans Verkuil
On 20/04/2021 14:10, Benjamin Gaignard wrote: > The HEVC HANTRO driver needs to know the number of bits to skip at > the beginning of the slice header. > That is a hardware specific requirement so create a dedicated control > for this purpose. > > Signed-off-by: Benjamin Gaignard > --- > .../use

Re: [PATCH v10 6/9] media: uapi: Add a control for HANTRO driver

2021-05-06 Thread Hans Verkuil
On 05/05/2021 17:20, Benjamin Gaignard wrote: > > Le 05/05/2021 à 16:55, Hans Verkuil a écrit : >> On 20/04/2021 14:10, Benjamin Gaignard wrote: >>> The HEVC HANTRO driver needs to know the number of bits to skip at >>> the beginning of the slice header. &

Re: [PATCH v10 0/9] Add HANTRO G2/HEVC decoder support for IMX8MQ

2021-05-25 Thread Hans Verkuil
On 05/05/2021 16:42, Hans Verkuil wrote: > Hi Benjamin, > > On 20/04/2021 14:10, Benjamin Gaignard wrote: >> The IMX8MQ got two VPUs but until now only G1 has been enabled. >> This series aim to add the second VPU (aka G2) and provide basic >> HEVC decoding support.

Re: [PATCH v5 02/16] phy: Distinguish between Rx and Tx for MIPI D-PHY with submodes

2021-05-26 Thread Hans Verkuil
On 15/01/2021 21:01, Paul Kocialkowski wrote: > As some D-PHY controllers support both Rx and Tx mode, we need a way for > users to explicitly request one or the other. For instance, Rx mode can > be used along with MIPI CSI-2 while Tx mode can be used with MIPI DSI. > > Introduce new MIPI D-PHY P

Re: [PATCH v5 00/16] Allwinner MIPI CSI-2 support for A31/V3s/A83T

2021-05-26 Thread Hans Verkuil
Hi Paul, On 15/01/2021 21:01, Paul Kocialkowski wrote: > This series introduces support for MIPI CSI-2, with the A31 controller that is > found on most SoCs (A31, V3s and probably V5) as well as the A83T-specific > controller. While the former uses the same MIPI D-PHY that is already > supported

Re: [PATCH 00/38] media sparse/smatch warn fixes

2020-09-07 Thread Hans Verkuil
arate function > media: vivid: move the devnode creation logic to a separate function > media: vivid: fix error path For these vivid patches and after fixing the "unused variable 'i'" warning as reported by the kernel test robot: Reviewed-by: Hans Verkuil Thank you

Re: [PATCH 0/5] ARM: dts: sun8i: r40: Enable video decoder

2020-09-17 Thread Hans Verkuil
Hi Maxime, On 27/08/2020 17:19, Maxime Ripard wrote: > On Tue, Aug 25, 2020 at 07:35:18PM +0200, Jernej Skrabec wrote: >> Allwinner R40 SoC contains video engine very similar to that in A33. >> >> First two patches add system controller nodes and the rest of them >> add support for Cedrus VPU. >>

Re: [PATCH] media: cedrus: Propagate OUTPUT resolution to CAPTURE

2020-09-17 Thread Hans Verkuil
On 14/05/2020 17:39, Nicolas Dufresne wrote: > As per spec, the CAPTURE resolution should be automatically set based on > the OTUPUT resolution. This patch properly propagate width/height to the > capture when the OUTPUT format is set and override the user provided > width/height with configured OU

Re: [PATCH RFT/RFC v2 00/47] staging: media: bring back zoran driver

2020-09-28 Thread Hans Verkuil
Hi Corentin, On 25/09/2020 20:30, Corentin Labbe wrote: > Hello > > The zoran driver was removed in 5.3 > The main reason of the removing was lack of motivation to convert it to > VB2 > Since I need it, I worked on bringing it back. > > So the plan to achieve it was: > - clean up the coding styl

Re: [PATCH RFT/RFC v2 00/47] staging: media: bring back zoran driver

2020-09-28 Thread Hans Verkuil
On 28/09/2020 15:53, Laurent Pinchart wrote: > Hi Hans, > > On Mon, Sep 28, 2020 at 03:45:03PM +0200, Hans Verkuil wrote: >> On 25/09/2020 20:30, Corentin Labbe wrote: >>> Hello >>> >>> The zoran driver was removed in 5.3 >>> The main reason of t

Re: [PATCH v2 0/6] ARM: dts: sun8i: v3s: Enable video decoder

2020-10-30 Thread Hans Verkuil
Maxime, Are you OK with this series? It looks good to me. Regards, Hans On 12/09/2020 16:30, Martin Cerveny wrote: > First patch extends cedrus capability to all decoders > because V3s missing MPEG2 decoder. > > Next two patches add system control node (SRAM C1) and > next three patch

Re: [PATCH -next] media: cedrus: fix reference leak in cedrus_start_streaming

2020-11-04 Thread Hans Verkuil
On 02/11/2020 15:18, Maxime Ripard wrote: > On Mon, Nov 02, 2020 at 10:26:22PM +0800, Zhang Qilong wrote: >> pm_runtime_get_sync will increment pm usage counter even it >> failed. Forgetting to pm_runtime_put_noidle will result in >> reference leak in cedrus_start_streaming. We should fix it. >> >>

Re: [PATCH v2 0/6] ARM: dts: sun8i: v3s: Enable video decoder

2020-11-05 Thread Hans Verkuil
Hi Martin, On 12/09/2020 16:30, Martin Cerveny wrote: > First patch extends cedrus capability to all decoders > because V3s missing MPEG2 decoder. > > Next two patches add system control node (SRAM C1) and > next three patches add support for Cedrus VPU. > > Tested on "Lichee Zero" V3s platform

Re: [PATCH 0/7] sunxi: Remove the calls to dma_direct_set_offset

2020-11-11 Thread Hans Verkuil
On 06/11/2020 16:14, Maxime Ripard wrote: > Hi, > > Here's an attempt to removing the dma_direct_set_offset calls we have in > numerous drivers and move all those quirks into a global notifier as suggested > by Robin. For patches 4-7: Acked-by: Hans Verkuil It's fin

Re: [PATCH v2 0/6] ARM: dts: sun8i: v3s: Enable video decoder

2020-11-16 Thread Hans Verkuil
On 15/11/2020 19:59, Martin Cerveny wrote: > Hello. > > On Thu, 5 Nov 2020, Hans Verkuil wrote: > >> Hi Martin, >> >> On 12/09/2020 16:30, Martin Cerveny wrote: >>> First patch extends cedrus capability to all decoders >>> because V3s missing MP

Re: [PATCH v2 0/6] ARM: dts: sun8i: v3s: Enable video decoder

2020-11-16 Thread Hans Verkuil
On 16/11/2020 13:07, Martin Cerveny wrote: > Hello. > > On Mon, 16 Nov 2020, Martin Cerveny wrote: >> On Mon, 16 Nov 2020, Hans Verkuil wrote: >>> On 15/11/2020 19:59, Martin Cerveny wrote: >>>> On Thu, 5 Nov 2020, Hans Verkuil wrote: >>>>> On 1

Re: [PATCH v3 0/6] ARM: dts: sun8i: v3s: Enable video decoder

2020-12-02 Thread Hans Verkuil
Hi Martin, Maxime, On 16/11/2020 13:56, Martin Cerveny wrote: > First patch extends cedrus capability to all decoders > because V3s missing MPEG2 decoder. > > Next two patches add system control node (SRAM C1) and > next three patches add support for Cedrus VPU. I've picked up patches 1, 4 and

Re: [PATCH] media: allegro: Fix use after free on error

2020-12-16 Thread Hans Verkuil
On 14/12/2020 18:16, Michael Tretter wrote: > On Mon, 14 Dec 2020 14:54:47 +0300, Dan Carpenter wrote: >> The "channel" is added to the "dev->channels" but then if >> v4l2_m2m_ctx_init() fails then we free "channel" but it's still on the >> list so it could lead to a use after free. Let's not add

Re: [PATCH] media: rkvdec: silence ktest bot build warning

2021-01-07 Thread Hans Verkuil
On 08/12/2020 16:55, Adrian Ratiu wrote: > Some configurations built by the ktest bot produce the following > warn, so mark the struct as __maybe_unused to avoid unnecessary > ML spam. > >>> drivers/staging/media/rkvdec/rkvdec.c:967:34: warning: unused variable >>> 'of_rkvdec_match' [-Wunused-con

Re: [PATCH] media: imx: queue subdev events to reachable video devices

2019-01-08 Thread Hans Verkuil
On 12/09/18 20:57, Steve Longerbeam wrote: > From: Steve Longerbeam > > Forward events from a sub-device to its list of reachable video > devices. > > Note this will queue the event to a video device even if there is > no actual _enabled_ media path from the sub-device to the video device. > So

Re: [PATCH 2/2] media: cedrus: Allow using the current dst buffer as reference

2019-01-09 Thread Hans Verkuil
On 01/09/19 15:19, Paul Kocialkowski wrote: > It was reported that some cases of interleaved video decoding require > using the current destination buffer as a reference. However, this is > no longer possible after the move to vb2_find_timestamp because only > dequeued and done buffers are consider

Re: [PATCH 2/2] media: cedrus: Allow using the current dst buffer as reference

2019-01-09 Thread Hans Verkuil
On 01/09/19 15:42, Paul Kocialkowski wrote: > Hi, > > On Wed, 2019-01-09 at 15:29 +0100, Hans Verkuil wrote: >> On 01/09/19 15:19, Paul Kocialkowski wrote: >>> It was reported that some cases of interleaved video decoding require >>> using the current destinati

Re: [PATCH v12 00/13] media: staging/imx7: add i.MX7 media driver

2019-02-05 Thread Hans Verkuil
error path > > Philipp Zabel: > - Add reviewed tag to video mux patch 12/13 > > v9->v10: > Hans: > - move dt-bindings patch up in the series to avoid checkpatch warnings > - Fix SPDX tag > > Sakari: > - use debugfs and drop driver parameters &g

Re: [PATCH v13 10/13] media: imx7.rst: add documentation for i.MX7 media driver

2019-02-06 Thread Hans Verkuil
On 2/6/19 11:25 AM, Rui Miguel Silva wrote: > Add rst document to describe the i.MX7 media driver and also a working > example from the Warp7 board usage with a OV2680 sensor. > > Signed-off-by: Rui Miguel Silva > Acked-by: Sakari Ailus Checkpatch gives me: Applying: media: imx7.rst: add docum

Re: [PATCH v14 01/13] media: staging/imx: refactor imx media device probe

2019-02-06 Thread Hans Verkuil
On 2/6/19 4:13 PM, Rui Miguel Silva wrote: > Refactor and move media device initialization code to a new common > module, so it can be used by other devices, this will allow for example > a near to introduce imx7 CSI driver, to use this media device. > > Signed-off-by: Rui Miguel Silva > --- > d

Re: [PATCH v14 05/13] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7

2019-02-20 Thread Hans Verkuil
On 2/6/19 4:13 PM, Rui Miguel Silva wrote: > Adds MIPI CSI-2 subdev for i.MX7 to connect with sensors with a MIPI > CSI-2 interface. > > Signed-off-by: Rui Miguel Silva > --- > drivers/staging/media/imx/Makefile |1 + > drivers/staging/media/imx/imx7-mipi-csis.c | 1186 ++

Re: [PATCH] media: staging: use strscpy() instead of strlcpy()

2019-03-29 Thread Hans Verkuil
On 3/29/19 4:29 PM, Mauro Carvalho Chehab wrote: > There are a few left overs at staging with were still using the > deprecated strlcpy() function. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Hans Verkuil Thanks! Hans > --- > drivers/staging/media

Re: [PATCH v3 1/2] media: v4l: Add definitions for the HEVC slice format and controls

2019-04-02 Thread Hans Verkuil
On 2/14/19 10:53 AM, Paul Kocialkowski wrote: > This introduces the required definitions for HEVC decoding support with > stateless VPUs. The controls associated to the HEVC slice format provide > the required meta-data for decoding slices extracted from the bitstream. > > This interface comes wit

Re: [PATCH v3 11/41] media/v4l2-core/mm: convert put_page() to put_user_page*()

2019-08-07 Thread Hans Verkuil
sion, as described in commit fc1d8e7cca2d > ("mm: introduce put_user_page*(), placeholder versions"). > > Cc: Mauro Carvalho Chehab > Cc: Kees Cook > Cc: Hans Verkuil > Cc: Sakari Ailus > Cc: Jan Kara > Cc: Robin Murphy > Cc: Souptick Joarder > Cc: Da

Re: [PATCH v3 10/41] media/ivtv: convert put_page() to put_user_page*()

2019-08-07 Thread Hans Verkuil
sion, as described in commit fc1d8e7cca2d > ("mm: introduce put_user_page*(), placeholder versions"). > > Cc: Andy Walls > Cc: Mauro Carvalho Chehab > Cc: linux-me...@vger.kernel.org > Signed-off-by: John Hubbard Acked-by: Hans Verkuil Regards, Hans

Re: [PATCH 0/7] media: cedrus: Improvements/cleanup

2019-08-12 Thread Hans Verkuil
On 5/30/19 11:15 PM, Jernej Skrabec wrote: > Here is first batch of random Cedrus improvements/cleanups. Only patch 2 > has a change which raises a question about H264 controls. > > Changes were tested on H3 SoC using modified ffmpeg and Kodi. > > Please take a look. This has been sitting in pat

Re: [PATCH 8/8] media: cedrus: Add support for V4L2_DEC_CMD_FLUSH

2019-08-29 Thread Hans Verkuil
On 8/22/19 9:45 PM, Jernej Skrabec wrote: > This command is useful for explicitly flushing last decoded frame. > > Signed-off-by: Jernej Skrabec > --- > .../staging/media/sunxi/cedrus/cedrus_video.c | 34 +++ > 1 file changed, 34 insertions(+) > > diff --git a/drivers/staging/me

Re: [PATCH 7/8] media: cedrus: Add support for holding capture buffer

2019-08-29 Thread Hans Verkuil
On 8/22/19 9:44 PM, Jernej Skrabec wrote: > When frame contains multiple slices and driver works in slice mode, it's > more efficient to hold capture buffer in queue until all slices of a > same frame are decoded. > > Add support for that to Cedrus driver by exposing and implementing > V4L2_BUF_CA

Re: [PATCH] media: staging: tegra-vde: Disable building with COMPILE_TEST

2019-08-29 Thread Hans Verkuil
On 8/26/19 3:31 PM, YueHaibing wrote: > If COMPILE_TEST is y and IOMMU_SUPPORT is n, selecting TEGRA_VDE > to m will set IOMMU_IOVA to m, this fails the building of > TEGRA_HOST1X and DRM_TEGRA which is y like this: > > drivers/gpu/host1x/cdma.o: In function `host1x_cdma_init': > cdma.c:(.text+0x6

Re: [PATCH 5/8] media: cedrus: Detect first slice of a frame

2019-08-30 Thread Hans Verkuil
On 8/22/19 9:44 PM, Jernej Skrabec wrote: > When codec supports multiple slices in one frame, VPU has to know when > first slice of each frame is being processed, presumably to correctly > clear/set data in auxiliary buffers. > > Add first_slice field to cedrus_run structure and set it according t

Re: [PATCH 2/8] videodev2.h: add V4L2_DEC_CMD_FLUSH

2019-08-30 Thread Hans Verkuil
On 8/30/19 11:38 AM, Alexandre Courbot wrote: > On Fri, Aug 23, 2019 at 4:45 AM Jernej Skrabec > wrote: >> >> From: Hans Verkuil >> >> Add this new V4L2_DEC_CMD_FLUSH decoder command and document it. >> >> Signed-off-by: Hans Verkuil >> Signed-

Re: [PATCH v2 0/6] media: cedrus: h264: Support multi-slice frames

2019-09-30 Thread Hans Verkuil
Cedrus > - hold capture buffer flag is set according to source format > - added v4l m2m stateless_(try_)decoder_cmd ioctl helpers > > Hans Verkuil (2): > vb2: add V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF > videodev2.h: add V4L2_DEC_CMD_FLUSH > > Jernej Skrabec (4): > me

Re: [PATCH v2 6/6] media: cedrus: Add support for holding capture buffer

2019-09-30 Thread Hans Verkuil
On 9/29/19 10:00 PM, Jernej Skrabec wrote: > When frame contains multiple slices and driver works in slice mode, it's > more efficient to hold capture buffer in queue until all slices of a > same frame are decoded. > > Add support for that to Cedrus driver by exposing and implementing > V4L2_BUF_C

Re: [PATCH v2 0/6] media: cedrus: h264: Support multi-slice frames

2019-09-30 Thread Hans Verkuil
On 10/1/19 12:27 AM, Jernej Škrabec wrote: > Dne ponedeljek, 30. september 2019 ob 10:10:48 CEST je Hans Verkuil > napisal(a): >> On 9/29/19 10:00 PM, Jernej Skrabec wrote: >>> This series adds support for decoding multi-slice H264 frames along with >>> supp

Re: [PATCH v2 3/6] media: v4l2-mem2mem: add stateless_(try_)decoder_cmd ioctl helpers

2019-10-04 Thread Hans Verkuil
On 9/29/19 10:00 PM, Jernej Skrabec wrote: > These helpers are used by stateless codecs when they support multiple > slices per frame and hold capture buffer flag is set. It's expected that > all such codecs will use this code. > > Signed-off-by: Jernej Skrabec > --- > drivers/media/v4l2-core/v4

Re: [PATCH v2 3/6] media: v4l2-mem2mem: add stateless_(try_)decoder_cmd ioctl helpers

2019-10-07 Thread Hans Verkuil
On 10/7/19 8:02 AM, Jernej Škrabec wrote: > Dne petek, 04. oktober 2019 ob 11:21:12 CEST je Hans Verkuil napisal(a): >> On 9/29/19 10:00 PM, Jernej Skrabec wrote: >>> These helpers are used by stateless codecs when they support multiple >>> slices per frame and hold

Re: [PATCH v2 3/6] media: v4l2-mem2mem: add stateless_(try_)decoder_cmd ioctl helpers

2019-10-07 Thread Hans Verkuil
On 10/7/19 10:32 AM, Hans Verkuil wrote: > On 10/7/19 8:02 AM, Jernej Škrabec wrote: >> Dne petek, 04. oktober 2019 ob 11:21:12 CEST je Hans Verkuil napisal(a): >>> On 9/29/19 10:00 PM, Jernej Skrabec wrote: >>>> These helpers are used by stateless codecs when they su

Re: [PATCH v2 0/6] media: cedrus: h264: Support multi-slice frames

2019-10-07 Thread Hans Verkuil
> > Best regards, > Jernej > > Changes from v1: > - added Rb tags > - updated V4L2_DEC_CMD_FLUSH documentation > - updated first slice detection in Cedrus > - hold capture buffer flag is set according to source format > - added v4l m2m stateless_(try_)decoder_cmd ioctl helpers

Re: [PATCH v2 0/6] media: cedrus: h264: Support multi-slice frames

2019-10-09 Thread Hans Verkuil
On 10/7/19 9:01 PM, Jernej Škrabec wrote: > Dne ponedeljek, 07. oktober 2019 ob 12:44:24 CEST je Hans Verkuil napisal(a): >> Hi Jernej, >> >> On 9/29/19 10:00 PM, Jernej Skrabec wrote: >>> This series adds support for decoding multi-slice H264 frames along with >

Re: [PATCH] staging: media: Fix alignment to match open parenthesis

2019-10-09 Thread Hans Verkuil
Hi Amol, For future reference: always include the driver name in the subject. I've added "imx: " to the subject for you, so no need to resend, but the driver name is important information. Regards, Hans On 9/11/19 6:56 PM, Amol Grover wrote: > CHECK: Alignment should match open parenth

Re: [PATCH] staging: meson: add space to fix check warning

2019-10-16 Thread Hans Verkuil
On 10/16/19 12:34 AM, Jules Irenge wrote: > Fix "alignment should mactch open parenthesis" check. > Issue detected by checkpatch tool > > Signed-off-by: Jules Irenge > --- > drivers/staging/media/meson/vdec/codec_mpeg12.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/

Re: [PATCH 11/15] [media] Deprecate v4l2_mbus_pixelcode

2014-11-05 Thread Hans Verkuil
On 11/05/14 16:15, Boris Brezillon wrote: > On Wed, 5 Nov 2014 17:08:15 +0200 > Sakari Ailus wrote: > >> Hi Boris, >> >> On Tue, Nov 04, 2014 at 10:55:06AM +0100, Boris Brezillon wrote: >>> The v4l2_mbus_pixelcode enum (or its values) should be replaced by the >>> media_bus_format enum. >>> Kee

Re: [PATCH 11/15] [media] Deprecate v4l2_mbus_pixelcode

2014-11-05 Thread Hans Verkuil
On 11/05/14 16:30, Boris Brezillon wrote: > On Wed, 05 Nov 2014 16:19:56 +0100 > Hans Verkuil wrote: > >> >> >> On 11/05/14 16:15, Boris Brezillon wrote: >>> On Wed, 5 Nov 2014 17:08:15 +0200 >>> Sakari Ailus wrote: >>> >>>> H

Re: [PATCH v2 01/10] [media] Move mediabus format definition to a more standard place

2014-11-07 Thread Hans Verkuil
On 11/07/14 12:43, Sakari Ailus wrote: > Hi Boris, > > Thank you for the update. > > On Thu, Nov 06, 2014 at 10:56:59AM +0100, Boris Brezillon wrote: >> Rename mediabus formats and move the enum into a separate header file so >> that it can be used by DRM/KMS subsystem without any reference to th

Re: [PATCH v3 10/10] [media] v4l: Forbid usage of V4L2_MBUS_FMT definitions inside the kernel

2014-11-07 Thread Hans Verkuil
Nitpicks: On 11/07/14 15:07, Boris Brezillon wrote: > Place v4l2_mbus_pixelcode in a #ifndef __KERNEL__ section so that kernel > users don't have access to these definitions. > > We have to keep this definition for user-space users even though they're > encouraged to move to the new media_bus_for

Re: [PATCH v3 00/10] [media] Make mediabus format subsystem neutral

2014-11-07 Thread Hans Verkuil
). > > The series first defines MEDIA_BUS_FMT_ macros, and then replace all > references to the v4l2_mbus_pixelcode enum and its values within the > kernel. Looks good! For patches 1-9: Acked-by: Hans Verkuil Patch 10 needs a bit more work, see my reply to that patch. If I get

Re: [PATCH v5 10/10] [media] v4l: Forbid usage of V4L2_MBUS_FMT definitions inside the kernel

2014-11-10 Thread Hans Verkuil
On 11/08/2014 04:47 PM, Boris Brezillon wrote: > Place v4l2_mbus_pixelcode in a #ifndef __KERNEL__ section so that kernel > users don't have access to these definitions. > > We have to keep this definition for user-space users even though they're > encouraged to move to the new media_bus_format en

Re: [PATCH] [media] omap24xx/tcm825x: remove pointless Makefile entry

2014-11-24 Thread Hans Verkuil
I found the same thing and it is already part of my pull request to Mauro. I'm setting this patch as Obsoleted in patchwork. It's unclear what happened. My original patch definitely removed both Makefile lines. Regards, Hans On 11/24/14 11:53, Paul Bolle wrote: > The deprecated omap2 c

Re: [PATCH] drivers:staging:media:omap24xx:v4l2-int-device.h: Added a '*' before ')'--(parenthesis closing)

2014-12-01 Thread Hans Verkuil
On 11/30/2014 11:58 AM, Anjana Sasindran wrote: > This patch fix a checkpatch.pl error: > > ERROR: space prohibited before ')' parenthesis closing > > Signed-off-by: Anjana Sasindran Thanks for the patch, but this driver is removed in kernel 3.19. So there is no point in patching it. Regards,

Re: [PATCH] drivers:staging:media:omap24xx:v4l2-int-device.h: Added a '*' before ')'--(parenthesis closing)

2014-12-01 Thread Hans Verkuil
On 12/01/2014 02:01 PM, anjana s wrote: > Should I do anything on this further? No. The driver will disappear in 3.19, so there is no point to this patch. BTW, always check the Kconfig to see if a staging driver is marked deprecated. If so, then patches are pointless. Regards, Hans >

Re: [PATCH 2/2] tlg2300: Fix media dependencies

2014-12-23 Thread Hans Verkuil
Acked-by: Hans Verkuil On 12/23/2014 06:02 PM, Mauro Carvalho Chehab wrote: > Changeset ea2e813e8cc3 moved the driver to staging, but it forgot to > preserve the existing dependency. > > Fixes: ea2e813e8cc3 ("[media] tlg2300: move to staging in preparation for > removal&

Re: [PATCH 1/2] vino: Fix media dependencies

2014-12-23 Thread Hans Verkuil
Acked-by: Hans Verkuil On 12/23/2014 06:02 PM, Mauro Carvalho Chehab wrote: > Changeset c1d9e03d4ef4 moved the driver to staging, but it forgot to > preserve the existing dependency. > > fixes: c1d9e03d4ef4 ("[media] vino/saa7191: move to staging in preparation > for rem

Re: [PATCH] staging: media: zoran: fix trailing whitespaces

2019-04-10 Thread Hans Verkuil
On 4/8/19 8:51 AM, Dan Carpenter wrote: > On Mon, Apr 08, 2019 at 01:35:30AM -0300, Arthur Moraes do Lago wrote: >> There were several form feeds(^L) in the file, this patch removes them >> to conform with the coding style. >> >> Signed-off-by: Arthur Moraes do Lago >> --- >> drivers/staging/medi

Re: [PATCH] Fixed coding style: do not initialise statics to NULL

2019-04-12 Thread Hans Verkuil
Hi Tiago, On 4/12/19 4:45 AM, Tiago Macedo wrote: > The standard guarantees that a pointer with static storage duration > and no other initializer will be initialized to be a null pointer. > > Signed-off-by: Tiago Macedo > --- > drivers/staging/media/zoran/videocodec.c | 2 +- > 1 file changed,

Re: [PATCH v5 1/4] media: v4l: Add definitions for the HEVC slice controls

2019-05-25 Thread Hans Verkuil
Hi Paul, This patch is missing your Signed-of-by line! Can you reply with your SoB? Regards, Hans On 5/24/19 11:36 AM, Paul Kocialkowski wrote: > This introduces the required definitions for HEVC decoding support with > stateless VPUs. The controls associated to the HEVC slice format pr

Re: [PATCH v5 3/4] media: pixfmt: Document the HEVC slice pixel format

2019-05-25 Thread Hans Verkuil
On 5/24/19 11:36 AM, Paul Kocialkowski wrote: > Document the current state of the HEVC slice pixel format. > The format will need to evolve in the future, which is why it is > not part of the public API. > > Signed-off-by: Paul Kocialkowski > --- > .../media/uapi/v4l/pixfmt-compressed.rst |

Re: [PATCH v5 1/4] media: v4l: Add definitions for the HEVC slice controls

2019-05-25 Thread Hans Verkuil
Hi Paul, Besides the missing SoB I have two more comments: On 5/24/19 11:36 AM, Paul Kocialkowski wrote: > This introduces the required definitions for HEVC decoding support with > stateless VPUs. The controls associated to the HEVC slice format provide > the required meta-data for decoding slice

Re: [PATCH v8 5/5] media: imx: Try colorimetry at both sink and source pads

2019-05-27 Thread Hans Verkuil
> moved out to appropriate places in each subdev try_fmt. > > The IC now supports Rec.709 and BT.601 Y'CbCr encoding, and both limited > and full range quantization for both YUV and RGB space, so allow those > for pipelines that route through the IC. > > Signed-off-by: Steve Lo

Re: [PATCH v1 3/4] staging: media: tegra-vde: Add IOMMU support

2019-06-17 Thread Hans Verkuil
On 6/2/19 11:37 PM, Dmitry Osipenko wrote: > All Tegra's could provide memory isolation for the video decoder > hardware using IOMMU, it is also required for Tegra30+ in order > to handle sparse dmabuf's which GPU exports in a default kernel > configuration. > > Inspired-by: Thierry Reding > Sign

Re: [PATCH v1 4/4] staging: media: tegra-vde: Defer dmabuf's unmapping

2019-06-17 Thread Hans Verkuil
On 6/2/19 11:37 PM, Dmitry Osipenko wrote: > Frequent IOMMU remappings take about 50% of CPU usage because there is > quite a lot to remap. Defer dmabuf's unmapping by 5 seconds in order to > mitigate the mapping overhead which goes away completely and driver works > as fast as in a case of a disab

  1   2   3   >