Re: [PATCH v3] staging: erofs: use explicit unsigned int type

On Sun, Sep 09, 2018 at 08:37:53PM +0200, Thomas Weißschuh wrote: > Changes since v1: > > * Removed changes that conflicted with > [PATCH 1/6] staging: erofs: formatting fix in unzip_vle_lz4.c > * Added patch description > > Changes since v2: > > * Fixed conflicts with other patchsets > * Don'

Re: [PATCH 1/2 dhowells/mount-api] staging: erofs: rename superblock flags (MS_xyz -> SB_xyz)

On Thu, Sep 06, 2018 at 06:37:37PM +0800, Gao Xiang wrote: > > > On 2018/9/6 18:08, David Howells wrote: > > Gao Xiang wrote: > > > >> This patch follows commit 1751e8a6cb93 ("Rename superblock > >> flags (MS_xyz -> SB_xyz)") and after commit ("vfs: Suppress > >> MS_* flag defs within the kerne

Re: [PATCH v6 3/3] staging: mt7621-mmc: Fix debug macro IRQ_MSG and its usages

On Sat, Sep 01, 2018 at 03:51:10AM +0530, Nishad Kamdar wrote: > Replace all usages of IRQ_MSG with with dev_ without __func__ > or __LINE__ or current->comm and current->pid. Remove the do {} > while(0) loop for the single statement macro. Drop IRQ_MSG from dbg.h. > Issue found by checkpatch. > >

Re: [PATCH] staging: clocking-wizard: Add support for dynamic reconfiguration

On Mon, Sep 10, 2018 at 10:28:25PM +0530, Shubhrajyoti Datta wrote: > On Mon, Sep 10, 2018 at 2:41 PM Greg KH wrote: > > > > On Mon, Sep 10, 2018 at 10:47:28AM +0530, shubhrajyoti.da...@gmail.com > > wrote: > > > From: Shubhrajyoti Datta > > > > > > The patch adds support for dynamic reconfigura

Re: [PATCH 1/4] staging: vboxvideo: Fix modeset / page_flip error handling

On Tue, Sep 11, 2018 at 09:15:41AM +0200, Hans de Goede wrote: > The default settings for Linux vms created in VirtualBox allocate only > 16M of videomem. When running fullscreen on a 1920x1080 (or bigger) monitor > this is not a lot. > > When using GNOME3 on Wayland we have already been seeing ou

Re: [PATCH 1/4] staging: vboxvideo: Fix modeset / page_flip error handling

On Wed, Sep 12, 2018 at 09:54:51AM +0200, Hans de Goede wrote: > Hi, > > On 11-09-18 20:46, Greg Kroah-Hartman wrote: > > On Tue, Sep 11, 2018 at 09:15:41AM +0200, Hans de Goede wrote: > > > The default settings for Linux vms created in VirtualBox allocate only > > &

Re: [PATCH v2 05/17] compat_ioctl: move more drivers to generic_compat_ioctl_ptrarg

double-checked all these drivers to ensure that all ioctl arguments > are used as pointers or are ignored, but are not interpreted as integer > values. > > Signed-off-by: Arnd Bergmann Acked-by: Greg Kroah-Hartman ___ devel

Re: [PATCH v2 02/17] compat_ioctl: move drivers to generic_compat_ioctl_ptrarg

igned-off-by: Arnd Bergmann Acked-by: Greg Kroah-Hartman ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 0/8] staging: erofs: error handing and more tracepoints

On Fri, Sep 14, 2018 at 10:40:22PM +0800, Gao Xiang wrote: > In order to avoid conflicts with cleanup patches, Chao and I think > it is better to send reviewed preview patches in the erofs mailing list > to the community in time. > > So here is reviewed & tested patches right now, which clean up a

Re: [PATCH] staging: mt7621-mmc: Remove do {} while (0) loop for single statement macro

On Sat, Sep 15, 2018 at 06:47:51PM +0530, Nishad Kamdar wrote: > This patch removes do {} while (0) loop for single statement macros. > Issue found by checkpatch. > > Signed-off-by: Nishad Kamdar > --- > drivers/staging/mt7621-mmc/sd.c | 28 +++- > 1 file changed, 7 inser

Re: [PATCH v7 1/1] staging: mt7621-mmc: Delete IRQ_MSG() and its users.

On Sat, Sep 15, 2018 at 08:28:03AM +0530, Nishad Kamdar wrote: > This patch removes IRQ_MSG() and its users as currently it is a no-op. > > Signed-off-by: Nishad Kamdar > --- > Changes in v7: > - Delete IRQ_MSG() and all its users > Changes in v6: > - No change > Changes in v5: > - No chang

Re: [PATCH 0/8] staging: erofs: error handing and more tracepoints

On Tue, Sep 18, 2018 at 08:02:30PM +0800, Gao Xiang wrote: > Hi Greg, > > On 2018/9/18 19:19, Greg Kroah-Hartman wrote: > > On Fri, Sep 14, 2018 at 10:40:22PM +0800, Gao Xiang wrote: > >> In order to avoid conflicts with cleanup patches, Chao and I think > >> it i

Re: [PATCH 0/8] staging: erofs: error handing and more tracepoints

On Tue, Sep 18, 2018 at 04:03:37PM +0300, Dan Carpenter wrote: > On Tue, Sep 18, 2018 at 08:31:22PM +0800, Gao Xiang wrote: > > (I have no clang environment to build kernel yet... :( I will try later, > > but I have no idea why it happens, > > and it seems a false warning). > > > > Thanks, > > Ga

Re: [PATCH] staging: erofs: initialize `pblk' with 0 first in `z_erofs_map_blocks_iter'

ialize the variable to keep gcc from printing foolish warnings. > > [1] https://lists.ozlabs.org/pipermail/linux-erofs/2018-September/000637.html > > Reported-by: Greg Kroah-Hartman > Thanks-to: Dan Carpenter > Signed-off-by: Gao Xiang > --- > drivers/staging/erofs/unzip_vl

Re: [PATCH v2 0/8] staging: erofs: error handing and more tracepoints

On Tue, Sep 18, 2018 at 10:25:32PM +0800, Gao Xiang wrote: > change log v2: > - fix a gcc warning reported by Greg for the patch > staging: erofs: clean up z_erofs_map_blocks_iter > > > In order to avoid conflicts with cleanup patches, Chao and I think > it is better to send reviewed pr

Re: [PATCH 00/12] staging: vboxvideo: Preparation work for moving to atomic modesetting

On Tue, Sep 18, 2018 at 07:44:26PM +0200, Hans de Goede wrote: > Hi Greg, > > Here is a series of various cleanups and other prep. work for moving > the vboxvideo driver over to atomic modesetting so that it can be moved > out of staging. Nice work, all now applied. greg k-h

Re: [PATCH] staging: dgnc: Fix Kconfig help header and text

On Tue, Sep 25, 2018 at 10:22:24AM -0600, sehro rautenkranz wrote: > Replace Kconfig help header and text to match other modules. Issue found > my checkpatch. > > Spacing adjusted to match Documentation/process/coding-style.rst. Issue > reported by rdun...@infradead.org. (try 2) The "try 2" needs

Re: [PATCH v2] staging: mt7621-mmc: Fix single statement macros in sd.c

On Sun, Sep 23, 2018 at 06:31:32AM -0700, Joe Perches wrote: > On Sun, 2018-09-23 at 15:08 +0530, Nishad Kamdar wrote: > > This patch fixes a few single statement macros in sd.c. > > It converts two macros to inline functions. It removes > > five other macros and replaces their usages with calls to

Re: [PATCH] staging: rtl8188eu: Simplify memcmp logical checks

On Thu, Sep 20, 2018 at 05:22:21PM -0700, Nathan Chancellor wrote: > Clang generates a warning when it sees a logical not followed by a > conditional operator like ==, >, or < because it thinks that the logical > not should be applied to the whole statement: > > drivers/staging/rtl8188eu/core/rtw_

Re: [PATCH] staging: rtl8723bs: Remove ACPI table declaration

On Tue, Sep 25, 2018 at 10:39:10PM -0700, Nathan Chancellor wrote: > Clang warns that the acpi_id declaration is not going to be emitted > in the final assembly: > > drivers/staging/rtl8723bs/os_dep/sdio_intf.c:25:36: warning: variable > 'acpi_ids' is not needed and will not be emitted > [-Wunneed

Re: [PATCH] staging: rtl8723bs: Remove ACPI table declaration

On Tue, Sep 25, 2018 at 11:44:37PM -0700, Nathan Chancellor wrote: > On Wed, Sep 26, 2018 at 08:22:45AM +0200, Greg Kroah-Hartman wrote: > > On Tue, Sep 25, 2018 at 10:39:10PM -0700, Nathan Chancellor wrote: > > > Clang warns that the acpi_id declaration is not going to be em

Re: [PATCH] staging: rtl8723bs: Mark ACPI table declaration as maybe unused

On Wed, Sep 26, 2018 at 12:02:09AM -0700, Nathan Chancellor wrote: > Clang emits the following warning: > > drivers/staging/rtl8723bs/os_dep/sdio_intf.c:25:36: warning: variable > 'acpi_ids' is not needed and will not be emitted > [-Wunneeded-internal-declaration] > static const struct acpi_device

Re: [PATCH] staging: rtl8723bs: Mark ACPI table declaration as used

On Wed, Sep 26, 2018 at 04:20:55PM -0700, Nathan Chancellor wrote: > Clang emits the following warning: > > drivers/staging/rtl8723bs/os_dep/sdio_intf.c:25:36: warning: variable > 'acpi_ids' is not needed and will not be emitted > [-Wunneeded-internal-declaration] > static const struct acpi_device

Re: [PATCH v3] staging: mt7621-mmc: Remove #if 0 blocks and fix macros in sd.c

On Thu, Sep 27, 2018 at 09:10:57PM +0530, Nishad Kamdar wrote: > This patch removes #if 0 code blocks and usages of the > functions defined in the #if 0 code block. It removes > the macro msdc_irq_restore() and replaces its usage > with call to the function called in the macro definition. > Issue f

Re: [PATCH 01/15] staging: vboxvideo: Cleanup vbox_set_up_input_mapping()

On Wed, Sep 26, 2018 at 09:41:52PM +0200, Hans de Goede wrote: > This cleanups 2 things: > > 1) The first time we loop over the crtc-s, to compare framebuffers, fb1 may > get set to NULL by the fb1 = CRTC_FB(crtci); statement and then we call > to_vbox_framebuffer() on it. The result of this call

Re: [PATCH 01/15] staging: vboxvideo: Cleanup vbox_set_up_input_mapping()

On Sat, Sep 29, 2018 at 02:23:37PM +0200, Hans de Goede wrote: > Hi, > > On 28-09-18 14:38, Greg Kroah-Hartman wrote: > > On Wed, Sep 26, 2018 at 09:41:52PM +0200, Hans de Goede wrote: > > > This cleanups 2 things: > > > > > > 1) The first time we loo

[PATCH 4.18 072/228] staging: android: ashmem: Fix mmap size validation

of the problem in userspace. Cc: Todd Kjos Cc: de...@driverdev.osuosl.org Cc: linux-ker...@vger.kernel.org Cc: kernel-t...@android.com Cc: Joel Fernandes Signed-off-by: Alistair Strachan Acked-by: Joel Fernandes (Google) Reviewed-by: Martijn Coenen Signed-off-by: Greg Kroah-Hartman Signed-off

[PATCH 4.14 053/137] staging: android: ashmem: Fix mmap size validation

of the problem in userspace. Cc: Todd Kjos Cc: de...@driverdev.osuosl.org Cc: linux-ker...@vger.kernel.org Cc: kernel-t...@android.com Cc: Joel Fernandes Signed-off-by: Alistair Strachan Acked-by: Joel Fernandes (Google) Reviewed-by: Martijn Coenen Signed-off-by: Greg Kroah-Hartman Signed-off

[PATCH 4.9 33/94] staging: android: ashmem: Fix mmap size validation

of the problem in userspace. Cc: Todd Kjos Cc: de...@driverdev.osuosl.org Cc: linux-ker...@vger.kernel.org Cc: kernel-t...@android.com Cc: Joel Fernandes Signed-off-by: Alistair Strachan Acked-by: Joel Fernandes (Google) Reviewed-by: Martijn Coenen Signed-off-by: Greg Kroah-Hartman Signed-off

Re: [PATCH] staging: comedi: ni_mio_common: protect register write overflow

On Wed, Sep 19, 2018 at 10:17:19AM -0600, Spencer E. Olson wrote: > Fixes two problems introduced as early as > commit 03aef4b6dc12 ("Staging: comedi: add ni_mio_common code"): > (1) Ensures that the last four bits of NISTC_RTSI_TRIGB_OUT_REG register is > not unduly overwritten on e-series de

Re: [PATCH v3] staging: dgnc: Fix Kconfig help header and text

On Mon, Oct 01, 2018 at 12:49:50PM -0400, Lidza Louina wrote: > On Mon, Oct 1, 2018 at 8:09 AM Mark Hounschell wrote: > > > On 9/28/18 3:59 PM, Lidza Louina wrote: > > > I haven't done work on this driver in a long time. I looked up the > > > devices, and they seem to already have an existing Lin

Re: [PATCH v5 1/3] staging: mt7621-mmc: Remove #if 0 blocks

On Mon, Oct 01, 2018 at 08:13:40PM +0530, Nishad Kamdar wrote: > This patch removes #if 0 code blocks and usages of > functions defined in the #if 0 blocks. > > Signed-off-by: Nishad Kamdar > --- > drivers/staging/mt7621-mmc/dbg.c | 21 +-- > drivers/staging/mt7621-mmc/dbg.h | 14 -- > drivers

Re: [PATCH] staging: comedi: ni_mio_common: protect register write overflow

On Tue, Oct 02, 2018 at 07:24:32PM -0600, Spencer Olson wrote: > On Tue, Oct 2, 2018 at 6:16 PM Spencer Olson wrote: > > > > On Tue, Oct 2, 2018 at 11:32 AM Greg Kroah-Hartman > > wrote: > > > > > > On Wed, Sep 19, 2018 at 10:17:19AM -0600, Spencer E.

Re: [PATCH] staging/rtlwifi: Fixing formatting warnings.

On Fri, Oct 05, 2018 at 02:58:15PM -0600, Scott Tracy wrote: > Signed-off-by: Scott Tracy > --- > drivers/staging/rtlwifi/core.c | 5 +++-- > drivers/staging/rtlwifi/efuse.c | 5 +++-- > 2 files changed, 6 insertions(+), 4 deletions(-) Hi, This is the friendly patch-bot of Gre

Re: [PATCH] staging: erofs: add SPDX identifer

On Mon, Oct 08, 2018 at 09:20:55PM +0800, Gao Xiang wrote: > Hi Loic, > > On 2018/10/8 18:41, Loic Tourlonias wrote: > > Add SPDX identifier to simplify header and remove whole license text > > > > Signed-off-by: Loic Tourlonias > > --- > > drivers/staging/erofs/lz4defs.h | 23 ++---

Re: [PATCH v2] staging: erofs: add SPDX identifer

On Mon, Oct 08, 2018 at 04:14:09PM +0200, Loic Tourlonias wrote: > Add SPDX identifier to simplify header and remove whole license text > > v1 -> v2: > > Move SPDX identifier to first line and change comment delimiter The "changes" need to go below the --- line. > > Signed-off-by: Loic Tourlon

Re: [PATCH v2] staging: erofs: add SPDX identifer

On Mon, Oct 08, 2018 at 10:36:39PM +0800, Gao Xiang wrote: > Hi Greg, > > On 2018/10/8 22:22, Greg Kroah-Hartman wrote: > > Why delete that line? > > > > But wait, why do we even have this file at all? What's wrong with the > > lib/lz4/ code that we have in

[PATCH 4.4 028/113] staging: android: ashmem: Fix mmap size validation

of the problem in userspace. Cc: Todd Kjos Cc: de...@driverdev.osuosl.org Cc: linux-ker...@vger.kernel.org Cc: kernel-t...@android.com Cc: Joel Fernandes Signed-off-by: Alistair Strachan Acked-by: Joel Fernandes (Google) Reviewed-by: Martijn Coenen Signed-off-by: Greg Kroah-Hartman Signed-off

Re: [PATCH] staging: gasket: Fix sparse "incorrect type in assignment" warnings.

On Thu, Oct 04, 2018 at 06:52:25PM +0100, Laurence Rochfort wrote: > Silence the below sparse warnings by casting betwen u8 __iomem *, and > void *. > > warning: incorrect type in assignment (different address spaces) >expected unsigned char [noderef] [usertype] *virt_base >got void *[assi

Re: [PATCH v4 00/13] device-global identifiers and routes introduced

On Wed, Oct 03, 2018 at 02:55:59PM -0600, Spencer E. Olson wrote: > This patch set is the second revision of a recent patch set of the same name. Thanks for sticking with this, all now applied. greg k-h ___ devel mailing list de...@linuxdriverproject.or

Re: [PATCH] staging: gasket: Fix sparse "incorrect type in assignment" warnings.

On Wed, Oct 10, 2018 at 03:03:05PM +0100, Laurence Rochfort wrote: > On Tue, Oct 09, 2018 at 03:13:03PM +0200, Greg Kroah-Hartman wrote: > > On Thu, Oct 04, 2018 at 06:52:25PM +0100, Laurence Rochfort wrote: > > > Silence the below sparse warnings by casting betwen u8 __iomem

[PATCH 3.18 036/120] staging: android: ashmem: Fix mmap size validation

of the problem in userspace. Cc: Todd Kjos Cc: de...@driverdev.osuosl.org Cc: linux-ker...@vger.kernel.org Cc: kernel-t...@android.com Cc: Joel Fernandes Signed-off-by: Alistair Strachan Acked-by: Joel Fernandes (Google) Reviewed-by: Martijn Coenen Signed-off-by: Greg Kroah-Hartman Signed-off

Re: [PATCH 00/11] staging: gasket: fixes

On Sun, Oct 14, 2018 at 09:59:16PM -0700, Todd Poynor wrote: > From: Todd Poynor > > Various fixes for gasket/apex drivers. For some reason you seem to have ignored/missed this patch: Subject: [PATCH v3] staging: gasket: Fix sparse "incorrect type in assignment" warnings. that was sent

Re: [PATCH 01/11] staging: gasket: core: debug log updates

On Sun, Oct 14, 2018 at 09:59:17PM -0700, Todd Poynor wrote: > From: Todd Poynor > > Add debug logs for device enable/disable events, Why? What is going to need this? > remove logs for > callbacks (the called functions can generate their own logs if needed). That's a different thing than "add

Re: [PATCH 05/11] staging: gasket: page_table: rearrange gasket_page_table_entry

On Sun, Oct 14, 2018 at 09:59:21PM -0700, Todd Poynor wrote: > From: Nick Ewalt > > Rearrange gasket_page_table entry to reduce padding slop. In the future, defining exactly what "slop" is here would be nice :) thanks, greg k-h ___ devel mailing list

Re: [PATCH 00/11] staging: gasket: fixes

On Mon, Oct 15, 2018 at 03:29:49AM -0700, Christoph Hellwig wrote: > On Sun, Oct 14, 2018 at 09:59:16PM -0700, Todd Poynor wrote: > > From: Todd Poynor > > > > Various fixes for gasket/apex drivers. > > I still can't find any explanation in the staging tree or in your > comments what gasket even

Re: [PATCH 3/3] staging: gasket: page_table: add mapping flags

On Tue, Oct 16, 2018 at 05:03:09AM -0700, Todd Poynor wrote: > From: Nick Ewalt > > This allows for more precise dma_direction in the dma_map_page requests. > Also leaves room for adding more flags later. Why are you adding new features to this code? It needs to have stuff cleaned up and remove

Re: Which SPDX Identifier for files without explicit GPL version

On Sun, Oct 28, 2018 at 11:04:06AM +0100, Michael Straube wrote: > Hi, > > which GPL version should be used in SPDX Identifiers for files that > are GPL licensed but do not mention any version? It is not clear to > me after reading license-rules.rst. > > For example: > > /***

Re: Which SPDX Identifier for files without explicit GPL version

On Sun, Oct 28, 2018 at 02:22:40PM +0100, Michael Straube wrote: > On 10/28/18 12:27 PM, Greg Kroah-Hartman wrote: > > On Sun, Oct 28, 2018 at 11:04:06AM +0100, Michael Straube wrote: > > > Hi, > > > > > > which GPL version should be used in SPDX Identifiers f

Re: [PATCH v2] staging: vboxvideo: Remove unnecessary parentheses

On Tue, Oct 23, 2018 at 02:43:04PM -0300, Shayenne da Luz Moura wrote: > Remove unneeded parentheses around the arguments of ||. This reduces > clutter and code behave in the same way. > Change suggested by checkpatch.pl. > > vbox_main.c:119: CHECK: Unnecessary parentheses around 'rects[i].x2 < >

Re: [PATCH] staging: Remove the mt29f_spinand driver

On Mon, Nov 05, 2018 at 11:12:27AM +0100, Miquel Raynal wrote: > Hi Greg, > > Boris Brezillon wrote on Mon, 22 Oct 2018 > 22:10:59 +0200: > > > A new SPI NAND subsystem has been added in drivers/mtd/nand/spi/ and > > Micron's MT29F devices are now supported in > > drivers/mtd/nand/spi/micron.c.

Re: [PATCH] staging: Remove the mt29f_spinand driver

On Mon, Nov 05, 2018 at 03:27:34PM +0100, Miquel Raynal wrote: > Hi Greg, > > Greg Kroah-Hartman wrote on Mon, 5 Nov > 2018 14:29:49 +0100: > > > On Mon, Nov 05, 2018 at 11:12:27AM +0100, Miquel Raynal wrote: > > > Hi Greg, > > > > > > Boris Bre

Re: [PATCH v3] driver-staging: vsoc.c: Add sysfs support for examining the permissions of regions.

On Wed, Nov 07, 2018 at 10:30:43AM +0800, Jerry Lin wrote: > Add a attribute called permissions under vsoc device node for examining > current granted permissions in vsoc_device. > > This file will display permissions in following format: > begin_offset end_offset owner_offset owned_value >

Re: [PATCH v3] staging: olpc_dcon: olpc_dcon_xo_1.c: Switch to the gpio descriptor interface

On Tue, Nov 06, 2018 at 01:13:19PM +0530, Nishad Kamdar wrote: > Use the gpiod interface instead of the deprecated old non-descriptor > interface in olpc_dcon_xo_1.c. > --- > Changes in v3: > - Resolve a few compilation errors. > Changes in v2: > - Resolve a few compilation errors. > - Add a lev

Re: [staging:staging-testing 42/93] drivers/staging//media/tegra-vde/tegra-vde.c:265:5: warning: format '%d' expects argument of type 'int', but argument 6 has type 'long unsigned int'

On Wed, Nov 07, 2018 at 08:45:40PM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > staging-testing > head: 64ce301c971bb323ab63f59014498d7e975586ee > commit: 42e764d05712c07e44318bc8f6b8665a9c216505 [42/93] staging: tegravde: > repl

Re: [PATCH v3] driver-staging: vsoc.c: Add sysfs support for examining the permissions of regions.

On Thu, Nov 08, 2018 at 08:49:41AM +0800, wahahab wrote: > > > On 7 Nov 2018, at 5:15 PM, Greg Kroah-Hartman wrote: > > > > On Wed, Nov 07, 2018 at 10:30:43AM +0800, Jerry Lin wrote: > >> Add a attribute called permissions under vsoc device node for examining >

Re: [PATCH] media: staging: tegra-vde: print long unsigned using %lu format specifier

On Thu, Nov 08, 2018 at 11:02:24AM +, Colin King wrote: > From: Colin Ian King > > The frame.flags & FLAG_B_FRAME is promoted to a long unsigned because > of the use of the BIT() macro when defining FLAG_B_FRAME and causing a > build warning. Fix this by using the %lu format specifer. > > Cl

Re: [PATCH 5/6] staging:iio:ad2s90: Add SPDX license identifier

On Fri, Nov 09, 2018 at 09:19:52PM -0200, Matheus Tavares Bernardino wrote: > On Fri, Nov 9, 2018 at 8:13 PM Fabio Estevam wrote: > > > > Hi Matheus, > > > > Hi, Fabio > > > On Fri, Nov 9, 2018 at 8:01 PM Matheus Tavares > > wrote: > > > > > > This patch adds the SPDX GPL-2.0-only license ident

Re: [PATCH] staging: greybus: arche-apb-ctrl.c: Switch to the gpio descriptor interface

On Sun, Nov 11, 2018 at 11:14:14AM +0530, Nishad Kamdar wrote: > Use the gpiod interface instead of the deprecated old non-descriptor > interface. > > Signed-off-by: Nishad Kamdar > --- > drivers/staging/greybus/arche-apb-ctrl.c | 158 ++- > 1 file changed, 65 insertions(+),

Re: [PATCH v3] driver-staging: vsoc.c: Add sysfs support for examining the permissions of regions.

On Mon, Nov 12, 2018 at 04:49:30PM +0800, wahahab wrote: > > > On 10 Nov 2018, at 1:15 AM, Dan Carpenter > > wrote: > > > > On Wed, Nov 07, 2018 at 10:30:43AM +0800, Jerry Lin wrote: > >> Add a attribute called permissions under vsoc device node for examining > >

Re: [PATCH 1/3] staging: erofs: unzip_vle.c: Replace comparison to NULL.

On Mon, Nov 12, 2018 at 09:43:57PM +0100, Cristian Sicilia wrote: > Replace equal to NULL with logic unary operator, > and removing not equal to NULL comparison. > > Signed-off-by: Cristian Sicilia > --- > drivers/staging/erofs/unzip_vle.c | 86 > +++ > 1 fil

Re: [PATCH 1/1] staging: rtlwifi: Add new line to stay in 80 characters

On Tue, Nov 13, 2018 at 12:18:56AM +0100, Cristian Sicilia wrote: > The parameter is sent to next line to stay in 80 > characters > > Signed-off-by: Cristian Sicilia > --- > drivers/staging/rtlwifi/core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > You sent two 1/1 patches, sho

Re: [PATCH 1/3] staging: erofs: unzip_vle.c: Replace comparison to NULL.

On Tue, Nov 13, 2018 at 12:31:58AM +0100, Cristian Sicilia wrote: > On Mon, Nov 12, 2018 at 11:46 PM Greg Kroah-Hartman < > gre...@linuxfoundation.org> wrote: > > > On Mon, Nov 12, 2018 at 09:43:57PM +0100, Cristian Sicilia wrote: > > > Replace equal to NULL with l

[PATCH 4.19 119/205] x86/hyper-v: Enable PIT shutdown quirk

asan Cc: sta...@vger.kernel.org Link: https://lkml.kernel.org/r/1541303219-11142-3-git-send-email-mikel...@microsoft.com Signed-off-by: Greg Kroah-Hartman --- arch/x86/kernel/cpu/mshyperv.c | 11 +++ 1 file changed, 11 insertions(+) --- a/arch/x86/kernel/cpu/mshyperv.c +++ b/arch/x86

[PATCH 4.19 129/205] clockevents/drivers/i8253: Add support for PIT shutdown quirk

: "a...@canonical.com" Cc: vkuznets Cc: "jasow...@redhat.com" Cc: "marcelo.ce...@canonical.com" Cc: KY Srinivasan Cc: sta...@vger.kernel.org Link: https://lkml.kernel.org/r/1541303219-11142-2-git-send-email-mikel...@microsoft.com Signed-off-by: Greg Kroah-Hartman

[PATCH 4.18 096/171] x86/hyper-v: Enable PIT shutdown quirk

asan Cc: sta...@vger.kernel.org Link: https://lkml.kernel.org/r/1541303219-11142-3-git-send-email-mikel...@microsoft.com Signed-off-by: Greg Kroah-Hartman --- arch/x86/kernel/cpu/mshyperv.c | 11 +++ 1 file changed, 11 insertions(+) --- a/arch/x86/kernel/cpu/mshyperv.c +++ b/arch/x86

[PATCH 4.18 104/171] clockevents/drivers/i8253: Add support for PIT shutdown quirk

: "a...@canonical.com" Cc: vkuznets Cc: "jasow...@redhat.com" Cc: "marcelo.ce...@canonical.com" Cc: KY Srinivasan Cc: sta...@vger.kernel.org Link: https://lkml.kernel.org/r/1541303219-11142-2-git-send-email-mikel...@microsoft.com Signed-off-by: Greg Kroah-Hartman

[PATCH 4.14 064/124] x86/hyper-v: Enable PIT shutdown quirk

asan Cc: sta...@vger.kernel.org Link: https://lkml.kernel.org/r/1541303219-11142-3-git-send-email-mikel...@microsoft.com Signed-off-by: Greg Kroah-Hartman --- arch/x86/kernel/cpu/mshyperv.c | 11 +++ 1 file changed, 11 insertions(+) --- a/arch/x86/kernel/cpu/mshyperv.c +++ b/arch/x86

[PATCH 4.14 072/124] clockevents/drivers/i8253: Add support for PIT shutdown quirk

: "a...@canonical.com" Cc: vkuznets Cc: "jasow...@redhat.com" Cc: "marcelo.ce...@canonical.com" Cc: KY Srinivasan Cc: sta...@vger.kernel.org Link: https://lkml.kernel.org/r/1541303219-11142-2-git-send-email-mikel...@microsoft.com Signed-off-by: Greg Kroah-Hartman

[PATCH 4.9 52/83] clockevents/drivers/i8253: Add support for PIT shutdown quirk

: "a...@canonical.com" Cc: vkuznets Cc: "jasow...@redhat.com" Cc: "marcelo.ce...@canonical.com" Cc: KY Srinivasan Cc: sta...@vger.kernel.org Link: https://lkml.kernel.org/r/1541303219-11142-2-git-send-email-mikel...@microsoft.com Signed-off-by: Greg Kroah-Hartman

[PATCH 4.4 136/160] clockevents/drivers/i8253: Add support for PIT shutdown quirk

: "a...@canonical.com" Cc: vkuznets Cc: "jasow...@redhat.com" Cc: "marcelo.ce...@canonical.com" Cc: KY Srinivasan Cc: sta...@vger.kernel.org Link: https://lkml.kernel.org/r/1541303219-11142-2-git-send-email-mikel...@microsoft.com Signed-off-by: Greg Kroah-Hartman

Re: [PATCH] staging: greybus: arche-platform: Switch to the gpio descriptor interface

On Sat, Nov 17, 2018 at 04:40:27PM +0100, Johan Hovold wrote: > On Sat, Nov 17, 2018 at 12:41:11PM +0530, Nishad Kamdar wrote: > > On Fri, Nov 16, 2018 at 05:06:22PM +0100, Johan Hovold wrote: > > > On Fri, Nov 16, 2018 at 08:47:44PM +0530, Nishad Kamdar wrote: > > > > Use the gpiod interface inste

Re: [PATCH] staging: rtl8188eu: core: coding style check

letions(-) Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was cr

Re: [PATCH v3] driver-staging: vsoc.c: Add sysfs support for examining the permissions of regions.

On Tue, Nov 13, 2018 at 11:32:51AM +0800, wahahab wrote: > > > On 12 Nov 2018, at 8:40 PM, Greg Kroah-Hartman wrote: > > > > On Mon, Nov 12, 2018 at 04:49:30PM +0800, wahahab wrote: > >> > >>> On 10 Nov 2018, at 1:15 AM, Dan Carpenter &g

Re: [PATCH 02/10] staging: erofs: fix race when the managed cache is enabled

On Tue, Nov 20, 2018 at 10:34:17PM +0800, Gao Xiang wrote: > When the managed cache is enabled, the last reference count > of a workgroup must be used for its workstation. > > Otherwise, it could lead to incorrect (un)freezes in > the reclaim path, and it would be harmful. > > A typical race as f

Re: [PATCH 02/10] staging: erofs: fix race when the managed cache is enabled

On Tue, Nov 20, 2018 at 10:34:17PM +0800, Gao Xiang wrote: > When the managed cache is enabled, the last reference count > of a workgroup must be used for its workstation. > > Otherwise, it could lead to incorrect (un)freezes in > the reclaim path, and it would be harmful. > > A typical race as f

Re: [PATCH 01/10] staging: erofs: fix `trace_erofs_readpage' position

On Tue, Nov 20, 2018 at 10:34:16PM +0800, Gao Xiang wrote: > `trace_erofs_readpage' should be placed in .readpage() > rather than in the internal `z_erofs_do_read_page'. Why? What happens with the code today? > > Fixes: 284db12cfda3 ("staging: erofs: add trace points for reading zipped > data"

Re: [PATCH 03/10] staging: erofs: atomic_cond_read_relaxed on ref-locked workgroup

On Tue, Nov 20, 2018 at 10:34:18PM +0800, Gao Xiang wrote: > It's better to use atomic_cond_read_relaxed, which is implemented > in hardware instructions to monitor a variable changes currently > for ARM64, instead of open-coded busy waiting. > > Reviewed-by: Chao Yu > Signed-off-by: Gao Xiang >

Re: [PATCH 04/10] staging: erofs: fix `erofs_workgroup_{try_to_freeze, unfreeze}'

On Tue, Nov 20, 2018 at 10:34:19PM +0800, Gao Xiang wrote: > There are two minor issues in the current freeze interface: > >1) Freeze interfaces have not related with CONFIG_DEBUG_SPINLOCK, > therefore fix the incorrect conditions; > >2) For SMP platforms, it should also disable pre

Re: [PATCH 05/10] staging: erofs: add a full barrier in erofs_workgroup_unfreeze

On Tue, Nov 20, 2018 at 10:34:20PM +0800, Gao Xiang wrote: > Just like other generic locks, insert a full barrier > in case of memory reorder. > > Reviewed-by: Chao Yu > Signed-off-by: Gao Xiang > --- > drivers/staging/erofs/internal.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/d

Re: [PATCH 07/10] staging: erofs: separate into init_once / always

On Tue, Nov 20, 2018 at 10:34:22PM +0800, Gao Xiang wrote: > `z_erofs_vle_workgroup' is heavily generated in the decompression, > for example, it resets 32 bytes redundantly for 64-bit platforms > even through Z_EROFS_VLE_INLINE_PAGEVECS + Z_EROFS_CLUSTER_MAX_PAGES, > default 4, pages are stored in

Re: [PATCH 08/10] staging: erofs: locked before registering for all new workgroups

On Tue, Nov 20, 2018 at 10:34:23PM +0800, Gao Xiang wrote: > Let's make sure that the one registering a workgroup will also > take the primary work lock at first for two reasons: > 1) There's no need to introduce such a race window (and consequently > overhead) between registering and lockin

Re: [PATCH 01/10] staging: erofs: fix `trace_erofs_readpage' position

On Thu, Nov 22, 2018 at 06:49:53PM +0800, Gao Xiang wrote: > Hi Greg, > > On 2018/11/22 18:19, Greg Kroah-Hartman wrote: > > On Tue, Nov 20, 2018 at 10:34:16PM +0800, Gao Xiang wrote: > >> `trace_erofs_readpage' should be placed in .readpage() >

Re: [PATCH 04/10] staging: erofs: fix `erofs_workgroup_{try_to_freeze, unfreeze}'

On Thu, Nov 22, 2018 at 06:29:34PM +0800, Gao Xiang wrote: > Hi Greg, > > On 2018/11/22 18:21, Greg Kroah-Hartman wrote: > > On Tue, Nov 20, 2018 at 10:34:19PM +0800, Gao Xiang wrote: > >> There are two minor issues in the current freeze interface: > >> >

Re: [PATCH 04/10] staging: erofs: fix `erofs_workgroup_{try_to_freeze, unfreeze}'

On Thu, Nov 22, 2018 at 06:29:34PM +0800, Gao Xiang wrote: > Hi Greg, > > On 2018/11/22 18:21, Greg Kroah-Hartman wrote: > > On Tue, Nov 20, 2018 at 10:34:19PM +0800, Gao Xiang wrote: > >> There are two minor issues in the current freeze interface: > >> >

Re: [PATCH 07/10] staging: erofs: separate into init_once / always

On Thu, Nov 22, 2018 at 06:34:10PM +0800, Gao Xiang wrote: > Hi Greg, > > On 2018/11/22 18:23, Greg Kroah-Hartman wrote: > >> + > >> + DBG_BUGON(work->nr_pages); > >> + DBG_BUGON(work->vcnt); > > How can these ever be triggered? I understand the

Re: [PATCH 02/10] staging: erofs: fix race when the managed cache is enabled

On Thu, Nov 22, 2018 at 06:42:52PM +0800, Gao Xiang wrote: > Hi Greg, > > On 2018/11/22 18:17, Greg Kroah-Hartman wrote: > > Any specific reason why you are not using the refcount.h api instead of > > "doing it yourself" with atomic_inc/dec()? > > >

Re: [PATCH 07/10] staging: erofs: separate into init_once / always

On Thu, Nov 22, 2018 at 07:11:08PM +0800, Gao Xiang wrote: > Hi Greg, > > On 2018/11/22 19:05, Greg Kroah-Hartman wrote: > > On Thu, Nov 22, 2018 at 06:34:10PM +0800, Gao Xiang wrote: > >> Hi Greg, > >> > >> On 2018/11/22 18:23, Greg Kroah-Hartman wrot

Re: [PATCH 02/10] staging: erofs: fix race when the managed cache is enabled

On Thu, Nov 22, 2018 at 07:43:50PM +0800, Gao Xiang wrote: > Hi Greg, > > On 2018/11/22 19:06, Greg Kroah-Hartman wrote: > > On Thu, Nov 22, 2018 at 06:42:52PM +0800, Gao Xiang wrote: > >> Hi Greg, > >> > >> On 2018/11/22 18:17, Greg Kroah-Hartman wrote:

Re: [PATCH 02/10] staging: erofs: fix race when the managed cache is enabled

On Thu, Nov 22, 2018 at 08:41:15PM +0800, Gao Xiang wrote: > Hi Greg, > > On 2018/11/22 20:26, Greg Kroah-Hartman wrote: > > Ugh, every page? Ok, nevermind, I take back my objections. You all are > > crazy and need to do crazy things like this :) > > ...Do you have

Re: [PATCH 07/10] staging: erofs: separate into init_once / always

On Thu, Nov 22, 2018 at 09:01:31PM +0800, Gao Xiang wrote: > Hi Greg, > > On 2018/11/22 20:00, Gao Xiang wrote: > > Hi Greg, > > > > On 2018/11/22 19:26, Greg Kroah-Hartman wrote: > >> Don't make people rebuild your code with different options for >

Re: [PATCH 0/2] Parenthesis fix and temp vars

On Tue, Nov 27, 2018 at 12:19:07AM +0100, Cristian Sicilia wrote: > In the first patch there is a fix of some parenthesis that terminate > on end of line and some parameters that are not aligned with > previous parenthesis. > > The second patch is a proposal that avoid the long line refactoring >

Re: [PATCH 1/2] staging: emxx_udc: Align parameter with parenthesis

On Tue, Nov 27, 2018 at 09:57:16PM +0100, Cristian Sicilia wrote: > Align parameters with parenthesis and removed > open parenthesis at the end of line. > > > Signed-off-by: Cristian Sicilia > --- > drivers/staging/emxx_udc/emxx_udc.c | 270 > ++-- > 1 file chan

Re: [PATCH 1/2] staging: greybus: Align function call parameters to parenthesis

On Tue, Dec 04, 2018 at 09:58:14PM +0100, Cristian Sicilia wrote: > Aligned some parameters to the previous parenthesis. > > Signed-off-by: Cristian Sicilia > --- > drivers/staging/greybus/loopback.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/sta

Re: [PATCH] binder: fix sparse warnings on locking context

On Wed, Dec 05, 2018 at 06:02:22AM -0800, Todd Kjos wrote: > On Wed, Dec 5, 2018 at 2:57 AM Greg KH wrote: > > > On Mon, Dec 03, 2018 at 12:24:54PM -0800, Todd Kjos wrote: > > > Add __acquire()/__release() annnotations to fix warnings > > > in sparse context checking > > > > > > There is one case

Re: [PATCH 2/2] staging: greybus: Added space between string concatenated

On Thu, Dec 06, 2018 at 09:43:46AM +, Bryan O'Donoghue wrote: > On 05/12/2018 21:00, Sicilia Cristian wrote: > > It doesn't change the result string > > So why do it then ? Because it is easier to read this way and odds are checkpatch is happier. thanks, greg k-h ___

Re: [PATCH 2/2] staging: greybus: Added space between string concatenated

On Thu, Dec 06, 2018 at 04:14:53PM +, Bryan O'Donoghue wrote: > On 06/12/2018 15:05, Greg Kroah-Hartman wrote: > > On Thu, Dec 06, 2018 at 09:43:46AM +, Bryan O'Donoghue wrote: > > > On 05/12/2018 21:00, Sicilia Cristian wrote: > > > > It doesn&#x

Re: [PATCH v2 1/3] binder: fix sparse warnings on locking context

On Thu, Dec 06, 2018 at 08:37:41AM -0800, Todd Kjos wrote: > On Thu, Dec 6, 2018 at 6:51 AM Greg KH wrote: > > > > On Wed, Dec 05, 2018 at 03:19:24PM -0800, Todd Kjos wrote: > > > Add __acquire()/__release() annnotations to fix warnings > > > in sparse context checking > > > > > > There is one cas

Re: [PATCH] staging: fix ignoring return value warning

> + dev_err(&pdev->dev, "failed to reset device\n"); > + return ret; > + } > > dd = &dma_dev->ddev; > dma_cap_set(DMA_MEMCPY, dd->cap_mask); > -- > 2.1.0 > Hi, This is the friendly patch-bot of Greg

Re: [PATCH] staging: rtl8723bs: fix block comments alignment

723B( > struct adapter *Adapter, > u8 eRFPath, > @@ -369,17 +369,17 @@ s32 PHY_MACConfig8723B(struct adapter *Adapter) > } > > /** > -* Function: phy_InitBBRFRegisterDefinition > -* > -* OverView: Initialize Register definition offset for Radio Path A/B/C/D > -* > -* Input: > -*

  1   2   3   4   5   6   7   8   9   10   >